- 23 Dec, 2020 40 commits
-
-
Yue Zhang authored
The dismiss status is recorded in profile prefs. Bug: 1157892 Change-Id: I3fe60ffa5bd1ed99a9973e18fc6df1812b7517d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597902 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839203}
-
Hui Yingst authored
In OutOfProcessInstance, the attributes `zoom_`, `device_scale_`, `first_paint_` and `in_paint_` are used for drawing graphics, and they will be used by PdfViewWebPlugin in the future. Therefore this CL moves them into PdfViewPluginBase so that they can be shared between PdfViewWebPlugin and OutOfProcessInstance, and adds accessors and mutators for them. Meanwhile, to avoid providing pointer access to `in_paint_`, this CL moves the definition of OnPaint() into PdfViewPluginBase while keeping the majority of its functionality wrapped in DoPaint(), which is delegated to PdfViewPluginBase's derived classes. Bug: 1140629 Change-Id: Ie2439d883836d5755ca4d86291ae9ccecc1b07a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601039Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839202}
-
Toni Barzic authored
It uses slide animation to be consistent with how other tray items - mainly the unified system tray - animate their size. On each animation step, it updates the tray icon preferred size, which updates the shelf layout. Adds a previews container view to HoldingSpaceTrayIcon, to make it easier to compose the transform changes on the previews during resize. A preview movement has two components: * shift animation to handle preview index change within the icon * offset due to icon size change. The icon is expected to grow towards the start of the icon, which is opposite of how bounds grow by default. As the size changes, the items have to shift so their position remains constant relative to the end of the icon. The latter is handled by updating transform on the container view layer as the resize animation progresses. Bug: 1142572 Change-Id: I411844c9a9c8fc4a270feaa94530f34be7bae088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601757 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839201}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0162f9bf2635..457828e81aca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: chanli@google.com,mohsen@google.com Change-Id: Icff151867b24f1e4a0f9a0cc5369ed82cc3e1561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839200}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20fad3206488..a07076b6a8f9 2020-12-23 brianosman@google.com Fix GN issue with incorrect task outputs 2020-12-23 brianosman@google.com Make all fragmentProcessors implicitly nullable in SkSL 2020-12-23 brianosman@google.com Fix skslc compilation on Windows 2020-12-23 csmartdalton@google.com Clean up GrStrokeIndirectOp #ifs for using SIMD 2020-12-23 bungeman@google.com Remove MakeDescriptorForPaths. 2020-12-23 johnstiles@google.com Fix fuzzer-discovered crash with negated swizzles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I875de9c7a8da81fd297799c6ac26e5f11591ccfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839199}
-
Mason Freed authored
The same id was used twice, whereas they should have been unique. No behavior changes, just a cleanup, so TBR: TBR=masonfreed@chromium.org Bug: 1042130 Change-Id: I58e4acc00acabbb728c730fe3910aea65c4c11e1 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601052Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#839198}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a7fb5599fb16..db8fb909f397 2020-12-23 cturner@zyme.xyz Fix CSSShadowEditor not appearing with !important If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd71eacddd54ac00c7ebe1eb2ecb71775978aca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602508Reviewed-by:
-
Jesse McKenna authored
This CL makes the following cleanup changes to render_process_host_impl.h and .cc: * remove DISALLOW_COPY_AND_ASSIGN * replace empty constructor body with `= default;` * use range-based for loop where possible * replace .reset() with std::make_unique * add missing `#include <memory>` (used for unique_ptr) Change-Id: I074ec44ba1451851e00f0d6d480f20df004636f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601282Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#839196}
-
Mohsen Izadi authored
This reverts commit 511c6eb0. Reason for revert: The original CL had actually fixed the issue and should not have been relanded. Reverting again. Original change's description: > Reland "Wait until safe time to create web document" > > This reverts commit 1af362f4. > > Reason for revert: The rollback did not fix bots, so I am relanding > the CL. > > Original change's description: > > Revert "Wait until safe time to create web document" > > > > This reverts commit 593304b4. > > > > Reason for revert: Suspect it caused failures in content_browsertests > > Accessibility tests. > > > > Original change's description: > > > Wait until safe time to create web document > > > > > > TBR=kinuko@chromium.org > > > > > > Bug: 1156939 > > > Change-Id: I23443fc4461dc61223fef249bac109a8b7e8183e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586233 > > > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#838244} > > > > TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1156939 > > Change-Id: Iac0282f6e1a24119a67dacf81c5e1c33ed303d33 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596292 > > Reviewed-by: Tal Pressman <talp@google.com> > > Commit-Queue: Tal Pressman <talp@google.com> > > Cr-Commit-Position: refs/heads/master@{#838585} > > TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,talp@google.com > > # Not skipping CQ checks because this is a reland. > > Bug: 1156939 > Change-Id: Ib7571aa00acc5c1202abdbebfb40e2180aba36e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598303 > Reviewed-by: Tal Pressman <talp@google.com> > Commit-Queue: Tal Pressman <talp@google.com> > Cr-Commit-Position: refs/heads/master@{#838596} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,talp@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1156939 Change-Id: Idc167071dce6a0fc2ab2db915e6c5899a6426b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600392Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839195}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815ee4029d9e..6005f1179a65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibedcc7c3e36462c946c5a91684deed8cb630b7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602578Reviewed-by:
-
Dominic Mazzoni authored
This is a simple refactoring that should have no side effects. The change 'Use EmbeddingTokens as the "backing store" for AXTreeIDs' (http://crrev.com/c/2270065) got rid of AXContentTreeUpdate, which was previously a more complex version of AXTreeUpdate with some extra content-specific fields. There was a small missed opportunity to refactor here - AXTreeSnapshotterImpl was serializing to a AXContentTreeUpdate and then converting that to an AXTreeUpdate. Since AXContentTreeUpdate no longer exists, the code to populate one struct and then copy it to another one is redundant and can be simplified. This shouldn't result in any change in functionality. AXTreeSnapshotter is already covered by tests, primarily in snapshot_ax_tree_browsertest.cc Bug: 1094150, 1161541 AX-Relnotes: N/A Change-Id: If9863ce23cca5538eeab5e0a34350d2f9bfe9e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602438Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839193}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d447829c19fd..c500ee031d36 2020-12-23 jmadill@chromium.org Revert "Changes to build inside a Dawn checkout." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ie1689b46801faced6606bfd6059f0cad9d8acc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600583Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8986f3ce67ec..815ee4029d9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30bda8ecc9058525fa08555ed215a3e40d7643cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602112Reviewed-by:
-
Alexander Timin authored
Refactor startup tracing logic out of TracingControllerImpl and use modern TracingSession from Perfetto client API directly. This allows for much greater simplification, including removing substantial amount of logic from TracingControllerImpl (including logic for finishing trace recording after a timeout) and removing PerfettoFileTracer. This also allows for a clean implementation of features like streaming trace to a file and merging browsertest and startup tracing logic. R=eseckler@chromium.org,skyostil@chromium.org BUG=1157954,1082916 Change-Id: Id4c608b05cbd6b0696cb8e3445888b6a9d86c797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587040 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#839190}
-
Joey Arhar authored
Focus rings are rendered differently in dark mode, so we need additional pixel tests for dark mode. Fixed: 1067517 Change-Id: I94ba8b86a03943b7d30cddd44a30ac2cc380e0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596019Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
-
Alan Screen authored
Printer capabilities have been located under //components since r540621, when they were moved here in anticipation of the upcoming printing backend service. However, once it came time to introduce the service it landed under //chrome, because of the guidelines required to add it to //components were not satisfied. [1] One ripple effect of the service landing under //chrome is that printer capabilities need to also be moved out from //components. Its presence under //components results in a dependencies conflict for Mac because it ends up causing a dependency on //content/browser, which is not allowed. [2] Since printer capabilities are referenced by only one space, [3] resolve this by moving printer capabilities code out of //components and into a home under //chrome like where the service is. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/README.md [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/BUILD.gn;drc=98fd3773af40462359d2cef844f946526e99b1fe;l=1301-1305 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/webui/print_preview/ Bug: 809738 Change-Id: I50d76e18f6e86f6bf483883c1d0654c8fc0724d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592628 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#839188}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c463a784c340..fec83cc86025 2020-12-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2eaf311e..cc240573 (839031:839139) 2020-12-23 philipel@webrtc.org Remove unused NTP time functions from RtpPacketReceived. 2020-12-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ad7eaf17..2eaf311e (838850:839031) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I849974bd57cbd90c14f5881e131d04d07fab2415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602502Reviewed-by:
-
rajendrant authored
Currently OAuthed site is detected at the last stage of login flow when the redirect happens with the completion request parameters. However this site at the final step may be wrong due to multiple sites using a common site for handling the OAuth login. Instead this CL detects this OAuth requestor site based on the first navigation to the OAuth provider site. This CL also refactors a bit to pass down the entire navigation redirect chain to the detector. Bug: 1161451 Change-Id: I3f76c76b0f36106150b1ffa1277e129102a7e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602078Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#839186}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6bf67526ef67..a7fb5599fb16 2020-12-23 michael.liao@microsoft.com [Accessibility]: Adding grouping labels to sidebar tree in Applications view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157691 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06743d7c82358fd8317187fe68d41e5ce4eaea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602499Reviewed-by:
-
Gil Dekel authored
As explained in crbug.com/1161556, hardware mirroring is rarely used, and when it is, it often results in unfavorable outcomes. This CL introduces a disabled-by-default flag to control hardware mirroring as the first step towards permanently disabling it. Bug: 1161556, b:176092209, b:127878082, b:173159439 Test: display_unittest && ozone_unittest Change-Id: I02b356626d077c15f4c90f6b44d95d66214ad671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601397 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3c9279ae878962c1694187947f7c1d3a14967356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602362Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839183}
-
David Tseng authored
R=akihiroota@chromium.org, josiahk@chromium.org Fixed: 1161524 Test: existing browser_tests --gtest_filter=ChromeVox*.*Select* Change-Id: I5c6e72b78bdcd7db829e67e712d8b7ce965b4de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602113Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839182}
-
Sam Maier authored
Change-Id: I746c6af582fa88d74cf8c6cb4c6e6ecdbed62b95 Bug: 1159984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595259Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#839181}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33bf309c1d45..a4fb42ac92cc 2020-12-23 jiawei.shao@intel.com Enable two dawn_end2end_tests on Win/Intel/Vulkan after bot upgrades If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4066587f0c933f95fa2d2196e53be70c4bc900af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602497Reviewed-by:
-
David Bokan authored
Both overrides of GetKeyboardConfig only ever call this method once and the chrome/ version already runs it with std::move. Bug: 1152268 Change-Id: I23861fd1945f62654bb0692492f61e73e94ab0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601517Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839179}
-
David Bokan authored
This class keeps a list of callbacks to invoke on page load but clears the list after invocation so they can only ever be invoked once. Bug: 1152268 Change-Id: I97e43b14be743ef6798ce7281b6003e6d34c99cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601228Reviewed-by:
-
Xiaoqian Dai authored
Bug: None Change-Id: I174f12dbaecc64e83f8fabbe53a481549dc79a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600052Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#839177}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33c64a447368..20fad3206488 2020-12-23 brianosman@google.com SkSL: Hide most integral types from runtime effects 2020-12-23 brianosman@google.com SkSL: Remove many unused sampler types 2020-12-23 brianosman@google.com SkSL: Hide non-square (half) matrices from runtime effects 2020-12-23 fmalita@chromium.org Add rsx_blob_shader GM 2020-12-23 reed@google.com Use bitmap.asImage() 2020-12-23 reed@google.com Work on hiding filter-quality 2020-12-23 brianosman@google.com SkSL: Remove all $gsamplerFoo types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I2876283ee04bfb56f43f91e8c396e98177ea3623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600581Reviewed-by:
-
Cattalyya Nuengsigkapian authored
This is a reland of http://crrev.com/c/2581684, which was reverted by http://crrev.com/c/2601580 due to flakiness of the test NoWindowInActiveDesk. The issue is that CompleteCycling() activates a window in another desk, so deskSwitchAnimation takes a screenshot and sometimes fail if the test ends before it is taken. TBR=afakhry@chromium.org Original CL description: - Add a tab slider and update windows shown in Alt-Tab so that "Current desk" mode only display windows in the active desk, while "All desks" display all windows. - Handle special cases: As before, entering Alt-Tab with less than two windows aren't allowed. However, if users switch from the all-desks mode to the current-desk mode resulting in zero or one window, it should show "no recent items" or show a window consecutively. - Hide behind Bento flag and make sure to overwrite kLimitAltTabToActiveDesk in case of conflict, so the old flag works. - Disable remapping Alt+LeftClick to a right click when using Alt-Tab. - Ash unittests for switching between modes and special cases. Bug: 1142726 Test: A manual test (a video in crbug) and unit tests `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.*` Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581684Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#838709} Change-Id: I52c67cbb878fc33dac5ee0d8b59cc4310eb08f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601480 Cr-Commit-Position: refs/heads/master@{#839175}
-
Daniel Libby authored
After crrev.com/c/2586450 removed NGPaintFragment and templates, this class is much easier to reuse in upcoming changes for selection recording for non-NG text, replaced, and SVG text. Remove dependencies on NGInlineCursor, force the caller to provide the selection rect, and factor out the early out checks so callers can compute the rect only when necessary. Bug: 1065049 Change-Id: If4bcc660c5e5b288fec0e0432d377d4d6289a878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598097Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839174}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815ee4029d9e..6005f1179a65 2020-12-23 fmayer@google.com Simplify GetPerfettoBinaryPath. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie6db04b050576657a5f417b119ef7a04e8bab48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600931Reviewed-by:
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. A previous CL added an accessor to net::HttpBasicState as well as one to net::HttpStream. This change continues the plumbing by adding a field to net::HttpResponseInfo to store the alias list in the HttpCache and the code to net::HttpNetworkTransaction and net::HttpCache::Transaction to save the aliases to this field. We moreover add the code to network::URLLoader to set the field `dns_aliases` in network::mojom::URLResponseHead. Relevant tests: net:net_unittests out/Default/net_unittests --gtest_filter=*Dns*Alias* services/network:tests out/Default/services_unittests --gtest_filter=*Dns*Alias* Bug: 1151047 Change-Id: I9adebfcc5fa811ece4d55e70f3d624d495ca6d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569956Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#839172}
-
Sam Maier authored
Bug: 1029038 Change-Id: I84568516fea23cf21bc91afb79bb90096d8a5963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595721 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
manukh authored
Split AC was added in CL crrev.com/c/2424985 . It allows e.g. the input 'a c' to match the text 'a [b ]c[ d]' When generating the text selections from word matches, it removes empty matches and merges adjacent matches. E.g. the input 'a b' produces the selections 'a b[ c]' instead of 'a| |b[ c]'. This is desirable usually, but not desirable for the last selection which is used to determine the cursor position; merging or filtering the last selection incorrectly alters the cursor. This CL makes sure to preserve the last selection and, therefore, the correct cursor. E.g. the input 'a c' produces selections 'a [b ]c|' instead of 'a [b ]c'. Bug: 1062446 Change-Id: Icfb13321d86454a8a2fbc89289fefda53287b770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601046 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#839170}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61cbb8911dcc..815ee4029d9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2f421f3f0e7503143bc20b058f6b5189199d1297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602111Reviewed-by:
-
Tom Anderson authored
After [1], Chrome and ANGLE use separate X11 connections, so in order for Chrome to receive exposure events, it must select for them its own connection. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177 Change-Id: If01cd9d106bf900a5c7a56768602b34dc50b1a23 Bug: 1158170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602441 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839168}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608724675-36d361379e6ecc2792aff1f82c923e32f70d38c4.profdata to chrome-mac-master-1608746256-3ed2cb6bb1e0224e9725c01d978e3ae9cf598e54.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic9519823505646d1c7cd055ec7ba781cef58194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602496Reviewed-by:
-
Alan Screen authored
The Linux sandbox causes created files to be automatically deleted once they are closed. This means that creating a file without leaving an open file handle is useless afterwards for any subsequent calls expecting it to exist with results of previous work. Change ParsePpdCapabilities() to open a stream for a temporary file and keep that open for the duration of the file operations, instead of doing multiple open/close operations against a common filename. This is necessary for supporting sandboxing of the print backend in a utility process. Bug: 809738 Change-Id: Id16dc686873decad7be980ce4621747b4233184a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597143Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839166}
-
Frank Liberato authored
WeakLearningSessionImpl::PredictDistribution accessed the session, without first checking if its weak ptr was valid. This CL adds that wp check. Bug: 1159663 Change-Id: I2c26fd8cb22cd2c78d39267e58e8b79217cee1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602258Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#839165}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608724675-48ba6591ad34bc4b599f70e6d7e6561723f787a8.profdata to chrome-linux-master-1608746256-194231b3dc387c7a03e0631c0ae6df5b6e567b63.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id4e4946b70d99e7323975c1fd1be9696e6541d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600584Reviewed-by:
-
