- 05 Oct, 2017 40 commits
-
-
Thanh Pham authored
Client InputMethodMus needs a way to know if there's candidate pop up window which is created in different process, i.e., Chrome. We can provide SetCandidateWindowVisible() interface in ime.mojom to allow RemoteTextInputClient in Chrome process to send visible property of candidate window pop up to InputMethodMus in client process. Bug: 637416 Change-Id: I5c5785972ba90d6ec2e6ceabc9e29043ee226761 Reviewed-on: https://chromium-review.googlesource.com/680037Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thanh Pham <thanhph@chromium.org> Cr-Commit-Position: refs/heads/master@{#506639}
-
Lucas Garron authored
Remove `overridable` parameter from ContentBrowserClient::AllowCertificateError() and its overrides. content::SSLManager previously contained some logic for computing whether/how an interstitial should be bypassable, which it then passed into ContentBrowserClient::AllowCertificateError(), though only ChromeContentBrowserClient's implementation was using it. This presented a problem for the interstitial refactor because this logic is needed for interstitial display, but SSLManager/ChromeContentBrowserClient::AllowCertificateError() is no longer going to be the point that triggers interstitial display. crrev.com/c/679937 moved this logic into //chrome's SSLErrorHandler, which is a more convenient place for the logic to live because both the old and new interstitial display codepaths pass through that point. In order to simplify reviews, that CL kept the interface of `ContentBrowserClient::AllowCertificateError()` intact, even though the `overridable` calculation is now done in SSLErrorHandler. This follow-up CL modifies `AllowCertificateError` to remove the defunct `overridable` parameter. Note that this change does not update the similar parameter in WebClient::AllowCertificateError() on iOS. TBR=jochen@chromium.org Bug: 768105 Change-Id: I8214a89b6497108dea3dfe636735c865041a0673 Reviewed-on: https://chromium-review.googlesource.com/680114 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506638}
-
Khushal authored
This reverts commit b2aea62a. Reason for revert: The offending change has been reverted on https://chromium-review.googlesource.com/c/chromium/src/+/699755. Original change's description: > //tools/perf: Disable story on smoothness benchmark > > TBR=rnephew > > Bug: 771368 > Change-Id: Ic194b890084702105f00b9246b1971f9062dbf2f > Reviewed-on: https://chromium-review.googlesource.com/699312 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: rnephew <rnephew@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506228} TBR=rnephew@chromium.org,martiniss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 771368 Change-Id: I3de10e67b4ab36c08d1a82ab4e8fcef226295037 Reviewed-on: https://chromium-review.googlesource.com/701316Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506637}
-
Shakti Sahu authored
1 - This CL tries to fix the coordinates where the media download IPH bubble should be shown. Currently we show it as soon as it starts playing, but the controls moves down afterwards and we should probably set it after it has settled. 2 - Added a y-offset to account for the viewport location offset on screen. 3 - Dismiss the in-product-help message after a orientation change. This should be unnecessary if blink could send us the correct coordinates after the rotate. 4 - Added a pulse highlight around the download button. Bug: 761085 Change-Id: Id21c67f65f077ac69fd2d8c862433f1e476085d8 Reviewed-on: https://chromium-review.googlesource.com/661051 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#506636}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e34fde0f. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2561 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Ice0eeca1959fe65db3bdff88b41837345aab6e9a Reviewed-on: https://chromium-review.googlesource.com/701697 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506635}
-
Charles Harrison authored
Bug: 768636 Change-Id: Iaa49f32a16a57c079c6aaaf4fd3ba84756aa88a7 Reviewed-on: https://chromium-review.googlesource.com/701139Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#506634}
-
Darren Shen authored
Currently, when we encounter something like: .a { @extends } We would consume up the '}', expecting a semicolon. We then erroneously consume '}' thinking that it's a ';', which would cause the next rule to be parsed incorrectly. This patch fixes this issue by only consuming if it is a ';'. We also add DCHECK to ensure that we never consume a '}' to catch these errors in the future. I also manually tested this on the pixel 2 page which has this issue (see bug) and it seems to work fine. Bug: 771679 Change-Id: Idbe014f76e32af60af0c18fdcac9d68e95bcfa2c Reviewed-on: https://chromium-review.googlesource.com/701894Reviewed-by:nainar <nainar@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#506633}
-
Steve Kobes authored
Swarming task IDs aren't comparable to BuildBot build numbers. We'll need something smarter in a post-BuildBot world, but this gets things working for now. Bug: 755401, 771438 Change-Id: Ifa13bc95c3a7527d7272fa3f35cbd385328aa945 Reviewed-on: https://chromium-review.googlesource.com/701916 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Rob Buis authored
They made commits in the past, however were never added to AUTHORS. This confuses some of our internal search queries. Bug: None Change-Id: I0076827d6338dca98b9b1bde1b0dda39d934c086 Reviewed-on: https://chromium-review.googlesource.com/701405Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#506631}
-
chrome-release-bot authored
TBR=mmoss@chromium.org Change-Id: I475c68ce35e7d5d46a8e9667e7add3d39d26b710 Reviewed-on: https://chromium-review.googlesource.com/701699Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506630}
-
Raymes Khoury authored
The release is being pushed back from M63 to M64. BUG=689802 Change-Id: I3528170d37d6b9725709afc61274447355d13d78 Reviewed-on: https://chromium-review.googlesource.com/700194Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506629}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/813882679eb6..120c1cb3fd18 $ git log 813882679..120c1cb3f --date=short --no-merges --format='%ad %ae %s' 2017-10-03 dtu [pinpoint] Add trace links. 2017-10-04 joelaf atrace: Increase timeout of collect to 10 mins 2017-10-04 joelaf tracing: add preempt and irqsoff events importer Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I537ac1c3c4b303a63b1f75dd15e1c9f0881447d7 Reviewed-on: https://chromium-review.googlesource.com/702015 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506628}
-
John Wu authored
Bug: 753660 Change-Id: I52b05e132bde91651fc4c8cae944fc650812d72e Reviewed-on: https://chromium-review.googlesource.com/659481 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#506627}
-
Xiaocheng Hu authored
Bug: 771398 Change-Id: Ic35d94a75a5bb9d4ef00fc9abdb839c0e26c2c78 Reviewed-on: https://chromium-review.googlesource.com/701414Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#506626}
-
Yafei Duan authored
Implemented ClearDigestTask which is responsible for cleaning the digest field of an offline page in the metadata store. Also had minor fix for MarkPageAccessedTask and AddPageTask. Bug: 753595 Change-Id: I74757781d50d93faa14590892dd7eecdec8ec7b5 Reviewed-on: https://chromium-review.googlesource.com/699157 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#506625}
-
Alexey Kozyatinskiy authored
Based on test results this test is all green on try bots [1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&showExpectations=true&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger-breakpoints%2Fdom-breakpoints.html TBR=dgozman@chromium.org Bug: chromium:233303 Change-Id: I817a6c24157c91814c4586f86e2874d3de380040 Reviewed-on: https://chromium-review.googlesource.com/701276Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#506624}
-
Eric Willigers authored
The tests were commented out as they were failing, but they are also invalid. https://bugs.chromium.org/p/chromium/issues/detail?id=273092#c5 BUG=273092 Change-Id: Ia33c9dbeb877b627789714c606e621e10996bf01 Reviewed-on: https://chromium-review.googlesource.com/701934Reviewed-by:
-
Xiaocheng Hu authored
Bug: Change-Id: I8b414973cb4f8e22c5e088898a8b8d1045f5c03e Reviewed-on: https://chromium-review.googlesource.com/700977 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506622}
-
Conley Owens authored
The validation macros for javascript generate whitespace in the resultant file. This change cuts out that whitespace. This is important so that unmodified versions of these generated files can be placed into the third_party/WebKit/LayoutTests/external/wpt/ directory which is exported to github. BUG=509038 Change-Id: Ie09e90935324a87380376ddeaf7d527ea9f9e93b Reviewed-on: https://chromium-review.googlesource.com/701370Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#506621}
-
Blake O'Hare authored
Currently ImeMenuTray is getting information about the extended input methods (emoji, handwriting, voice) from the InputMethodManager directly whenever the UI for this menu loads. Instead of querying InputMethodManager directly from ImeMenuTray, store this information in the ImeController and update from the ImeControllerClient which is conveniently an InputMethodManager::Observer. Bug: 738213 Change-Id: I6bfe9281434f6ec68a5ff4f77be10829f8e787c8 Reviewed-on: https://chromium-review.googlesource.com/675084Reviewed-by:
Lan Wei <azurewei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506620}
-
Khushal authored
CompositorFrames can have opaque SkImageFilters which internally may contain codec backed images. No cc client should be using such filters. Assert this during filter serialization. R=enne@chromium.org, reed@chromium.org Bug: 768511 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I222cf4f7189e879537c19d723bf57b739aa9ad57 Reviewed-on: https://chromium-review.googlesource.com/688656 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#506619}
-
Dmitry Gozman authored
Bug: none Change-Id: I7e0731abe89efa49a80a7a731798005ecf6e5830 Reviewed-on: https://chromium-review.googlesource.com/639069 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506618}
-
Devlin Cronin authored
The icon in the install dialog is just the icon of the extension, whose name is included in the title. Currently, this icon simply says "image" when VoiceOver is used to highlight the element. We could add an alt-text of "<Extension name> icon", but this doesn't add any additional context beyond what the title (immediately before the image) provides. Instead, remove the icon from the VoiceOver tree entirely. Bug: 747624 Change-Id: Ic5373ca4a766b72696839062ffa89d8780d97e35 Reviewed-on: https://chromium-review.googlesource.com/701918Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506617}
-
chrome://flagsCharles Harrison authored
The UI is not implemented yet on desktop. Bug: 661629 Change-Id: Iee0b2134d02eb63325b20376c38500a38d49fb9a Reviewed-on: https://chromium-review.googlesource.com/701474Reviewed-by:
-
Leo Zhang authored
Added "Translate" to the general accessibility message and refactored getAccessibilityMessage param from TextView to CharSequence. Tested "out/Default/bin/run_chrome_public_test_apk -vv -f InfoBarTest*" and Passed all tests. Bug: 723115 Change-Id: I1b2b973cea35bdda984cb885b13642393e247245 Reviewed-on: https://chromium-review.googlesource.com/665900Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506615}
-
Devlin Cronin authored
Add a test that non-lazy listeners are removed when the event page is torn down. Bug: None Change-Id: Icdc1d1e5e6bc6dbc05f6b99ae36da1de2ffaccb5 Reviewed-on: https://chromium-review.googlesource.com/695644Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506614}
-
Yoshifumi Inoue authored
This patch Introduces flat tree version of |SampleSelection::GetSelectionText()| as |GetSelectionTextInFlatTree()| to help writing tests for |SelectionInFlatTree|. Change-Id: I0a66af714b65cb0aa856a3a9ce8eb4eea6b100ca Reviewed-on: https://chromium-review.googlesource.com/694724Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506613}
-
proberge authored
This reverts commit 7cd54377. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=770001: PrefHashBrowserTestUnchangedCustomInstance browser_tests are failing on "Linux64/Win32&64/Mac64 - trunk" Original change's description: > Reland "Extension content verification: unify "is from store" logic" > > (Not a direct reland: the change to extension_settings_browsertest.h > was not in the original CL) > > This is a reland of f3bd7c65 > Original change's description: > > Extension content verification: unify "is from store" logic > > > > Bug: 766806 > > Change-Id: I1a210ded77cc9ffdc0039fca097c6fdba7ff0131 > > Reviewed-on: https://chromium-review.googlesource.com/677403 > > Commit-Queue: proberge <proberge@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#505092} > > Bug: 766806 > Change-Id: I4a0c69c50d7bc41a47e264ad9b9e3136a729ec96 > Reviewed-on: https://chromium-review.googlesource.com/698985 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506422} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,proberge@chromium.org Change-Id: I55c8e8de6077788b1833457f660aca9299710815 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766806 Reviewed-on: https://chromium-review.googlesource.com/701318Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#506612}
-
Devlin Cronin authored
This CHECK was added to (help) ensure we tracked down the cases when we were trying to set an invalid opener. It's been a few cycles, and we haven't seen any crashes, so downgrade to a DCHECK. Bug: 700518 Change-Id: I3f607fe4ae7b98bbaac30fa910c0bf7394388270 Reviewed-on: https://chromium-review.googlesource.com/693309Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/5ced63b1db3f..813882679eb6 $ git log 5ced63b1d..813882679 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 oysteine Move py_vulcanize from third_party to common Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iaa2370174d7c119130fba9377a10fed3267cf61d Reviewed-on: https://chromium-review.googlesource.com/701467 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506610}
-
Dave Schuyler authored
This CL removes a call to PapperInkyFocusBehaviorImpl so that it would not need to be explicitly imported. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I68d90de1716f1e6567de8927d9e9386501a3fd80 Reviewed-on: https://chromium-review.googlesource.com/693040 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506609}
-
Patrick Hulce authored
Win10 tests will be skipped for now. This is a reland of 5d92868c Original change's description: > DevTools: Add tests for audits2 panel > > * Introduces Audits2TestRunner and audits2 test folder. > * Adds test coverage for default flow, limited category flow, and > unauditable page message help text. > * Fixes a bug where help text was not updated on URL change. > > BUG=762911,747357,762906,762897 > > Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4 > Reviewed-on: https://chromium-review.googlesource.com/661894 > Commit-Queue: Patrick Hulce <phulce@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505924} Bug: 762911, 747357, 762906, 762897 Change-Id: Iaf210e383e86fbfe0e31b372d8b87c461e8beecb Reviewed-on: https://chromium-review.googlesource.com/701294Reviewed-by:
Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#506608}
-
Istiaque Ahmed authored
EventRouter didn't used to load pref-saved listeners for Service Workers. Load them. This CL is a precursor to dispatching a SW event after a browser restart. One caveat (TODO) in this CL is that it is currently assumed that SW events are only registered from '/' scope. That support will be incrementally added. Also, add a test to demonstrate that an event can be dispatched after a worker is shut down along with its extension (event page). This test can easily be expanded in future to test the aforementioned browser restart scenario. Bug: 721147 Change-Id: I80f0ae097772500f41c7509435b878762d55ff98 Reviewed-on: https://chromium-review.googlesource.com/696720 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506607}
-
Kai Ninomiya authored
Regression test for GLVirtualContextsTest.VertexArrayObjectRestoreDefault on devices with use_client_side_arrays_for_stream_buffers and use_virtualized_gl_contexts. Bug: 768324 Test: WithWorkarounds/GLVirtualContextsTest.VertexArrayObjectRestoreDefault/1 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1b1f8fb791a02c614f1a4c9f869016c198902a16 Reviewed-on: https://chromium-review.googlesource.com/699459 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506606}
-
Mustafa Emre Acer authored
This CL introduces chrome::GetIsCaptivePortal() which returns true if the OS reports a captive portal. It uses NetworkListManager API on Windows and net::android::GetIsCaptivePortal() on Android. The result is used to determine whether to show a captive portal interstitial. NetworkListManager API returns the WebHijack status for each network adapter separately. GetIsCaptivePortal() returns true if all connected adapters have the WebHijack bit set. As a side note, captive_portal_helper_android.cc contains both the JNI code and chrome::GetIsCaptivePortal() implementation for Android. This is why this CL contains both captive_portal_helper.h and captive_portal_helper_android.h files. Bug: 380762 Change-Id: I9e1d9b709dd3e98b2d615ce2167cf39991f6564b Reviewed-on: https://chromium-review.googlesource.com/665439 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#506605}
-
Peter Boström authored
Removes SetFontList on the undo link as it defaults to the correct style (not CONTEXT_SMALL_DEPRECATED). BUG=chromium:654115 R=bsep@chromium.org Change-Id: Ib49cbd57ced4514a2778ebf0d453cb116ef5f722 Reviewed-on: https://chromium-review.googlesource.com/701263Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506604}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0078e912718c..98156c4592d9 $ git log 0078e9127..98156c459 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 mtklein refactor SkColorSpaceXform a bit 2017-10-04 csmartdalton Don't execute onFlush op lists until after GPU data is uploaded 2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ cb62d86fc..10d4026b3 (1 commit) 2017-10-03 bungeman Clean up SkString reference counting a bit. 2017-10-04 reed Avoid overflow computing reserve for aaclip 2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ baf5d9458..cb62d86fc (1 commit) 2017-10-04 egdaniel Revert "Revert "Update lockTextureProxy to return mipped proxys if mipping is requested."" 2017-10-04 brianosman Sever fOriginalPath connection whenever a GrShape becomes a simple type 2017-10-04 brianosman Fix path renderer cache test logic to account for other resources 2017-10-04 caryclark starting next gaggle of docs Created with: roll-dep src/third_party/skia BUG=713764 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1c7ba3862483d32a694242e204a58c727094614f Reviewed-on: https://chromium-review.googlesource.com/701642Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506603}
-
rbpotter authored
Add a testing setup and unit tests for PrintPreviewHandler. Bug: None Change-Id: Id6180fe1de475854c6dd5ac265f14dddc166294c Reviewed-on: https://chromium-review.googlesource.com/695715 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Charles Harrison authored
This CL does a few things. 1. Instantiate the tab-under nav throttle unconditionally, only *block* the navigation if the feature is enabled. This allows us to combine logic more effectively for metrics, by e.g. removing the flat set of navigations occurring in the background. For this data we can just trust the nav throttle. 2. Remove the old tab visibility metrics gated on cross origin redirects in favor of an approach that just logs 3 metrics: a. Tab.VisibleTime b. Tab.TabUnder.VisibleTime c. Tab.TabUnder.PopupToTabUnderTime I believe these three metrics are the most important, and they are now logged directly from input from the throttle, so they are comparable what will actually happen when we turn the experiment on. 3. A bug fix where we assume a navigation that started in the background, ends in the background. 4. Some new tests. Bug: 661629 Change-Id: Idc1b82528cbf2bf2a1a94d174b4e07823ec30d17 Reviewed-on: https://chromium-review.googlesource.com/700718Reviewed-by: -
Jamie Madill authored
Explicitly specifying the GPU driver version in the config will allow us to safely test new driver versions. Because the tests will pick machines of a particular driver version specified in the json, we can ask infra to upgrade a few machines, then run a try job using the new driver version. This modifies the generate script to allow use of wildcards in test dimension set specifiers. Wildcards are only supported as the last character in the dimension. This allows us to more easily match ranges of driver versions. The current NVIDIA driver version used by the bots is 372.54. R=kbr@chromium.org BUG=771654 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5875b9e91fbe8d2d626a8af20005161bc3f082bb Reviewed-on: https://chromium-review.googlesource.com/699761Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#506600}
-
