- 13 Aug, 2019 40 commits
-
-
Antonio Gomes authored
... and use the WTF counterparts, Vector and String. BUG=704136 R=haraken@chromium.org Change-Id: I99adf8785525376a47b1a5e52cfee345f5618d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752063Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#686523}
-
lgcheng authored
Re-center opt in dialog upon launching when no resizing is needed. Bug: b/132199704 Change-Id: I2cbfd157c7b1be2428e3f76e82b8f389aa7a6976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752173Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#686522}
-
Rakib M. Hasan authored
In the build found at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82258 the benchmark is causing one of the shards to time out. Bug: chromium:992837 Change-Id: Ib0110a8bb379e89fd94389ed6a7d68fa2cf812e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750802 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#686521}
-
Richard Knoll authored
As part of the Click to Call feature, we open the dialer with a prefilled phone number. We want to track how many times an actual call is made shortly after that to measure an end to end user journey. Bug: 976311 Change-Id: If966f2fd87f7e7c3675805bac31e547774349989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746466 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#686520}
-
Nate Fischer authored
WebView currently has no UMA records. One possible explanation is if the client_id is always a consistent value. It's hard to check if it's always a consistent value, but we can check for a few classes of invalid values (incorrect length, invalid characters). Tentatively add CHECK()s so we can look for crash data. We'll remove these CHECK()s when we know the root cause. Bug: 992250 Test: None Change-Id: I920061f973a8320bb5b6df14cf2a3a193751e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750346Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d37448e..83ed3059 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I708b4d67c5b3a6778a885acc34123fb6193f1519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686518}
-
Ian Kilpatrick authored
This may not be strictly better, as now we have to initialize, and directly compare these flags. However this harmonizes everything to be similar in the constraint space now. Initially we had this enum to save us from manually copying all of the flags from the builder to the final space. However we changed the builder to directly mutate a space at a later date making this less needed. We then also started to move flags out of this enum, e.g. "size constraints" which go through a different set of checks. Change-Id: I662f2eaf03ebe64bf6d9b51ccc4d1f7de263091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751923Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686517}
-
Jenna Himawan authored
Bug: 993074 Change-Id: I0e43376a89cdb1d5d199309209c118b85a4f44c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746653Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/master@{#686516}
-
Bret Sepulveda authored
In an unrelated patch I discovered that there was no difference between the two Param variables in TabStripTest. is_touch was unexpectedly still false inside GetLayoutConstants even though it should have been overridden to true by TabStripTest::test_api_ . Because ViewsTestBase was calling MaterialDesignController::Initialize() inside SetUp, the value set by TabStripTest::test_api_ was being overwritten. To fix this, the ViewsTestBase call is moved to its constructor, so that it will always happen first. This caused TabCloseButtonVisibilityWhenNotStacked/1 to fail, which was because FakeBaseTabStripController was calling TabStrip::SetSelection before TabStrip::RemoveTabAt, which seems wrong (the tab at active_index_ isn't removed yet). In non-test code, TabStripModel will call RemoveTabAt first, so this patch switches the order and fixes the test. It is unknown why TabCloseButtonVisibilityWhenNotStacked/0 was not failing. This patch also adds a test to ensure the layout is different when switching from touch UI to normal UI and vice versa. Change-Id: I447ffe0ebd99cb56ab77c23e60fa67cf09ba98f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747175Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#686515}
-
Caitlin Fischer authored
(Googlers only) go/owners-expansion-verification-for-components Bug: 989112 Change-Id: Idbbbc3fb8d7da9102a186fd87daf2ccd96b255a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751502 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#686514}
-
Mike Frysinger authored
Python 3 has dropped the types module, so switch to six for the types that still make sense. For basic types (like tuple), we can just use the builtin instead. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9d1fffdcf38c5550dffb9e946bf5890930399280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700507Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686513}
-
John Budorick authored
Bug: 922145 Change-Id: I0cf46ce3601794c07abd0bb4bc56d0474e8d4f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752530Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686512}
-
Shimi Zhang authored
Since both Java and JavaScript uses UTF16 strings, makes it more compatible to use base::string16 in C++. Per comment from http://crrev/c/1719453. Bug: 918065 Change-Id: Ie979c0e400604ec2230bd7cb8319dc74f39616e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750093 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686511}
-
Maksim Ivanov authored
Replace strings hardcoded into the Ash user pod views implementation with the proper i18n calls. Bug: 983103 Change-Id: I975652541e294eba02df2085a12b76ab89b8e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751326 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9fc459b69c78..e765f652958c git log 9fc459b69c78..e765f652958c --date=short --no-merges --format='%ad %ae %s' 2019-08-13 mmoss@google.com [depot_tools] Set "is_luci=False" for buildbot tests. 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e765f652958c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:993137 Change-Id: I617964a8b75cd546bd131b0ecf0cad82aad6ad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686509}
-
Devlin Cronin authored
The downloads.drag API has exceedingly low usage, and has other issues. Remove it. Bug: 986043 Change-Id: I3f0f41fba02a8d729feee9af036a1f383a0e1b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742547Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686508}
-
Malay Keshav authored
This patch adds the posting of important messages to the parent thread. The messages are send when: - a lottie animation is initialized. - a lottie animation has started playing. - a lottie animation has resized its canvas. This patch also fixes the lint for the wrapper code to be closer to chromium's style guide. Change-Id: Ibf27da53ec4bba6ec696041e312c7fb317a64833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747195 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#686507}
-
David Benjamin authored
It is now only set in tests, where it is a largely a no-op because False Start since acquired an ALPN requirement. When False Start is triggered, we do need to worry about post-Connect() handshake data and sessions being established late, but TLS 1.3 has the same problem unavoidably. Abstract the ticket-forcing logic behind a new helper so we can easily add it as needed in the future. (Firefox actually no longer requires ALPN for False Start. This may be worth considering, in which case we may need to revisit some more of these tests. Additionally, SpawnedTestServer doesn't support TLS 1.3 and most of these tests haven't moved to EmbeddedTestServer, which may also require fixing up tests.) Bug: none Change-Id: I444ee12b66aed88898d1492ee0df29817c155348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708675 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#686506}
-
Michael Spang authored
Audio only devices have no display and no GPU. Disable swiftshader so we don't see an error on startup trying to load it. Bug: b/139101843 Change-Id: Ib15d38a1da17e8a5057390879fd684a8b2b9bd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752167Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686505}
-
Xianzhu Wang authored
This is like what we do for paint properties in the document. Bug: 984881 Change-Id: Ib799e852017642d31de2616a5ebab554cbeb3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686504}
-
Justin Cohen authored
These tests are also failing on iPhone now. Bug: 989550 Change-Id: If673678464e4c1158a859a1adfafa118bbfc3698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752080Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686503}
-
Irina Yatsenko authored
The current integration of crash keys into v8 got the dependencies wrong: it introduced into v8 a dependency on components and base. This change is the second half of fixing the design to keep the dependencies in the embedder. The change depends on https://chromium-review.googlesource.com/c/v8/v8/+/1699102. Bug: v8:9323 Change-Id: Ib5b497a50718c451ab38b2bf32c4d68f5a9e22e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690003 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#686502}
-
Danton Vu authored
The items eat the events aimed for the controller than shifts the grid left and right, we need to change so window drags on begin on long presses. Test: manual, added tests Bug: 991346 Change-Id: I387fa0a4acff17e4b9673f1d042cf8ae8d4b1eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749710 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686501}
-
George Steel authored
Update devtools to no longer require the id property as identifying the animation name or transition property and instead use the proper IDL hierarchy and properties. Bug: 849927 Change-Id: I85a1c6eda7f176ce23906ee64b4c9c2d3374c57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740647 Auto-Submit: George Steel <gtsteel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#686500}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: Ia6950462efa1ed9128892059abca965fb9aeb86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751725 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#686499}
-
Min Qin authored
Currently extensions are allowed to use the download API to override downloaded file extensions. This causes some security issues as file with dangerous extensions can be override to safe extensions and bypassing dangerous prompt. And there are also other possible attacks using this feature. This CL blocks plugings from changing the file extensions to an arbitrary one. The mime type will be used to determine the final extension. However, it is possible for plugins to remove the extensions from the final file name. BUG=989078 Change-Id: Idd28510d3db191f40bbe24256d64449856e4644f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740048Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686498}
-
Elly Fong-Jones authored
These were added during the MacViews port to support Mac code like this: if (IsUsingViewsDialogs()) ShowThingViews(); else ShowThingCocoa(); without the Mac code directly linking the Views code, but that build config is now long dead. A followup CL will also remove CreateLoginHandlerViews, but that will be more involved. Bug: None Change-Id: Ifef442e159317763bd6f6f8e652e56495cc195f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752066 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686497}
-
Andrew Grieve authored
This is now safe to do for all of our apks since we don't support JellyBean anymore. Bug: 993342 Change-Id: I670a0d54e6b524c6fa21f712efc6214a04c74bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752102 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686496}
-
Stephen Chenney authored
Various webkit-appearance tests have been passing for quite some time. TBR=ikilpatrick@chromium.org BUG=626703 Change-Id: I68a2659e39ec80387de851d6a5035854abb69380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752125Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#686495}
-
Mia Bergeron authored
This CL adds the current track title and artist to the right of the artwork in a vertical layout. This CL also fixes the elide behavior of the app/source label on the header row. See bug for pictures. Bug: 991647 Change-Id: Ia9c8601a17e1ce472bb984e90cb8a11926edb307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752170Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#686494}
-
Xiaocheng Hu authored
The original counter only counts unitless length literals, which is incorrect and was exposed by a recent refactoring crrev.com/c/1696274 This patch changes the counter to also count unitless lengths involved in math functions (e.g., calc(1 + 1%)). Bug: 979895 Change-Id: I49744bceee307485e979addb3ea9be95d9d22922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750189Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686493}
-
Sorin Jianu authored
This CL is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1747031 It implements the updater::TaskScheduler class to allow creating scheduled tasks using Windows's task scheduler. The code is similar to what //chrome/chrome_cleaner/os has for this purpose. Future refactoring work to eliminate duplicated code is possible but unknown at this point how such effort could proceed. Several dependencies are needed for unit testing this code. The general idea is that a program is invoked by the unit tests scheduled tasks. To detect that such program has run, synchronization with the unit test execution is required. Since the MS task scheduler API is finicky, minimal changes were done to the TaskScheduler class implementation. Bug: 992551 Change-Id: I429a979f3a0aad70bedcf4d6c4847f97dc4b1392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751766Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686492}
-
minch authored
Do not provide the color for inkdrop directly, provide the background color of the element that wants to apply inkdrop instead. And then use AshColorProvider::GetRippleAttributes to get the ripple attributes based on the given background color. Bug: 982950 Change-Id: I7404b24f1df74ca7782a411c21290a975205d72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746765Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#686491}
-
Sébastien Marchand authored
This reverts commit f57f0ad1. Reason for revert: Causes crashes, see crbug.com/993442 Original change's description: > CHECK that OnURLsDeleted() receives info for all deleted origins. > > A developer reported a failure in the DCHECK that verifies that > LocalSiteCharacteristicsDataStore::OnURLsDeleted() receives details > for the origin of all deleted URLs. > > This CL transforms the DCHECK into a CHECK to determine whether this > can happen in production. > > Bug: 966059 > Change-Id: Ia3328ca7d832935ee906ddb5570aa3035a65c0ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749248 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686219} TBR=fdoray@chromium.org,sebmarchand@chromium.org Change-Id: I761101e0e2f4f122013ea7f76c701c3024b2b621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752079Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#686490}
-
Ian Struiksma authored
This flag will spin up WPR in quiet mode, so that the log doesn't balloon with basic stdout call and response information This helps the readability and usefulness of the logs for diagnosing issues Bug: 988509 Change-Id: Ibc195ed4bb135ecdb07e78d0bae7e5701e240917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747863 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#686489}
-
Xianzhu Wang authored
Remove the wrong baselines on mac and linux. The wrong baselines contained wrong width of margin box for an element, which were created probably because of a pre-LayoutNG bug. Bug: 984926 Change-Id: I3f4f163e3c5d96cf129a3399b145110722a9c189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747978Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686488}
-
sangwoo.ko authored
This allows DropdownBarHost animation to be driven by ui::Compositor. There's no intentional behavior change. Bug: 953585 Change-Id: Ie2d4ce5666dd8f1d07918083fcbb813e06c1c3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750504 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#686487}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09cf3681. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I745b557eb4b60ac2f52edb05176dbb31ec483b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752062Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686486}
-
James Cook authored
There's no longer anything to do here. Bug: 729808 Change-Id: Ic0cf93abdcbdfdbfc2392df1a46e1c129a5166fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752286 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686485}
-
yilkal authored
This cl removes stale reference to components/supervised_user_error_page/OWNERS which has been moved. NOPRESUBMIT=true Bug: 969748 Change-Id: I5b82b8ff2e18415e1b191c1a3fbb04383482f03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751969Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#686484}
-