GitLab

The layout guides were not set up in showcase, so the popup was broken.

This also fixes a autolayout warning when the second text view was
larger than one line. The stack view didn't know which text view to
shrink if necessary.

This also turns on adjusting content insets due to safe area for the
popup view controller, so the bottom of the popup does respect the
safe area.

Bug: 962957
Change-Id: I626fcb40420f8728094760cb1261766899e82df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611823Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#662603}

Bug: webrtc:5298
Change-Id: Ie51de26cfe002d087ebc919586e9b3f75aa35ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594530Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662602}

Adds PluginVm.LaunchResult UMA histogram, that records PluginVm launch
result as success or error. Launch result is recorded each attempt to
launch PluginVm.

Bug: 962952
Change-Id: I6ebf8cbbddc2949dff7cf8c469b2480b9e3b6952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611983
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662601}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bd0a8835..b78e7c13

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2743d48b2e9b4316988fb1c376fb18d477c9e46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625799Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662600}

As part of trying to remove the forced UpdateStyleAndLayoutTree on
parsing finished, this test started failing. Parsing the document would
finish and force a style update after display is set to none, but before
the promise is resolved through rAF. Add another rAF to allow for a
lifecycle update of the computed style instead.

Bug: 742413
Change-Id: I91d21b5cd871d82d81dd8fb156465762ad594318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627355Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662599}

Force a style calclation before setting webkitAnimationName in
animation-iteration-event-destroy-renderer.html

Otherwise the animation may be considered to have already completed
before event listeners were added.

BUG=936462

Change-Id: I5db698db48fe8d029079b144c31673abcef2550a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623725
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662598}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22003298ae1b..836ac4b41082


Created with:
  gclient setdep -r src-internal@836ac4b41082

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: Iccba71b5b1ac2faa8ec993cb28f35cf560cd182a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625797Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662597}

Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1607641
This extends plugin_vm::IsPluginVmAllowedForProfile with an
alternative condition for testing and adds the whole check to
ChromeFeaturesServiceProvider so that Chrome OS does the proper
checks for PluginVm.

Adapts all relevant PluginVm tests accordingly.
Currently only PluginVm unit tests rely on PluginVmTestHelper - plan to
change it in the future CLs and file a P3 bug for now.

--gtest_filter="PluginVm*"

Bug: 920999
Test: unit_tests --gtest_filter="PluginVm*" && browser_tests
Change-Id: I0e24186fbf4411de423141dfbf33bf2886b2a357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624192
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662596}

Before, the favicon completion was always called asynchronously,
leading to the original icon appearing for a split second when a
favicon was found in the cache. Now, that completion will be displayed
instantly.

The asynchronicity was there to simplify the FaviconRetriever logic
(the completion was always called asynchronously), but that isn't
actually super important.

Bug: 964918
Change-Id: I30b7d2f8d9fe0ed9324e48eb994ce677398b388b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626861
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662595}

The constructor takes ownership of the injected HttpPostProviderFactory
so let's trivially adopt std::unique_ptr to make this obvious.

While doing this, some member fields are trivially marked as const.

Bug: None
Change-Id: Ieb199dc48c71d68fe6354f1f075a7977f72e7299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626416
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662594}

This is step 3 of https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj

Bug: 950905
Change-Id: I756b531abbab7510384097da1a2b5c003ad1812d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602643
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662593}

https://chromium.googlesource.com/catapult.git/+log/4d346fbec70e..a021ed986342


git log 4d346fbec70e..a021ed986342 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 khokhlov@google.com disable TabTest.testActivateTab on chromeos


Created with:
  gclient setdep -r src/third_party/catapult@a021ed986342

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:947675
TBR=eyaich@google.com

Change-Id: I2c6102aae16f12a5c5414a2478775880d7798119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627297Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662592}

This allows all platforms to have a empty implementation (which reduces
preprocessor macros), and later in this patch chain we will add a
implementation for android.

Bug: 966047
Change-Id: I5446f4da7f9de1e0cb4ecddf77a2142ad1868de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624815Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662591}

The change is related to CL:1598991. Add histogram infomation in
histograms.xml to make the histogram visible on chromedashboard.

BUG=chromium:960297

Change-Id: I7ed0300d6b24f663d897228970057fe33e774377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608966Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662590}

This makes it clear to the casual reader (like me) which things run on
the main thread and which on the background thread.

Bug: none
Change-Id: Ica9eb3f0fc26e0080d5e7c07750e89f51b2192b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627032
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662589}

This reverts commit 28b151ee.

Reason for revert: Reverting to confirm the nature of the original errors.

Original change's description:
> sheriff: Disable flaky SystemHealthBenchmarkSmokeTest stories on Nexus5X.
> 
> The failures are caused by an internal WebSocketException, details
> in bug linked.
> 
> TBR=eyaich@chromium.org
> 
> Bug: 964960
> Change-Id: I1ed9697988164151519eb0b2b1fbb56884f51061
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619829
> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
> Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#661363}

TBR=mbarowsky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964960
Change-Id: Ibb7f61efd2fcbb4ed05f3724a4b4984325929ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627034Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662588}

Add UMA metrics to TextFragmentAnchor to record usage, number of
selectors, rate of matched selectors, whether the user cancelled the
scroll into view, and a performance metric for the latency between
parsing the anchor and scrolling into view.

Verified metrics with chrome://histograms/TextFragmentAnchor

Bug: 932589
Change-Id: Ief1d20ff990c1e121a3a905beeb35f0a38f4268d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596619
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662587}

As described in https://github.com/boostorg/thread/issues/215 and
https://github.com/pocoproject/poco/issues/1836, this API became
available in NDK version 21, not NDK version 20.

Change-Id: I473d19b08e7b20698eec8bc012e0035eee7070b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626298Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662586}

Replace by didReplaceWebState
Move logic from didChangeTab to updateTabViewForWebState
and use it inside didChangeTab & didReplaceWebState.

Bug: 911350
Change-Id: I198b7f39192fa52f5b0e79b72eb9949da27bc0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620707
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662585}

When a long URL is displayed, the steady state omnibox clips it from
the head (and shows only the host), to show the most meaningful part
of the url.
For data: URLs the most meaningful part is the "data:" part, so
it makes more sense to clip on the tail.

Bug: 953294
Change-Id: Ib5404cb85f4f155a3f9cf284343d354262858cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617822
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662584}

We already did this in Chrome [1], and we should also do it here to
prevent confusing error messages for old devices that are not using
cros-camera service.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_stream_manager.cc?l=541&rcl=db450183134eacfd8b877f7c55ada55f52d4dd1f

  "bind /var/run/camera/camera3.sock: Permission denied (13)"
  on old devices.

Bug: b:132770443
Test: Passes capture_unittests, and there is no error message like
Change-Id: I02a0bab188a242b0690fb1f24f123305bb2d5dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627273
Auto-Submit: Shik Chen <shik@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662583}

No behavioral changes are expected, although it's not trivial to claim
so due to subtle ordering changes.

In particular, the registration of control types is now taken care of
in SyncManagerImpl, immediately before NotifyInitializationSuccess() is
run, which continues in SyncEngineBackend where the old code lived.

Somewhat related, the mechanism to brodcast SyncEncryptionHandler-
related events via a proxy observer is also moved to SyncManagerImpl.

We do this in preparation for changing the behavior in future patches.

Bug: 922900
Change-Id: Ie43d06e40403e1bb0476ffec6f82d2596e018588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619813
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662582}

Replace both of their usages by didInsertWebState.
Previously willOpenTab was called from WebStateListObserver's method
didInsertWebState defined in TabModelNotificationObserver. Also didInsertTab
was called from didInsertWebState defined in TabModelObserverBridge. The problem
is there are expectations for the didInsertTab to be called before willOpenTab.
And that it just happens that they get run in the proper order based on which
one is inserted first!
To fix this problem I'm adding a restoration state to TabModel, and entirely
removing the TabModelNotificationObserver. This state (isRestoringSession) will
be used by BVC to determine if the animation part of Tab should run or not
(previously located inside TabModelNotificationObserver which was disabled when
the restoration starts and re-enabled after the restoration is done). This
should be considered a temporary solution as the optimal solution is to move
restoration logic out of TabModel and have a keyed service for it and use the
service to get the restoration state.


This CL also :
Changes tabViewForTab to tabViewForWebState in TabStripController.
Changes updateContentOffsetForTabIndex to updateContentOffsetForWebStateIndex
in TabStripController.
Introduces initiateNewTabAnimationForWebState which handles the logic of
starting the animation previously handled by TabWillOpen in BVC.
Changes animateNewTab to animateNewTabForWebState in BVC.
Updates DisplaySyncErrors in sync_utils.h/mm to take webState instead of Tab as
input and its users.
Updates ReSignInInfoBarDelegate::Create to take webState instead of Tab and its
users.

Bug: 911350
Change-Id: I9aa62b85dfa2a7fcb63b5a1c85c2a5336823cc35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617547
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662581}

This CL moves some referrer and back-forward-list related code from
CRWWebController into CRWWKNavigationHandler.

Bug: 956511
Change-Id: I5411795ab6d814ea38e075804889b76d6a3c20d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624808
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662580}

Clear the response_body_loader_client field on ScriptResource when the
resource body finishes loading. This matches what the ResourceLoader
does, and removes a memory leak.

Bug: 944471
Change-Id: Icd2ef954c7f19624f4947a816882ef028321c95c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626858Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662579}

The crashes occur (on beta channel) when network service is enabled and
web_contents are null, see crbug.com/965488.

Fix: Similar to chrome, early-out when web_contents is null.

BUG=841556,965488

Change-Id: I37a1f5c4d992507adfc4693f4d348ecba993c387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622205Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662578}

This reverts commit db977c4b.

Reason for revert: Suspected culprit for failing Linux ChromiumOS MSan Tests. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/13070

Original change's description:
> Mash cleanup: begin converting login mojo to C++
> 
> This patch moves types implemented in login_user_info.mojom to
> //ash/public/cpp/login_types.h. The handful of methods on
> mojom::LoginScreen which used these types are moved to C++
> interfaces.
> 
> There are two new public-facing C++ interfaces:
> 1. ash::LoginScreen, which is a direct translation of the mojom.
>    This is implemented by ash::LoginScreenController.
> 2. ash::LoginScreenModel, which is used for the methods that
>    were simple thunks in LoginScreenController.
>    (LoginDataDispatcher implements this interface.)
> 
> Bug: 958206
> Change-Id: I329d606b234556bf05aee40849f3aa5ccc6c0be0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610588
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662372}

TBR=xiyuan@chromium.org,estade@chromium.org,tsepez@chromium.org

Change-Id: I0b132ea591725613e9cf2751a099f8376546a18f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626420Reviewed-by: Lowell Manners <lowell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662577}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8d98ba69205..22003298ae1b


Created with:
  gclient setdep -r src-internal@22003298ae1b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: I9b97a432c650a667570e7cf58035fd6a77a23cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627296Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662576}

The copy_bundle_data tool is implemented in terms of pax for directories
and ln hard links for files. The pax command does preserve symbolic
links within the tree that is being copied. But with the way that pax is
invoked by the tool, cd-ing into the source, if the source is itself
a symbolic link to a directory, the tree will be logically copied rather
than just as a symbolic link.

A similar issue exists with the non-directory symbolic link source case,
where a hard link will be produced instead of a symbolic link.

Fix both of these cases by specifically testing if the source is a
symbolic link and then re-creating it if so.

Bug: 955936
Change-Id: I69cf96878e59b0b7b121ae46cba5bc1e81f261ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626269Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662575}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/24e3eea4..bd0a8835

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I57e8105e16ca8e10d615230da10d4b98e5fb784c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625793Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662574}

Note that <image>, <transform-list> and <transform-function> syntaxes
aren't shipping at this time, and remain enabled for testing only.

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QjcyhPZ_sNI/SuB-GuNPDAAJ

Bug: 641877
Change-Id: I548db4896c355ab61c0b3a98bfa5119c2fd896f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623945
Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662573}

This function is never used except in the function unit tests.
Remove it and the corresponding unit tests.

Bug: 842655, 964232, 714018
Change-Id: Ia0e2f85dd86019db776dfed9980b4800def49580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627370
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662572}

During experimentation phase, passwords sync metadata got corrupted
when trying different approaches during the USS passwords sync launch.

This CL is pumping up the database version and clean any
potentially corrupted sync metadata.

This is safe because the corrupted version influenced only
Canary and Dev users, and hence very small number of users should
be affected.

This CL only clears the sync metadata and doesn't remove any password
data. Users will then automatically go through the first sync
experience!

Bug: 902349
Change-Id: If6179c814045b24c16aff8d34b769dc8fe14aaad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625114
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662571}

Before this CL:
The PasswordSyncBridge report a model error whenever adding a password
fails.

After this CL:
Depending on the reason of the failure, if the reason is the remote
update contains an invalid password data, the bridge will instruct the
processor untrack that entity and ignore that update.

Bug: 902349
Change-Id: I5fbb04e91d888593e4ecf0cd028c116ce3a1a3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622211
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662570}

Changing -[AdvancedSigninSettingsCoordinator abortWithDismiss:] to
-[AdvancedSigninSettingsCoordinator abortWithDismiss:animated:completion:]
This is to prepare the main controller to dismiss the SigninInteractionCoordinator.

Related to: http://go/open-url-unity-project

See: crrev.com/c/1621136

Bug: 965463
Change-Id: Idd560498c544a9165a59274f41239fa9c968fd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621172
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662569}

Multilogin was using GoogleServiceAuthError, but it's misleading.
In particular, it was using INVALID_GAIA_CREDENTIALS to represent
transient errors, which is not intuitive.

This CL uses a new error type instead.

This CL also does some cleanup in oauth_multilogin_result:
- removes the use of JSONReader::ReadDeprecated(),
- removes uninitialized variables in parsing code which would
  cause the behavior to be inconsistent when keys are missing.

Bug: 956570
Change-Id: Ic5b29dcea8753b4c471fc5a943326436f59e6d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588557
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662568}

Bug: 520391

Change-Id: Ica3bc5d021cf406e6c0743ed5691b6475e3151ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625792Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Auto-Submit: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#662567}

This CL adds Finch-activated IPH bubbles pointing to the autofill
suggestion chips in the Keyboard Accessory bar.

Screenshots: (supposed to be public, fallback below)
https://storage.googleapis.com/chromium-translation-screenshots/c7398a54e31c16465587c316a41f47c3b457fe57
https://storage.googleapis.com/chromium-translation-screenshots/10e4465d1a9ae7342337b6042611348482ffceaf
https://storage.googleapis.com/chromium-translation-screenshots/415cb951b4882a3d26048284f875747f2836b4c8
Fallback screenshots:
https://photos.app.goo.gl/42TLVALJWSPWsbiKA
https://photos.app.goo.gl/GVg7U3hm5tGNHt229
https://photos.app.goo.gl/kSM3xTA1JhfFBYNx9

The IPH will be activated via Finch by defining studies as shown in
testing/variations/fieldtrial_testing_config.json. To test the IPH,
save a configuration as shown below to ~/tmp/SomeStudy.json and
launch chrome with:
  python ./tools/variations/fieldtrial_util.py \
  ~/tmp/SomeStudy.json android shell_cmd | xargs -I {} \
  out/AndroidDebug/bin/chrome_apk run --args="{}"

Below, one example study that shows IPH iff ...
 ... the feature becomes available to the user (no delay),
 ... it wasn't used at least twice within the last 90 days,
 ... the IPH hasn't already been shown within the last 90 days
 ... and *no* other IPH was shown during this session.
This is also how I intend to launch them and how all three are
currently defined in fieldtrial_testing_config.json:
{
    "KeyboardAccessoryAddressIPH": [
        {
            "platforms": [
                "android"
            ],
            "experiments": [
                {
                    "name": "Address_IPH_Enabled",
                    "params": {
                        "availability": "any",
                        "event_trigger": "name:keyboard_accessory_address_filling_iph_trigger;comparator:<1;window:90;storage:360",
                        "event_used": "name:keyboard_accessory_address_suggestion_accepted;comparator:<2;window:90;storage:360",
                        "session_rate": "<1"
                    },
                    "enable_features": [
                        "IPH_KeyboardAccessoryAddressFilling"
                    ],
                    "disable_features": []
                }
            ]
        }
    ]
}

Bug: 911085
Change-Id: I4477365faf881256804b50c8bc15397cfcb0eed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585883Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662566}

This patch enables port matching in network::OriginAccessList.
Callers in Blink and chrome, or extensions will specify port
information to support port matching in following CLs.

In this CL, all callers still use kAnyPort not to make any
behavior changes.

Bug: 936900
Change-Id: I572ee883050035acb719aaabf71355048472c43a
Tbr: rdevlin.cronin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617561
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662565}

WebThreadSupportingGC is mostly wrapping blink::Thread. Code should use
blink::scheduler::WorkerThread instead.

This CL replaces all the WebThreadSupportingGC::Post*Task() methods by
TaskRunner's Post*Task() ones. That requires a new temporary API in
WebThreadSupportingGC to retrieve the TaskRunner. This will ease the transition
from WebThreadSupportingGC to WorkerThread.

Bug: 961743
Change-Id: I7f323e1a3d79b7c70ee45152df90b841b9a5975f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625107
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662564}