- 01 Feb, 2018 40 commits
-
-
Koji Ishii authored
Following bot results are included. 3441 3449 16 lines were removed and 29 lines were deflaked by consecutive results since 3384. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibb9f9f1b9ce9e290f152bb72aec7104a27ba1dbd Reviewed-on: https://chromium-review.googlesource.com/897222 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533602}
-
Raphael Kubo da Costa authored
We had been using the same checks for both object and any Web IDL types to determine if they were present, namely !(member.IsEmpty() || member.IsNull() || member.IsUndefined()) However, both `null' and `undefined' are valid values for the any type, and they should be considered distinct. Add a separate check for any types without the "member.IsNull()" part of the above one, so that one can pass `null' to an any member and get it back instead of `undefined'. Bug: 803448 Change-Id: I90dce8f0fc6c0f4d4764d724501a58cf26e92526 Reviewed-on: https://chromium-review.googlesource.com/895304Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#533601}
-
Koji Ishii authored
From yoichio's review for the reuslt 3333. https://docs.google.com/spreadsheets/d/1anBCj4MpgP4aY1MNJoJjshFl8-V2k4UIco-p-bhK2oQ/edit#gid=0 Excluded 3 tests that look like to have other issues. NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I31d0ae6bb10aced5299c18ffce42ba5aaf17272d Reviewed-on: https://chromium-review.googlesource.com/896664Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533600}
-
Khushal authored
With sync scheduling, we don't have a draw deadline that can be used to predict whether the main thread will commit before it. Since the heuristic for detecting this does not for the sync scheduling case, currently we default to assume it to be slow and always perform the invalidation at the beginning of frame. This will result in more raster and block the main thread from committing. This change ensures that with sync compositing, we always defer the invalidation in order to merge with the main frame. R=brianderson@chromium.org Bug: 794986 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If56ad4136de91d999dcf3423a90580ba64a1ccb1 Reviewed-on: https://chromium-review.googlesource.com/895188Reviewed-by:
Brian Anderson <brianderson@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533599}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I04bdf03c290f51cd349ffdc921e85d7996ed1759 Reviewed-on: https://chromium-review.googlesource.com/896027Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533598}
-
Trent Apted authored
TBR=mmenke@chromium.org Bug: 807821 Change-Id: I0e3d42610cea3d87565550dee22e4806959d2893 Reviewed-on: https://chromium-review.googlesource.com/897302Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533597}
-
Ramin Halavati authored
A bug is fixed in DEPS to download traffic annotation test executables on Windows, and the executables are updated. Bug: 690323 Change-Id: I0fca767d012f8bad37e0d38bc337aa9442b38a97 Reviewed-on: https://chromium-review.googlesource.com/895593Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#533596}
-
Ramin Halavati authored
'tools\clang\pylib\clang\compile_db.py' uses 'ninja' file to run ninja, while on windows 'ninja.exe' should be called. Change-Id: I2431aeb8b4c887acf0b8a0d8cafac83d062bda78 Reviewed-on: https://chromium-review.googlesource.com/894206Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#533595}
-
Takashi Toyoshima authored
CORSStatus.h is placed at public/platform, but is not used outside Blink. This patch is a mechanical change to move the CORSStatus.h to platform/loader/cors. Bug: 736308 Change-Id: I0febd97b85fe8ad9ce7866925831b043e494081d Reviewed-on: https://chromium-review.googlesource.com/892728Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533594}
-
rbpotter authored
Add the highlighting of the search query in the destination change dialog for Print Preview. Refactor some highlighting code out of chrome/browser/resources/settings/search_settings.js in order to reuse it in print_preview. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id79fdb23717c83337cc5e208331066f364b355bf Reviewed-on: https://chromium-review.googlesource.com/892209 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533593}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/539248475d66..b13fba7efb08 $ git log 539248475..b13fba7ef --date=short --no-merges --format='%ad %ae %s' 2018-01-31 mmoss Allow bools in gclient recipe custom_vars. 2018-01-31 mmoss Allow custom_vars to override vars in flattened output. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifde2934380453412d82d41e778eb5826907de19f Reviewed-on: https://chromium-review.googlesource.com/896548Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533592}
-
Siddhartha authored
GetOrCreate dump is only used when the provider is not certain if the dump should be created. Multiple dumps should have unique IDs. BUG=791205 Change-Id: I46dec025517fb22f0b62a12d7e3ae64c45aa333a Reviewed-on: https://chromium-review.googlesource.com/892488 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533591}
-
Xianzhu Wang authored
Consider <mask> element's bounds. Bug: 807379 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2f78202095881318f9d8b09c190354ea2b9decd6 Reviewed-on: https://chromium-review.googlesource.com/896232 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533590}
-
Kenneth Russell authored
NOTRY=true TBR=xlai@chromium.org Bug: 807742 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I28ca7cadaf38000f08ee1c93f6170271666e9b73 Reviewed-on: https://chromium-review.googlesource.com/896838 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533589}
-
Alex Moshchuk authored
This is a reland of cd5b76ea. PrerenderBrowserTest.PrerenderWindowSize still failing after revert. Original change's description: > Allow navigations to opener's site to go back into opener SiteInstance. > > Previously, when a popup and its opener were cross-site, and neither > site required a dedicated process, navigating the popup back to the > opener's site did not swap processes, so the two ended up in different > processes and couldn't script each other. Even though > DetermineSiteInstanceForURL contains logic to place same-site popups > into their opener's SiteInstance (added as part of the fix for a > similar issue 796912), this logic was never reached because we never > attempted a process transfer in this case, thanks to > IsRendererTransferNeededForNavigation() returning false. > > This CL tweaks IsRendererTransferNeededForNavigation so that a > cross-process transfer is always attempted is such cases. This allows > DetermineSiteInstanceForURL to always place the popup that's going back > to its opener site into the opener's SiteInstance. > > Bug: 807184 > Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec > Reviewed-on: https://chromium-review.googlesource.com/894369 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533410} TBR=alexmos@chromium.org Bug: 807184, 807821 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7808cef9292ff069bcfdd00fe71883d321d7f577 Reviewed-on: https://chromium-review.googlesource.com/897262 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Minh X. Nguyen authored
Bug: 722942 Change-Id: I3beee6eb439cc4ed0819771996ee4f9f4f09197f Reviewed-on: https://chromium-review.googlesource.com/877043 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533587}
-
k2.nagaraju authored
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines https://github.com/w3c/webvtt/pull/423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586}
-
Kenneth Russell authored
Call it "trigger_multiple_dimensions.py" to be more accurate. Remove all GPU-specific references from the code. Update unit test. Change GPU buildbot JSON script to use the script in its new location and with its new command line args. Fixed pylint warnings that weren't caught by the presubmit checks in the script's original location. Add OWNERS for this new directory who are working on Swarming trigger scripts in various capacities. NOTRY=true Bug: 807810 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaed86ff2689e38a655d7969ce3899de3c6ebc998 Reviewed-on: https://chromium-review.googlesource.com/896831 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Kent Tamura authored
#533442 updated html.idl, but didn't update interfaces-expected.txt. TBR=lukebjerring@chromium.org Bug: 807791 Change-Id: I220bdf89c5120598ae65747abb10bf71a8f6b52b Reviewed-on: https://chromium-review.googlesource.com/897164 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533584}
-
Hayato Ito authored
Bug: 776656 Change-Id: I12b79d3867d313331507cd78bc8c75068c84ea3c Reviewed-on: https://chromium-review.googlesource.com/895027 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533583}
-
Kent Tamura authored
Fold them into their callsites. - Having complex logic in generated code is not nice. - Want to centralize custom-element-related code to Document.cpp or core/html/custom/. This CL has no behavior changes. Bug: 806641 Change-Id: Ie0e616715307d773c0733c5cef483454c5f86148 Reviewed-on: https://chromium-review.googlesource.com/897084Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533582}
-
James West authored
- The MediaPipelineBackend::AudioDecoder interface allows SetConfig() to be called before SetDelegate(), but AudioDecoderSoftwareWrapper fails a DCHECK or potentially crashes if that happens. - AudioDecoderSoftwareWrapper::SetConfig() returns true if the codec is AC-3, E-AC-3, or DTS and the underlying audio decoder does not support them, and OnDecoderError() is later called on the DecoderDelegate. Those codecs cannot be decoded in software without a license, so SetConfig() should always return false if the underlying audio decoder does not support them. Bug: internal b/62147653 Test: cast_media_internal_unittests and smoke test on Chromecast Audio Change-Id: If351cb4e6bbd7cbe35550a559f032faafa8ed1b8 Reviewed-on: https://chromium-review.googlesource.com/896975Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#533581}
-
Kazuhiro Inaba authored
The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db BUG=807856 TEST=manually try the migration Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d Reviewed-on: https://chromium-review.googlesource.com/897066Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#533580}
-
Kenneth Russell authored
Fixed the suffixes for the two active histograms (BlacklistFeatureTestResults and BlacklistFeatureTestResultsWindows) and deleted an obsolete one (BlacklistFeatureTestResultsWin). NOTRY=true TBR=isherman@chromium.org Bug: None Change-Id: Ib5e372dfdf58acc5bc08c9bb17cacd938bd88c77 Reviewed-on: https://chromium-review.googlesource.com/882552 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533579}
-
https://webrtc.googlesource.com/src.git/+log/6ade76d69d85..98fd8e5021de $ git log 6ade76d69..98fd8e502 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id33b1e6bc90b935f38af5ac55f819834b6d12532 Reviewed-on: https://chromium-review.googlesource.com/896549Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533578}
-
Yoshifumi Inoue authored
This patch introduces test cases for |NextWordPosition()| to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: Ic98cdea94e5be2f3d13448aa9e087a02b70a0df0 Reviewed-on: https://chromium-review.googlesource.com/895236 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Koji Ishii authored
As our code becomes more matured, it became clear that there are good amount of needs to traverse NGPaintFragment or NGPhysicalFramgnet for a LayoutText/LayoutInline, with the offset to the container box. This is for one that legacy FrameRect is built that way and makes adopting existing code for NG easier, but there are certain operations that operates on a DOM node or a CSS box before line fragmentations. NGPaintFragment is not supposed to be shared across frames, nor at different subtree of a frame, and has a pointer to NGPhysicalFragment. This patch creates a list of NGPaintFragment and keep it in LayoutText/LayoutInline. Some of properties of NGPaintFragment are computed in pre-paint phase, such as VisualRect(), but the NGPaintFragment tree is constructed at the end of layout phase that this list is available whenever layout is complete. Because NGPaintFragment has a pointer to NGPhysicalFragment, NGInlineFragmentTraversal can use this mechanism to find NGPhysicalFragment for a LayoutText/LayoutInline. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I84b628674436523a0ef864aae50b973e6982313e Reviewed-on: https://chromium-review.googlesource.com/888362 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#533576}
-
Jaebaek Seo authored
WebKitHitTestTest.testUnfocusedNodeAndTouchRace fails when enabling --use-zoom-for-dsf, because AwContents.AwViewMethodsImpl.onTouchEvent() passes the event position in DIPs to nativeRequestNewHitTestDataAt() method while values in physical pixels are expected. This CL lets AwContents.AwViewMethodsImpl.onTouchEvent() passes those values in physical pixels when --use-zoom-for-dsf is enabled. TEST=webview_instrumentation_test org.chromium.android_webview.test. WebKitHitTestTest#testUnfocusedNodeAndTouchRace on NEXUS 5X Bug: 737777 Change-Id: I6a51be615d646a9bc671cfad7374c1f73a69fbd3 Reviewed-on: https://chromium-review.googlesource.com/895102 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533575}
-
Devlin Cronin authored
According to the documentation [1], app windows should only be returned from chrome.windows functions if they belong to the calling item. This makes sense, since Chrome Apps are supposed to be entirely separate from extensions running in the browser (which is the reason, e.g., we don't run content scripts in app windows or webviews). Currently, this isn't enforced if the extension supplies a filter. Fix this so that the restriction is properly enforced in all cases, whether the caller supplies a filter or not. Note: There's a reasonable amount of complexity that should be able to be cleaned up as a result of this change, but there's also a likelihood of this being merged. With that in mind, this is a deliberately small and targeted change. A followup will perform the rest of the cleanup. [1] https://chromium.googlesource.com/chromium/src/+/5c7b0986b75f2846359a8adde0d65b0ba31c2e00/chrome/common/extensions/api/windows.json#105 Bug: 804822 Bug: 805528 Change-Id: Ibbb118a8fd6c47a4e87b86380211af5132f3add1 Reviewed-on: https://chromium-review.googlesource.com/893944Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533574}
-
Siddhartha authored
BUG=803822 Change-Id: I6d635e220a5e7a1bf0001426ac4e6c643b90b8fd Reviewed-on: https://chromium-review.googlesource.com/892466Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#533573}
-
Sam McNally authored
Bug: 804793 Change-Id: I5db57099fd3a0d3e348dc97a95e30af21e79d5b2 Reviewed-on: https://chromium-review.googlesource.com/892543Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533572}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Some files in core/ are also updated due to a change in #include dependency. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idd1b01cba2be5a48eb0233058dbcad7e97c4dad1 Reviewed-on: https://chromium-review.googlesource.com/895130Reviewed-by:
-
Siddhartha authored
When TakeHandle() is called, the SharedMemory instance resets itself and transfers ownership to the caller. In this case stop tracking the instance since Unmap() will be noop since memory will be nullptr. On Mac TakeHandle() just duplicates the handle and doesn't reset the current instance. So, still tracking this memory is ok. Note: This will change how private memory footprint is calculated since we no longer track some shared memory instances. BUG=804399 Change-Id: I28ed88bfee2033cdf07595d314505413f067e49b Reviewed-on: https://chromium-review.googlesource.com/884999 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533570}
-
https://chromium.googlesource.com/angle/angle.git/+log/61d5325e631e..15443ebad659 $ git log 61d5325e6..15443ebad --date=short --no-merges --format='%ad %ae %s' 2018-01-31 geofflang Fix angle_gles1_conformance_tests compilation in Chromium. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I7fbc0b9b4eeb7973a3d8a4f5853c98ee23fd5f68 Reviewed-on: https://chromium-review.googlesource.com/896327 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533569}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 806641 Change-Id: Ia3a49d4f1e87ee9a1d027fa700d0c62567b35bf0 Reviewed-on: https://chromium-review.googlesource.com/897062Reviewed-by:
-
Kenichi Ishibashi authored
The current spec says that it isn't nullable [1]. This CL also removes null check in client-navigate-worker.js. There is test coverage for null clientId in fetch-event.https.html so the explicit check here is not needed. You can find spec discussion in [2]. [1] https://github.com/w3c/ServiceWorker/commit/8b483b091e0f0bae6b698cf05d915c2029748ae0 [2] https://github.com/w3c/ServiceWorker/issues/1266 Bug: 807818 Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22 Reviewed-on: https://chromium-review.googlesource.com/892762 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Chris Nardi authored
According to the shortest-serialization principle [1], values should be omitted if their omission wouldn't change the value of reparsing. As "1"/"on" is the default value for font-feature-settings, omit this when serializing, matching the behavior of Firefox. [1]: https://github.com/w3c/csswg-drafts/issues/1564 Bug: 807744 Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07 Reviewed-on: https://chromium-review.googlesource.com/896203Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533566}
-
Sergey Kuznetsov authored
Change-Id: Icb9ed445fa93d0206801eac21117494672165c2a Reviewed-on: https://chromium-review.googlesource.com/895766 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Robert Liao authored
This reverts commit ddb183db. Reason for revert: MSVC generates dynamic initializers for constexpr constructors with non-constexpr variables. It's not clear if the C++ spec allows for this. Original change's description: > Make LazyInstance's constructor constexpr. > > This allows hiding the buffer into private state, this will allow adding more POD > members as a follow-up. > Believe it or not, there was a user of this private state up until very recently..! > https://chromium-review.googlesource.com/c/chromium/src/+/850294 > > This also allows removing the need for the LAZY_INSTANCE_INITIALIZER > construction hack (will follow-up with a mass removal CL). > > -Wglobal-constructors (https://chromium-review.googlesource.com/c/chromium/src/+/866738) > in //base guarantees that this doesn't result in global constructors. > > Bug: 797129 > Change-Id: Id891d051180b18155f0e23c0ec55cb0f4d3018ac > Reviewed-on: https://chromium-review.googlesource.com/861426 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530469} TBR=dcheng@chromium.org,gab@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 797129, 807491 Change-Id: I3bac97268584295fdd39563428c7f7dbe9ae8560 Reviewed-on: https://chromium-review.googlesource.com/896603Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
In spellchecker code, some callbacks are created by binding unretained ptrs, which is not necessarily safe. This patch changes them to use weak ptrs instead. Bug: 807397 Change-Id: I948da2c17f6d693ebf56d82f9300854b638a8826 Reviewed-on: https://chromium-review.googlesource.com/894475Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533563}
-
