- 07 Jul, 2020 40 commits
-
-
Rohit Rao authored
This test's SetUp() tries to mock a class that no longer exists on iOS14 (and therefore crashes). BUG=1102903 Change-Id: Iba82cecec3b5ae6c98b2b3001b5ff91a05788321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284100Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#785985}
-
Joao Victor Almeida authored
This CL proposes new metrics using Presentation Feedback Time instead of Gpu Swap Begin Time as the approximation for the timestamp when the frame is presented in the screen. This is more accurate than the Gpu Swap Begin time as it is the time when the OS compositor starts scan out. This attempt to enhance the AverageLag metrics' precision is a step towards improving the scroll prediction for touch events, by enhancing the metrics used to measure it's quality for a further analysis on alternative prediction timings. The new metrics proposed are: - Event.Latency.ScrollUpdate.Touch.AverageLagPresentation - Event.Latency.ScrollUpdate.Touch.AverageLagPresentation. PredictionPositive - Event.Latency.ScrollUpdate.Touch.AverageLagPresentation. PredictionNegative Bug: 1079024 Change-Id: I92708cf3851e91581a0cf59331b39b169438384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236272 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785984}
-
Meilin Wang authored
This CL handles the system suspend/resume events accordingly when ambient is on. Misc: Minor refactoring including: rename functions and use |ScopedObserver| instead. Bug: b/157252087 Test: covered by unittests. Change-Id: I3a1244e2aa5e47fd83082a7ada40e5b2fb5aabd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270676 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785983}
-
Yuly Novikov authored
For Pixel Wrangler convenient monitoring of SwANGLE CI bots. Bug: 1064477 Change-Id: I31263cb8e5ca94de14f9d6d86ad14f195f420e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284408 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785982}
-
Ben Pastene authored
Everything's been replaced with betty-pi-arc, so these configs are old & unused. Bug: b/150926708 Change-Id: Idf7504557d00288d93311211a3c09e3d79ccda76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284091 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#785981}
-
Matt Menard authored
Add 'DeviceExternalPrintServers' and 'DeviceExternalPrintServersAllowlist' policies to manage external print servers using device policy. Bug: 1100777 Change-Id: I18718c465d14650fbbf7f829ff6221a2fd234002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225861 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#785980}
-
Aya ElAttar authored
Bug: 2270317 Change-Id: I756802a8ac8d8a526f4cf6a5f4c5f15c6fe8ddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282925Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Auto-Submit: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#785979}
-
David Maunder authored
When a Tab has been closed after a grouping operation, the user has moved on so we should not give them an option to undo the grouping (which doesn't make sense anyway as the group no longer exists) Bug: 1100248 Change-Id: I0f7137a51c84e008c2a2edf87d6c727881b569fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278178Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#785978}
-
Victor Costan authored
GetHostUsage() is implemented as GetHostUsageWithBreakdown() plus an adapter callback that strips the extra information. This CL removes GetHostUsage(). A future CL will rename GetHostUsageWithBreakdown() to GetHostUsage(). Bug: 1016065 Change-Id: I0df6dd00c47556c3557afa97cdc022c75c3293b8 Tbr: dullweber Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281727Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#785977}
-
Vicky Min authored
Adding a chrome flag that can enable and disable enumeration and communication of SPP devices means that testing and experimentation can be done without breaking the rest of the serial backend. Bug: 1043300 Change-Id: Ia2158e2292db4d1503188deed44e2e51f49180d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278592 Commit-Queue: Vicky Min <vickymin@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#785976}
-
Joao Victor Almeida authored
Moving the event collection to LayerTreeHostImpl is an initial step towards a new version of the AverageLag metrics using PresentationFeedback times instead of GpuSwap times, which are available through LayerTreeHostImpl. Moving them from LatencyTracker is also interesting as it aggregates events across all viz clients at the end of the GPU pipeline, which can potentially mix up events from multiple sources. Tracking events by viz client (through LayerTreeHostImpl) avoids it. As AverageLagTracker should be dedicated to Telemetry, it is interesting to remove all LatencyInfo preprocessing from it, as LatencyInfo stores a lot of information that is irrelevant to AverageLagTracker. This CL proposes to move the scroll events collection from LatencyTracker to LayerTreeHostImpl. It also proposes an AverageLagTrackingManager, an intermediary class for using AverageLagTracker that preprocesses LatencyInfo objects so AverageLagTracker can be independent from it. As the event collection is moved to LayerTreeHostImpl, the AverageLagTrackingManager also serves to encapsulate any preprocessing from LayerTreeHostImpl and AverageLagTrakcer. Bug: 1079024, 989207 Change-Id: I2e73e244eee9565239a638f00dfbf19d5658eadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189633 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d158aa372c5f..b2dfd8a6ee8c 2020-07-07 hypan@google.com devil: Use device properties to check dtbo and vbmeta images. 2020-07-07 hypan@google.com Add logging when TimeoutError occurs in _RunAdbCmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056214,chromium:1090485,chromium:1093602 Tbr: eseckler@google.com Change-Id: Ie95ce7b83d52dbeeb81d919b852fa68a040b2f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785974}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22f9d885..f612d485 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie17b5a6036f00a0a9e444d55e451d6e275aa8446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283292Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785973}
-
James Long authored
Vue instances initialized in `index.js` have been moved to a component folder in support of the upcoming changes which will involve having multiple endpoints (for class and package graphs). The move to a components-based structure will hopefully reduce duplicate code between the two very similar (for now) pages. Bug: 1093962 Change-Id: I22ae0e5b5604386e341db9293a39aa5121474a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281169 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#785972}
-
Domenic Denicola authored
Bug: 1042415 Change-Id: Ic742454a819841f1bdc8487aa5f16504775d95d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285329Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#785971}
-
Mason Freed authored
This fixes the UAF detected by ClusterFuzz in [1], caused by [2]. The test case added here is a minimized version of the clusterfuzz case, and I verified that it crashes (ASAN UAF) before this patch and no longer crashes after. [1] https://clusterfuzz.com/testcase-detail/6224868955193344 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1912682 Fixed: 1102408 Change-Id: Ieb6a9582ff5b9676596048920bbcff881fdc2eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283901 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#785970}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8a9d2ae039a21c19e224f86ba05807b0fdcacb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285314Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I79957612fb092096fe718a8158f7f819157bafce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284975Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#785968}
-
Kai Ninomiya authored
Bug: 953991 Change-Id: I8174aff1d572a5bb771ff46d96d94ff1b737439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261795 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#785967}
-
Aleks Totic authored
Data structure that holds collapsed borders. Bug: 958381 Change-Id: If9716b5c81f6869dfd07468677490546f1eed34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277060 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#785966}
-
Alex Gough authored
These classes are tied to process creation so it is very unlikely they can be overflowed without also exhausting system resources. It is ok to set a good example though. Bug: 1101547 Change-Id: I2d109a6e9c7ed8f4094495af5de994ae18adb757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278319 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#785965}
-
Stephanie Kim authored
Moved android-official and fuchsia-official to main console since their builds are consistently green now. Changed the android-official timeout back to the default 3 hours since they're now taking around 1-2 hours to complete. Bug: 1072012 Change-Id: I031225052ddc2bffa7f5e53458d2ac8137e1d36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285075 Auto-Submit: Stephanie Kim <kimstephanie@google.com> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Scott Violet authored
This patch removes usage of CancelableTaskTracker from sessions. In general, consumers of sessions code are long lived and make use of the API that uses CancelableTaskTracker early on. This mean using CancelableTaskTracker isn't really useful in sessions code, and generally just adds a bunch of complexity. BUG=1025372 TEST=covered by tests Change-Id: Ib7f332db7c7e3961624d9709a4599a7c6f3a698c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283933Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#785963}
-
Emily Stark authored
These flags are enabled by default and expired since M76. I'm cleaning these up now because I'm starting to think about uneliding scheme/trivial subdomains on hover (for the omnibox UI simplified domain field trials), and it'll be simpler code if we don't have to reason about these expired flags in both enabled and disabled states. Bug: 797354 Change-Id: I766a30c2f886ae1d651c2bf8eed0bc094664bde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277880Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785962}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/0879314d807e..5e8c30a1e0e0 $ git log 0879314d8..5e8c30a1e --date=short --no-merges --format='%ad %ae %s' 2020-06-30 huangdarwin Fix a problem that could cause an infinite loop in the fts3 'merge' command. Created with: roll-dep src/third_party/sqlite/src Bug: 1097979 Change-Id: Id43071991f992cbf999917ee24a3c69e44c4b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283888 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785961}
-
Sreeja Kamishetty authored
-All/RenderFrameHostManagerDefaultProcessTest.NavigationRacesWithSitelessCommitInDefaultProcess/* -All/RenderFrameHostManagerTest.BrowserInitiatedNavigationsSwapBrowsingInstance/* -All/RenderFrameHostManagerTest.ErrorPageNavigationReloadBrowsingInstanceSwap/* -All/RenderFrameHostManagerTest.ProactivelySwapBrowsingInstance/* -All/RenderFrameHostManagerUnloadBrowserTest.PendingDeleteRFHProcessShutdownDoesNotRemoveSubframes/* -RenderDocumentHostUserDataTest.CheckInPendingDeletionState -RenderDocumentHostUserDataTest.CrossSiteNavigation -RenderDocumentHostUserDataTest.FailedNavigation -RenderFrameHostImplBeforeUnloadBrowserTest.SubframeShowsDialogWhenMainFrameNavigates -RenderFrameHostImplBrowserTest.CheckIsCurrentBeforeAndAfterUnload -RenderFrameHostImplBrowserTest.CheckLifecycleStateTransitionOnMainFrame -All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoOpener/* -All/RenderFrameHostManagerTest.NavigateToFooThenBarThenAboutBlankThenFoo/* -NavigationBrowserTest.RendererInitiatedCrossSiteNavigation BUG=1102629 Change-Id: I55ae7cf2b87e200b6cdabdb900763066c65a6be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284224 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785960}
-
Mason Freed authored
This suite was useful during the development of the Form Controls Refresh feature, but now that the feature has been enabled by default for all desktop platforms, this virtual suite can be deleted. Bug: 1034611 Change-Id: Ib2e8b098e50fd8a619371ede2cb5c2e5fd91de36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285073 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#785959}
-
Toby Huang authored
Currently, if an app is disabled pending custodian approval, and the supervised user tries to open it through the launcher, nothing happens. This CL fixes this behavior by either asking for parent permission or displaying an error dialog. If the parent has the "Permissions for sites, apps and extensions" toggle enabled, then launching the app will ask for parent permission. Otherwise, the user will see an error dialog. This CL also refactors some common logic between the ManagementAPI and ExtensionEnableFlow into the SupervisedUserExtensionsDelegate for determining which dialog to show when enabling extensions for supervised users. Bug: 1079415,1071255 Change-Id: I585238db5e9a9de96849b7a15dda120b13339b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238408 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785958}
-
Reilly Grant authored
This change converts callback types in BluetoothTaskManagerWin from base::Callback to base::OnceCallback. There should be no behavioral change from this patch. Bug: 834319 Change-Id: Iaf22099ed65b64681c5787c074d22de9c6c043e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283951 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Peng Huang authored
As my test, With AMD GPU, import semaphore to GL costs 60us. It is costy if we import several semaphores per frame. So Add several UMA for measuring semaphore related cost. Bug: None Change-Id: I6358c198201d9ac69be6ac955a19f705af2ca1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281035 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#785956}
-
James Cook authored
The Lacros browser runs on Chrome OS, but reports a special OS name to differentiate itself from the built-in ash browser + window manager binary. See bug for link to discussion thread. Bug: 1096268 Test: added to components_unittests Change-Id: I37fd53c956b69c991732f58c69a20331addfcbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284228Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#785955}
-
Evan Stade authored
Cancel JS dialogs when a WebContents's delegate is set to null, as the dialog can't show without a WebContentsDelegate. Bug: 1060986 Change-Id: I5272faa23d5461fc8251887d9bc02f03c54e37e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283388Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#785954}
-
Wenyu Fu authored
This reverts commit c41c5c46. Reason for revert: Changed to a different implementation, and fix the flaky test failed on M+ bots. Original change's description: > Revert "[HomepagePromo] Add finch param supressing_sign_in_promo" > > This reverts commit 25269f24. > > Reason for revert: test testSetUp_SuppressingSignInPromo fails constantly in android-arm64-proguard-rel (and fyi builder android-marshmallow-x86-fyi-rel) since > * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2020 > * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/767 > > Original change's description: > > [HomepagePromo] Add finch param supressing_sign_in_promo > > > > Adding the option for homepage promo to suppress the sign in promo when > > user is not signed in. > > > > Bug: 1068831 > > Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379 > > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781109} > > TBR=twellington@chromium.org,wenyufu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1068831 > Change-Id: I97f226e93962469cc8a705e922a3db72d7e84cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265398 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#782189} TBR=twellington@chromium.org,hypan@google.com,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068831 Change-Id: Id652d450f84f44f4d15b2409c61c3cf84fa7c48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269484 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#785953}
-
Jan Wilken Dörrie authored
This change adds a focusConfig for the Password Check button to passwords_section.js, allowing for the proper highlighting when navigating from chrome://settings/passwords/check to chrome://settings/passwords. Since the Password Check button is not an immediate child of the parent autofill page, but rather embedded within the passwords section, a single query selector string is not sufficient, and executing our own handler is required. Fixed: 1101298 Change-Id: I76a23778461880e38f23a25f2b9f4d2ca5328dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275455 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#785952}
-
Rohit Rao authored
BUG=None Change-Id: I13c7aeee67a7e72b665f23a4b1c4b942452db9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284058 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Philip Rogers authored
Change-Id: I379af4d45d9815de894670e4d602263a48f21d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284054 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#785950}
-
Kevin Babbitt authored
The caret-color property was using a one-off StyleAutoColor class which stores similar information to StyleColor with an extra affordance for the |auto| keyword. This CL makes StyleAutoColor a lightweight derived class of StyleColor to allow caret-color to store system color keywords more cleanly. Bug: 1081945 Change-Id: I8f3097471950d96999437f7d6b82ab1b56acc7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274588 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#785949}
-
Zentaro Kavanagh authored
- Use push_back instead of emplace_back where appropriate - See abseil.io/tips/112 Bug: None Test: manual Change-Id: I10538be7fd33b4a66da7409f54ac526b18ee6479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283765 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#785948}
-
Xiaoqian Dai authored
The changes in this CL: - Remove kRed from base layer. - Add Alert, Warning, Positive to control layer, text and icons content layer. - Rename kButtonIconColorProminent to kIconColorProminent to detach it from the button usage only. - Add kButtonLabelPrimary in content layer. Bug: 972162 Change-Id: I9e185186fda651bc022e4cadf457032df59cdb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284216 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
If the user navigates to a modal or system menu (other than by focus automatically jumping there), we should still use the custom behavior for modals. AX-Relnotes: n/a. Bug: None. Change-Id: Ie0b963f1540568cdd8f249ee016e787de45c0b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270468 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#785946}
-
