Commits · 879bf96b6ee0c85cfe39196caae27337cc27b914 · eriksson monteiro / tangled

25 Mar, 2014 40 commits

Rename /shadow-deep/ combinator to /deep/ · 879bf96b

tasak@google.com authored Mar 25, 2014

Shadow DOM styling spec link:
http://drafts.csswg.org/css-scoping/#deep-combinator

BUG=348891
TEST=no new tests because just renaming.

Review URL: https://codereview.chromium.org/210813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

879bf96b

DevTools: move search in styles out of experimental. It proved to be stable. · a7827314

pfeldman@chromium.org authored Mar 25, 2014

R=apavlov@chromium.org

Review URL: https://codereview.chromium.org/211193004

git-svn-id: svn://svn.chromium.org/blink/trunk@169959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a7827314

Restore attribute array length in RecursionCheckPoint. · 3483ee6b

rune@opera.com authored Mar 25, 2014

Missing restore caused unnecessary invalidations in subsequent subtrees.

Also renamed a misnamed parameter in RuleFeature.h

R=esprehn
BUG=356196

Review URL: https://codereview.chromium.org/211333003

git-svn-id: svn://svn.chromium.org/blink/trunk@169958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3483ee6b

[webcrypto] Add structured clone tests for RSA private keys. · f1ccd848

eroman@chromium.org authored Mar 25, 2014

BUG=245025

Review URL: https://codereview.chromium.org/210693002

git-svn-id: svn://svn.chromium.org/blink/trunk@169957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f1ccd848

CHR-1706: Context menu with Shift+F10 shows out of Opera when web contents... · da4f95e8

mboc@opera.com authored Mar 25, 2014

CHR-1706: Context menu with Shift+F10 shows out of Opera when web contents scrolled. In case we are opening a context menu on an element, the menu should be shown as currently, since the element has most probably a correct transform available. Since the <body> element possibly has contents of great height, the context menu should be shown on the upper edge of the displayed part of the element.

BUG=Context menu with Shift+F10 shows out of Opera when web contents scrolled.
The menu's position should not be translated by scroll position in case of
opening a menu for the <body> element.

Review URL: https://codereview.chromium.org/110533004

git-svn-id: svn://svn.chromium.org/blink/trunk@169956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

da4f95e8

Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits · f52fbd4f

eae@chromium.org authored Mar 25, 2014

Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits
method from FontPlatformDataHarfBuzz.

BUG=355806
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/210573002

git-svn-id: svn://svn.chromium.org/blink/trunk@169955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f52fbd4f

DevTools: Fix timeline overview window selection · 9285f505

alph@chromium.org authored Mar 25, 2014

The window selection is shown in a left corner when drag was initiated on a marker.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/211343003

git-svn-id: svn://svn.chromium.org/blink/trunk@169954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9285f505

DevTools: Remove event Console.messageRepeatCountUpdated · 38618f00

sergeyv@chromium.org authored Mar 25, 2014

BUG=

Review URL: https://codereview.chromium.org/211023002

git-svn-id: svn://svn.chromium.org/blink/trunk@169953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

38618f00

Point to build requirements page when there is a dependency check failure. · 456c6242

mlamouri@chromium.org authored Mar 25, 2014

BUG=None

Review URL: https://codereview.chromium.org/196413027

git-svn-id: svn://svn.chromium.org/blink/trunk@169952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

456c6242

This CL add power profiler in DevTools frontend, and draw power data in... · d879445d

pan.deng@intel.com authored Mar 25, 2014

This CL add power profiler in DevTools frontend, and draw power data in PowerOverview of Timeline panel.

BUG=337138

Review URL: https://codereview.chromium.org/104523002

git-svn-id: svn://svn.chromium.org/blink/trunk@169951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d879445d

Remove the include "core/events/ThreadLocalEventNames.h" · cfa40f88

rijubrata.bhaumik@intel.com authored Mar 25, 2014

Only EventTarget.h needs this include

This is a follow up patch for this CL by Adam Barth
https://codereview.chromium.org/26890003

BUG=

Review URL: https://codereview.chromium.org/210133002

git-svn-id: svn://svn.chromium.org/blink/trunk@169950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cfa40f88

Oilpan: Move CSSAnimations and CSSAnimationUpdate to oilpan's heap · 15f5977a

haraken@chromium.org authored Mar 25, 2014

BUG=341032

Review URL: https://codereview.chromium.org/211113002

git-svn-id: svn://svn.chromium.org/blink/trunk@169949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

15f5977a

ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement · 8059218f

rhodovan.u-szeged@partner.samsung.com authored Mar 25, 2014

The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
to default 0. This way we have to check its existence before the usage.

Backported from my WebKit patch: http://trac.webkit.org/changeset/154439

R=hayato@chromium.org
BUG=350414

Review URL: https://codereview.chromium.org/190993002

git-svn-id: svn://svn.chromium.org/blink/trunk@169948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8059218f

DevTools: Collect truncated scopes for async stacks. · d3030bc8

aandrey@chromium.org authored Mar 25, 2014

For async stacks we will collect scopes up to the Local scope (i.e. no inner With or Catch scopes).
This is way more faster (about 2x), since inner scopes require script parsing and scope analyzing.

In the DevTools UI this is a small reduction, as any With object or exception can be evaluated on
async call frame in the console while paused, or looked via a popup on mouseover.

Speed gain: more than 2x.

BUG=340285
R=yurys, pfeldman

Review URL: https://codereview.chromium.org/209473013

git-svn-id: svn://svn.chromium.org/blink/trunk@169946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d3030bc8

Oilpan: Move CSSAnimationData and CSSAnimationDataList to oilpan's heap · dd99f0eb

haraken@chromium.org authored Mar 25, 2014

BUG=341032

Review URL: https://codereview.chromium.org/207683005

git-svn-id: svn://svn.chromium.org/blink/trunk@169945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dd99f0eb

Replace the Persistent in SQLiteDatabase with a member and trace it. · 72c7e0e8

zerny@chromium.org authored Mar 25, 2014

R=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204543005

git-svn-id: svn://svn.chromium.org/blink/trunk@169944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

72c7e0e8

DevTools: limit number of crumbs strip layouts during the update to 3. · 288ffd0b

pfeldman@chromium.org authored Mar 25, 2014

R=aandrey@chromium.org, apavlov@chromium.org

Review URL: https://codereview.chromium.org/208843006

git-svn-id: svn://svn.chromium.org/blink/trunk@169943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

288ffd0b

Move InterpolationEffect to oilpan's heap · 1359cc5a

haraken@chromium.org authored Mar 25, 2014

BUG=341032

Review URL: https://codereview.chromium.org/210823003

git-svn-id: svn://svn.chromium.org/blink/trunk@169942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1359cc5a

Move Event to oilpan's heap · 01fcc90d

haraken@chromium.org authored Mar 25, 2014

Now there is no test failing when I change RefCounted<Event> to RefCountedGarbageCollected<Event>. Thus this CL does the change.

BUG=341032

Review URL: https://codereview.chromium.org/208173004

git-svn-id: svn://svn.chromium.org/blink/trunk@169941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

01fcc90d

DevTools: Fix a bug in Array.remove · 16073072

alph@chromium.org authored Mar 25, 2014

Review URL: https://codereview.chromium.org/199793022

git-svn-id: svn://svn.chromium.org/blink/trunk@169940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

16073072

Blink gardening: updated test expectations · 1d84b119

vsevik@chromium.org authored Mar 25, 2014

TBR=philipj@opera.com
BUG=356148

Review URL: https://codereview.chromium.org/199963006

git-svn-id: svn://svn.chromium.org/blink/trunk@169939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1d84b119

DevTools: rename SourceEditor to SourceView, make entire SourcesPanel a drop target. · 84796abe

pfeldman@chromium.org authored Mar 25, 2014

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/211003002

git-svn-id: svn://svn.chromium.org/blink/trunk@169938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

84796abe

DevTools: Re-land r169860 with UI fixed (empty boxes and missing Styles toolbar buttons) · 5c590cc8

apavlov@chromium.org authored Mar 25, 2014

TBR=pfeldman

Review URL: https://codereview.chromium.org/208653013

git-svn-id: svn://svn.chromium.org/blink/trunk@169937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5c590cc8

Check if input element is a range control before painting slider ticks · 4f491f69

keishi@chromium.org authored Mar 25, 2014

We weren't checking if the input element is a range control inside paintSliderTicks and so we were hitting an assert.

TEST=Automated. Added slider-appearance-with-ticks-crash.html.
BUG=350905

Review URL: https://codereview.chromium.org/194273004

git-svn-id: svn://svn.chromium.org/blink/trunk@169936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4f491f69

Make InterpolationRecord GarbageCollectedFinalized · 30f7d1b5

haraken@chromium.org authored Mar 25, 2014

Since InterpolationRecord has a RefPtr, it should be GarbageCollectedFinalized.

BUG=341032
TBR=ager

Review URL: https://codereview.chromium.org/208283005

git-svn-id: svn://svn.chromium.org/blink/trunk@169935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

30f7d1b5

Fix button color on Android to match Ash · 5bd1e350

keishi@chromium.org authored Mar 25, 2014

buttons and <select> buttons were darker on Android than on Ash.

BUG=351275

Review URL: https://codereview.chromium.org/189263006

git-svn-id: svn://svn.chromium.org/blink/trunk@169934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5bd1e350

Update screen.orientation to follow the latest version of the specs. · 19908d78

mlamouri@chromium.org authored Mar 25, 2014

It also returns 'portrait-primary' when the frame is detached
instead of empty string (current behaviour).

BUG=162827

Review URL: https://codereview.chromium.org/207833003

git-svn-id: svn://svn.chromium.org/blink/trunk@169932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

19908d78

Revert of DevTools: Implement Styles search and Computed style filter... · e43015d6

apavlov@chromium.org authored Mar 25, 2014

Revert of DevTools: Implement Styles search and Computed style filter (https://codereview.chromium.org/129793013/)

Reason for revert:
Broke the Styles pane

Original issue's description:
> DevTools: Implement Styles search and Computed style filter
> 
> The user can search styles by property name, value, or rule selector.
> Computed style properties are filtered, so that only matching ones are visible.
> 
> R=eustas, pfeldman, vsevik
> BUG=278852
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169860

TBR=eustas@chromium.org,pfeldman@chromium.org,vsevik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=278852

Review URL: https://codereview.chromium.org/208503006

git-svn-id: svn://svn.chromium.org/blink/trunk@169931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e43015d6

Oilpan: Prepare to move DatabaseAuthorizer to Oilpan heap. · 4432716e

tkent@chromium.org authored Mar 25, 2014

Note: This CL changes the argument type of SQLiteDatabase::setAuthorizer from
PassRefPtr<DatabaseAuthorizer> to DatabaseAuthorizer*. We don't need to use
PassRefPtr<> here.

BUG=347902

Review URL: https://codereview.chromium.org/210853002

git-svn-id: svn://svn.chromium.org/blink/trunk@169930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4432716e

Oilpan: Prepare to move SQLResultSet and SQLResultSetRowList to oilpan heap. · b9847a89

tkent@chromium.org authored Mar 25, 2014

Without this CL, a SQLResultSet object in SQLStatementBackend can be constructed
in a database thread, moved to main/worker thread, and referred by JavaScript
object in the main/worker thread.

We can't move object ownership over threads in Oilpan. So, SQLStatementBackend
should construct a SQLResultSet object in the SQLStatementBackend constructor,
which runs in main/worker thread. SQLResultSet should have a validity flag to
represent nullness in the code without this CL.

Note:
* Change the return type of AbstractSQLStatementBackend::sqlResultSet from
  PassRefPtr<SQLResultSet> to SQLResultSet* because the function doesn't release
  the ownership of the SQLResultSet object.

* Change the order of data members of SQLResultSet to pack better.

BUG=347902

Review URL: https://codereview.chromium.org/207453006

git-svn-id: svn://svn.chromium.org/blink/trunk@169929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b9847a89

DevTools: Rename WebInspector.DOMAgent into WebInspector.DOMModel · 3c189d3c

sergeyv@chromium.org authored Mar 25, 2014

BUG=

Review URL: https://codereview.chromium.org/206313004

git-svn-id: svn://svn.chromium.org/blink/trunk@169928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3c189d3c

Support invalidation sets for :host pseudo. · 4de702b3

rune@opera.com authored Mar 25, 2014

Traverse the selectorList() for :host pseudo, extract features, and create
class invalidation sets like we do for features and classes on the top level.

R=esprehn,ojan
BUG=335247,339729

Review URL: https://codereview.chromium.org/209333005

git-svn-id: svn://svn.chromium.org/blink/trunk@169927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4de702b3

PassRefPtr is stolen by first agent invocation. · 7a99d4dc

eustas@chromium.org authored Mar 25, 2014

BUG=353921

Review URL: https://codereview.chromium.org/206073005

git-svn-id: svn://svn.chromium.org/blink/trunk@169926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7a99d4dc

Rename drawSystemFocusRing() to drawFocusIfNeeded() · 4c07a73c

jinho.bang@samsung.com authored Mar 25, 2014

RESOLUTION: to change draw SystemFocusRing to drawFocusIfNeeded.

public discussion:
  http://www.w3.org/Bugs/Public/show_bug.cgi?id=23980
  http://www.w3.org/WAI/PF/HTML/wiki/Summary_of_2014-01-13_Meeting
  http://www.w3.org/2014/01/13-html-a11y-minutes.html#item02

other browsers:
  It has already been agreed or changed.
  http://bugzilla.mozilla.org/show_bug.cgi?id=959820 (Firefox)

BUG=354960

Review URL: https://codereview.chromium.org/208003003

git-svn-id: svn://svn.chromium.org/blink/trunk@169925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4c07a73c

Deprecate webkitRequestAnimationFrame and friends as vendor-specific · e4d956a5

philipj@opera.com authored Mar 25, 2014

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/nNsZDn_utUc/dUtD3ulsFMkJ

BUG=354921

Review URL: https://codereview.chromium.org/208263005

git-svn-id: svn://svn.chromium.org/blink/trunk@169924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e4d956a5

Remove EventPath::parent() in favor of NodeRenderingTraversal::parent(). · 5fa209cd

hayato@chromium.org authored Mar 25, 2014

EventPath::parent() is only used in adjusting the result of HitTest in some places.
For example, if a text node is clicked, we have to adjust the result to the *reasonable* parent element of the text node.

In adjusting, we should use NodeRenderingTraversal::parent() instead of EventPath::parent().
That means the adjusted result is no longer shadow roots or insertion points.
The result would be the parent element of the text node in the composed tree.
That should make sense because neither shadow roots nor insertion points are rendered.

BUG=354366

Review URL: https://codereview.chromium.org/210753002

git-svn-id: svn://svn.chromium.org/blink/trunk@169923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5fa209cd

Do not zero-initialize RawPtr. · 4b1ae5bf

ager@chromium.org authored Mar 25, 2014

RawPtr is a transition type that will be removed and replace with a
normal pointer. Normal pointers are not default initialized and therefore
RawPtr shouldn't be either. Instead, we introduce a zap value in debug
mode to make it easier to find uninitialized RawPtrs during the transition.

R=erik.corry@gmail.com, oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org

Review URL: https://codereview.chromium.org/209433004

git-svn-id: svn://svn.chromium.org/blink/trunk@169922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4b1ae5bf

DevTools: [Frameworks] Bugfix: do StepOut in framework code after StepIn limit is up. · e148fa29

aandrey@chromium.org authored Mar 25, 2014

Bump up the limit from 10 StepIns to 20.
Add a test on framework code.

BUG=267592
R=pfeldman, yurys

Review URL: https://codereview.chromium.org/210243002

git-svn-id: svn://svn.chromium.org/blink/trunk@169921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e148fa29

Avoid duplicate hash lookups in CustomElementScheduler::ensureCallbackQueue · 372218eb

esprehn@chromium.org authored Mar 25, 2014

We can use add() to avoid doing two hash lookups in the common case where
there's no callback queue yet (ex. setting a new attribute) and we can
also return a reference.

Review URL: https://codereview.chromium.org/206623006

git-svn-id: svn://svn.chromium.org/blink/trunk@169920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

372218eb

Oilpan: Move Interpolation's hierarchy to oilpan's heap · b7854d8c

haraken@chromium.org authored Mar 25, 2014

This CL moves Interpolation's hierarchy and InterpolationRecord to oilpan's heap. I'll move other Interpolation objects in a follow-up CL.

BUG=341032
NOTRY=true

Review URL: https://codereview.chromium.org/210783002

git-svn-id: svn://svn.chromium.org/blink/trunk@169919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b7854d8c