GitLab

Rather than having to manually define each function in Window.Callback
and forward it along, instead use reflection to automatically forward
all calls that aren't interesting.

BUG=487378

Review URL: https://codereview.chromium.org/1139913005

Cr-Commit-Position: refs/heads/master@{#330015}

QueryResultManager allows the Media Router dialog to query for sets of media sinks compatible with specific media sources.  Each media source is in a correspondence to a cast mode (a specific action/button the user can take to
initiate casting).

NOTE: The mock_media_router.{h,cc} files will be put later into a proper test_support target for the media_router.

BUG=464216

Review URL: https://codereview.chromium.org/1131913003

Cr-Commit-Position: refs/heads/master@{#330014}

Disable flaky tests on Mac: PlatformChannelPairPosixTest.SendReceiveFDs and PipeCount/MultiprocessMessagePipeTestWithPipeCount.PlatformHandlePassing/2

TBR=viettrungluu@chromium.org
BUG=488260,488258

Review URL: https://codereview.chromium.org/1126293008

Cr-Commit-Position: refs/heads/master@{#330013}

Before, the TransportConnectJob simply inferred that, if the main socket
failed to connect, the address it was using was the last address in the
list. With this change, the TCPClientSocket actually tracks all of the
connection attempts made (as it tries each address in the list), and the
TransportConnectJob copies the attempts from both the main and fallback
sockets and records all of them in the ClientSocketHandle in
GetAdditionalErrorState.

BUG=480565
TBR=jam

Review URL: https://codereview.chromium.org/1096203006

Cr-Commit-Position: refs/heads/master@{#330012}

HttpResponseInfo contains a "network_accessed" flag that is currently
set when HttpNetworkTransaction finishes sending the request. This is
not entirely accurate; it ends up false for requests that don't send a
request but do touch the network in other ways (e.g. DNS resolution
fails, or TCP connection is terminated before we finish sending the
request).

This flag is used only by Domain Reliability for checking whether a
request touched the network, and by ServiceWorker for histograms.
horo says ServiceWorker won't be affected, and I would prefer these
semantics for Domain Reliability's use, so I'm changing it.

Note that this also changes several instances of GetResponseInfo
to stop returning NULL.

See also for context:

https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/Wtn65jGyot0

BUG=480565

Review URL: https://codereview.chromium.org/1072423005

Cr-Commit-Position: refs/heads/master@{#330011}

Review URL: https://codereview.chromium.org/1135823008

Cr-Commit-Position: refs/heads/master@{#330010}

Revert of Media Router GYP/GN cleanup (patchset #14 id:260001 of https://codereview.chromium.org/1136623003/)

Reason for revert:
Broke Linux bots on Chromium waterfall, see

http://build.chromium.org/p/chromium/builders/Linux/builds/62091
http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=3231

The error in gclient runhooks is:

gyp: Key 'dependencies' repeated at level 3 with key path 'targets.3' while reading /b/build/slave/Linux_x64/build/src/chrome/browser/media/router/media_router.gyp

Not sure why this didn't show up on other bots or trybots.

Original issue's description:
> Media Router GYP/GN cleanup:
>
> - Refactor GYP and GN files to share source lists.
> - Extract a proper test_support target.
> - Fix upstream files with new target structure.
>
> BUG=461815,464199,464205
>
> Committed: https://crrev.com/9c5e5781517823c18144b0bb5b66b66a1afd6733
> Cr-Commit-Position: refs/heads/master@{#330002}

TBR=brettw@chromium.org,kmarshall@chromium.org,mfoltz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461815,464199,464205

Review URL: https://codereview.chromium.org/1140183002

Cr-Commit-Position: refs/heads/master@{#330009}

This completes the path from the secure surface preference, through requestMediaKeySystemAccess() and finally to CDM creation on Android where secure codecs are enabled. With this change, configs requiring secure codes are rejected without the preference and the CDM is only configures to use hardware-secure codecs if the config requires it.

There is a separate bug (http://crbug.com/478185) for implementing similar plumbing for the use of secure surfaces.

BUG=467779

Review URL: https://codereview.chromium.org/1131753003

Cr-Commit-Position: refs/heads/master@{#330008}

BUG=b/19776978

Review URL: https://codereview.chromium.org/1131853004

Cr-Commit-Position: refs/heads/master@{#330007}

Lo-Fi directives were added to the Chrome-Proxy response header.
Adding testing of these responses in the Lo-Fi integration test.

BUG=487879

Review URL: https://codereview.chromium.org/1131063005

Cr-Commit-Position: refs/heads/master@{#330006}

BUG=485649
TEST=PartialScreenShotTest.VisibilityTest
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/1128933009

Cr-Commit-Position: refs/heads/master@{#330005}

Bugs 237703 & 168933 have been closed, adjusting comment to reflect
that reality

TBR=mpearson@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1139773004

Cr-Commit-Position: refs/heads/master@{#330004}

Plus a few other small clang-format fixes.

BUG=None
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1131683003

Cr-Commit-Position: refs/heads/master@{#330003}

- Refactor GYP and GN files to share source lists.
- Extract a proper test_support target.
- Fix upstream files with new target structure.

BUG=461815,464199,464205

Review URL: https://codereview.chromium.org/1136623003

Cr-Commit-Position: refs/heads/master@{#330002}

This includes:
* Creating CmaRenderer and its dependencies (most of the renderer-side),
  stubbing out at the IPC level.
* Moving FakeDemuxerStream to media/base/ to allow use outside of //media

R=servolk@chromium.org,xhwang@chromium.org

Review URL: https://codereview.chromium.org/1137263002

Cr-Commit-Position: refs/heads/master@{#330001}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1130163005

Cr-Commit-Position: refs/heads/master@{#330000}

This works the same way as NativeAppWindowCocoa by inserting a colored
NSView into the window's contentView's superview.

This also adds a test that checks for correct frame colors when active and
inactive.

BUG=459877

Review URL: https://codereview.chromium.org/1053303003

Cr-Commit-Position: refs/heads/master@{#329999}

MessageLoopProxy is deprecated.
This basically does a search and replace of:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

MessageLoopProxy -> SingleThreadTaskRunner

BUG=391045

Review URL: https://codereview.chromium.org/1124153005

Cr-Commit-Position: refs/heads/master@{#329998}

Treat a delay of under 1 millisecond in MessagePumpDefault as a signal that the corresponding delayed task needs to execute

On Windows for e.g. the lowest resolution we can get on the system clock is 1 ms or 4 ms depending on whether the machine
is powered by AC or battery. The OS default is 15ms. So that effectively means that if a delayed task is waiting to execute
for a delay of under 1 ms would cause the underlying OS WaitForSingleObject call to return immediately effectively spinning
a tight loop with a kernel mode context switch.

Fix is to treat a delay of under 1 ms as a signal that the task is ready to execute for all platforms.

BUG=487724

Review URL: https://codereview.chromium.org/1137453006

Cr-Commit-Position: refs/heads/master@{#329997}

There are two ways of accessing IsReadyToDraw and NeedsRaster. One is
via tile->IsReadyToDraw(), the other is via
tile->draw_info().IsReadyToDraw(). The first one is actually does the
same thing as the second one. This patch removes the shortcut and
makes all uses of this functionality consistent.

R=enne

Review URL: https://codereview.chromium.org/1139673008

Cr-Commit-Position: refs/heads/master@{#329996}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/0e5c45a...e53550b.

BUG=484833

Review URL: https://codereview.chromium.org/1128743004

Cr-Commit-Position: refs/heads/master@{#329995}

Revert of vea_unittest: Calculate per-frame encode latency (patchset #16 id:300001 of https://codereview.chromium.org/1117853002/)

Reason for revert:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/X86%20%28chromium%29/builds/4667

chromium-os builders went red. Looks like there's a signed/unsigned comparison.

Original issue's description:
> vea_unittest: Calculate per-frame encode latency
>
> Calculates per-frame encode latency, which is basically the time delay from
> input of each VideoFrame (VEA::Encode()) to output of the corresponding
> BitstreamBuffer (VEA::Client::BitstreamBufferReady()).
>
> It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.
>
> Also fix a wrong comment.
>
> BUG=345181
> TEST=Check "Encode latency for the 50%/75%/95%" in output logs.
>
> Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86
> Cr-Commit-Position: refs/heads/master@{#329819}
>
> Committed: https://crrev.com/738487a69f150975376c36e214c64a77b1ff0cc6
> Cr-Commit-Position: refs/heads/master@{#329838}

TBR=owenlin@chromium.org,posciak@chromium.org,wuchengli@chromium.org,jchuang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=345181

Review URL: https://codereview.chromium.org/1145543002

Cr-Commit-Position: refs/heads/master@{#329994}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/e3ef0c4c8e...aa79b394e7

Picked up changes:
aa79b39 Strip bgcolor attribute from all table elements
ec27418 Show distilled page in Chrome Extension
1f211a4 Simplify testImageWithSrcset
b9e2b72 Update doc about Developing on Mac OS X
270058c Shuffle tests in continuous integration
f5070fd Properly restore test environment between tests
7a0544c Support running jstests repeatedly
fa4d011 Support running tests in random order
a03cbd2 Disregard "comment" appearing in className when too many classes
0650d41 Never regard HTML elements as comments
31359c2 Allow test.filter to begin with a dash
d4854eb Catch errors in continuous integration script
8a6e619 Skip tests using URL() in continuous integration
af015b9 Update document about filter syntax in jstest
b27ab2b Replace create_standalone_js.py with a custom GWT linker
10bc28c implement validations of pagination URLs
1ec32c2 Strip color attributes from font tags
772dbda Add script for landing CLs on behalf of external authors.
c0edaeb Find Python using 'env' in protoc plugin
9ae05a4 Fix regression in srcset handling

BUG=382993,436226,437113,464123,483036,483149,483172

Review URL: https://codereview.chromium.org/1130823004

Cr-Commit-Position: refs/heads/master@{#329993}

Do not run list these tests to run on Android for now.

BUG=486220
TBR=sky@chromium.org
TEST=mojo/tools/apptest_runner.py mojo/tools/data/apptests out/android_Debug passes.

Review URL: https://codereview.chromium.org/1122373003

Cr-Commit-Position: refs/heads/master@{#329992}

Three basic tests added:
1) DamageTriggersSwapBuffers
2) NoDamageDoesNotTriggerSwapBuffers
3) LockingResourcesDoesIndirectlyCauseDamage

The last test is a regression test to make sure we
don't accidentally damage the root surface every frame.
It fails with the following patch applied, which
got reverted:
https://codereview.chromium.org/1073323002

BUG=476544

Review URL: https://codereview.chromium.org/1124273004

Cr-Commit-Position: refs/heads/master@{#329991}

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1141153002

Cr-Commit-Position: refs/heads/master@{#329990}

When Chrome's ETW tracing is enabled it can consume more than half
of the total CPU time in the process, which means it is distorting
the results it is trying to measure. It also puts a lot of data into
the trace which cannot be viewed.

The biggest consumer of CPU time, by far, is AppendAsTraceFormat, which
consumes over 95% of the CPU time in TraceEventETWExport::AddEvent. Because
all categories are enabled this ends up creating many large buffers. The
cc::LayerTreeHostImpl events have been seen up to 22,500 bytes and
cc::Picture payloads have been seen up to 3,200,000 bytes! Ironically
the WPA trace viewer can't view payloads larger than 4094 bytes so all we
see for this effort and overhead is "Unable to parse data".

Truncating the payloads would let us see the partial data but would still
leave the distortion of execution time. The long-term solution is to
specify what categories are enabled in order to manage the volume of data.
Until then the prudent thing to do is to disable calls to AppendAsTraceFormat.

In addition, there is no reason for phase_string to be a std::string. This
overhead is relatively minor but measurable. It's worth fixing because the
fix is clean and simple.

The net effect is to drop the CPU overhead from 33-50% down to 1-7%.

This change makes Chrome's ETW tracing much more usable.

R=primiano@chromium.org
BUG=488257

Review URL: https://codereview.chromium.org/1140843003

Cr-Commit-Position: refs/heads/master@{#329989}

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1125213007

Cr-Commit-Position: refs/heads/master@{#329988}

When a cadence based rendering sequence exceeds drift, we should not
count the over-rendered frame against the next in sequence.  Doing
so causes an accumulation of errors.

Also extends the moving average for durations to 32 values and the
allowable drift to 16.66ms to stabilize the Catzilla 60fps and
Elite: Dangerous 60fps clips, which were hitting hysteresis very
frequently.

BUG=439548
TEST=new unittest.

Review URL: https://codereview.chromium.org/1139973003

Cr-Commit-Position: refs/heads/master@{#329987}

This allows manual override of the AppListMixer field trial.

BUG=487494
TEST=On ChromeOS, turn on flag enable-new-app-list-mixer. Search for
"goog" should return more than 6 total results.

Review URL: https://codereview.chromium.org/1139083002

Cr-Commit-Position: refs/heads/master@{#329986}

- Removes drop-down-button custom polymer element.
- Removes Media Router drop-down icons.
- Replace drop-down-button with core-icon-button.

Review URL: https://codereview.chromium.org/1128023003

Cr-Commit-Position: refs/heads/master@{#329985}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/842d065..dc02170

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1142563002

Cr-Commit-Position: refs/heads/master@{#329984}

On at least one machine Chrome hits a problem where DwmGetCompositionTimingInfo
says that qpcRefreshPeriod is 60. This implies a refresh rate of ~34,000 fps.
Chrome dutifully tries to hit this frame rate leading to excessive CPU usage.

This change adds a couple of checks to detect bad values and fix them. In
parallel this bug is being reported.

R=piman@chromium.org
BUG=486226

Review URL: https://codereview.chromium.org/1141013004

Cr-Commit-Position: refs/heads/master@{#329983}

BUG=487866

Review URL: https://codereview.chromium.org/1132933004

Cr-Commit-Position: refs/heads/master@{#329982}

This CL adds functionality to check whether
http://clients4.google.com/generate_204 URL can be reached and returns
status code HTTP 204. The cache is bypassed and no redirects are allowed.

The functionality this provides will be used by the feedback system to
provide additional data in the report akin to a "Is this thing on?" type
test.

BUG=386395

Review URL: https://codereview.chromium.org/1127983002

Cr-Commit-Position: refs/heads/master@{#329981}

SetHighPerfMode needs root, but it currently only checks to see if
we already have root rather than trying to enable it.

BUG=478104

Review URL: https://codereview.chromium.org/1135393005

Cr-Commit-Position: refs/heads/master@{#329980}

This enables VoiceOver in OS X 10.10 to use the rotor and other
keyboard shortcuts that move by element type.

BUG=471119

Review URL: https://codereview.chromium.org/1134653003

Cr-Commit-Position: refs/heads/master@{#329979}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/87a773c..9d21429

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1128363007

Cr-Commit-Position: refs/heads/master@{#329978}

What was WindowManagerInternal* is now ViewManagerRoot*.

The initial bootstrap is:
. App connects to view_manager and asks for ViewManagerService.
. ViewManager asks this connection for ViewManagerClient, and calls
  OnEmbed.
. The ViewManager exposes the services ViewManagerRoot to the initial
  connection.

All of this is handled for you if you use ViewManagerInit.

As WindowManager is no more, Embed with just a url is lost. I'm
assuming you'll add that back.

BUG=487870
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1138073007

Cr-Commit-Position: refs/heads/master@{#329977}

GN will now compute the list of files required for targets to run based on dependencies and data files listed on the targets.

This is exposed via the "gn desc ... runtime_deps" command, and via a new switch that will write runtime deps files for specific targets at generation time.

Review URL: https://codereview.chromium.org/1130183007

Cr-Commit-Position: refs/heads/master@{#329976}