GitLab

BUG=465495

Review URL: https://codereview.chromium.org/1022673002

Cr-Commit-Position: refs/heads/master@{#321295}

As announced on chromium-dev: http://goo.gl/NqrmLk (and after
discussions with chrome-eng-review).

This CL shouldn't change any user-visible UI, just change the way Chrome
is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
rather than the (outdated) ui/app_list/cocoa/.

A ~0.43% sizes regression on Mac is expected with this CL (~652kB
uncompressed). Full details in a doc: http://goo.gl/oHucmf

With this change, toolkit-views test cases in interactive_ui_tests will
start running on bots. views_unittests will be added to the Mac bots in
a follow-up.

BUG=363529

Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
Cr-Commit-Position: refs/heads/master@{#321075}

Review URL: https://codereview.chromium.org/984513002

Cr-Commit-Position: refs/heads/master@{#321294}

Keep this hack until fractional scrolling with fixed-pos layer works
correctly.

BUG=468513

Review URL: https://codereview.chromium.org/1015273002

Cr-Commit-Position: refs/heads/master@{#321293}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8dc58ed..1a5041e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1023583002

Cr-Commit-Position: refs/heads/master@{#321292}

Remove those two pages from top_25_smooth because top_25_smooth pages should be runnable on all platforms.

BUG=468085

Review URL: https://codereview.chromium.org/1018213002

Cr-Commit-Position: refs/heads/master@{#321291}

Create Mac specific BrowserNonClientFrameViewMac, stop sharing
OpaqueBrowserFrameView.
Draw the frame using Mac colors, assets, and spacing.

Screenshot: https://code.google.com/p/chromium/issues/detail?id=425229#c40

BUG=425229

Review URL: https://codereview.chromium.org/1019023002

Cr-Commit-Position: refs/heads/master@{#321290}

R=ajuma

Review URL: https://codereview.chromium.org/1022653002

Cr-Commit-Position: refs/heads/master@{#321289}

As there's no API to know existence of certain menu item, we have to try
removing non-existent menu item.
Outputting error on console for such case is confusing, so this CL suppress the
error by reading runtime.lastError.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1003303003

Cr-Commit-Position: refs/heads/master@{#321288}

Querying CAPI and CNG seem to both fail on some environments. Rather
than hope smartcards and whatnot implement the necessary features,
bypass Windows APIs entirely and extract the information out of the
public key in the certificate using BoringSSL APIs.

BUG=468345

Review URL: https://codereview.chromium.org/1002013009

Cr-Commit-Position: refs/heads/master@{#321287}

The PNaCl toolchain will soon be required by SCons to build the IRT. Even
though nacl_integration doesn't use the IRT built by SCons, it still wants to
set up the environment as part of the SCons global initialization, and that
fails if the compiler is not found.

Also remove the extra download, since the toolchain in the native_client directory (which is already synced by gclient) is now used.

R=ncbray@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4088

Review URL: https://codereview.chromium.org/1021563002

Cr-Commit-Position: refs/heads/master@{#321286}

Simplify the code that calls SetNeedsBeginFrames on the frame source so
that it's easier to understand. This paves the way for the state machine
to know as little as possible about the deadline which is required for
the upcoming webview-scheduler refactor.

BUG=439275

Review URL: https://codereview.chromium.org/987563002

Cr-Commit-Position: refs/heads/master@{#321285}

Some devices which use exnynos need more ampere to boot up at the initial time.
In this case, the StartUpCurrent should be set to 5 at least.
SetStartupCurrent function is for setting the initial ampere value in monsoon profiler.

Review URL: https://codereview.chromium.org/1013943002

Cr-Commit-Position: refs/heads/master@{#321284}

This renders and injects the chrome-search://large-icon and
chrome-search://fallback-icon URLs for the local NTP, which (in upcoming
CL) uses the presence of these flags to decide whether to render icons
instead of thumbnails. The feature is hidden behind flag "IconNTP/Enabled".

BUG=467712

Review URL: https://codereview.chromium.org/1016793003

Cr-Commit-Position: refs/heads/master@{#321283}

We do it in two stages, first a DOM element requests fullscreen inside <webview>,
this fires a permissionrequest to the embedder of <webview> to decide
whether to allow/deny the request. The element goes fullscreen within
the <webview>'s bounds at this point.
The embedder can:
a) allow the request: in this case we perform the second stage, where the
<webview> element in the embedder enters fullscreen (provided that
the embedder has permission to enter fullscreen).
b) deny the request: in this case, <webview> exits fullscreen mode.

Note that b) will cause a flicker and blink interface is required to avoid that.
That is tracked on http://crbug.com/466854.

BUG=141198
Test=
Load a chrome app with a <webview> in it, make the <webview> point to
some site that has html5 fullscreen request, e.g. youtube.com.

Add an event listener in the chrome app so that it allows <webview> fullscreen, e.g.

<webview>.addEventListener('permissionrequest', function(e) {
  if (e.permission === 'fullscreen') e.request.allow();
});

Now perform necessary action to request fullscreen from the <webview>, for the
youtube case, this would be fullscreening the video player.

Check that the element enters fullscreen mode.

Review URL: https://codereview.chromium.org/984963004

Cr-Commit-Position: refs/heads/master@{#321282}

Flash while rendering text calls into pepper to create a canvas and then sends IPCs like PpapiHostMsg_Flash_DrawGlyphs
to draw into the canvas. In Win32K lockdown mode we create a memory canvas instance (ImageDataSimpleBackend). This class
returns NULL in its GetPlatformCanvas implementation which causes the OnDrawGlyphs call to bail.

Fix is to call the GetCanvas function instead of GetPlatformCanvas. Both functions do the same thing.

BUG=468418
R=cpu

Review URL: https://codereview.chromium.org/1007993006

Cr-Commit-Position: refs/heads/master@{#321281}

When opening the new window, it is opened on the current
window. Even though the mouse position is not updated, the
mouse leave event should be triggered on the previous
window. However, when showing the context menu or the popup,
the mouse leave event shouldn't be triggered.

The test checks if the mouseleave event is triggered when
showing the UI.

BUG=450631
R=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/891213002

Cr-Commit-Position: refs/heads/master@{#321280}

Run HostDiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemoryForChild on FILE_USER_BLOCKING thread

Should prevent some jank on OS X (and Linux), as allocating shared memory is a filesystem operation there.

BUG=467781,466405

Review URL: https://codereview.chromium.org/1007323005

Cr-Commit-Position: refs/heads/master@{#321279}

Depends on the Blink change: https://codereview.chromium.org/1015903002

BUG=459007

Review URL: https://codereview.chromium.org/999003004

Cr-Commit-Position: refs/heads/master@{#321278}

After I landed https://codereview.chromium.org/985663002/ I noticed that there is some problems in ServiceWorker DevTools protocol.

1. ServiceWorkerHandler::ContextObserver can't get the state of ServiceWorkerVersion correctly.
 ServiceWorkerHandler::ContextObserver is using GetLiveVersion in OnVersionUpdated().
 But when OnVersionUpdated() is called the live versions may already be deleted.
 This is because OnVersionUpdated() is called via ObserverListThreadSafe<ServiceWorkerContextObserver> in ServiceWorkerContextCore.
 So I change ServiceWorkerContextObserver::OnRunningStateChanged() and ServiceWorkerContextObserver::OnVersionStateChanged() to pass the new state and introduce OnNewLiveRegistration() and OnNewLiveVersion().

2. We have to distinguish the ServiceWorkerRegistrations which are deleted from the storage.
 We shuold show the registrations which are already deleted from the storage but are still exist in the memory.
 This could happen when ServiceWorkerRegistration.unregister() has been called but there are still some controlled pages.
 So I will add isDeleted flag to ServiceWorkerRegistration DevTool's protocol. (https://codereview.chromium.org/996363002/)
 And we can stop using workerRegistrationDeleted event.

3. Stop using {active/waiting/installing}_version properties of ServiceWorkerRegistration in DevTools protocols.
 We send the all ServiceWorkerVersion infromation with workerVersionUpdated event and it has "state" properties.
 So we don't need {active/waiting/installing}_version properties of ServiceWorkerRegistration.

This change depends on https://codereview.chromium.org/996363002/.

BUG=466871

Review URL: https://codereview.chromium.org/998173002

Cr-Commit-Position: refs/heads/master@{#321277}

When an app is being uninstalled and the "confirm removal" dialog is
closed, the focus controller selects the most recently used window to
return focus to. However, the MruWindowTracker doesn't take into
consideration the app list container, and hence the app list window is
not on the MRU window list. Focus is then returned to something else (if
you have other windows open) which causes the dismissal of the App list.

R=oshima@chromium.org,skuhne@chromium.org
BUG=467877

Review URL: https://codereview.chromium.org/1011283004

Cr-Commit-Position: refs/heads/master@{#321276}

The App Info dialog was getting a nullptr on apps with the 'fileSystem'
permission in Guest Mode (notably, the Get Help app). Added null checks
to work around the problem.

BUG=457346

Review URL: https://codereview.chromium.org/994283003

Cr-Commit-Position: refs/heads/master@{#321275}

BUG=467797

Review URL: https://codereview.chromium.org/1017913003

Cr-Commit-Position: refs/heads/master@{#321274}

The problem was that the height of the header (where the extension name and icon are shown) was not being taken into account by the animation of the options overlay.

BUG=468024

Review URL: https://codereview.chromium.org/1012233002

Cr-Commit-Position: refs/heads/master@{#321273}

The reset command takes upwards of 3 minutes on KK, this runs
the set usb 1 command so that it will set charging to on while it
is resetting.

BUG=

Review URL: https://codereview.chromium.org/1012383006

Cr-Commit-Position: refs/heads/master@{#321272}

Make STLDeleteValues do like STLDeleteElements and increment the
iterator before deleting the value. This protects against modifications
to the container that may invalidate the current iterator.

STLDeleteContainerPairSecondPointers already provides this ability.

Review URL: https://codereview.chromium.org/1020673002

Cr-Commit-Position: refs/heads/master@{#321271}

No changes aside from package/imports.

BUG=428882

Review URL: https://codereview.chromium.org/1017783004

Cr-Commit-Position: refs/heads/master@{#321270}

This change adds functions to return the content line height and the answer line height.  It also makes the answer line height the large font.

(Separated out from CL 795933009).

BUG=455418

Review URL: https://codereview.chromium.org/1017323003

Cr-Commit-Position: refs/heads/master@{#321269}

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1019653002

Cr-Commit-Position: refs/heads/master@{#321268}

This operation requires accessing the filesystem on OS X and linux and could be slow.

BUG=466437

Review URL: https://codereview.chromium.org/1018953005

Cr-Commit-Position: refs/heads/master@{#321267}

Review URL: https://codereview.chromium.org/1022473003

Cr-Commit-Position: refs/heads/master@{#321266}

This avoids a crash in debug builds on Linux.

BUG=454893
TEST=Change IsErrorDueToBadClock() to always return true, launch a debug
build, visit a bad SSL site, and click "Update date and time". Observe
no crash.

Review URL: https://codereview.chromium.org/1002013008

Cr-Commit-Position: refs/heads/master@{#321265}

This picks up various bug fixes, but no new functionality.

TBR=scottmg@chromium.org
BUG=430215
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1016083003

Cr-Commit-Position: refs/heads/master@{#321264}

BUG=429053

Review URL: https://codereview.chromium.org/1000483002

Cr-Commit-Position: refs/heads/master@{#321263}

This CL adds support for third-party VPNs to the network details dialog:
* The title contains both the VPN provider name and the network name.
* Fields not applicable to third-party VPNs are hidden.
* A new field showing the provider name is added.
* The "Configure" button triggers the VPN provider's configuration UI.

BUG=460428
TEST=Manual

Review URL: https://codereview.chromium.org/1006553002

Cr-Commit-Position: refs/heads/master@{#321262}

R=brucedawson@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/943893003

Cr-Commit-Position: refs/heads/master@{#321261}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/24e06d5..8dc58ed

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019673002

Cr-Commit-Position: refs/heads/master@{#321260}

Revert of [Android] Make failure to find tombstones nonfatal. (patchset #2 id:20001 of https://codereview.chromium.org/1002293004/)

Reason for revert:
Looks like this is causing flaky failures on the CQ.

Original issue's description:
> [Android] Make failure to find tombstones nonfatal.
>
> BUG=467918
>
> Committed: https://crrev.com/724e0baba29a167e97c119335eff476fa4437269
> Cr-Commit-Position: refs/heads/master@{#321219}

TBR=klundberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467918

Review URL: https://codereview.chromium.org/1004803008

Cr-Commit-Position: refs/heads/master@{#321259}

The GpuDataManager should be initialized before SetRunRendererInProcess to ensure
the gpu features/blacklists are correctly set for renderer.

BUG=468150

Review URL: https://codereview.chromium.org/1015633003

Cr-Commit-Position: refs/heads/master@{#321258}

R=asvitkine@chromium.org
BUG=463209

Review URL: https://codereview.chromium.org/1011093004

Cr-Commit-Position: refs/heads/master@{#321257}

This is the GYP counterpart of the GN changes in
https://codereview.chromium.org/1008603002/.

R=mtklein@google.com,petarj@mips.com,reed@google.com
BUG=none

Review URL: https://codereview.chromium.org/1010773007

Cr-Commit-Position: refs/heads/master@{#321256}