GitLab

Removing the fakebox bottom margin (per spec) eliminates the scrollbar.
There's still a margin above custom links, separating them from the fakebox.
Before & after screencast:
https://drive.google.com/file/d/1IvcCIm1keZPfQzSYMDYHd0xRJfo9YCMp/view?usp=sharing

Bug: 863445, 869659, 867763
Change-Id: Ibd0edbb3a4a5b1a0a17e544b5a9cc072dc3ffe60
Reviewed-on: https://chromium-review.googlesource.com/1163200Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580912}

The error event was not being sent when the client was reset.

Bug: 721414
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I951422061022d50644d8453900af14be27bb9eaf
Reviewed-on: https://chromium-review.googlesource.com/1150403
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580911}

Updating the Google services commands to have the data type as a
parameter to toggle each data type to sync, instead of having one
command per data type.
When a data type switch is toggled, the mediator enable/disable the
data type with the sync setup service.
The mediator listens to the sync setup service notifications. It
reloads the sync switchs only if when the notifications don't come from
a UI changes (to let the switch animation goes to the end).

The EarlGrey tests will be done in another patch.

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7586af0591a30956df7c635e025d045c1b3648be
Reviewed-on: https://chromium-review.googlesource.com/1148571
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580910}

This is to validate whether they are causing the failures

Bug: 868675
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I3ccdb25614fbfddfc77224b3df9314a79970fc57
Reviewed-on: https://chromium-review.googlesource.com/1163638
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580909}

https://skia.googlesource.com/skia.git/+log/12fb9cfeee07..439da2812f74


git log 12fb9cfeee07..439da2812f74 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd4c8631343f..02956e4cced0 (1 commits)
2018-08-06 benjaminwagner@google.com Update remaining Mac bots to 10.13.6, except iOS builds.
2018-08-06 caryclark@skia.org clean up includes
2018-08-06 jvanverth@google.com More SkOffsetSimplePolygon optimizations.
2018-08-06 bsalomon@google.com Store GrMeshDrawOps' meshes in GrOpFlushState's arena.
2018-08-06 egdaniel@google.com Start adding support for some base extensions which others build on.


Created with:
  gclient setdep -r src/third_party/skia@439da2812f74

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:862292
TBR=djsollen@chromium.org

Change-Id: I5bbbf92917eb2917d6cb9214fcf78f070934fa22
Reviewed-on: https://chromium-review.googlesource.com/1163117Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580908}

Fingerprint enrollment session is ended automatically when it is complete.
Local object path needs to be reset for this case.

Bug: 834448
Change-Id: Ieedf5f2f9fbf6ef7b3519414ef792b5cb54ba163
Reviewed-on: https://chromium-review.googlesource.com/1162906Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580907}

This removes passing of the origin and is_top_frame values from the
(untrusted) renderer. Instead we retrieve them from the render frame
host at the time the MediaMetricsProvider is created.

BUG=800610
TEST=updated test still pass.

Change-Id: I70abbd5a98b574d0bbbc0d64d9fd194c4fb82e90
Reviewed-on: https://chromium-review.googlesource.com/1161186Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580906}

This is a reland of eab3705f

Original change's description:
> Delay audio service launch on the browser startup.
>
> (see the bug) From the traces the service/process creation gets posted to the
> IO thread during startup.
> It may be delaying startup for some other services needed for the first paint, or it may be
> just eating up CPU when the load is already quite high. We'll experiment with delaying
> the service launch.
>
> Bug: 867461
> Change-Id: I048e33d049e665d8e9489046c5813918d8077524
> Reviewed-on: https://chromium-review.googlesource.com/1153248
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579460}

Bug: 867461,870171
Change-Id: Ia1a0c31ccc6c643ad10fb250862a9d1fb408c216
Reviewed-on: https://chromium-review.googlesource.com/1162184
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580905}

sys_{mmap|munmap|mremap}(...) calls are replaced with
syscall(SYS_{mmap|munmap|mremap}, ...), as the former are not allowed
by Chromium's sandbox.

BUG=724399,b:70905156

Change-Id: I04d87567a7c6194a0619140ffd5d4449c73a398b
Reviewed-on: https://chromium-review.googlesource.com/1130786Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580904}

Most of the callers to CrOSComponentManager::Load expect the
callback to be called on the UI thread (the same as the thread from
which the method was called)- the only exception
is CrostiniManager, which does not assume the callback is called
on the UI thread, but still just relays the callback result back to
UI thread.

Currently, callbacks are run using base::PostTask, which post the
callback to the task runner. To make the behavior of the method match
the expectations, use ThreadTaskRunnerHandle::Get to get the current
task runner, and use it to asynchronously run the callback.

Bug: None
Change-Id: I9f365a11ba2634154488c580615ceede59e2a9d3
Reviewed-on: https://chromium-review.googlesource.com/1163071
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580903}

Add metric to record the suppress reason when the
consent bump should not be shown.

Additional changes:
 - Don't show consent bump when any on-by-default privacy
 setting was off during migration.

Bug: 858870, 863948
Change-Id: Iac7bbb6b8d1d332db3439b2f96c6035ed255e6b3
Reviewed-on: https://chromium-review.googlesource.com/1162233
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580902}

Change-Id: I980ed5d43a3afef2d96a3702bc9f7129c68950ab
Reviewed-on: https://chromium-review.googlesource.com/1163605Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580901}

1. Flip the feature flag.
2. Fix test errors.

Bug: 865139
Change-Id: Ibbb7c5e6fa1f94a419015591c318a2b2a1905809
Reviewed-on: https://chromium-review.googlesource.com/1142441
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580900}

The test was observed to be flaky.

Bug: 870852
Change-Id: I3163111ba26e30d0864ff3a52a1ab21e64137725
TBR: nednguyen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1163678Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580899}

TBR=rch

Change-Id: Ic149856ad452e82c1eafc69057b01865ac98335e
Reviewed-on: https://chromium-review.googlesource.com/1162741Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580898}

Suggestion chips replace suggested apps, expand arrow is moved and
apps grid's layout id changed, so focus is broken.

Changes:
1. Up and down key will move focus to previous/next row in apps grid.
   If the target focus index is invalid, shift it to the nearby valid
   index.
2. Disable focus of suggestion chips when folder is opened.
3. Fix test errors.

Bug: 859644
Change-Id: Iaf9707b44f6d72a181a26ce5bc34612f26e01aaf
Reviewed-on: https://chromium-review.googlesource.com/1161494Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580897}

Bug: 853688
Change-Id: Ibac26f2adab7a360d866e3abc75b36f0bab8ab51
Reviewed-on: https://chromium-review.googlesource.com/1152085
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580896}

The user consent can never be given when no user is connected. In the
EarlGrey test, first the user should be logged in, and then the user
consent can be set.

TBR: sczs
Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5beeea0d4b05032f8d940883dc92a3523f81dc55
Reviewed-on: https://chromium-review.googlesource.com/1163717
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580895}

No longer using experiment_only_when_loading in
SchedulingSettings configuration.

Change-Id: Ia1ebbdc513c677c884c3be656a976deb2ef4435f
Reviewed-on: https://chromium-review.googlesource.com/1162332
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580894}

Ensure both displays are on before allowing multi-display.

BUG=824954

Change-Id: If235135d3dfbfa6c42f31bd30c0a3deba145f33f
Reviewed-on: https://chromium-review.googlesource.com/1162912Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580893}

- Prepare V8PerIsolateData for holding V8HeapController.
- Harden existing tests to swap in the expected visitor/controller. This way it
  is possible to test ScriptWrappableVisitor while already running on a different
  embedder heap tracer.

Change-Id: I169de233a4dd9886d153e7d97ca63e7caee0d809
Bug: chromium:843903
Reviewed-on: https://chromium-review.googlesource.com/1160656
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580892}

TBR=sullivan@chromium.org

Bug: 859514
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I7b6c0203596df67d668c18a084039c1832b3f52b
Reviewed-on: https://chromium-review.googlesource.com/1162628Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580891}

When we integrated content alignment in the track sizing algorithm
(r566412) we forgot to do it too when the 2nd pass is needed.

The patch is very simple and just adds the calls to apply
content alignment in LayoutGrid::RepeatTracksSizingIfNeeded()
for each axis.

The spec also mentions it in the new 3 and 4 steps:
https://drafts.csswg.org/css-grid/#algo-overview
So the new code just aligns with the spec.

BUG=870634
TEST=external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-001.html

Change-Id: Iccbcea5da1011eae37b4923bb78334cddc76d027
Reviewed-on: https://chromium-review.googlesource.com/1161925Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#580890}

This replaces the "Summary" field (which used to contain state +
disable reasons) by separate "Transport State" and "Disable Reasons"
fields, and also introduces a new "Is Sync Feature Enabled" field.

Bug: 856179
Change-Id: I65e3c203faeb1c4b0193b01ce509e541817aef7e
Reviewed-on: https://chromium-review.googlesource.com/1162238
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580889}

TBR=jchinlee

Bug: 869503
Change-Id: Ice82ca146c5c7d1dea36725d7e9170e5a22fabda
Reviewed-on: https://chromium-review.googlesource.com/1163311
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580888}

The transactionId field is now required in the WebIDL, so the proper
error is now a TypeError.

Bug: 803494
Change-Id: Iaf49c2cd192b8ac99678acb74a163670f4c93893
Reviewed-on: https://chromium-review.googlesource.com/1163666
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580887}

Temporary disable flaky tests on Linux until we figure out the root cause for the failures:
- CallWithAudioDebugRecordings
- TwoCallsWithAudioDebugRecordings

Bug: 871182
Change-Id: I331a9d96a4dd2d2a300f1e5a068913d31ea3314d
Reviewed-on: https://chromium-review.googlesource.com/1163616Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580886}

Change-Id: Ic0858a6106dc3c3b00cfa092b649bb14b83b3e4d
Reviewed-on: https://chromium-review.googlesource.com/1163641Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580885}

Before this CL, BookmarkModelObserverImpl assumed that bookmark nodes
creation notification must arrive before update notification which
isn't true.

Considering the following secnario:
1. New bookmark added.
2. BookmarkModel notifies all the observers about the new node.
3. One observer A get's notified before us.
4. Observer A decided to update the bookmark node.
5. BookmarkModel notifies all observers about the update.
6. We received the notification about the update before the creation.
7. We will get the notification about the addition later and then we can
   start tracking the node.

For example, BookmarkLastVisitUpdater::BookmarkNodeAdded() updates
the node metainfo.

After this CL, any update notification for an untracked node is ignored.
A later creation notification should take care of that node.

Bug: 516866,867036
Change-Id: I16801891759c756a7d1f8e18e932929f67d1759b
Reviewed-on: https://chromium-review.googlesource.com/1162323
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580884}

Adds kHitIsolateCacheWhenStreamingSource.

BUG=chromium:865098
TBR=delphick@chromium.org

Change-Id: I9112410a1ddf9b9f56667a7880152d306d4a2612
Reviewed-on: https://chromium-review.googlesource.com/1163672
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580883}

Move the verfication of enrollment failure into teardown because test body
is skipped as Chrome quit during launch.

Also remove the runloop in the test because the enrollment process blocks
Chrome launch process which also blocks the browser test.

Bug: 871238
Change-Id: Ic886ac50b4c4cc215e2cad33294b43f308e17322
Reviewed-on: https://chromium-review.googlesource.com/1161465
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580882}

That field should not get autocomplete suggestions.

Change-Id: Ie711c8d15cffb612e55dfcc057db8a7a4ef8eb19
Reviewed-on: https://chromium-review.googlesource.com/1156912Reviewed-by: Grace Kloba <klobag@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580881}

https://skia.googlesource.com/skia.git/+log/2e77f54f46e8..12fb9cfeee07


git log 2e77f54f46e8..12fb9cfeee07 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 ethannicholas@google.com added SkSL saturate() function


Created with:
  gclient setdep -r src/third_party/skia@12fb9cfeee07

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I5aed12e5730e3cae7d9dae34c106ef25694b2fb4
Reviewed-on: https://chromium-review.googlesource.com/1163114Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580880}

Screenshot: https://drive.google.com/file/d/1ipME4JlplC_99fQzx6lukvmHUyA3MUfG/view?usp=sharing

Bug: 856242
Change-Id: I5f70c8b697de5b310019258ad79c27f975b7ce36
Reviewed-on: https://chromium-review.googlesource.com/1162342Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580879}

Two of the failures are related to stacking contexts:
* external/wpt/css/css-contain/contain-paint-021.html
* external/wpt/css/css-contain/contain-layout-016.html

The other one was a mistake that has been already fixed in WPT
(see https://github.com/web-platform-tests/wpt/pull/12314):
* external/wpt/css/css-contain/contain-paint-001.html

TBR=eae@chromium.org

BUG=870811,868102,870157

Change-Id: I60e89decd2f939d1d9a850a1b8b556d31658e872
Reviewed-on: https://chromium-review.googlesource.com/1163673Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#580878}

R=maruel@chromium.org

Expand-Timezone-Coverage: Yes
No-Try: True
Change-Id: I420e4e804ec107b079187f23acec18516052714a
Reviewed-on: https://chromium-review.googlesource.com/1163636Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580877}

These tests follow the format currently under discussion here:
https://github.com/WICG/origin-policy/pull/39

Bug: 751996
Change-Id: Ief33c794498cb3ed84dac670ecff4ddc366b9592
Reviewed-on: https://chromium-review.googlesource.com/1130531Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580876}

Change-Id: Ib7db0bbf5298c9b3bde3a6d949df92de3daad6e2
Reviewed-on: https://chromium-review.googlesource.com/1163606Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580875}

The test is flaky on Mac as well.

Bug: 704980
Change-Id: I6d56312bd8ffb8fffe6911535a0029d95a27812a
TBR: mseaborn@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1163676
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580874}

Spacebar normally inserts a space into the Omnibox. If the cursor (or
selection) is at the end of the text and the tab switch button is
"focused", instead activate the button.

Bug: 780835
Change-Id: I121f72bf3a979213d0506da1168a7658be84e706
Reviewed-on: https://chromium-review.googlesource.com/1160597Reviewed-by: Justin Donnelly (OOO until Aug 13) <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580873}