- 31 Aug, 2020 40 commits
-
-
Henrik Boström authored
This CL migrates to the spec-compliant OnNegotiationNeededEvent[1], only firing it it the Operations Chain is empty. It also makes the "negotiationneeded" and "icecandidate" events fire without additional delay. This is important, because Perfect Negotiation is very timing-sensitive, and the way we've been firing these events is wrong. A bug in the Perfect Negotiation WPT is discovered: if an incoming follow-up offer is sent to the impolite peer while the SRD(answer) of the previous O/A exchange is still pending, the impolite peer would incorrectly ignore the offer. This is fixed with the introduction of a boolean variable to keep track of if SRD is pending, allowing the impolite peer to predict that it is about to become "stable" and can thus chain the incoming offer onto its Operations Chain. With these changes, we pass the Perfect Negotiation WPTs! Hurray! [1] https://webrtc-review.googlesource.com/c/src/+/180620 Bug: chromium:1060083 Change-Id: I8e8c684ef6cfc1faac0256d33b8fc89be3fc614f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330014 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#803072}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Bug: 1104836 Change-Id: I1afabd42053515a0b436f7f92bac5eed0a14c2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366935Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#803071}
-
Maxim Kolosovskiy authored
This reverts commit 6d7617fa. Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert. Original change's description: > Revert "Add Media Capture and Generic Sensors mojom.js files to mojojs.zip" > > This reverts commit 1edcb047. > > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 > > Original change's description: > > Add Media Capture and Generic Sensors mojom.js files to mojojs.zip > > > > This is the first step before removing those files from WPT. > > > > Bug: 1119858 > > Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325 > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Michael Moss <mmoss@chromium.org> > > Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> > > Cr-Commit-Position: refs/heads/master@{#803031} > > TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,robertma@chromium.org,arnaud.mandy@intel.com > > Change-Id: I94a722412f3cd37ef6ad9ab15274f6951855e9c7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1119858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383027 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803040} TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,kolos@chromium.org,robertma@chromium.org,arnaud.mandy@intel.com # Not skipping CQ checks because this is a reland. Bug: 1119858 Change-Id: I96db7fc48ab349c86a23c972071dea8e534a4cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384034Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803070}
-
Friedrich Horschig authored
This CL adds favicons to each credential row or a fallback if no icon is available for a site. Screenshots in the bug. Bug: 1106724, 1092444 Change-Id: I246f128fc76838142f599b75666912a1187bf9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362895Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803069}
-
Jeroen Dhollander authored
This example code is really useful, but it contained a few minor C++ mistakes. Bug: N/A Test: compiled Change-Id: If0b110c89657a4f018e2b406b0e4b2213a4fe420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354594 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#803068}
-
Sergei Glazunov authored
This CL allows the CheckedPtr constructor to quickly skip unsupported pointers. Change-Id: Ibabb8802f4feb3734e1e7740fd86bd8df9a4e657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379831Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sergei Glazunov <glazunov@google.com> Cr-Commit-Position: refs/heads/master@{#803067}
-
Danila Kuzmin authored
After migrating eula screen to LoginScreenBehaior the screen is temporarily named as "oobe-eula-md". This CL is a follow up name update. Bug: 1121655 Change-Id: Ifcfbc0d8a3528d33deda01d9227c5ec449b0c1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378029Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#803066}
-
Tanmoy Mollik authored
This cl is the second part that implements the onClickListeners for SyncErrorCard buttons. It also adds the preference to ManageSyncSettings page. The preference is not visible unless MOBILE_IDENTITY_CONSISTENCY feature is enabled. Bug: 1107420 Change-Id: I55a1fcf73747e9e75d950daad0794220226ed0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346439 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803065}
-
chrome://flagsJan Wilken Dörrie authored
Bug: 927473 Change-Id: I86ea71e72d2d3db4473c7a0b9687c700212d5975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379765Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#803064}
-
Morten Stenshorne authored
The containing block of a rendered legend of a fieldset that also establishes a multicol container is the fieldset itself, not the flow thread (and also not the anonymous fieldset contents wrapper). However, since dynamic changes may change which legend is the rendered legend, we'll keep it simple, and always let them be treated as part of the flow thread - so that they trigger creation of a LayoutMultiColumnSet - so that we are guaranteed to actually have a LayoutMultiColumnSet if the rendered legend ceases to be the rendered one. Bug: 1122722 Change-Id: I5a287e367f8824dc0c5a27620c74d2ec6eedfd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379723Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803063}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6730854c3971..16ee2a22abb6 2020-08-29 apodtele@gmail.com [smooth] Don't set target in direct mode. 2020-08-29 apodtele@gmail.com Improve FT_Outline_Render docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I89510122adea0c26d939ddcc19b74ad69c6644da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#803062}
-
Julian Pastarmov authored
Aligning the various reporting paths to return the same type of identifiers. BUG=b/165296736 TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo Change-Id: Id4789d368d99097cbdbe1f65be098902cb773183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380285Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#803061}
-
Fredrik Söderqvist authored
The effect of this parameter can be described using the other parameters (is_additive = is_cumulative = false). For list types it was previously used to avoid copying a list into itself (clobbering it in the process), but that can achieved by just comparing objects. Similar techniques were applied in SVGPath and SVGTransformList, but those classes could deal with the issue differently. Rewrite SVGPath::CalculateAnimatedValue() to eliminate the extra copy which should (no longer) be needed. Change SVGTransformList::CalculateAnimatedValue() to compute the transform first and then handle addition. Also re-order the computations to try to get a somewhat canonical order: interpolation, accumulation, addition. In SVGAnimateMotionElement, always set |to_point_at_end_of_duration_| instead of setting and checking a separate bool. AnimateAdditiveNumber() handles the accumulation if required. Bug: 1017723 Change-Id: I8adb2a7ad415a2d00aa057bfb93f55953450dd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382111 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#803060}
-
Rune Lillesveen authored
Bug: 1123140, 1123457 Change-Id: I316e49bca0153737c89e3ac418d407655f03ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383025Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#803059}
-
Mitsuru Oshima authored
This can happen when a layer is recreated for animation for example. (observed in crrev.com/c/2375686) Bug: None Test: Covered by unittest Change-Id: Ia8e4bae050ef5c281ad498a461171900ceae13a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384070Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9d64f51f078..45c7cc03636d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897717 Tbr: kolos@google.com Change-Id: I3c7032cbb8ed1dac11b1f030a566e8a9f9394305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803057}
-
Hans Wennborg authored
The test broke after crrev.com/802490 TBR=thakis Bug: 1100257, 1123469 Change-Id: Ie8ae2f26b1ffd92fa422d719a80aecc161f18738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382836Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#803056}
-
Kuo Jen Wei authored
Add new dom.* utility functions replacing assertInstanceof+querySelector/querySelectorAll. Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: I7932bc65ad21e45c1c982bc0e9b77eb88084c5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382992Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#803055}
-
Maya Lekova authored
This is a follow-up of the recently added Blink support for fast calls: https://chromium-review.googlesource.com/c/chromium/src/+/2361939 The new flag is called --enable-unsafe-fast-js-calls. Bug: chromium:1052746 Binary-Size: Size increase is unavoidable (see above). Change-Id: Iad5e398bb1398868d631345d1197a4596f4be423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315680 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#803054}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2f291c0bd181..b4c90eee2f9f 2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ec3650f56ca2 to a2e6c1a149f4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4be057a7b32d91fff2af14f9df7abe9e259023aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384849Reviewed-by:
-
Frédéric Wang authored
ServiceWorkerRequestHandler has been removed in [1] while ServiceWorkerNavigationLoader has been renamed in [2]. This CL removes remaining references to these classes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2150289 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2210292 Bug: 1083047 Change-Id: I00b61033db140b1dd005f6111431e94b3ad44038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379511Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#803052}
-
Tanmoy Mollik authored
If sync hasn't been turned on, the string should be "Sign out". Otherwise, the existing "Sign out and turn off sync" string should be used. Bug: 1107421 Change-Id: I2dc84c34aba4deea8707d5b49fd838b153da9040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368360 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#803051}
-
Henrik Boström authored
Due to a bug about scheduling to dispatch various events instead of dispatching them immediately, the setRemoteDescription was also scheduled to be resolved rather than be resolved immediately, as to ensure that all events had fired prior to the promise resolving. This causes timing issues that become a problem for Perfect Negotiation. This CL makes the events fire and the promise resolve synchronously in the following order: - Fire track.onmute. - Fire stream.onremovetrack and stream.oninactive. - Fire stream.onaddtrack and stream.onactive. - Fire legacy pc.onaddstream. - Fire legacy pc.onremovestream. - Fire pc.ontrack. - Fire track.onunmute. - Resolve setRemoteDescription's promise. (Same order for SLD.) Supporting this in Unified Plan was mostly a matter of changing ScheduleDispatchEvents to DispatchEvents. We already processed addition and removal in the same place, and could process all state changes before firing events. To support this in Plan B however, we had to merge DidAddReceiverPlanB and DidRemoveReceiverPlanB into a single method DidModifyReceiversPlanB. This is because we have to process all state changes before firing events, otherwise an event listener in JS would not see all receivers or remote streams when inspecting the peer connection. In both Plan B and Unified Plan, now that stream.onaddtrack and stream.onremovetrack fire synchronously, when listening to "onaddtrack" you can observe each track being added separately (rather than stream.getTracks() containing all the tracks that was added in the first event). Note: We still fire pc.onsignalingstatechange at the end; this should be fired at the start, but this can be fixed in a separate CL. Bug: chromium:788558 Change-Id: I9be34d7919a73799e944089f9afe0e90ba1de90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332158Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803050}
-
Alice Wang authored
This CL adds two view fields in AccountPickerBottomSheetView for the logo and horizontal divider. They will be used later for logo setup. There is no behavior change in this CL. Bug: 1120308 Change-Id: I1e1368bac873c37e0633fa34270a013f66aa0d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379760Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803049}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/08291a3a9e22..f428aa39ca2b 2020-08-28 afdx@google.com spirv-fuzz: Remove opaque pointer design pattern (#3755) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Iea2ab880632015213a44e8b63a935beff91b1546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384528Reviewed-by:
-
Rune Lillesveen authored
overflow:clip is not implemented. Bug: 966283, 1123140 Change-Id: I4177e663726573da352b9beaa0bb0494fcc70af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382080Reviewed-by:
-
Alice Wang authored
This CL adds render tests to check that clicking on the |Try Again| button of the sign-in general error view opens the sign-in in progress view. Bug: 1120308 Change-Id: If11c943987c6d722665241d26a933f90655c1c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379711Reviewed-by:
-
Nohemi Fernandez authored
This allows us to outsource all cookie tracking efforts to the dedicated Chrome implementation rather than re-implementing the cookie request queue. Bug: 1102794 Change-Id: I284888a796acd60cfc696598e53e7debc726b6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346664 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#803045}
-
Maxim Kolosovskiy authored
This reverts commit 7d2bed26. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > OOR-CORS: Remove BlinkCORS related tests > > This patch removes network::features::kOutOfBlinkCors and > network::features::ShouldEnableOutOfBlinkCorsForTesting() references > from existing tests as now BlinkCors was deprecated, and we already > turned down CORS fyi bots. > > This is part of the work to remove the kOutOfBlinkCors feature. > > Bug: 1053866 > Change-Id: I4ba14005fd3fb310cbd246e6c0bd6cc18bd005d8 > TBR: mkwst@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377633 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803029} TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,mkwst@chromium.org Change-Id: I96044df30b8694433c6bad6e9eb719b949f6413e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385075Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 57af2c42. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Reland "cros: Implement ClipboardImageModelFactory" > > This reverts commit 5822a03a. > > Reason for revert: > It turned out that the test is flaky regardless of this change. > Probably this just made it easier to reproduce the flakiness. > > Original change's description: > > Revert "cros: Implement ClipboardImageModelFactory" > > > > This reverts commit 056d2885. > > > > Reason for revert: > > This is a speculative revert for failures on > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382 > > > > This could fail the following test: > > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText > > > > Original change's description: > > > cros: Implement ClipboardImageModelFactory > > > > > > Implements ClipboardImageModelFactoryImpl. > > > Previous CL landed ClipboardImageModelFactory, and all > > > ash-side usages of the factory. > > > > > > This CL implements rendering of HTML via > > > ClipboardImageModelRequest. > > > > > > Bug: 1117230 > > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395 > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#802779} > > > > TBR=xiyuan@chromium.org,newcomer@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1117230 > > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532 > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803003} > > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1117230 > Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803027} TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org Change-Id: Iad7614b249091bfcce8a27f10ae4e67de86a2a29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382603Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit a0522042. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Roll DevTools Frontend from b6f22fe80638 to f36682af28e2 (1 revision) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6f22fe80638..f36682af28e2 > > 2020-08-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I36dc0e3b5f615bdce8a95973f1fbfd7ac8c61611 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384520 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#803028} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f83210f4dba60997d57602d00694b50e02959e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382120Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 437b61ae. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > [Telemetry SWX] Add battery capacity routine > > Add implementation to chrome://. > > Add implementation to chrome-untrusted://. > > Add tests. > > Bug: b:162051831 > Change-Id: Ib2d618c4eacce43e6cd588c766e8d40af9ae318b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362933 > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Oleh Lamzin <lamzin@google.com> > Cr-Commit-Position: refs/heads/master@{#803030} TBR=tsepez@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com Change-Id: I675879ec1c65f834362901ba862923acadfa9551 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:162051831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383028Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 1edcb047. Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190 Original change's description: > Add Media Capture and Generic Sensors mojom.js files to mojojs.zip > > This is the first step before removing those files from WPT. > > Bug: 1119858 > Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> > Cr-Commit-Position: refs/heads/master@{#803031} TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,robertma@chromium.org,arnaud.mandy@intel.com Change-Id: I94a722412f3cd37ef6ad9ab15274f6951855e9c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383027Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598701830-094fa9b25781b44321eb93f9a4da522936ebbe2a.profdata to chrome-win64-master-1598853319-353b2ae72aeb030448b18cf22e3efb9470af52fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I6d08477818ba5c08a7042cdb6d7febfee202ee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384526Reviewed-by:
-
Alice Wang authored
This CL cleans the checkCollapsedAccountList() method used in AccountPickerBottomSheetTest. Bug: 1121536 Change-Id: I1bf45237bb7a29d1a53baf82629bfaa805c0de81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377498Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 0426308f. Reason for revert: I suspect it caused compilation failures https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190? Original change's description: > [WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes > > The feature policy to enable WebAuthn get requests in cross-origin > iframes shipped in M84 but did not include a use counter. This CL adds > one. > > Change-Id: Ie404ab62de3cfe665a1927883a31d7f17c329c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384651 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#803026} TBR=kenrb@chromium.org,martinkr@google.com Change-Id: I07e8edb0aeed3c53118f69bb4c7304cb6f34342f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383026Reviewed-by:
-
Guido Urdaneta authored
This prevents potential cross-origin mid-stream redirects from braking the cross-origin restrictions. Bug: 1111149 Change-Id: I18d05a5836b9a390dec50e10c43d3d2b9ec5915a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377811 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#803036}
-
Yusuke Sato authored
This CL depends on the following CLs: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2380431 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2378806 https://chrome-internal-review.googlesource.com/c/chromeos/overlays/project-cheets-private/+/3238221 BUG=b:166314117 TEST=arc.Boot.vm still passes, arcvm-adbd runs Change-Id: I385a807d84a98b4a97dcc66daf6bef5881eef2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380733 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803035}
-
Andrey Zaytsev authored
This prevents users from only enabling the #safety-check-android flag and getting a crash on the Safety check screen because the required #password-check flag is disabled. Note: this is only possible if the user changes the flags manually; the Finch config never has the Safety check flag without the Password check one. Bug: 1070620, 1120824, 1122473 Change-Id: I9720a5fcee845648fb7d617926395c1f855356d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379898Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#803034}
-
Glen Robertson authored
Fixes a `gn check` error. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I4739841f3c2fe9f80d21bb11ca44d00102650ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383514 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#803033}
-
