GitLab

1. Extend the expires time of 'Power.PowerButtonMenuAction' by some
   branches.

2. Add label for feedback source type kFeedbackSourceAssistant, which
   might be missed while adding the type.

Bug: None
Change-Id: I088f8a9041b6d293bad64469d2a72dc1da050f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643499
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666318}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2f31cc65dea..075cb05bdeb5


git log d2f31cc65dea..075cb05bdeb5 --date=short --no-merges --format='%ad %ae %s'
2019-06-05 jbudorick@chromium.org tryserver: add a 10 minute timeout on fetching CL info from gerrit.


Created with:
  gclient setdep -r src/third_party/depot_tools@075cb05bdeb5

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7126b721a096019ceed371b2fa5c3db687b8f210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645794Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666317}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961075
Change-Id: Ib3c729da5cf45d77c9130f66cedb911434ccd03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641562
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666316}

It appears that this expected.txt is causing the failure on Mac:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/23664
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/12244

Deleting this should work.

Bug: 968791
Change-Id: I6134b3c67fa38a316b66ab97be2eb7a46525d364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645378Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666315}

The color computation tries to inset its samples by 1 pixel on each
edge, but that doesn't work for 1 pixel wide images. Skip the inset
if the image is too narrow or too short.

See bug for details.

Bug: 970343
Test: Added to gfx_unittests
Change-Id: If558a8bbacb27d9011da93868ad3b6f0e72f8754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644299
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666314}

Some gpu bugs are related to the monitor refresh rate. Adding this display
information will help us on gpu debugging.

Bug: 964095
Change-Id: I54d468dd192110a77f2aa46f7d441ed257f06491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644232Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666313}

Follow-up to:
https://chromium-review.googlesource.com/c/chromium/src/+/1640601

Remove unused C++ message handlers:
* Search engines
* Fonts
* Import browser data

None of these are used in OS settings.

Bug: 960937, 950007
Change-Id: I8a74207f03d2ed66cbf919dfa16cbe6dce04b8e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645131
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666312}

The output XML contains a relative path to the mojom file. On Windows,
the expected path contains '\' separators, but the actual contains '/'.
tools/metrics/histograms/update_use_counter_feature_enum.py will update
the enums.xml file, but uses a hardcoded path.  The fix is to use a
hardcoded path for
third_party/blink/public/mojom/web_feature/PRESUBMIT.py as well.

Bug: 966496
Change-Id: Iad605bea175ee86abe7bb8c160ae2be30bf8f65e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627636Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666311}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961029
Change-Id: I189cfe1a129ed7af4f87d256e3ecf1d9d84a392a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638920Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666310}

Bug: 969978
Change-Id: I320b622be2113fb3b6edb98e48e9178c92c826b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645304
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666309}

Ports most of //c/test/data/webui/settings/settings_main_test.js to
the OS settings page.

Initializes CrOncStrings in the test because the test does not load
os_settings_ui.js, but the global must exist for the network page.

Adds assertions for CrOncStrings to make this failure more obvious
in the future (otherwise the error is just "reading property of
undefined" without a useful line number).

Bug: 967910
Test: browser_tests

Change-Id: Ia86483a2c204d82387a6c771a02075f76acc3681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642249Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666308}

Using wpt-import in Chromium c55eb1b1.
With Chromium commits locally applied on WPT:
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
abf2ac5e "webrtc wpt: avoid race conditions"
1bbbd106 "Add feature policy for client hints, used for third-party subresources."
ab94a58b "Add the remaining Client Hints to Feature Policy."
a5b31124 "DetachLayoutTree clear hover/active state on dom removal."
04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ie8eeb95b20de14ce7b41e9a695f35f1f2a9028b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645496Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666307}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961017
Change-Id: Ie2d163715da8322c8727030a153ed9600462a7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636866
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666306}

When this command line option is added, a dialog box with GPU process ID will
pop up at the process launch for the short-lived unsandboxed GPU process that
collects GPU information.

This is to separate the the other command line option --gpu-startup-dialog which
is for the main GPU process.

Bug: 961662
Change-Id: I0a3a91270a1ba7d793f3998b397aac541b28da8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642489Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666305}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961039,969160
Change-Id: Ied0a27fde7a99c5d801a49adc235c712e5fedce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638923
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666304}

This reverts commit 0c8cf257.

Reason for revert: The upstream CL got reverted.

Original change's description:
> [scheduler] Registering the current task executor.
> 
> I'm saving to TLS the current task executor on registration, and providing
> it for the base::CurrentThread() trait.
> 
> Bug: 968047
> Change-Id: I753213ff57249ed55d10cb0a576ec56975a4088e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642562
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Karolina Soltys <ksolt@chromium.org>
> Commit-Queue: Karolina Soltys <ksolt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666291}

TBR=skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org

Change-Id: Iebd1add6a23939b48ae2c25335b49ce2869a2f97
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 968047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645777Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666303}

When showing the system tray with the shortcut, the auto-hide shelf is
shown and the system tray gets the focus. Then tapping on the shelf
button will change the focus and system tray (including shelf)
is dismissed. The shelf button starts to handle the gesture event after
the shelf is closed. As a result, the shelf button does not respond to
gesture events.

In this CL, when a touch-pressing event comes and shelf is visible,
ShelfBezelEventHandler holds the shelf until the touch-releasing event
arrives. It is effective because ShelfBezelEventHandler receives the
event before SystemTrayEventFilter.

Bug: 902680
Change-Id: Id04780e2211c0ab19691db811496e703950f81d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639082Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666302}

android-code-coverage keeps failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-code-coverage
Looks like it is searching for 8 cores, which should be 32 cores, e.g.:
https://chromium-swarm.appspot.com/task?id=453ef7394666fa10&o=true&w=true


Bug: 967011,961808
Change-Id: Ib1b958e0e27c29868cad080786a9aa83767c2773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644878Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666301}

This reverts commit 973df87d.

Reason for revert: Let's not land TaskTraits that don't do what they say.

We can reland this in the base::experimental:: namespace or something
but I'm strongly against having it while it's not supported and tested.

Original change's description:
> [scheduler] Adding base::CurrentThread trait.
> 
> I'm adding a trait specifying that the task should run on the current
> thread. It will be one of the 3 possible destinations (alongside
> ThreadPool and BrowserThread), specifying which will be made mandatory
> in a future CL.
> 
> A future CL will add the desired functionality backing this trait.
> 
> Bug: 968047
> Change-Id: I16f244911b9e25da354148b034bd766c988dec11
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642559
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Karolina Soltys <ksolt@chromium.org>
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Karolina Soltys <ksolt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666288}

TBR=torne@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,ksolt@chromium.org

Change-Id: I2c100ff743dd25aeabf943c2ee47d4f811141340
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 968047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645307Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666300}

The default font returned by Skia should take the initial size from the
default value kDefaultBaseFontSize specified in PlatformFont.

R=robliao@chromium.org, asvitkine@chromium.org
CC=benck@google.com

Bug: 944227
Change-Id: I6b230b80c349abbe5968edb3cebdd6e89db4c4a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642738Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666299}

BrowserAddPersonEnabled policy controls whether Chrome allows Add Person
from the user manager. Hovewer, it doesn't inhibit the user from
creation of a new profile from the profile menu in the menu bar on Mac.

This CL removes Add Person menu item if BrowserAddPersonEnabled policy
is set to false.

Bug: 807860
Change-Id: Id8a34bbe164cad8998de2d36f2d23b9396d95c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645224Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666298}

Over time we have to introduce new parameters for Register/
RegisterWithCertificate requests, and this list is growing
unmanageable. We need to add one more parameter, so this CL
just groups such parameters into a single struct with reasonable
values for defaults.

Change-Id: I362ffda59f0b78cc25541953f8afb3e2df11b1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625124
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666297}

Bug: 958228
Change-Id: I7fbe6243e15daaf800f720f4b022360124ec661f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642962
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666296}

TBR=gayane@chromium.org
NOTRY=true

Bug: 971262
Change-Id: I0a5a2b0ea5cb6d046b0efbdbb4c67637afb015aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645130Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666295}

Bug: 935698
Change-Id: Icdc04204eba3f98f1dd34e26be694d48887a068a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641520Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666294}

(Accessors like |GetUnsigned| will crash if the type of the value is
anything unexpected.)

Change-Id: Ic7c5e0971b00e2c566d32b18efc620780ee7c96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636649
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666293}

TBR=gayane@chromium.org
NOTRY=true

Bug: 971259
Change-Id: Idc4025936bf8a3275a7d52567c93bf2b047f08a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644837Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666292}

I'm saving to TLS the current task executor on registration, and providing
it for the base::CurrentThread() trait.

Bug: 968047
Change-Id: I753213ff57249ed55d10cb0a576ec56975a4088e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642562Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666291}

Change-Id: Ie7ce5e6567d78c7a96da355c8413062c23344335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641369
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666290}

This interface used to be referenced from blink::PushController
and implemented by content::PushMessagingClient, but now those
two classes are gone we can safely remove this unused API.

Bug: 939943
Change-Id: Id0cbf05091234f94fa69e0b65e1079d92afbdf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631596
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666289}

I'm adding a trait specifying that the task should run on the current
thread. It will be one of the 3 possible destinations (alongside
ThreadPool and BrowserThread), specifying which will be made mandatory
in a future CL.

A future CL will add the desired functionality backing this trait.

Bug: 968047
Change-Id: I16f244911b9e25da354148b034bd766c988dec11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642559Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666288}

This CL improves the fuzzer coverage of ParsedCookie's mutator methods
(SetName, SetValue, etc.). It also adds a check for the property that
serializing, deserializing, and then reserializing a valid cookie
produces the same cookie line both times.

Change-Id: If2db605195daf2a7e77a8dded4b391281eb83c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643754Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666287}

TBR=gayane@chromium.org
NOTRY=true

Bug: 781935
Change-Id: I9973c749525060323531229f997e5da1adee76f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645379Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666286}

Having rendering_representative_perf_tests on testing/BUILD.gn adds a
dependency into the //chrome tree for the //testing build process. This
CL merely moves the target to //chrome/test in order to remove this
dependency spread.

Change-Id: Iae6b25d5ddcf8d014f4ca9f8a47499244980b04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635812
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666285}

TBR=gayane@chromium.org
NOTRY=true

Bug: 971256
Change-Id: I3ac4e30183589e472541eb62ffe56f977efb962c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644834Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666284}

This is a quick fix to remove v8::Persistent from IDL callbacks.
V8PersistentCallback{Function,Interface}Base should be removed
in a follow-up patch.

Change-Id: Ic6526252749e6d70c8c02092ae0b07716702e176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645713Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666283}

This CL is removing useless forward declaration and unused include file.

There is no behavior change.

R=robliao@chromium.org, asvitkine@chromium.org
CC=​benck@google.com

Bug: 944227
Change-Id: Ifcda56f000119dd3682eff2e7665f59a49c84ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643381Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666282}

When calling AddView from AddLabelledRowToGridLayout,
released unique_ptr to pass to argument.

Bug: 948287
Change-Id: I71373a27ee7b8c7ae3bf8c1fdb8eed86b806eac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644889
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666281}

ImagePaintTimingDetector has an overflow issue in multiplying two
integers (height*width). In this patch we will use
rect.Size().Area() to compute the size. As the function has handled
the overflown issue properly, we can use it to fix the bug.

The fix has been verified with a local run of the Cluster Fuzz.

Bug: 969295
Change-Id: I67fda6339bbcbc8346b02397031d9a73c3c61f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643091Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666280}

When RenderProcessUserData is destroyed from the destructor of
RenderProcessHostImpl, it is done in the destructor of RenderProcessHost.
At this point RemoveObserver override is already freed, so RenderProcessHost
is pure virtual. This crash happens at least building with GCC:

    at /usr/include/c++/8/ext/new_allocator.h:140
    (this=0x7fffffffcb50, __in_chrg=<optimized out>) at /usr/include/c++/8/bits/stl_tree.h:964

We need to destroy RenderProcessUserData before that happens. To do that
we can just override RenderProcessHostDestroyed.

Bug: 910288
Change-Id: I38107b178829b0cb7494f5333b765e5b087d82cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645366
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666279}