- 07 Mar, 2019 26 commits
-
-
Oksana Zhuravlova authored
This change adds a link to 'Receiving responses' section in C++ reference and updates the link to the IPC to Mojo conversion page. Change-Id: I91316b16d9ca2ed51518ebe9671849b4c13ce8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506610Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638373}
-
Pedro Amaral authored
Introduces a new root MVC component for bottom controls UI. This component has a composited component to allow the bottom controls to be scrolled offscreen. Currently only the split toolbar lives in the bottom controls component but soon tab groups bottom toobar will also live there. Change-Id: I2070301da2faf6a2182dacf0a75b66b2bd97e61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496599 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638372}
-
Dan Beam authored
Screenshot: https://imgur.com/a/REuT5VD R=hcarmona@chromium.org BUG=926658 Change-Id: I7ec299554e136a7fd7a948bbeadba73b0af829d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506479 Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#638371}
-
Greg Kerr authored
This calls the modern UnmountEx method in cryptohome instead of the deprecated Unmount method. Bug: 811551 Change-Id: I262b3b29eaf2dba969c95f9d0a7cfc70468f4f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464453Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638370}
-
Aga Wronska authored
Instead of enabling lock screen authentication, store info about local overrides in a pref and pass it to UsageTimeLimitProccessor to calculate state. That way local override is preserved in-between the sessions and works consistently with remote overrides. Bug: 911326 Test: UsageTimeLimitProcessorTest Change-Id: I8135a2093f805188dd75b48d10c5c1a8aac1c711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497611 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638369}
-
Pete Williamson authored
Bug: 939037 Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d TBR: rockot@chromium.org Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506878 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638368}
-
Becky Zhou authored
Bug: 936983 Change-Id: Iea620167cd0885da55b36ccd0a74e6405c7565bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506106Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638367}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07f80c4df1b0..a2ef7be242bc git log 07f80c4df1b0..a2ef7be242bc --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fjhenigman@users.noreply.github.com Add Linux ASAN bot configs. (#2427) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a2ef7be242bc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iffffd9b79247600577b3656afb6d1c3f644d46bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638366}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f094bac94992..14126505b237 git log f094bac94992..14126505b237 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 jmadill@chromium.org Revert "Use a constexpr array for es3 copy conversion table." 2019-03-06 cwallez@chromium.org Revert "Allow enabling trace annotations" 2019-03-06 jmadill@chromium.org Disable non-conformant configs on official builds. 2019-03-06 syoussefi@chromium.org Vulkan: Decouple EGLSync from renderer serial 2019-03-06 syoussefi@chromium.org Vulkan: shave off 60 bytes from AttachmentOpsArray 2019-03-05 courtneygo@google.com Fix scoped trace events 2019-03-05 syoussefi@chromium.org Add Orientation and Starter-Projects docs 2019-03-05 jmadill@chromium.org Use a constexpr array for es3 copy conversion table. 2019-03-05 jmadill@chromium.org Add glmark2 to build. Created with: gclient setdep -r src/third_party/angle@14126505b237 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic68a7f10cd056ea6d1659ee4e9fa9087bf2ec3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505900Reviewed-by:
-
Juan Antonio Navarro Perez authored
Graduating these out of experimental folder in catapult. Bug: 922030 Change-Id: I3ac3679f865aa4f409c96608348cf65d6941f82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494880Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638364}
-
Peter Williamson authored
This reverts commit 08c128cd. Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11 TBR: carlosil@chromium.org failures: SSLClientSocketReadTest.Read/1 SSLClientSocketReadTest.Read/0 HTTPSEVCRLSetTest.FreshCRLSetNotCovered WebSocketEndToEndTest.BasicSmokeTest SSLClientSocketReadTest.DumpMemoryStats/0 SSLClientSocketReadTest.DumpMemoryStats/1 URLRequestTestFTP.FTPCheckWrongUser WebSocketEndToEndTest.TruncatedResponse WebSocketEndToEndTest.HstsWebSocketToWebSocket WebSocketEndToEndTest.TrailingWhitespace HTTPSOCSPTest.IntermediateResponseTooOld URLRequestTestFTP.FTPCheckWrongUserRestart URLRequestTestFTP.FTPCheckWrongPasswordRestart HTTPSOCSPTest.Revoked HTTPSFallbackTest.TLSv1_1NoFallback HTTPSFallbackTest.TLSv1_3Interference URLRequestTestFTP.FTPCheckWrongPassword WebSocketEndToEndTest.HeaderContinuations HTTPSCRLSetTest.ExpiredCRLSetAndRevoked HTTPSEVCRLSetTest.FreshCRLSetCovered SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1 SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18 HTTPSOCSPTest.Valid HTTPSEVCRLSetTest.ExpiredCRLSet OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16 … 70 more (100 total) … Original change's description: > Refactor SSLCertificateErrorPageController > > SSLCertificateErrorPageController is no longer only used on SSL errors, > renamed it to SecurityInterstitialErrorPageController, and removed the > net::Error code passed to EnablePageHelperFunctions since it's no > longer used. > > Bug: 910794 > Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638232} TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039Reviewed-by:
-
Sajjad Mirza authored
This is a reland of 6b7213a4 Original change's description: > Adding an exclusion list to the coverage wrapper script. > > The script now assumes GN adds coverage flags to the cflags for each > source file. The script removes the flag if the file is in an exclusion > list, or if `--files-to-instrument` is set it will also remove flags if > the file is not listed in that argument. > > The script supports multiple exclusion lists that can be selected with > the `--target-os` flag. > > It's expected that GN will set these flags correctly and invoke the > script in all coverage builds. http://crrev.com/c/1496002 does that. > > > Bug: 918215 > Change-Id: I4454f67067a083581f31a22cfef85368825789f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637892} Bug: 918215 Change-Id: I1254d288ff263ff94c46b46e6be99738e31b9574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506974Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@google.com> Cr-Commit-Position: refs/heads/master@{#638362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab64c504cf5..b9c4c2512141 Created with: gclient setdep -r src-internal@b9c4c2512141 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:936957 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Ifab15f85eb4ff18ae228a0f4ade6c945a042ad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638361}
-
Alex Moshchuk authored
Previously, isolated origins would apply globally for all profiles in the entire browser. This CL introduces support for associating isolated origins with specific BrowserContexts (i.e., profiles): 1. The API for adding new isolated origins, ChildProcessSecurityPolicyImpl::AddIsolatedOrigins(), can now take a BrowserContext in which the origin should apply. 2. Entries in the map of isolated origins are extended to optionally contain the BrowserContext to which they apply. If this is not specified, the corresponding isolated origin still applies globally to all profiles. To facilitate checks on the IO thread, the ResourceContext (BrowserContext's representation on the IO thread) is also stored in the entry. 3. IsolationContext now also carries profile information (as BrowserOrResourceContext), and GetMatchingIsolatedOrigin() consults it to see if the profiles match when looking for matching isolated origins. Various tests are updated to pass a proper BrowserContext to the IsolationContexts they construct. Bug: 905513 Change-Id: Iad1fd2ca4ea701f9e088d30fa1b8582de9fbed67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497794 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#638360}
-
Li Lin authored
Bug: b:124796759 Test: Manual Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638359}
-
Nigel Tao authored
Previously, the plan was to re-use the low bits of the IconKey.u_key to represent icon post-processing effects such as desaturation to gray. On further thought, we would also like to apply such effects to IconKeys that already use the u_key to represent a resource ID, and do not use an IncrementingIconKeyFactory. It is therefore clearer to have an explicit field for icon effects. In this commit, this new field is always zero. A follow-up commit will use non-zero values. BUG=826982 Change-Id: I6453a648ed2608a2af59d0d01e1fe9bf4af5c90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505741Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638358}
-
Peter Wen authored
- This is the first step in converting autofill_assistant to a DFM. - Create a new //chrome/android/features/autofill_assistant:java target that includes almost all files that used to be under org.chromium.chrome.browser.autofill_assistant.*. - Create separate strings and resources targets. - Split out instrumentation test code. - Add the resulting target to chrome_all_java. - Due to a dependency from CustomTabs, this move excludes: - AutofillAssistantClient.java - AutofillAssistantFacade.java - AutofillAssistantMetrics.java - AutofillAssistantPreferencesUtil.java Tbr: Just moving existing DEPS into a new DEPS file Bug: 846440,922053 Change-Id: I0ee13a75f5f0ce59496e924bcc8e54ef6e960957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499720Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638357}
-
Siye Liu authored
This CL fixes two issues with the TSF support on windows. 1. Add TS_SS_TRANSITORY flag to the return value of TsfTextStore::GetStatus. By adding the flag, Korean reconversion feature is disabled. User can only do conversion during composition. Editing frameworks may not support Korean reconversion by design. 2. Fix Japanese IME implicit commit on draft.js framework. Editing frameworks like draft.js may manage their own selection during composition. We should not set selection after inserting composition text during composition. Bug: 657623 Change-Id: Ic9fb3d9187b2a1228807b15132e20e3227bf1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504035 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#638356}
-
Owen Min authored
With policy enabled, component cloud policies use POLICY_SOURCE_PRIORITY_CLOUD instead to override platform policies that have same scope. Bug: 749530 Change-Id: I7d53034073ebd24034fb3c0dfe7034229d683089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489902 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638355}
-
Ken Rockot authored
This type is an internal dependency of Mojo bindings and nested enum definitions are currently broken in JS lite bindings. Work around that by pulling this enum out of SerializedHandle. Bug: 939078 Change-Id: I9be1737a6271201d9b56a1cb69d6018e26514b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506767 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3df5c7cf7b58..a07afc58f2d7 git log 3df5c7cf7b58..a07afc58f2d7 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Fix lookahead check in CFGAS_FormatString::GetNumericFormat(). Created with: gclient setdep -r src/third_party/pdfium@a07afc58f2d7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938626 TBR=dsinclair@chromium.org Change-Id: Ib5903f320f3cb33ac354420058f13300527f562b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506607Reviewed-by:
-
Jérôme Lebel authored
Some of the code were using TableViewImageCell.textLabel, without compiler errors, since UITableView.textLabel exists. To avoid any errors, titleLabel is renamed into textLabel. Bug introduced: crrev.com/c/1478795 Change-Id: I5c07d31565d7c23a212a44103371a311ef327e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503575Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638352}
-
Varun Khaneja authored
Functionally, this is a NO-OP but it does simplify the code and eliminates the NOT_SENT_MISSING_WEB_CONTENTS scenario. R=drubery Bug: 938559,907280 Change-Id: Ifd3e27b865df97aa07d5a1b7653cd0f01910454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504958Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638351}
-
Daniel Murphy authored
This is a reland of 1bc0f674 Original change's description: > [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager > > This allows scopes to be used in the DeleteDatabase call, and cleans up > some code in the IndexedDBDatabase class. > > The last part of the codebase that doesn't have locks before being used > is the IndexedDBBackingStore::Initialize call. Since this happens on the > opening of the database, this can probably use just the raw database + > a WriteBatch. > > Bug: 862456 > Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48 > Reviewed-on: https://chromium-review.googlesource.com/c/1478391 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634358} Bug: 862456 Change-Id: I821c28b93fde903678737d49eaeb44c1b7369e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506552Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638350}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9584fe43a9c2..2c25b14c34c1 git log 9584fe43a9c2..2c25b14c34c1 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 chrisforbes@google.com Implement GetPhysicalDeviceSparseImageFormatProperties Created with: gclient setdep -r src/third_party/swiftshader@2c25b14c34c1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118429780 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ice50ccffd1bc0d3cb54e1d8d1659183aa6785d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506692Reviewed-by:
-
Yulun Wu authored
Improper use of GetLsbReleaseBoard() is tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=938738 Bug: b:120050686 Change-Id: I386fff94be6350ce9ae80e4891251e92d31fb92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501760Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638348}
-
- 06 Mar, 2019 14 commits
-
-
Mei Liang authored
The CL only caches the TabGroupAndroid feature flag for devices that are eligible for tab group. Bug: 934557 Change-Id: I200bd417e60897c39675eb80b37abbe610e957df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501912 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638347}
-
Jinsuk Kim authored
The RTL property can be obtained dynamically from Tab's title. This CL updates a single callsite so that Tab doesn't have to manage the property. Bug: 925242 Change-Id: Ia9e55818b1f07e320337da4c7991a344c88b1b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501894Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Tom Anderson authored
Change necessary to fix Windows build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/417a7dee1c4653bd3a4753710a84c8fd356ba7d9 Change necessary to fix _LIBCPP_DEBUG=1 build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 Full changelist: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6dd25e5efc59124ba1c00b8f98b14be4201..9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 BUG=801780,923166 R=thakis Change-Id: Ib4d81c9a756d84fb2e7b0d5912c3cea493728608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506566 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638345}
-
Brandon Jones authored
Previous CL got reverted after a separate commit moved a script that the new test was relying on. Bug: 933411 Change-Id: I6ba8bce0ef72da44480bfc7b8464720e616a2111 TBR: klausw@chromium.org, bsheedy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506816Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638344}
-
Matthew Mourgos authored
-Add a ghost while dragging an item in an apps_grid_view. -Location of the ghost will be the reorder_placeholder_. -This ghosting is disabled by default for now behind the flag "enable-app-grid-ghost". -GhostImageViews are kept track of by two pointers within apps_grid_view. The GhostImageView pointers are deleted when the view is done hiding or once the pointer is needed to initialize a newer GhostImageView. Bug: 914094 Change-Id: Iee850d0b8b109b6cb0b024d2ee53b45bafc1a4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1467721 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638343}
-
Tommy Steimel authored
This CL removes MPRIS from components and moves it into ui/base. Bug: 935624 Change-Id: Ie0bbf358a4df00e5e1b8905576c3e85ed7b29eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506465Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638342}
-
Daniel Rubery authored
Replace a few usages of base::Callback with base::OnceCallback, and update the corresponding base::Binds with base::BindOnce. TEST=Triggered a ping twice for the same page, one with and one without this change. The generated features were the same. Bug: 933537 Change-Id: Ib9e5454be2e67342868b00af83a58b16cde6c163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489423Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638341}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/c5db41e3e5d0..b6880f79b56f $ git log c5db41e3e..b6880f79b --date=short --no-merges --format='%ad %ae %s' 2019-03-06 rch hpack_whole_entry_buffer_test: Include http2_test_helpers.h Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ia235444ce03fbda3d39923bca26a0140849b2c74 Bug: 937886 Change-Id: Ia235444ce03fbda3d39923bca26a0140849b2c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506664Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638340}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/359fddbf..4c5c3fce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I353da1f13ae7390aa4e39529944a35b35bfcb32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506594Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb4eb612f02f..93c47cc8e359 git log cb4eb612f02f..93c47cc8e359 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 brianosman@google.com SkReflected - avoid double registration, auto register base types, etc. 2019-03-06 fmalita@chromium.org Make SkCubicMap public 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4c84dbdce271..9584fe43a9c2 (1 commits) 2019-03-06 jvanverth@google.com Another stab at MTLRenderCommandEncoder memory leak. 2019-03-06 mtklein@google.com encode F16Norm as rec2020 2019-03-06 reed@google.com change gradients4f to use srgb 2019-03-06 herb@google.com Fix: set SDFT if there is only fallback 2019-03-06 brianosman@google.com Add glf16norm config to DM 2019-03-06 nifong@google.com Interface for passing skp file from JS to WASM 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 10736f2da359..5e67e5c19fd3 (1 commits) 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-06 brianosman@google.com Particles: Cleanup and better UI 2019-03-06 mtklein@google.com rework colorImage testing 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-06 herb@google.com Move process* closures into the GrTextBlob 2019-03-06 halcanary@google.com SkPDF: Add experimental Harfbuzz font subsetter 2019-03-06 mtklein@google.com also tag DM results with color and alpha type Created with: gclient setdep -r src/third_party/skia@93c47cc8e359 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931719 TBR=reed@chromium.org Change-Id: Ib0ef742bdd3eb7a574dfc4304cfa236a35387138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506693Reviewed-by:
-
Aran Gilman authored
This is a follow-up to https://crrev.com/c/1500255. Bug: 938511 Change-Id: If3a4f8a3488557808551da8180ff858522f23052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506872 Commit-Queue: Aran Gilman <gilmanmh@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638337}
-
siyua authored
Also removed the EnableAutofillCreditCardLocalCardMigrationExperiment() in unittests since as we add more experiment flags, this function does not help. Set a helper function in TestPersonalDataManager to change the sync state, which can help us in case of such need in the future. Bug: 897998 Change-Id: Id212077092d80738b8495f4b50bd7034e9f1ead6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501754 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638336}
-
Miyoung Shin authored
- unsigned long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I6eaddcae79f2b22cde719df027f9fce95664db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504485Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638335}
-
Daniel Murphy authored
This reverts commit c8bd0362. Reason for revert: The crashes have stopped, so these debugging CLs are being reverted. Original change's description: > [DOMStorageS13N] Making bind calls sync and adding crash info > > There are renderer hangs on the GetAll call, and it is unclear why. This > change adds crash metadata to know what kind of dom storage is hanging, > and make the 'bind' calls also sync. This will help narrow down what > exactly is hanging (or being dropped) so that the GetAll call never > completes. > > This change is meant to be reverted after the culprit is found. > > TBR: jam@chromium.org > Bug: 927534 > Change-Id: I3c9727f007cddae93b7b274a72f0a6313343ae29 > Reviewed-on: https://chromium-review.googlesource.com/c/1449160 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629630} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927534 Change-Id: I1d864a6a085c8cd8546bd575f06a4be2d12145d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506533Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638334}
-
