GitLab

Use a static variable to initialize the malloc instance lazily only once.

This replicates the behavior from the old tcmalloc, and removes 11
static initializers in malloc_extension.cc.

In addition, make current_instance an std::atomic variable to avoid
potential data races on accesses to it.

BUG=b:119055819
TEST=Unit tests pass

Change-Id: I702ca3563a9ea2494755bced38f56ee985ce1556
Reviewed-on: https://chromium-review.googlesource.com/c/1464108
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632042}

Currently we reset the |white_listed_touch_action_| at GestureScrollEnd,
which could cause crash to the fling cancel case. In this case, the
touch/gesture sequence looks like this:
TouchSequenceStart1--GestureTapDown1--GSB1--GSU1...--TouchSequenceEnd1--
GSU1...--GSU1--TouchSequenceStart2--GSE1--GSB2--GSU2...--GSU2...

In the above sequence, the suffix "1" indicates which gesture sequence
it is. When it is the TouchSequenceStart2, |white_listed_touch_action_|
is set, and will be reset at GSE1. Then when it comes to GSB2, the
|white_listed_touch_action_| has no value, and there maybe a crash.

This CL fixes it by not resetting the var at GSE. Unit test is added
to ensure the correctness.

Bug: 904648
Change-Id: I616ccdd3568ad2df935b613c77cabfc54a8ff90d
Reviewed-on: https://chromium-review.googlesource.com/c/1463981Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632041}

operator bool() and is_bound() are the same for InterfacePtr.

Bug: None
Change-Id: I29e311d6e1f80ba49d3ebc15a0b5ad619aff2621
Reviewed-on: https://chromium-review.googlesource.com/c/1471377Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632040}

Automates the VR manual tests for ensuring that file and data URLs
are properly emphasized/colored differently.

Bug: 887613
Change-Id: Id9658f0d0b93febbadb8ba61d54d18324ba2b2bc
Reviewed-on: https://chromium-review.googlesource.com/c/1468022Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632039}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I4592806534e9aacf5c3d9dd95aa478ec03b3b0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1470959Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632038}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googletest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

Bug: 925652
Change-Id: I29fdb61495d0e3f8e7014878ada10df78f1a3fe8
Reviewed-on: https://chromium-review.googlesource.com/c/1469648
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632037}

UI Automation uses these interfaces for accessibility tree navigation,
associating accessibility trees with HWNDs, hit testing, and focus
management.

Also included are a few supporting bugfixes and additional properties on
IRawElementProviderSimple in order to make the tree more usable in the
inspect.exe debugging tool and improve the experience in Windows
Narrator.

Bug: 928811
Change-Id: I2c03ff34adff3e7c29d08da17a9edf292cdbb6a8
Reviewed-on: https://chromium-review.googlesource.com/c/1455025Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#632036}

We are far away from shipping pre-L bundles, so this target is not yet
worth maintaining.

Change-Id: I6f2f44782579716ecb73e3014ecd1d7f27571717
Reviewed-on: https://chromium-review.googlesource.com/c/1471218Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632035}

Bug: None
Change-Id: I688e919c0360407b5a04beb861c5f3afb45e35f2
Reviewed-on: https://chromium-review.googlesource.com/c/1459927
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632034}

- Converts TabGridCoordinator into a TabListCoordinator as it was easy
to make it modular.
- Add TabStripViewBinder and ViewHolder to build tab strip specific UI
pieces
- Uses TabList- classes to make a new TabStrip component
- The new component is not used currently (tested on the grid setup to
make sure it is working)

Change-Id: Ibd3da520c7dec0710df5324e93af8d3af2aacfe9

BUG= 930898

Change-Id: Ibd3da520c7dec0710df5324e93af8d3af2aacfe9
Reviewed-on: https://chromium-review.googlesource.com/c/1465060
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632033}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googletest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

TBR=blundell

Bug: 925652
Change-Id: Ibf01039345188ea7458a6773b4eea52d2104cd52
Reviewed-on: https://chromium-review.googlesource.com/c/1471379Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632032}

Using wpt-import in Chromium 73293fd4.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I373fde919fb89f79d2f5293648656de275203b2d
Reviewed-on: https://chromium-review.googlesource.com/c/1470725Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632031}

Chrome flakily failed the test because it doesn't guarantee the order
between message and fetch event. That might violate the spec, but the
test doesn't need to test this. It's meant to test that the client
message queue isn't enabled until a certain time. We can test
that without requiring message/fetch ordering.

Loosen the test to just check that the messages arrive after
|earliest_dispatch|.

Bug: 926670
Change-Id: Ic291b25443358412936b4a5eeb24ee6f8efa6b71
Reviewed-on: https://chromium-review.googlesource.com/c/1469842
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632030}

https://pdfium.googlesource.com/pdfium.git/+log/f7e697617c77..bf42afa0df14


git log f7e697617c77..bf42afa0df14 --date=short --no-merges --format='%ad %ae %s'
2019-02-13 tsepez@chromium.org Handle creation of CGFAS_Decimals from floats with bigger values.


Created with:
  gclient setdep -r src/third_party/pdfium@bf42afa0df14

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I51da4e5357292a810ff163436d9ec9005441e8fa
Reviewed-on: https://chromium-review.googlesource.com/c/1470958Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632029}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52ea556bdd54..7ec701934993


Created with:
  gclient setdep -r src-internal@7ec701934993

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:790528,chromium:790522,chromium:891734,chromium:891734
TBR=mmoss@chromium.org

Change-Id: Id5ddc949ecab3b1677a1ff2f5c0f3665c8a42be7
Reviewed-on: https://chromium-review.googlesource.com/c/1470957Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632028}

Disable PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess,
which is failing on Windows.

TBR=fdoray@chromium.org

Bug: 931720
Change-Id: I77fabc5c796b949f1616e0daf262695bf22ea14b
Reviewed-on: https://chromium-review.googlesource.com/c/1471385Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632027}

BUG: 888093

Change-Id: I448c5a807e524b32bcf5535c56932ee936a8c443
Reviewed-on: https://chromium-review.googlesource.com/c/1339139
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632026}

This reverts commit 8e40f476.

Reason for revert: crbug.com/931878, touch tab-dragging gets broken

Original change's description:
> chromeos: disables event throttling in window-service clients
> 
> Only the window-service should throttle.
> 
> BUG=929914
> TEST=none
> TBR=sadrul@chromium.org
> 
> Change-Id: Iab7ea987c8fcb1f52b9c1e69576a0f950d790787
> Reviewed-on: https://chromium-review.googlesource.com/c/1470941
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631868}

TBR=sadrul@chromium.org,sky@chromium.org

Change-Id: I4c356212aed1cf03b6c381ef05ce404a58517351
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 929914
Reviewed-on: https://chromium-review.googlesource.com/c/1471458Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632025}

This reverts commit fca998b7.

Reason for revert: crbug.com/931878, touch tab-dragging gets broken

Original change's description:
> Reland "chromeos: makes resizes smoother with mash"
> 
> This reverts commit 643813e1.
> 
> Reason for revert: My test was wrong, we actually block mouse on device in certain modes. Sorry for the noise.
> 
> Original change's description:
> > Revert "chromeos: makes resizes smoother with mash"
> > 
> > This reverts commit b805090b.
> > 
> > Reason for revert: This makes the mouse get stuck hidden on device.
> > 
> > Original change's description:
> > > chromeos: makes resizes smoother with mash
> > > 
> > > This contains two changes:
> > > 1. Adds call from ClientRoot to Compositor::OnChildResizing(). This ensures
> > >    that WindowTreeHost doesn't dispatch move events until the frame has been
> > >    activated.
> > > 2. Converts resetting of pointer moves lock from OnCompositingDidCommit()
> > >    to OnCompositingEnded(). OnCompositingDidCommit() seems to be called much
> > >    to earlier in the mash case, and results in jank when resizing.
> > > 
> > > BUG=929914
> > > TEST=none
> > > 
> > > Change-Id: I68d87d6e7f237f246c2fad6218d9da5356c98641
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1467917
> > > Commit-Queue: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Saman Sami <samans@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#631743}
> > 
> > TBR=sky@chromium.org,samans@chromium.org
> > 
> > Change-Id: Iaf103ed66885da652c7013fcc412b0269e10b303
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 929914
> > Reviewed-on: https://chromium-review.googlesource.com/c/1470935
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#631803}
> 
> TBR=sky@chromium.org,samans@chromium.org
> 
> Change-Id: I828256b878dfb8f5a8ec0bbd6c6c533e091ddb5f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 929914
> Reviewed-on: https://chromium-review.googlesource.com/c/1471010
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631820}

TBR=sky@chromium.org,samans@chromium.org

Change-Id: Id7eb67f636e13677122c6a8bd0c8e50bd4b51986
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 929914
Reviewed-on: https://chromium-review.googlesource.com/c/1471493Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632024}

Tab doesn't need to keep the controls height and a flag for control
affecting the view resizing. This CL removes the APIs for them, and
lets TabWebContentsDelegate get the values directly from
ChromeFullscreenManager.

Bug: 925242
Change-Id: I69d1868078b46e9d9b268245396c68538ccbfd35
Reviewed-on: https://chromium-review.googlesource.com/c/1436465
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632023}

The ImagePaintTimingDetector is now using IsImage to tell whether an
object is a layout image. But this is incorrect. We shuld use
IsLayoutImage instead.

Bug: 869924
Change-Id: I018118d41cb9a434d6c13c0920ca5a1486827216
Reviewed-on: https://chromium-review.googlesource.com/c/1471219Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632022}

Disallow setting NEL headers and queueing NEL reports when the HTTP
response is fetched via a proxy. Disallow NEL reporting on 407
responses.

Bug: 930777
Change-Id: I803c3e087630cd5e6c244771550c97091e5d6e74
Reviewed-on: https://chromium-review.googlesource.com/c/1466195
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632021}

Currently we mark unused pages inaccessible but don't release their
memory back to the OS. Release it so that we can make use of a large
quarantine without incurring memory overhead. This showed a ~2-4%
regression on a microbenchmark that looped allocating and
deallocating.

Bug: 912286
Change-Id: Iab5fd441071ef0fc45aa793708b886c7fe864158
Reviewed-on: https://chromium-review.googlesource.com/c/1471331
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632020}

This method allows to replace the content of the page with
given data and MIME type.
The method does not trigger a navigation.

The method also takes a URL that will replace the current
URL in the navigation stack.

Bug: 929492
Change-Id: If1295915718d8dd9e582d2e88035eb63ce7341ea
Reviewed-on: https://chromium-review.googlesource.com/c/1436359
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632019}

Add the ability to simulate an inline update flow, which will be used by variations,
test, and PM/UX to look at the update flow.

BUG=922714

Change-Id: Ic313e8cae6e9fc9f0413c227c151990d192e62a5
Reviewed-on: https://chromium-review.googlesource.com/c/1461831Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632018}

This CL is meant as a low-risk fix of Issue 926602 to merge back to M73.
For the long term, it will be preferable to avoid maximizing windows
before snapping them. Then we might even be able to eliminate
|defer_bounds_updates| altogether (even though it existed before
anything about snapped windows carrying over from desktop to tablet).

  TabletModeControllerTest.DeferBoundsUpdatesForWindowsInOverview*
  TabletModeControllerTest.ProgrammaticallyStartSplitViewAndThenOverview

Test: ash_unittests TabletModeControllerTest.StartTablet*
Test: ash_unittests
Test: ash_unittests
Bug: 926602
Change-Id: I0a068ffae314871c8466d1364bcd96f72b69d345
Reviewed-on: https://chromium-review.googlesource.com/c/1457235Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#631462}
Reviewed-on: https://chromium-review.googlesource.com/c/1471013
Cr-Commit-Position: refs/heads/master@{#632017}

This reverts commit 200e1df8.

Reason for revert: Forgot to make necessary changes chromium_tests.

Original change's description:
> Add win32-arm64-rel to the gitiles trigger.
> 
> Bug: 925575
> Change-Id: I0fb736af2963b307f6bf141ea1c23ee16b1cf671
> Reviewed-on: https://chromium-review.googlesource.com/c/1471249
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632005}

TBR=jbudorick@chromium.org,gbeaty@chromium.org

Change-Id: Ic5959773ad89664013cbc3801be08feddda60951
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 925575
Reviewed-on: https://chromium-review.googlesource.com/c/1471453
Commit-Queue: Erik Staab <estaab@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632016}

A few domains used to be whitelisted to always allow them to load non-PNaCl
NaCl modules.
Remove the the whitelist and the associated tests.

Bug: 919940
Change-Id: I98d410313adcd75ab3b69e724c97a4550ce18f1c
Reviewed-on: https://chromium-review.googlesource.com/c/1471232Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632015}

ChromeDriverTest.testActionsTouchStart is flaky on Mac10.12 bot, fix
the test to pass on Mac bot.

Bug: 931440

Change-Id: I8d8d2080d20c23c8f4de6352eb8067ba3f09c9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1471305Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632014}

Bug: 887005
Change-Id: Ic5940c15a652c0fceea34f8a1ca493b7707d9236
Reviewed-on: https://chromium-review.googlesource.com/c/1467022
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632013}

Add the following style:
  white-space: pre-wrap;
  line-height: 1.5;

Change-Id: I51be1df221787ff5fcac3cf92c528fbecb27c744
Reviewed-on: https://chromium-review.googlesource.com/c/1469198
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632012}

This adds CHECKs to all loaders that are not null checked before calling
ResumeReadingBodyFromNet, which will hopefully give a better stack so we
can find the real culprit.

Bug: 916098
Change-Id: I11f01f6bffe44dd17efb16f9c89ee5d6bd078d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1471210Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632011}

This CL:
* Fixes a Polymer2 bug where networkProxy.isShared_ was called while
  networkProperties was undefined without checking, causing a console
  error.
* Fixes a DCHECK in the ONC code when configuring Ethernet nameservers
  or IP config properties.
* Also updates NULL -> nullptr in onc_translation_tables.cc.

Bug: issue 931845
Change-Id: I87a953a0b7779f0d7f4538a5b9e8a5a95f9d5235
Reviewed-on: https://chromium-review.googlesource.com/c/1471307Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632010}

Instead of showing the Search Provider favicon in the omnibox, this
experiment shows a generic magnifying glass icon.

This also applies to the NTP, as the omnibox in the NTP has always had
the same icon as the omnibox showing a search suggestion.

Doing something different would require a more extensive change.

Bug: 931836
Change-Id: Ia16422b8e4c710b6d664d10c20a322b1083dd57a
Reviewed-on: https://chromium-review.googlesource.com/c/1471247Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632009}

Modify DWriteFontLookupTableBuilder to support off-main-thread
scheduling of the font unique name lookup table construction.

For now, schedule this as a USER_BLOCKING-prioritized startup task in a
separate SequencedTaskRunner. Synchronize using a WaitableEvent that the
DWriteFontProxyImpl can wait on when it receives an incoming Mojo
request from a renderer for this table.

Once the UpdatePriority() API for SequencedTaskRunners becomes
available, downgrade the priority to BEST_EFFORT, then bump it once the
renderer requests the table. This TODO is tracked in [1].

Background for font unique name local lookups in the design review doc
in https://crbug.com/828317. See also startup job scheduling discussion
in [2].

[1] https://crbug.com/931366
[2] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iDClDAsZnrE/bb5eZXkUFAAJ

Bug: 889864
Change-Id: I8e19d34520422fc9404ca01cb8357221d7a11495
Reviewed-on: https://chromium-review.googlesource.com/c/1459635
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632008}

This reverts commit ab8cc613.

Reason for revert: Changed the trybot, meant to change the CI bot.

Original change's description:
> Use 32 cores on 'win-asan'
> 
> https://crrev.com/i/828938 added a new bot which has 32 cores. This CL
> should make the builder use that machine instead of the old 8 core
> machine.
> 
> Bug: 919189
> Change-Id: I3cf8894e73c21a9d590ce709c3fa3b40ca23d0f2
> Reviewed-on: https://chromium-review.googlesource.com/c/1470991
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Auto-Submit: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631830}

TBR=martiniss@chromium.org,jbudorick@chromium.org,gbeaty@chromium.org

Change-Id: I8ba9ebc0cc660e736106afdf91baf058906040d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919189
Reviewed-on: https://chromium-review.googlesource.com/c/1471344Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632007}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googletest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

TBR=hychao,bartfab

Bug: 925652
Change-Id: I71a4345703ca76c05540fc8062ca0d24c7d204c2
Reviewed-on: https://chromium-review.googlesource.com/c/1471375Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632006}

Bug: 925575
Change-Id: I0fb736af2963b307f6bf141ea1c23ee16b1cf671
Reviewed-on: https://chromium-review.googlesource.com/c/1471249Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632005}

This patch replaces the erase(std::remove_if()) used in the chrome
folder with base::EraseIf().

Bug: 875665
Change-Id: I8ebc80225ca4477dac2ae96f2e6dd21ef4602c52
Reviewed-on: https://chromium-review.googlesource.com/c/1469183Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#632004}

Bug: 931458
Change-Id: I9d78475075ae8cdb006fceb402b888c7dfd10bf8
Reviewed-on: https://chromium-review.googlesource.com/c/1471335Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632003}