- 07 Sep, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/157216ad..98633bd1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief253615e1fa4e12de8dd1fbac6284f01362986e Reviewed-on: https://chromium-review.googlesource.com/1213368Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589563}
-
chaopeng authored
This test failing because it need some rAFs for commit. Bug: 875097 Change-Id: I10aacf4a55ea8fe277fef1fc68b4d6c9ee287190 Reviewed-on: https://chromium-review.googlesource.com/1213545Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589562}
-
mrefaat authored
LoadQuery is called for commands such as (paste&Go, QRScan and voice search). the query passed to it is not sanitized and can have javascript which shouldn't be executed. This CL sanitize the input of the LoadQuery command to make sure it's safe. The sanitization works by compressing white spaces from the beginning of the query & then strip javascript: scheme if it exists on the beginning of the query. examples of sanitization results: "javascript:abc"->"abc", "javascript:" -> " java" -> " java" Bug: 877984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8524632092d3ecb0c4c23f26e3baa25ac305e58b Reviewed-on: https://chromium-review.googlesource.com/1205601Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#589561}
-
Nico Weber authored
They haven't been needed in (at least) the last 4 builds, so lock in the progression. The pak file determinism progression is likely from https://chromium-review.googlesource.com/1164536 The v8 isolate is still nondeterministic in component builds, so add some (hopefully temporary) logic to have files that are nondeterministic only in component builds. Bug: 330263 Change-Id: I721b1ff543410c066d6ef6ea6ffedbc4ba4f180b Reviewed-on: https://chromium-review.googlesource.com/1213525Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589560}
-
Charlie Reis authored
BUG=881497 TEST=See bug for repro steps. Change-Id: I392788d31e638bc79bb8d35e0451c79af6ca3a26 Reviewed-on: https://chromium-review.googlesource.com/1212145Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589559}
-
John Abd-El-Malek authored
TBR=aee Bug: 877109 Change-Id: I73a502d70b6ee1491589f5eba4fb07764e5f5d38 Reviewed-on: https://chromium-review.googlesource.com/1213506 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#589558}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b429aed84d8..459c914be7a2 git log 7b429aed84d8..459c914be7a2 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 mtklein@google.com fix in-gamut check in SkRasterPipeline::append_constant_color() 2018-09-07 egdaniel@google.com Remove caching of textures in GrAHardwareBufferImageGenerator. 2018-09-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 54b6cee88c40..52df767ea52b (1 commits) 2018-09-07 mtklein@google.com missed a place to clamp 2018-09-07 reed@google.com Use the unique_ptr variant of MakeFromStream (the other is deprecated) 2018-09-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 801719235b13..d84b6737fa10 (1 commits) 2018-09-07 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms da4870efd7b7..54b6cee88c40 (1 commits) 2018-09-07 michaelludwig@google.com Revert "Redo how extra emit code flushing operates" 2018-09-07 michaelludwig@google.com Redo how extra emit code flushing operates 2018-09-07 egdaniel@google.com Have SkImage_Base send out UniqueKey invalidations to GPU backend when destroyed. Created with: gclient setdep -r src/third_party/skia@459c914be7a2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I1a087db4057ec34a51d95542e9dc1cd66b0f0cde Reviewed-on: https://chromium-review.googlesource.com/1213763Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589557}
-
Daniele Castagna authored
FillModesetBuffer assumed all the buffers could be mmaped as dumb buffers. This doesn't work on some platforms. This CL mmaps the modeset buffer using gbm_map instead, that should work with tiled formats too. Bug: b/78892556 Change-Id: I20ff9e54ea12e9866360021d8d9c5f7940f5b551 Reviewed-on: https://chromium-review.googlesource.com/1198451 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#589556}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7600fc0e19c3..3e38c99f5d75 git log 7600fc0e19c3..3e38c99f5d75 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 dneto@google.com Start SPIRV-Toosl v2018.6-dev 2018-09-07 dneto@google.com Finalize SPIRV-Tools v2018.5 2018-09-07 dneto@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3e38c99f5d75 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibcde6a85451cdd902a6711be8c6a6ca51d393195 Reviewed-on: https://chromium-review.googlesource.com/1213471Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589555}
-
Pavel Shmakov authored
Introduced a basic Dagger structure for the application (components, modules, etc). Replaced ContextualSuggestionsDependencyFactory with proper dependency injection, and made corresponding adjustments to the tests. Bug: 787005 Change-Id: Id8107ed8793391df08976ba011a1ab8cc1de2814 Reviewed-on: https://chromium-review.googlesource.com/1194037 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#589554}
-
Takumi Fujimoto authored
When a stop button is in focus, the screen reader will say "stop, <sink name>, <sink status>, button". Bug: 881611 Change-Id: If90512e79c5c47a0cbe04a8e88e49fe165fcbb2c Reviewed-on: https://chromium-review.googlesource.com/1211666Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#589553}
-
Xiaoqian Dai authored
We need to restore a dragged window's transform back to identify first and then change its bounds, otherwise, if the window has a bubble, the bubble won't get the correct bounds, as seen in the bug. The reason is BubbleDialogDelegateView::SizeToContents() is only called to relayout the bubble when its anchor widget window's bounds changed, and if the anchor widget window has a non-identity transform in place when the function is called, the bubble can't be relayout'ed correctly as GetAnchorBoundsInScreen() takes the tranform into consideration. To fix this, we always restore the transform first and then change its bounds. We'll investigate if there is better way to fix it. Bug: 879359 Change-Id: I5dd36082eb4fff8fdcdbde21e22b12393663df76 Reviewed-on: https://chromium-review.googlesource.com/1197788 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#589552}
-
Eric Robinson authored
The test that checked the cross-origin status of a doc-written ad frame was flaky, and wasn't seeing any histogram entry at all. The operating theory is that this was due to the frame itself not being guaranteed to load all its subresources. This CL blocks the test until the subframe's load event is fired to ensure that subresources have been fully loaded. Bug: 874443 Change-Id: If4aa585d1e51dcf1e2350b768d6f6e5dfd3554cd Reviewed-on: https://chromium-review.googlesource.com/1211085 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589551}
-
Charlie Harrison authored
TBR=jkarlin@chromium.org Bug: 847933 Change-Id: If2f8e5f6a6971d865177daf98fab4faef045dcc4 Reviewed-on: https://chromium-review.googlesource.com/1213526 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589550}
-
Miguel Casas authored
This test removes the member variables |test_image_files_| and |expected_status_| and makes them into method parameters instead, which is more explicit and will make the methods more customisable down the line. Bug: 877694 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If1c63e32b7e3bf52f988bad76dd401324fd28a32 Reviewed-on: https://chromium-review.googlesource.com/1205312Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589549}
-
Alexandr Ilin authored
We observe many crashes on Mac caused by shm allocation failures. Our suspision is that allocations fail because we leak the shared memory, but there is no signal to help narrow down what that could be. This patch will make the browser crash as soon as a shm allocation fails, so we can have better stack traces on the crash server. Bug: 872237 Change-Id: Ib6bb1a181c0f262a72693e9134061abd707ccc6e Reviewed-on: https://chromium-review.googlesource.com/1213282Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589548}
-
Stephen McGruer authored
This CL converts most of the code referring to iteration_duration to use the transitional AnimationTimeDelta class. As it can be null (meaning 'auto'), it is wrapped in a base::Optional where necessary. Additional important changes resulting from this: * animation_browsertest.js is changed because a sufficiently large duration would now be treated as 'infinite', and the test doesn't want that (as it finish()es the animation). * timing_input.cc can now use UpdateValueIfChanged for iteration_duration because base::Optional has equality semantics that work for it. Bug: 737867 Change-Id: Ifa322d8a3672b2fe3ba93a0fd704636f383f2ef5 Reviewed-on: https://chromium-review.googlesource.com/1175860 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589547}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/801719235b13..d84b6737fa10 git log 801719235b13..d84b6737fa10 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 jmadill@chromium.org Cache ValidateDrawStates. Created with: gclient setdep -r src/third_party/angle@d84b6737fa10 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ifc8c78feaf56c7c0b18a7c1e7e046077205ca08c Reviewed-on: https://chromium-review.googlesource.com/1213602Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589546}
-
Manu Cornet authored
See some before/after screenshots here: https://bugs.chromium.org/p/chromium/issues/detail?id=881043#c8 Note that this also introduces the same margin in the "old" UI, but this is a desired side effect. Bug: 881043, 876474 Change-Id: Iddd8dd701076d3a2e230e841eba5eec467a94882 Reviewed-on: https://chromium-review.googlesource.com/1212092Reviewed-by:Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#589545}
-
Nicolas Ouellet-payeur authored
Bug: 873787 Change-Id: I591e0b158ca8e61e0f8ad9ac1099ac5e0ba28229 Reviewed-on: https://chromium-review.googlesource.com/1173401Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#589544}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23d65fd54de1..990810e4ba69 git log 23d65fd54de1..990810e4ba69 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 jrbarnette@chromium.org Remove code for the provisioning workqueue. 2018-09-07 jrbarnette@chromium.org Remove support for the provisioning workqueue. 2018-09-07 vapier@chromium.org binhost_test: output each failure in a sep log line 2018-09-07 vapier@chromium.org binhost_test: make output a bit easier to read 2018-09-07 vapier@chromium.org test_image: tweak the CLI names 2018-09-07 vapier@chromium.org binhost: normalize CompatId/BoardKey tuples to ASCII Created with: gclient setdep -r src/third_party/chromite@990810e4ba69 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf9d348efb509dd54d49b90435029b59c00decef Reviewed-on: https://chromium-review.googlesource.com/1213470Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589543}
-
Justin Donnelly authored
This reverts commit 2c0b1626. Reason for revert: The "SitePerProcessHitTestDataGenerationBrowserTest.PointerEventsNoneOOPIF/2" test is broken on the Android CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2797 Original change's description: > Do not hit test OOPIFs with pointer-events: none > > Frame owners may have pointer-events: none property which blocks them > from receiving mouse and touch events. Currently in V2 viz hit testing > hit test data provider has no information about whether OOPIFs have > pointer-events: none property. > > This CL plumbs pointer-events: none property from HTMLFrameOwnerElement > to cc::SurfaceLayer so that the hit test data provider in LayerTreeHostImpl > will be able to generate proper hit test data for pointer-events: none > OOPIFs. > > Bug: 841358 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I381c8f0b1dcfb14b7ef24c7b2b3806ae60ec4182 > Reviewed-on: https://chromium-review.googlesource.com/1127440 > Commit-Queue: Xianda Sun <sunxd@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589306} TBR=rjkroege@chromium.org,flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,chrishtr@chromium.org,fsamuel@chromium.org,sunxd@chromium.org,joelhockey@chromium.org,riajiang@chromium.org,gklassen@chromium.org Change-Id: I5fc43bd1b5dd60312ff9046802f8ac18b8f2e6bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841358 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1213823Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589542}
-
Vasilii Sukhanov authored
Currently it manages a set of fill credentials. However, for a frame there is just one list corresponding to the origin. Thus, the key is redundant. Bug: 876521,846404 Change-Id: I045768683512e3eb8c258d97397de8981e630be6 Reviewed-on: https://chromium-review.googlesource.com/1211262Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589541}
-
braveyao authored
Make braveyao own more desktop capture related files under chrome/browser/media/webrtc, majorly including the new files added for the getDisplayMedia() API. Bug: 867003 Change-Id: Id1e310dc42ff8473c79d0f41de388fcb64597a56 NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1212097Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#589540}
-
Anthony Vallee-Dubois authored
Bug: 865500 Change-Id: I104a80f132b5ab0420f242328227150e05e7fb93 Reviewed-on: https://chromium-review.googlesource.com/1211506 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#589539}
-
James Cook authored
To match the new class names. Doing this in two steps helps git track the file renames more easily. Bug: 866532 Change-Id: Iae46af10438336f2ec182c863498d0eeb1c3a29c Reviewed-on: https://chromium-review.googlesource.com/1212100 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589538}
-
Joshua Bell authored
A user or admin can make a site be "session-only", i.e. all data is cleared when the user leaves the site. In the UI at chrome://settings/content/cookies this is done by adding sites to the "Clear on exit" list. We shouldn't grant the permission for sites with this property, since we do so with heuristics and we encourage developers to request the permission before offering the user a of guarantee about offline storage availability. If we granted the permission, the site would end up giving a false commitment to the user. Bug: 824950 Change-Id: I6ccd53376fc3aed65dd742b3fc0938c203281e7b Reviewed-on: https://chromium-review.googlesource.com/1208149Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#589537}
-
Sorin Jianu authored
This is a mechanical change. The rationale for this change is that the value returned from this function is formated inside a component updater request. How this value is formated depends on the protocol encoding. Therefore, to abstract out the protocol encoding (XML or JSON), the function must return its data as a map of key-values instead of joined strings. Also, as a small change, replace std::map with base::flat_map for the extra request headers. BUG: 881076 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic39e94e8de0e3e27128a80cd24c055bdd434c45f Reviewed-on: https://chromium-review.googlesource.com/1208134 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#589536}
-
Justin DeWitt authored
This is used on the wire from the Explore Sites API to Chrome. Bug: 867488 Change-Id: Id830f53b7ea7cfad8fbd6c7e38694d2de43ff558 Reviewed-on: https://chromium-review.googlesource.com/1210945Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#589535}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 923d919c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24209 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I494c003064a6099673b3799b571d2d534089ecea Reviewed-on: https://chromium-review.googlesource.com/1213365 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589534}
-
Xida Chen authored
The original CL was reverted because there were many DumpWithoutCrashing, and the reason is that the num_of_active_touches_ goes below 0. The problem is that in InputRouterImpl::TouchEventHandled, we increment this num only when it is ack from the main thread. In other words, we missed other cases such as when there is a passive event listerner. This CL fixes the problem. PS#1 is exactly the same as the original CL, so that it is easier for review. PS#2 fixes the problem and added some more unit tests. It also removes the temporary fix to prevent crashes. TBR=tdresser@chromium.org Bug: 851644 Change-Id: I4d668ab322c94ea2704e3e220e2afd1a44833dca Reviewed-on: https://chromium-review.googlesource.com/1209545 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#589533}
-
Xida Chen authored
The above function could return nullptr sometimes, which is indicated in crbug.com/751768, we should check the result of this function instead of just DCHECK. Bug: 737109 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id732898bb35cc43c9ccce81979c39efa443f0610 Reviewed-on: https://chromium-review.googlesource.com/1212352Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589532}
-
Fabio Tirelo authored
This is to prepare the field for removing feature kAutofillExpandedPopupViews. Bug: 831603 Change-Id: Ib748de088912221c3af18435286904046befb58f Reviewed-on: https://chromium-review.googlesource.com/1210165 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589531}
-
Matthew Jones authored
This patch replaces the need for several larger objects in the BottomSheetController (LayoutManager and TabModelSelector) in favor of instead using the ActivityTabProvider. This simplifies the logic in this class. Change-Id: I001593cfccaadbf1c0e60ceaa7231e203c56a338 Reviewed-on: https://chromium-review.googlesource.com/1211447Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#589530}
-
Raymond Toy authored
Use simple linear extrapolation to resample the data when we reach the end of the buffer. Previously, the last sample would just be repeated enough times. Manually verified that the test passes on Firefox (nightly) and fails on Chrome without this CL. Bug: 881119 Test: the-audiobuffersourcenode-interface/buffer-resampling.html Change-Id: I1eb6ee089aa5477e03ff7184eb974f769b739528 Reviewed-on: https://chromium-review.googlesource.com/1211910 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589529}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b090b2b26803..7b429aed84d8 git log b090b2b26803..7b429aed84d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 michaelludwig@google.com Implement boolean short circuit folding in SkSL 2018-09-07 jvanverth@google.com Reland "Revert "update to new MakeFromStream signature"" 2018-09-07 reed@google.com Revert "Revert "update to new MakeFromStream signature"" Created with: gclient setdep -r src/third_party/skia@7b429aed84d8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Ie356656272734f414b91c1252ccb34816f4940bc Reviewed-on: https://chromium-review.googlesource.com/1213443Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589528}
-
Justin Donnelly authored
This reverts commit 12435aaa. Reason for revert: Suspected of breaking the build on android-rel and closing the tree. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/1629 for the error, which references "incremental" and "json". Original change's description: > Android: Skip incremental install json for targets that don't support it > > Change-Id: I111afe4c1cd7c0c152333d678c22dc9eb284adf3 > Reviewed-on: https://chromium-review.googlesource.com/1205805 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589523} TBR=agrieve@chromium.org,tiborg@chromium.org Change-Id: Ibc19c427d9afa4db971c46fa92aa05e8eb52f168 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1213370Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589527}
-
James Cook authored
NativeCursorManagerAshClassic is the only subclass. I'm going to rename the file in a follow-up CL to help git rename tracking preserve the blame history. Bug: 866532 Change-Id: Icb4a0ee7211a4256d6655797393d22bb43169e77 Reviewed-on: https://chromium-review.googlesource.com/1212143Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#589526}
-
Tibor Goldschwendt authored
Change-Id: Ia65a75f355ecf7d035f1bdd8cac3fb55f85160b2 Reviewed-on: https://chromium-review.googlesource.com/1213366Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589525}
-
Markus Heintz authored
This reverts commit 41c5a44c. Reason for revert: This broke many webkit tests: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Linux_Trusty_MSAN%2F9844%2F%2B%2Frecipes%2Fsteps%2Fwebkit_layout_tests%2F0%2Fstdout In https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9844 Revert speculatively since the error message is pointing to code potentially added by this cl 04:21:46.301 9979 #0 0x12242776 in blink::(anonymous namespace)::CanAccessWindowInternal(blink::LocalDOMWindow const*, blink::DOMWindow const*) ./../../third_party/blink/renderer/bindings/core/v8/binding_security.cc:73:79 04:21:46.301 9979 #1 0x1223dfac in CanAccessWindow ./../../third_party/blink/renderer/bindings/core/v8/binding_security.cc:110:7 04:21:46.301 9979 #2 0x1223dfac in blink::BindingSecurity::ShouldAllowAccessTo(blink::LocalDOMWindow const*, blink::DOMWindow const*, blink::BindingSecurity::ErrorReportOption) ./../../third_party/blink/renderer/bindings/core/v8/binding_se Original change's description: > Add a UseCounter for cross-origin accesses requiring 'document.domain'. > > Bug: 787905 > Change-Id: I2248173947ed87ff3e8f40dc86a8e9044ed2dd3b > Reviewed-on: https://chromium-review.googlesource.com/966442 > Commit-Queue: Mike West <mkwst@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589470} TBR=dcheng@chromium.org,yukishiino@chromium.org,jochen@chromium.org,mkwst@chromium.org Change-Id: Ib5c8fe269823c889c97da13e5107d1da75d7a457 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787905 Reviewed-on: https://chromium-review.googlesource.com/1213152Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589524}
-