- 12 Jun, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/36e1cdaf2d99..1c02d65fcbf3 $ git log 36e1cdaf2..1c02d65fc --date=short --no-merges --format='%ad %ae %s' 2017-06-12 ashleymarie Add names to stories used in unittests Created with: roll-dep src/third_party/catapult BUG=720002 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iccf75155d0e2ecc31f91681a8d1cc764fe4d0169 Reviewed-on: https://chromium-review.googlesource.com/531064 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478628}
-
magjed authored
Speculative fix for WebRTC test failures. See issue for more information. BUG=732345 TBR=emircan Review-Url: https://codereview.chromium.org/2934793002 Cr-Commit-Position: refs/heads/master@{#478627}
-
Mohamed Amir Yosef authored
Bug: 732161 Change-Id: I57dd0dd8029fd83fabdab063040fc5163059afc9 Reviewed-on: https://chromium-review.googlesource.com/530371 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#478626}
-
arthursonzogni authored
Remove the TODO and enable the disabled test expectation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2933803002 Cr-Commit-Position: refs/heads/master@{#478625}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b83d870b007f..c6fd58d69bd8 $ git log b83d870b0..c6fd58d69 --date=short --no-merges --format='%ad %ae %s' 2017-06-09 hnakashima Trimming brackets and quotes outside URLs. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ie2fb5b271a9b0e1f3f514b88522a02fe50332d62 Reviewed-on: https://chromium-review.googlesource.com/531124 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478624}
-
Primiano Tucci authored
This reverts commit 31b78339. Reason for reland: Fixed TestBackgroundTracingSetup flakiness, this time for real. In the last reland I forgot to git stash pop the actual fix and ended up just relanding the original CL as-is. Original change's description: > Revert "Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest" > > This reverts commit 05755b0f. > > Reason for revert: Failing frequently on linux_chromium_asan_rel_ng on the CQ. Has failed once so far on CI: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/36356 > > Original change's description: > > Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest > > > > This reverts commit ac66f89e. > > > > Reason for reland: Fixed race in the test > > > > Original change's description: > > > Revert "memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest" > > > > > > This reverts commit 16e17888. > > > > > > Reason for revert: MemoryDumpManagerTest.TestBackgroundTracingSetup fails under LSAN: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/36339 > > > > > > Original change's description: > > > > memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest > > > > > > > > This CL changes the memory-infra unittests to not depend on > > > > the RequestGlobalDump() API. From a logical viewpoint, > > > > the RequestGlobalDump() is not needed for an in-process-only > > > > test like MemoryDumpManagerTest. > > > > From a more practical viewpoint, this refactoring is required > > > > in preparation of the next CLs that will remove > > > > MemoryDumpManager::RequestGlobalDump() method and move all the > > > > clients to directly use the service. > > > > > > > > This CL doesn't cause any behavior change in memory-infra. > > > > > > > > BUG=720352 > > > > TBR=thakis > > > > > > > > Change-Id: I82ee1bf94dab55798be727f0ae70a1fede6634ca > > > > Reviewed-on: https://chromium-review.googlesource.com/525534 > > > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > > > Reviewed-by: siddhartha sivakumar <ssid@chromium.org> > > > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > > > Reviewed-by: Hector Dearman <hjd@chromium.org> > > > > Commit-Queue: siddhartha sivakumar <ssid@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#477851} > > > > > > TBR=thakis@chromium.org,primiano@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > BUG=720352 > > > > > > Change-Id: I7088bd3549c3a8a733d4b87226593209bd40c42e > > > Reviewed-on: https://chromium-review.googlesource.com/528032 > > > Reviewed-by: Sam McNally <sammc@chromium.org> > > > Commit-Queue: Sam McNally <sammc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#477875} > > > > TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org > > > > Change-Id: Ic6439b97024d65d19012133171249dddd2de8b88 > > Reviewed-on: https://chromium-review.googlesource.com/528098 > > Commit-Queue: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#477988} > > TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > > Change-Id: I0e9f5a6f930e096406ac0d46ac310ef2fae99370 > Reviewed-on: https://chromium-review.googlesource.com/528513 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#478109} TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org,jbudorick@chromium.org Change-Id: I7493014373569281e84049cb6fdca987fc9ee83e Reviewed-on: https://chromium-review.googlesource.com/530311 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#478623}
-
Colin Blundell authored
This CL moves these auth-related files to the auth/ subdirectory. Change-Id: Ic7853e63449f2f418d3e9353eaab094011f69b98 Reviewed-on: https://chromium-review.googlesource.com/522066 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#478622}
-
Sylvain Defresne authored
As ARC uses -autorelease (or at least the method used has similar effect), the -dealloc method call may be delayed. This does not mix well with C++ memory management. Add -shutdown method to ensure that Objective-C objects that need to deterministically deregister themselves from C++ objects can do it. BUG=722879 Change-Id: Ifdbddd584790b0a4d73029d92c3ecd8df413827e Reviewed-on: https://chromium-review.googlesource.com/528134Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#478621}
-
agrieve authored
Print(symbol_group[2:4]) now works more nicely as well. BUG=681694 Review-Url: https://codereview.chromium.org/2924343004 Cr-Commit-Position: refs/heads/master@{#478620}
-
marq authored
BUG= Review-Url: https://codereview.chromium.org/2936603002 Cr-Commit-Position: refs/heads/master@{#478619}
-
jif authored
This CLs breaks retain cycles such as: InfoBarView -> LabelLinkController -> BeforeTranslateInfoBarController -> InfoBarView BUG=732384 Review-Url: https://codereview.chromium.org/2933833002 Cr-Commit-Position: refs/heads/master@{#478618}
-
Samuel Huang authored
This reverts commit 0a8c2fcd. Reason for revert: Prime suspect for Linux Test failure for {headless_browsertests, browser_side_navigation_headless_browsertests} in: SimpleEventJsBindingsTest.RunAsyncTest ExperimentalCommandJsBindingsTest.RunAsyncTest Original change's description: > Generate experimental domain commands, fix method case and stray whitespace. > > An experimental class is now generated as well as the regular one, and is linked within > the main class. Just like in the C++ bindings the experimental class contains everything. > The class methods generated now start with a lowercase letter (same as in the protocol). > Some stray white space has been removed from the template. > > Bug: > Change-Id: I4e0d8e0f04990e9f635cab71fea18c1f21111754 > Reviewed-on: https://chromium-review.googlesource.com/529070 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#478601} TBR=skyostil@chromium.org,alexclarke@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: Change-Id: I21a4e119fd4f0b568789c72608553f530a88adc5 Reviewed-on: https://chromium-review.googlesource.com/531304Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#478617}
-
Morten Stenshorne authored
This is about how we behave when NeedsPreferredWidthsRecalculation() is true. This is a rather rare situation, and also an unfortunate one, since min/max width calculation should be strictly bottom-up. If we mark min/max widths of an object as dirty, we need to guarantee that they're actually going to be recalculated. Otherwise, if the object is left around with dirty min/max widths, it will block subsequent min/max dirtying of any descendant. We also need to make sure that if we mark min/max widths as dirty due to NeedsPreferredWidthsRecalculation(), we also need to mark the min/max widths of every child with the same issue as dirty, recursively, since any layout change may have affected the min/max widths there too. Documented NeedsPreferredWidthsRecalculation(). Added one test that has been failing for ages, and one that started to fail because of the bug referenced. Both pass now. BUG=728548 Change-Id: I8b9325ba20a6da2329d28d21a6eca6bc1aa36c06 Reviewed-on: https://chromium-review.googlesource.com/527640Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#478616}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f449ded72acf..5143f2f3763b $ git log f449ded72..5143f2f37 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 robertphillips Init fDevKLMMatrix in GrGLCubicEffect (possible valgrind fix) 2017-06-08 recipe-roller Roll recipe dependencies (nontrivial). 2017-06-11 update-skps Update SKP version 2017-06-10 reed remove unneeded methods 2017-06-10 reed remove unneeded SK_API 2017-06-10 reed SkXfermode no longer needs to e a flattenable Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I419c3450ef55198a74d06488504fc707c969e44a Reviewed-on: https://chromium-review.googlesource.com/530964Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478615}
-
Hiroki Nakagawa authored
As a cleanup, this CL... - merges WebWorkerContentSettingsClient into WebContentSettingsClient, - renames WebWorkerContentSettingsClientProxy into WebWorkerContentSettingsClient, and - makes CreateWorkerContentSettingsClient() return std::unique_ptr instead of a rawptr w/ ownership. Bug: 729500 Change-Id: Icc7b9f26f52f3312c16c36b356d2cf9c34b5a99a Reviewed-on: https://chromium-review.googlesource.com/527763Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#478614}
-
fayang authored
Merge internal change: 158527266 BUG= Review-Url: https://codereview.chromium.org/2933613002 Cr-Commit-Position: refs/heads/master@{#478613}
-
hlundin authored
This change sets the new default value for "clipping level min" to 70, and dismantles the experiment. BUG=672476 Review-Url: https://codereview.chromium.org/2928133002 Cr-Commit-Position: refs/heads/master@{#478612}
-
Morten Stenshorne authored
Don't hardcode HR as establishing a new formatting context. Set overflow:hidden in the UA stylesheet instead. [1] Also specify unicode-bidi:isolate [2] Some heavy test expectation rebaselining is necessary, since making HR overflow:hidden entails that it will now establish a PaintLayer. [1] https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2 [2] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering BUG=728499 Change-Id: I1734242d240cb236269b218283bcb16b4ca7c0e4 Reviewed-on: https://chromium-review.googlesource.com/521044 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#478611}
-
yamaguchi authored
User can change expose new files to another member or remove files that was visible for other members in the Files app by these operations: - Move files from a Team Drive to My Drive - Move/Copy files from My Drive to a Team Drive - Move/Copy files from a Team Drive to another Team Drive - Move files from a Team Drive to Downloads - Move/Copy files from Downloads to a Team Drive We'll show a confirmation dialog box before executing such operation, so that user can either choose to continue or cancel the operation after knowing what will happen. BUG=722324 TEST=manually tested by moving/copying files between different Team Drive/My Drive/Downloads CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930443002 Cr-Commit-Position: refs/heads/master@{#478610}
-
Kouhei Ueno authored
This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure and #fetch-the-descendants-of-and-instantiate-a-module-script to match recent spec change: https://github.com/whatwg/html/pull/2595 . Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html Bug: 727299, 594639 Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48 Reviewed-on: https://chromium-review.googlesource.com/528724 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#478609}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3a15e30f..4a77d640 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2934803002 Cr-Commit-Position: refs/heads/master@{#478608}
-
Guido Urdaneta authored
This is intended to be used in getUserMedia to implement spec-compliant audio constraints processing. BUG=657733 Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd Reviewed-on: https://chromium-review.googlesource.com/517782 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#478607}
-
Colin Blundell authored
This CL adds an interface for obtaining access tokens to the Identity Service. The CL also partially ports the implementation of the chrome.identity.getAuthToken() extension function to use it as a initial client. TBR=thakis Go to chrome://extensions, enable developer mode, and inspect the background page of the above app. At the JS console that that brings up, execute: chrome.identity.getAuthToken((token) => {console.log(token);} ) Verify that a long alphanumeric string appears rather than an error being reported. Bug: 683124 Test: Install a Chrome extension with the identity permissions in its manifest. Change-Id: I902dde8ff6d817575f07b0e3f1df1e35ed398891 Reviewed-on: https://chromium-review.googlesource.com/514047 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#478606}
-
Anthony Berent authored
Add a @ScreenShooter.Directory annotation. This lets the user of ScreenShooter set the directory names for the screen shots. Change-Id: I64ef9183b0e46d5449bd90832e9bfba77c04abdf Reviewed-on: https://chromium-review.googlesource.com/527158Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Anthony Berent <aberent@chromium.org> Cr-Commit-Position: refs/heads/master@{#478605}
-
pkl authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2916253003 Cr-Commit-Position: refs/heads/master@{#478604}
-
gambard authored
When a new Earl Grey is launched in Showcase, the UI is reset with a new collection. The close helper tests that it is returned to the home screen. This allows the test to fail if it ends in a bad state (alert displayed...). Before, if the test ended in a bad state, it would succeeded and the following test would fail, making it hard to debug. BUG=none Change-Id: I4e65fb527fd25724c140f42193ab0ce53feeb1bd Reviewed-on: https://chromium-review.googlesource.com/529105 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#478603}
-
dullweber authored
Add metrics for the new Clear Browsing Data dialog on Android. A histogram and actions are used to record which tab was used for a deletion. Time period changes are recorded as actions. A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded twice because the new dialog creates two instances of ClearBrowsingDataPreferences. BUG=731120 Review-Url: https://codereview.chromium.org/2927063002 Cr-Commit-Position: refs/heads/master@{#478602}
-
Alex Clarke authored
An experimental class is now generated as well as the regular one, and is linked within the main class. Just like in the C++ bindings the experimental class contains everything. The class methods generated now start with a lowercase letter (same as in the protocol). Some stray white space has been removed from the template. Bug: Change-Id: I4e0d8e0f04990e9f635cab71fea18c1f21111754 Reviewed-on: https://chromium-review.googlesource.com/529070 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#478601}
-
mathp authored
BUG=729633 TEST=VoiceOver Review-Url: https://codereview.chromium.org/2931503002 Cr-Commit-Position: refs/heads/master@{#478600}
-
lod authored
BUG=622743 Review-Url: https://codereview.chromium.org/2924013005 Cr-Commit-Position: refs/heads/master@{#478599}
-
tnagel authored
BUG=722374 Review-Url: https://codereview.chromium.org/2891933002 Cr-Commit-Position: refs/heads/master@{#478598}
-
Eric Stevenson authored
Prior to this CL, removing an Android resource wouldn't actually remove it from the final APK. This CL adds each resource to depfile_deps so that building after removing an Android resource will work as expected (after a gn gen - which is required when adding a resource as well). Bug: 730099 Change-Id: I9429b61fa19c2c8e3d21df3e30119ba7c6bdec01 Reviewed-on: https://chromium-review.googlesource.com/527492Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#478597}
-
Boris Sazonov authored
This CL changes layouts of account rows to confrom to Material spec and bring consistensy to the account lists. Bug: 701221, 722910 Change-Id: Ie70304cb9c9254335bbe7aaa94ac5e7d9c2ff519 Reviewed-on: https://chromium-review.googlesource.com/527098Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#478596}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/113a309a..3a15e30f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2934753002 Cr-Commit-Position: refs/heads/master@{#478595}
-
mkwst authored
Revert of Align `clear-site-data` syntax with the spec. (patchset #2 id:20001 of https://codereview.chromium.org/2929593002/ ) Reason for revert: Despite passing all the bots, this apparently breaks `content_browsertests`: https://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=57936. So, let's go fix that. Original issue's description: > Align `clear-site-data` syntax with the spec. > > We've shifted from an explicit JSON dictionary to a list of quoted > strings (that can be parsed as JSON for forward-compatibility). That is, > rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`, > we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing. > > Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27. > > BUG=607897 > > Review-Url: https://codereview.chromium.org/2929593002 > Cr-Commit-Position: refs/heads/master@{#478585} > Committed: https://chromium.googlesource.com/chromium/src/+/085b57ffe70b6cb90cd77b61585babcf59df3a95 TBR=msramek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607897 Review-Url: https://codereview.chromium.org/2933083002 Cr-Commit-Position: refs/heads/master@{#478594}
-
nednguyen authored
Rationale: I am the TL of benchmarking-dev@ (part of chrome-speed-ops@), and my team currently takes ownership of running WebKit performance tests on the perf waterfall (including sheriffing their perf regressions & breakages). In term of code familiarity, I have made sizable feature changes to the test framework in this directory (crbug.com/701059) & authored documentation for writing blink perf tests (https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/PerformanceTests/README.md) To ensure that the perf tests in this directory have consistent quality, I would want to become the owner of the directory. In term of process, this means that I will be responsible for reviewing all the commits in this folder. In longer term, I plan to grow other member of speed benchmarking team to also become maintainers of this directory. Review-Url: https://codereview.chromium.org/2928083002 Cr-Commit-Position: refs/heads/master@{#478593}
-
hbos authored
Make the WebRtcMediaStreamAdapter, which represent local streams, use the WebRtcMediaStreamTrackMap and AdapterRef classes for the handling of initializing, getting and uninitializing local tracks. WebRtcMediaStreamTrackAdapter is updated to allow local tracks from non-local sources (removed DCHECKs) which happens when redirecting remote sources as local streams. This is one step closer to decoupling streams and tracks. The same thing will be done in a follow-up CL for the remote streams case, RemoteMediaStreamImpl. BUG=705901, 700916 Review-Url: https://codereview.chromium.org/2897603004 Cr-Commit-Position: refs/heads/master@{#478592}
-
Alex Clarke authored
It seems java isn't necesarially present on mac which is causing pain for those trying to build all. Bug: Change-Id: I9fb58ec63b3c0e06b4882473b1b116b947810a3e Reviewed-on: https://chromium-review.googlesource.com/530944Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#478591}
-
Mike West authored
Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wu_fMIYkyaQ/85j16Cg6BAAJ Bug: 731752, 680419 Change-Id: I250e03b2fb614a21a2b7eb1a27b7a11a746e6fc8 Reviewed-on: https://chromium-review.googlesource.com/529249 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#478590}
-
vabr authored
Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=729393 Review-Url: https://codereview.chromium.org/2927233003 Cr-Commit-Position: refs/heads/master@{#478589}
-