GitLab

https://codereview.chromium.org/337883003/ accidentally made this test flaky.
Fix this by calling finish from the event listener.

BUG=390445
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/398413002

git-svn-id: svn://svn.chromium.org/blink/trunk@178497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- less code
- able to use features of text-based-repaint.js

Review URL: https://codereview.chromium.org/403843002

git-svn-id: svn://svn.chromium.org/blink/trunk@178496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use pass by reference here for efficiency.

Review URL: https://codereview.chromium.org/397723007

git-svn-id: svn://svn.chromium.org/blink/trunk@178495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178446

BUG=266214
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/406693006

git-svn-id: svn://svn.chromium.org/blink/trunk@178494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes it significantly easier to extend the interface for the needs for the Blink scheduler, web animations engine and future similar changes. It also brings the concept in Blink closer to the values in Chrome.

BUG=346230

Review URL: https://codereview.chromium.org/321373003

git-svn-id: svn://svn.chromium.org/blink/trunk@178493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Modifications to layout test framework so that it can work with browser_tests. (https://codereview.chromium.org/378113003/)

Reason for revert:
Might have broken a number of LayoutTests.

Original issue's description:
> Modifications to layout test framework so that it can work with browsertests. This is for end to end testing for print preview.
> 
> BUG=388517
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178486

TBR=dpranke@chromium.org,thestig@chromium.org,ivandavid@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=388517

Review URL: https://codereview.chromium.org/398543005

git-svn-id: svn://svn.chromium.org/blink/trunk@178492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This way we can move forward with using sheriff-o-matic, but have
the fallback of garden-o-matic if we encounter any bugs along the
way.

Eventually, we need to:
-merge this server with auto-sheriff.appspot.com.
-vulcanize the polymer widgets

NOTRY=true

Review URL: https://codereview.chromium.org/398813004

git-svn-id: svn://svn.chromium.org/blink/trunk@178491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/401973003

git-svn-id: svn://svn.chromium.org/blink/trunk@178490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename WebCore namespace to blink in Core

TBR=eseidel@chromium.org

git-svn-id: svn://svn.chromium.org/blink/trunk@178489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change Elemenet::setScrollLeft and setScrollTop to use LayoutUnit::
fromFloatRound instead of lroundf. This ensures that no unnecessary type
conversion takers place and that the values are clamped properly.

R=leviw@chromium.org
BUG=393464
TEST=fast/scrolling/scroll-max-value.html

Review URL: https://codereview.chromium.org/400633005

git-svn-id: svn://svn.chromium.org/blink/trunk@178488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/398673003

git-svn-id: svn://svn.chromium.org/blink/trunk@178487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Modifications to layout test framework so that it can work with browsertests. This is for end to end testing for print preview.

BUG=388517

Review URL: https://codereview.chromium.org/378113003

git-svn-id: svn://svn.chromium.org/blink/trunk@178486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Expose deviceScaleFactor on GraphicsContext and use to selectively
enable subpixel text regardless of the system font hinting settings for
high-dpi systems.

BUG=373441
R=derat@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/407553002

git-svn-id: svn://svn.chromium.org/blink/trunk@178485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

main_unittest was relying on the original sys.argv and passing that
to the arg-parsing code. If somehow you had something in argv that
wasn't a valid argument to test-webkitpy (e.g., by testing w/
unittest directly), the test would fail and raise SystemExit.

This was an unnecessarily fragile design, so I fixed to preserve
the original sys.argv and replace it for the test w/ something predictable.

R=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397723004

git-svn-id: svn://svn.chromium.org/blink/trunk@178484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

test-webkitpy tests running the -c flag for coverage; this would cause
us to leave a .coverage file in Tools/Scripts. This patch cleans that up

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/399193006

git-svn-id: svn://svn.chromium.org/blink/trunk@178483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't run these by default, so they bitrotted at some point.

In particular, it looks like svn 1.7 changed behavior so that if
you call

svn add foo
svn add foo/bar

the second call errors out with bar already having been added;
in svn 1.6, this was just a warning.

This comes up in our code because when adding a file we recursively
add the parent directories to ensure the whole path is versioned; we
need to change this so that we do not implicitly recurse down when
adding a parent directory.

Less importantly, it looks like the semantics for git svn clone -T 
change in Git v2, so the branch names are slightly different and 
we need to account for the remote branch refs differently as a result.

R=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397383002

git-svn-id: svn://svn.chromium.org/blink/trunk@178482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a SmoothScrollInterruptionTest class and tests using
this class.

BUG=243871

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178387

Review URL: https://codereview.chromium.org/398043005

git-svn-id: svn://svn.chromium.org/blink/trunk@178481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/403013002

git-svn-id: svn://svn.chromium.org/blink/trunk@178480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On flex items, specifying a flex shorthand with a flex basis in the
middle of two flex factors, e.g. flex: 1 0% 1 is getting accepted in
blink.

According to http://www.w3.org/TR/css3-flexbox/#flex-property, the
grammar of the flex shorthand is as follows:

Value:	none | [ <‘flex-grow’> <‘flex-shrink’>? || <‘flex-basis’> ]

It means that flex-grow and flex-shrink must appear together. Therefore flex
basis in the middle of two flex factors is invalid.

Currently blink consider flex: 1 0% 1 as valid, mapping the values as
 <flex-grow> <flex-basis> <flex-shrink>, i.e. flex: 1 0% 1 is equivalent
to flex: 1 1 0%.

This patch fixes this bug by adding an additional condition checking
if flex-basis is in the middle or not in flex argument list
while setting values for flex basis.

BUG=380984

Review URL: https://codereview.chromium.org/396263003

git-svn-id: svn://svn.chromium.org/blink/trunk@178479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394669

Review URL: https://codereview.chromium.org/396213010

git-svn-id: svn://svn.chromium.org/blink/trunk@178478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/400543004

git-svn-id: svn://svn.chromium.org/blink/trunk@178475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the fast/text/decomposed-after-stacked-diacritics.html test to
support subpixel text.

BUG=378610
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/359463002

git-svn-id: svn://svn.chromium.org/blink/trunk@178474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/400143002

git-svn-id: svn://svn.chromium.org/blink/trunk@178473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL follows https://codereview.chromium.org/392783003 and
https://codereview.chromium.org/393653002.

BUG=350531

Review URL: https://codereview.chromium.org/396753002

git-svn-id: svn://svn.chromium.org/blink/trunk@178472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added error message with stack trace and exception details if exception happened when command in console evaluate.

Review URL: https://codereview.chromium.org/369333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename the linux specific FontPlatformData implementation file from
FontPlatformDataLinuxHarfBuzz.cpp to FontPlatformDataLinux.cpp as all
platforms use HarfBuzz now.

R=jbroman@chromium.org

Review URL: https://codereview.chromium.org/404653004

git-svn-id: svn://svn.chromium.org/blink/trunk@178469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=302024

Review URL: https://codereview.chromium.org/399423006

git-svn-id: svn://svn.chromium.org/blink/trunk@178468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It doesn't need anything particular to block flows, and is used by other
kinds of renderers.

Review URL: https://codereview.chromium.org/397723006

git-svn-id: svn://svn.chromium.org/blink/trunk@178467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop the aging yellow popover and match the tooltip style in Chrome.

TBR=sergeyv
BUG=181703

Review URL: https://codereview.chromium.org/401013002

git-svn-id: svn://svn.chromium.org/blink/trunk@178466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394359

Review URL: https://codereview.chromium.org/397073006

git-svn-id: svn://svn.chromium.org/blink/trunk@178464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=ericu@chromium.org

Review URL: https://codereview.chromium.org/403793002

git-svn-id: svn://svn.chromium.org/blink/trunk@178463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Earlier this method returns class name for errors objects, now it returns className + ':' + error.message.

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/401843002

git-svn-id: svn://svn.chromium.org/blink/trunk@178462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/397313003

git-svn-id: svn://svn.chromium.org/blink/trunk@178461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While rendering, scrollOffset was taken into account. This lead to wrong points for creation of the shape.

Patch proposes removing of scrollOffset to avoid the behavior.

BUG=392857
R=pfeldman
TEST=Circle should render similarly, inspite of a scroll.

Review URL: https://codereview.chromium.org/396803010

git-svn-id: svn://svn.chromium.org/blink/trunk@178460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having "config" reference "non_test_config" does nothing. I'm
fixing the warning that will flag this. I checked and a bunch of
targets already add non_test_config, so it isn't obviously
broken otherwise.

TBR=eseidel

Review URL: https://codereview.chromium.org/403653002

git-svn-id: svn://svn.chromium.org/blink/trunk@178459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, it was the clients' responsibility to build raw locations
based on DebuggerAgent.Location.

R=vsevik

Review URL: https://codereview.chromium.org/402873002

git-svn-id: svn://svn.chromium.org/blink/trunk@178457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are two renderers in html/shadow/
RenderSliderContainer and RenderSliderThumb.
They moved into rendering/ so that they are tracked like any other
renderers.

BUG=346445

Review URL: https://codereview.chromium.org/403523003

git-svn-id: svn://svn.chromium.org/blink/trunk@178456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395137
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/397243005

git-svn-id: svn://svn.chromium.org/blink/trunk@178453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes incorrect marking as flaky in
https://codereview.chromium.org/398423005, which forgot that the
FlakyTests file is auto-generated.

BUG=395127
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/400223003

git-svn-id: svn://svn.chromium.org/blink/trunk@178452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/407493005

git-svn-id: svn://svn.chromium.org/blink/trunk@178450 bbb929c8-8fbe-4397-9dbb-9b2b20218538