- 31 Mar, 2020 40 commits
-
-
danakj authored
content/shell/renderer/ can see test_runner::WebTestInterfaces, so it can also see test_runner::TestInterfaces. The former is just a shallow wrapper around the latter, so it is not needed at all. R=avi@chromium.org Bug: 866140 Change-Id: Ic9ad15d27aae6d0293e23cdfb007e9511ff296d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128450Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754918}
-
Bo Liu authored
Read system setting on Android. Set to false on other platforms. Then check this state when the in fragment.onStart and send updates if there are changes. This matches chrome behavior. Bug: 1052496 Change-Id: Ib0d42949c0d6b8f57cd10f4781f0908ca3b34ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127896Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754917}
-
Dominique Fauteux-Chapleau authored
TBR=ellyjones@chromium.org Bug: 1066456 Change-Id: I362ca1266a31e57122402bd4d620db49a60c8e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128975Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754916}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a65fa055496b..bc44331c334d git log a65fa055496b..bc44331c334d --date=short --first-parent --format='%ad %ae %s' 2020-03-31 rsavitski@google.com Merge "Ban PERFETTO_EINTR(close(...)), which is actively incorrect" Created with: gclient setdep -r src/third_party/perfetto@bc44331c334d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I921e38a720231f8bafc7fac44c6fb6447621cbeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754915}
-
Maksim Sisov authored
This CL enables more tests as was discussed with rjkroege@. Bug: 1029240 Change-Id: I96afe797dcf841e0012bd07485c13e62e642303d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127027 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754914}
-
Hongchan Choi authored
This CL adds trace event in the following AudioNodes based on the popularity: - GaindNode - AudioBufferSourceNode - PannerNode - BiquadFilterNode It also adds trace event below to get the detailed tracing data from some problem areas. - AudioWorkletNode - MediaStreamAudioSourceNode - MediaStreamAudioDestinationNode Bug: 1065982 Change-Id: I0758786aa418ec3dc992333012f0da0f8867f636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127731Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754913}
-
Jeremie Boulic authored
A user in guest mode only has access to temporary storage, the downloaded files and other data coming from a guest user are stored in virtual memory. This is inconsistent with the way the "System" row is calculated, which takes into account data stored in a persistent storage space. We therefore hide the system row when the user is in guest mode. browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Test: Bug: 1061401 Change-Id: I5b7caafc9698f2853aacae3b043ea7ca6294387e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124276Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#754912}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7f02588fc51..2dbeb5da18b1 git log d7f02588fc51..2dbeb5da18b1 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 kimanh@chromium.org Update CDP and add string to reflect stack scope in scope view Created with: gclient setdep -r src/third_party/devtools-frontend/src@2dbeb5da18b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043034 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb01d274453f09c79f878f360559ab7129005ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754911}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/46de36f99362..65d3ad953957 git log 46de36f99362..65d3ad953957 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 reed@google.com remove unused bitmap method 2020-03-31 fmalita@chromium.org [skottie] Use a documenting alias for Animator::seek() return type 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1b2dd6f92a6b..05fa1a99914a (10 commits) 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1c29477aa06e..5cf1e9a31c90 (6 commits) 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src af1924a6..f43e7c4d (411 commits) 2020-03-30 bungeman@google.com Add GrTAllocator::push_back(T&&) 2020-03-30 michaelludwig@google.com Declare SkString in GrContext 2020-03-30 reed@google.com remove unused SkLightingShader 2020-03-30 brianosman@google.com Stop including SkCanvas.h from GrTypesPriv.h 2020-03-30 jvanverth@google.com Fix d3d debug clang build 2020-03-30 egdaniel@google.com Remove alpha versions of constant blend coeffs. 2020-03-30 bsalomon@google.com Revert "Assert that all GrCaps colortype/format -> swizzle queries are legal." 2020-03-30 jvanverth@google.com Fill in some D3D texture creation routines. 2020-03-30 bsalomon@google.com Assert that all GrCaps colortype/format -> swizzle queries are legal. 2020-03-30 sgilhuly@chromium.org Roll Dawn and add dependencies 2020-03-30 bsalomon@google.com Revert "Remove GrCaps::isFormatTexturableAndUploadable" 2020-03-30 csmartdalton@google.com Use GL_ANGLE_base_vertex_base_instance 2020-03-30 mtklein@google.com remove Builder inheritance 2020-03-30 mtklein@google.com fix unpremul() 2020-03-30 fmalita@chromium.org [skottie] Lazy adapter sync 2020-03-30 bsalomon@google.com Make memcmps in GrResourceKey::op== safe. 2020-03-30 brianosman@google.com Remove some legacy GN defines for Flutter 2020-03-30 mtklein@google.com don't run clang-tidy on third_party 2020-03-30 mtklein@google.com way more p-> inference 2020-03-30 bsalomon@google.com Remove GrCaps::isFormatTexturableAndUploadable 2020-03-30 mtklein@google.com remove negate() 2020-03-30 mtklein@google.com remove inv() Created with: gclient setdep -r src/third_party/skia@65d3ad953957 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064563 Tbr: michaelludwig@google.com Change-Id: If8f9c81789746a7a506ad2d7cdfcbc0f4ab536a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754910}
-
Josh Karlin authored
This reverts commit bda6c898. Reason for revert: GetExecutionContext() isn't as slow as I initially though. Reverting due to added complexity this change added for marginal performance win. Original change's description: > Speed up IsAdScriptInStack by passing ExecutionContext when known > > What: Some callers to IsAdScriptInStack know the ExecutionContext that > triggered the event. Those callers should pass the context in to > IsAdScriptInStack as there is a small cost to looking it up. > > Why: Some callers (such as core_probes) call frequently and looking up > the ExecutionContext when it's already known only slows things down. > > Bug: 851531 > Change-Id: Id8eadfc9855cdda0d18df34a4829dd47e31ac64f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090232 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747899} TBR=dcheng@chromium.org,jkarlin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851531 Change-Id: Idc280fb6acaf90a948a6363a8c7b3c23aad12834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127902Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754909}
-
Ilya Nikolaevskiy authored
Bug: webrtc:11461 Change-Id: Ia3eb4e99b70d3acdd4c0109f825cf6de45e7f0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119521Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#754908}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fa068336f9e0..d2aa8f97f109 git log fa068336f9e0..d2aa8f97f109 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 marinaciocea@webrtc.org Insert audio frame transformer between encoder and packetizer. 2020-03-31 tommi@webrtc.org Reducing calls to clock_->TimeInXyz in RTCPReceiver. Created with: gclient setdep -r src/third_party/webrtc@d2aa8f97f109 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4072dadf65b830cc8800268a5c1b9b1a7fe076ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754907}
-
Mikhail Khokhlov authored
We have collected enough data to choose the most relevant metric. All other jank metrics can be removed. Bug: b/151081375 Change-Id: I5e331294297de1fb69e4862ac088842368b4d717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128488Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#754906}
-
Mikhail Khokhlov authored
Adding categories that will help us investigate jank sources. Bug: b/151081375 Change-Id: I795a4850708c12d34539811e9a99c88d4a8c496a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128109Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#754905}
-
Nazerke authored
Removing the left |self.browserState| from the starting function in this coordinator. Change-Id: I02eaaed2d63a0fcaa2089786a6ff220fc1aa4c29 Bug: 1047881, 1029346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128072 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#754904}
-
Owen Min authored
Only 1000 requests are allowed which should be enough. For now, there won't be any user warning if that happen. Once the limitation is exceeded, some requests will be filter out. The filter is stable. One request contains a 32 characters extension id and int64 timestamp. 1000 requests should take less than 50kb per Profile. The report size limitation os 5mb. Bug: 1065458 Change-Id: Id9e654dfd43783d22f0535ba5f27679e744f4ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124908 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754903}
-
Tanmoy Mollik authored
This method is only used for testing code and introduces a redundant way of seeding accounts. AccountTrackerService.checkAndSeedSystemAccounts should be the only method used for seeding accounts. This cl creates a helper method in SigninTestUtil that polls for seeding complete in AccountTrackerService. Bug: 1054838 Change-Id: I2e5254d03b30e21aa931e8e9c181da6af53a6dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094309 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754902}
-
Mugdha Lakhani authored
Bug: 1025607 Change-Id: Id6dd0996394e3d2701bdcb5f6937f699395d1dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126926 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#754901}
-
Rouslan Solomakhin authored
Before this patch, the "default_applications" field in the payment method manifest had to contain only absolute URLs, which made testing Chrome and writing payment apps harder. This patch passes the URL of the downloaded payment method manifest to the parser, which uses it to resolve the relative URLs in "default_applications". After this patch, the "default_applications" field may contain either absolute or relative URLs to the web app manifest. Bug: 1064544 Change-Id: Ie1f9252294887569b0e44163aa720214399431ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120452Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754900}
-
Mark Cogan authored
This is a speculative bug fix; I wasn't able to repro the issue on trunk. It's a shutdown crash where the SceneController web state list observer method is triggered by TabModel closing all open tabs, while the interface provider isn't in a consistent state. In general, having BrowserViewWrangler be responsible for setting an observer on the web state lists in the browsers it creates seems problematic, since it doesn't know the purpose of the observation being set. Since SceneController is the one who cares about this observation, it (with this CL) becomes responsible for adding/removing itself as an observer. The specific fix for this bug is for SceneController (which observes the web state list so it can handle the last tab closing) to stop observing before shutting down BrowserViewWrangler. I wasn't able to repro the crash, so I couldn't verify the fix, but I could verify that with this fix in place, a force-quit in the simulator didn't cause any crashes. I also updated the comments for BrowserInterfaceProvider to not say some things that aren't true anymore. Bug: 1062241 Change-Id: I0d4b69f5889e141a243754c61450f77ea39ac523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128068Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#754899}
-
Michael Ludwig authored
Bug: 1066392 Change-Id: I9df2565785902de0940a63fc0a8b7589b88c60e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128711 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#754898}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ie9185e9977a99906f8d4961e58d9dc58ec4bb269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128710Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754897}
-
Gayane Petrosyan authored
screenshots: https://screenshot.googleplex.com/sTQU0sY0yEL.png https://screenshot.googleplex.com/e30urO57vCZ.png Bug: 993920 Change-Id: I9210c56ceb0ce7f59913bcbfa448bc5fb0c036ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125448Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#754896}
-
Gabriel Charette authored
[ThreadPool] Tighten evaluated TimeDelta of PooledSingleThreadTaskRunnerManagerCommonTest.PostDelayedTask and be more flexible with the result. Bringing it inline with ThreadGroupTestAllExecutionModes.PostDelayedTask R=etiennep@chromium.org Bug: 1062845 Change-Id: Icb41d86f1a8185f4cc49bf303842dc5ae6e7a81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128455 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#754895}
-
Michael Ershov authored
This reverts commit 2412286a. Reason for revert: Soon after this CL PageLoadMetricsBrowserTest.UseCounterFeaturesInNonSecureMainFrame and some other PageLoadMetricsBrowserTest* tests became flaky. Original change's description: > Propagate main frame document dimensions through frame intersections. > > This change calls OnMainFrameDocumentIntersectionChanged for the main > frame. The RenderFrame resets the main frame's intersection when the > frame commits a navigation to ensure we propagate a new intersection > for each committed navigation (otherwise we may lose updates when the > render frame observer propagates values for uncommitted loads to > page load metrics). > > This allows consumers to compare frame intersections with the main > frame's rect. This is a precursor to measuring page ad density. > > BUG=993453 > > Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622 > Commit-Queue: Justin Miron <justinmiron@google.com> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754626} TBR=szager@chromium.org,rsesek@chromium.org,johnidel@chromium.org,justinmiron@google.com Change-Id: I560698131b66fc9cb2b6a33737ffde2016cd5636 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993453, 1066455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129533Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#754894}
-
Robbie Gibson authored
Bug: 1048193 Change-Id: I111ceead01455b046f98c6da557aa1430679d0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124651Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#754893}
-
Anthony Vallee-Dubois authored
Following up on https://chromium-review.googlesource.com/c/chromium/src/+/2067624, this CL is one step to allow managed browsers on linux/windows/macos to obtain a device-level service account to be used to register for policy invalidations over FCM. DeviceAccountIntializer was mostly platform-agnostic already, so this only moves it to c/b/policy and removes a bunch of now unused includes (I imagine it was refactored some time ago). Bug: 1026261 Change-Id: I97ca06772e836fe10a115f7071b1c697a8a5071e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122391Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#754892}
-
Aaron Leventhal authored
Also, add comment explaining decision to avoid all AXLayoutObjects in locked subtree. Bug: None Change-Id: Iebad5db811dd3f0b6d046f98e1caab3f6b8c294a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127248Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#754891}
-
Gabriel Charette authored
Missed in https://chromium-review.googlesource.com/c/chromium/src/+/2063021 R=altimin@chromium.org Change-Id: I467b508eaa0005210c8c8259180ae9092c2013b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128458 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754890}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf4a734c7e6c..9120bcae6c53 git log bf4a734c7e6c..9120bcae6c53 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 344bd0889ac9..e157435c1e77 (3 commits) 2020-03-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src bec7b6e29260..d712a6b03b9e (4 commits) 2020-03-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 1c29477aa06e..5cf1e9a31c90 (6 commits) Created with: gclient setdep -r src/third_party/angle@9120bcae6c53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Id7e870dcbd2288621fae1c6066c1b254ee2246a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de6d9fd4428c..a65fa055496b git log de6d9fd4428c..a65fa055496b --date=short --first-parent --format='%ad %ae %s' 2020-03-31 lalitm@google.com perfetto: update trace processor and traceconv shas Created with: gclient setdep -r src/third_party/perfetto@a65fa055496b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I19298fa7c5793474811ef0e83d24c21650a51c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754888}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia7f3a8c34723bda5610f72e80151e0ce4a2a96dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fddb4d33089e..bb0867806ceb Created with: gclient setdep -r src-internal@bb0867806ceb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I61ac10cee242810637955cdbc834387ba5cd6ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129573Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754886}
-
Nohemi Fernandez authored
Because first run does not have access to experimental flags on startup this flag will not be used as a part of the migration experiment. It is simply an additional tool to more easily test that first run is working as we expect before migrating the code. Refactors user sign-in constants into a global sign-in constants class in order to hide the sign-in implementation details from outside clients (e.g. WelcomeToChromeViewController). Bug: 971989 Change-Id: I97316c952f4b215c33e62547112dde9f0d60efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121261Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#754885}
-
Ewann authored
This CL refactor the privacy table view controller. Bug: 1064961 Change-Id: I2ae5c23305c3d26cd61388b0a3ef925ad146f004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126233Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#754884}
-
Rune Lillesveen authored
Makes wpt tests for css-backgrounds pass. Bug: 959763 Change-Id: I7baefb3697bdb66ab55baf181abd630b621fc350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906406 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#754883}
-
Mike West authored
The existing //cookie/domain WPTs all use `a` as their cookie name, which means that they stomp on each other depending on how they're run. This patch alters the names to distinguish between tests, which should be more stable. Change-Id: I2359865246a717cf274be1ab66629b08509498eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127089Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#754882}
-
Jan Wilken Dörrie authored
Following r753559 this change applies the PassedToMoveRewriter on Android, CrOS and Windows. Furthermore, it adds includes for the <utility> header in files where it was missing. TBR=dcheng Bug: 714018 Change-Id: Ia49cdaa30cfebe14f75081e2c935a6242510700f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124385 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754881}
-
Robert Ogden authored
This struct keeps all the metrics about prefetching actions. This CL is in preparation for recording these metrics in UKM by plumbing them out of the TabHelper. Two small behavioral changes: * all predicted URLs will now be checked for eligibility, even if the max prefetching limit has already been reached. In reality, this would probably never happen anyways but it came up in testing. * Redirects count against attempts. This way, eligible and attempt #s always line up with respect to the maximum number of prefetches Bug: 1064726 Change-Id: I5d0f0b9706c12952f65335e67915b04eea60ed7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125615 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#754880}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, rename its filename to something more descriptive and less Chromium-specific (it currently references crbug.com/633212). Bug: 1063749 Change-Id: I5c733fc995a0323a32ffd824e0713a6f251f7a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126927 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754879}
-