- 28 Jan, 2016 40 commits
-
-
sky authored
https://codereview.chromium.org/1639223003/ makes it so clients can use whatever ids they want for windows. This means when surfaces resolve ids they need to resolve the id against the client that submitted the frame. This patch does that. BUG=566155 TEST=covered by tests R=fsamuel@chromium.org Review URL: https://codereview.chromium.org/1640253003 Cr-Commit-Position: refs/heads/master@{#371956}
-
reillyg authored
net::IOBuffer should be forward declared. This requires a number of source files to add their own includes where they use net::IOBuffer. BUG=None Review URL: https://codereview.chromium.org/1642493005 Cr-Commit-Position: refs/heads/master@{#371955}
-
yzshen authored
By default, enums are not extensible, which means any unknown value will fail validation. If an enum may grow in the future, it needs to have [Extensible=True] attribute specified. In that case, the user code is responsible for handling unknown values properly. This CL doesn't add corresponding validation for JS or Java. BUG=404186 Review URL: https://codereview.chromium.org/1618963006 Cr-Commit-Position: refs/heads/master@{#371954}
-
erg authored
[This is the same patch as before, but this fixes the win x64 gn bot which is a main waterfall tree closer, but doesn't have a default trybot run.] One common pattern that's coming up multiple times is that we want to read or write the full contents of a file. The first attempt at an interface to that had was put on the File object. However, file seeking behaviour differs between platforms. Performing a seek on an empty file is safe on posix and errors on Windows. And when dealing with arbitrary File objects, we want to seek to the beginning just in case there was any previous usage on the File object. It was also cumbersome. The user was still responsible for opening the file and closing it once they were done with it. Putting these operations on Directory not only removes a bug, but also simplifies the interface. BUG=557405 First Review URL: https://codereview.chromium.org/1634293002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1646673002 Cr-Commit-Position: refs/heads/master@{#371953}
-
pfeldman authored
BUG=580337 Review URL: https://codereview.chromium.org/1648463002 Cr-Commit-Position: refs/heads/master@{#371952}
-
danakj authored
These are named in kFooBar style, which doesn't need an underscore. The name should not change if we moved it to an enum, and this is the overwhelming (always used) style for nested constants in chromium. R=dcheng BUG=580746 Review URL: https://codereview.chromium.org/1644803002 Cr-Commit-Position: refs/heads/master@{#371951}
-
oshima authored
* Scale drag/drop events to Viewport in RenderViewHostImpl. * Scale the drag offset to Window/DIP in RenderViewImpl. * Use the screen info's scale factor to tag the drag image. * Make sure that the target image size passed to clampedImageScale is in DIP. BUG=485650 TEST=manual. I'll add a unit test after https://codereview.chromium.org/1586923002/ is landed. Review URL: https://codereview.chromium.org/1605143003 Cr-Commit-Position: refs/heads/master@{#371950}
-
thakis authored
Seems cleaner. libc++ recently added a few headers that shadow C headers, and shouldn't pick those up when building C files. No intended behavior change. BUG=none Review URL: https://codereview.chromium.org/1647493002 Cr-Commit-Position: refs/heads/master@{#371949}
-
estade authored
BUG=561133 TEST=on cros, right click on shelf > shelf position Review URL: https://codereview.chromium.org/1637973002 Cr-Commit-Position: refs/heads/master@{#371948}
-
scheib authored
Initial high level documentation for device/bluetooth. Review URL: https://codereview.chromium.org/1619173002 Cr-Commit-Position: refs/heads/master@{#371947}
-
sebsg authored
For phone fields that have a maxLength attribute of 10 (city code + phone number), if the value of the phone number is larger, fill the field with the last 10 digits. BUG=579674 TEST=AutofillFieldTest Review URL: https://codereview.chromium.org/1639563002 Cr-Commit-Position: refs/heads/master@{#371946}
-
dgrogan authored
Classes inside core/layout/ that need a reference to an InlineBox's layoutObject are being converted to use lineLayoutItem() so that we can rationalize access to the Layout tree. There are no functional changes. BUG=499321 Review URL: https://codereview.chromium.org/1640173005 Cr-Commit-Position: refs/heads/master@{#371945}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/c0307e6cea0f..d6996849f0c6 $ git log c0307e6ce..d6996849f --date=short --no-merges --format='%ad %ae %s' 2016-01-26 yunqingwang Fix a clang/win build error 2016-01-25 aconverse vp9: Be more responsive to massive overshoot. 2016-01-22 zoeliu Cleaned a code in define_gf_group() for firstpass 2016-01-20 aconverse Short circuit flat blocks when coding screen content at realtime speed. 2016-01-22 slavarnway VP9: Do not set up/left available in vp9_first_pass() 2016-01-22 yaowu Fix a minor typo 2016-01-21 marpan vp9 pickmode: Fix the shift on negative value. 2016-01-21 jzern vp9_aq_cyclicrefresh: fix double->float warning 2016-01-21 yaowu Fix a typo in ctrl_set_render_size() 2016-01-20 marpan vp9-aqmode=3: Reduce condition below which we turn off delta-qp. 2016-01-20 huisu Fix build with --enable-internal-stats 2016-01-20 aconverse Remove the vestigal skip_eob feature from tokenization. 2016-01-20 marpan vp9-svc: Allow frame-dropping in svc datarate control tests. 2016-01-20 marpan vp8-denoiser: Fix threshold for skin map. 2016-01-20 yaowu Remove duplicate definitions 2016-01-15 marpan Vidyo patch: Changes to the scalability code. 2016-01-19 slavarnway VP9: Eliminate MB_MODE_INFO 2016-01-18 rsbultje Use input framerate as timebase if none was explicitly specified. 2016-01-15 aconverse Tie the bit cost scale to a define. 2016-01-15 aconverse Deduplicate sign cost for ONE/TWO/THREE/FOUR tokens (...) R=johannkoenig@google.com Review URL: https://codereview.chromium.org/1641773002 Cr-Commit-Position: refs/heads/master@{#371944}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8283c4a90352..e8c9e565cd60 $ git log 8283c4a90..e8c9e565c --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1644683003 Cr-Commit-Position: refs/heads/master@{#371943}
-
lgarron authored
- ecobee.com: "I just noticed that this is actually a problem for us as we have some external sub-domains that are unable to support HTTPS at this time." - emilstahl.dk: Has only been on the list one week; asked to be removed. - liftcannabis.ca: "Unfortunately we found a few edge cases where HSTS is causing problems." - mbdb.jp: https://crbug.com/580764 BUG=527947, 580764 TBR=agl@chromium.org Review URL: https://codereview.chromium.org/1640963002 Cr-Commit-Position: refs/heads/master@{#371942}
-
pdr authored
Performance requires that some opaque chunks (such as the background) are drawn using a layer set to be opaque. This patch implements this idea by adding a bit to DrawingDisplayItem for whether the item is known to be opaque. The "knownToBeOpaque" bit is used to mark layers as explicitly opaque which lets us pass 2x more tests. BUG=580355 Review URL: https://codereview.chromium.org/1632263002 Cr-Commit-Position: refs/heads/master@{#371941}
-
fs authored
This implements the parsing algorithm for "list of floating point numbers" and uses it to parse the 'coords' attribute on <area>. The fractional part of numbers are no longer discarded. The old parsing code in platform/Length.cpp is no longer used and is removed. BUG=578114 Review URL: https://codereview.chromium.org/1636333003 Cr-Commit-Position: refs/heads/master@{#371940}
-
dyen authored
This reverts commit be50aafa. Previously our crash symbol parsing was not taking into account other files that are also loaded in (especially in debug builds). R=nednguyen@google.com BUG=563716 Review URL: https://codereview.chromium.org/1615173003 Cr-Commit-Position: refs/heads/master@{#371939}
-
scottmg authored
And make GetHostDesktopTypeForNativeView/Window and GetActiveDesktop() no-ops. R=sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1637943003 Cr-Commit-Position: refs/heads/master@{#371938}
-
davidben authored
This removes all uses of base::hash_*, BASE_HASH_NAMESPACE, and base::ScopedPtrHashMap in favor of the C++11 versions. BUG=576864, 579229 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1587283002 Cr-Commit-Position: refs/heads/master@{#371937}
-
hans authored
This build includes changes from https://codereview.chromium.org/1640873003/. The only difference between the new and the old archives is the addition of an empty file (the stub for the new library). Existing libraries were not rebuilt. BUG=520257 Review URL: https://codereview.chromium.org/1640983002 Cr-Commit-Position: refs/heads/master@{#371936}
-
dgrogan authored
Classes inside core/layout/ that need a reference to an InlineBox's layoutObject are being converted to use lineLayoutItem() so that we can rationalize access to the Layout tree. There are no functional changes. BUG=499321 Review URL: https://codereview.chromium.org/1645753002 Cr-Commit-Position: refs/heads/master@{#371935}
-
gcasto authored
Revert of Fix flaky remoting webapp javascript unittest. (patchset #1 id:1 of https://codereview.chromium.org/1633273002/ ) Reason for revert: This is still quite flaky on Linux. It has failed the 3 times in a row now. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Original issue's description: > Fix flaky remoting webapp javascript unittest. > > After forcing tests to fail after a 10 seconds timeout, turns out the > spy promise tests are the culprit. > I have removed them from our tests as they are originally intended to > test XHR's and we now have a better API for that. > > BUG=504204 > > Committed: https://crrev.com/aeb109ffd9b79927edb6a75f8cef7e72792fb356 > Cr-Commit-Position: refs/heads/master@{#371658} TBR=jamiewalch@chromium.org,kelvinp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504204 Review URL: https://codereview.chromium.org/1643823002 Cr-Commit-Position: refs/heads/master@{#371934}
-
danakj authored
This lets us build the clang tools with clang not gcc, which appears to have bugs! Also work around the gcc bug in one place we know it happens anyways, just because. R=dcheng BUG=580745 Review URL: https://codereview.chromium.org/1647733002 Cr-Commit-Position: refs/heads/master@{#371933}
-
pilgrim authored
This addition to the line layout API has cascading effects (all good): 1. Allows us to convert several methods in TextPainter to take a LineLayoutItem instead of LayoutText 2. Removes several instances of using the LineLayoutAPIShim just to call the resolveColor method 3. Converts a (required) reference of InlineBox::layoutObject() to lineLayoutItem() 4. Lets us convert TextPainterTest entirely to the line layout API There are no functional changes. BUG=499321 Review URL: https://codereview.chromium.org/1647473002 Cr-Commit-Position: refs/heads/master@{#371932}
-
eugenis authored
Add an empty file with the right name under instrumented_libraries to convince NSS not to load the system-wide uninstrumented library with the same name. We can not build this library from source. BUG=520257 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/1640873003 Cr-Commit-Position: refs/heads/master@{#371931}
-
senorblanco authored
In Skia, partially-resident textures of "flipped" textures occupy texcoords 1 to 1 - h (in Y). In cc, they occupy h to 0. In order to ease interop, we should pick a convention and unify. I chose the Skia model, since coords can flipped with a simple 1 - y, which doesn't require knowing the height of the active region. I also added a new test case for masks, since the math is a little hinky. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1643653002 Cr-Commit-Position: refs/heads/master@{#371930}
-
qyearsley authored
Revert of Disable storage.indexeddb_endure_tracing.reference perf test (patchset #1 id:1 of https://codereview.chromium.org/1355143002/ ) Reason for revert: Ref build rolled in December (https://code.google.com/p/chromium/issues/detail?id=458538), trying to re-enable. Original issue's description: > Disable storage.indexeddb_endure_tracing.reference perf test > > The perf test is failing on the reference build turning the waterfall > red. > > BUG=534409 > > Committed: https://crrev.com/0a30f13172c1f8be4f0f6e462419c9287de733ab > Cr-Commit-Position: refs/heads/master@{#349986} TBR=sullivan@chromium.org,pmeenan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=534409 Review URL: https://codereview.chromium.org/1640803004 Cr-Commit-Position: refs/heads/master@{#371929}
-
mfomitchev authored
Revert of Aura on Android: Remove unnecessary dependencies on ui/android. (patchset #6 id:100001 of https://codereview.chromium.org/1460633005/ ) Reason for revert: Reverting, since Android Aura has been cancelled. Original issue's description: > Aura on Android:Remove unnecessary dependencies on ui/android. > > BUG=NONE > > Committed: https://crrev.com/d2ff47131f1a53a712adf860275a2f7320d9da9f > Cr-Commit-Position: refs/heads/master@{#360835} TBR=sievers@chromium.org,moshayedi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=NONE Review URL: https://codereview.chromium.org/1646693002 Cr-Commit-Position: refs/heads/master@{#371928}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/9ce4110a29b0..bbb6dc80fdfe $ git log 9ce4110a2..bbb6dc80f --date=short --no-merges --format='%ad %ae %s' 2016-01-27 mtklein kill SkValue 2016-01-27 mtklein sketch hooking into PNG_FILTER_OPTIMIZATIONS CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1646713002 Cr-Commit-Position: refs/heads/master@{#371927}
-
rdevlin.cronin authored
Too many per-file rules with the addition of files like icon_with_badge_image_source.*. Substitute them for a comment in the file. BUG=None Review URL: https://codereview.chromium.org/1645683002 Cr-Commit-Position: refs/heads/master@{#371926}
-
dcastagna authored
This CL adds a flag in GPU capabilities that represents if the extension CHROMIUM_ycbcr_420v_image is available. BUG=524582 Review URL: https://codereview.chromium.org/1636123002 Cr-Commit-Position: refs/heads/master@{#371925}
-
kenrb authored
This is a speculative fix for crashes observed under the --isolate-extensions trial. A RenderWidgetHostViewGuest currently only clears its RenderWidgetHostInputEventRouter entry when the BrowserPlugin is detached. However, there are other paths for destruction that cause detachment, which might enable it to receive input events after DestroyGuestView() has been called, potentially leading to the observed null pointer crashes. This should be avoided by calling UnregisterSurfaceNamespaceId() before clearing the host_ pointer. BUG=571092 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1642743002 Cr-Commit-Position: refs/heads/master@{#371924}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/778c5a60..497b8970 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1647673002 Cr-Commit-Position: refs/heads/master@{#371923}
-
kimwjdalsl authored
Requests are not sorted by Method in network panel of DevTools. BUG=581313 Review URL: https://codereview.chromium.org/1641633002 Cr-Commit-Position: refs/heads/master@{#371922}
-
chrome://device-log/beaufort.francois authored
BUG=516825 Review URL: https://codereview.chromium.org/1587723007 Cr-Commit-Position: refs/heads/master@{#371921}
-
rjkroege authored
In the ozone drm platform, the ChannelObserver watches for changes on the IPC channel. However, ozone/drm will soon support execute in an in-process mode for MUS and the existing multi-process mode. Rename the class to reflect this. BUG=558602 Review URL: https://codereview.chromium.org/1603213002 Cr-Commit-Position: refs/heads/master@{#371920}
-
kozyatinskiy authored
Without this flag InspectorFrontendHost can call callbacks while devtools on pause. It makes debugging of layout tests useless. R=dgozman@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/1639973003 Cr-Commit-Position: refs/heads/master@{#371919}
-
mfomitchev authored
Revert of Introduce AndroidFocusRules and NativeWidgetAndroid (patchset #13 id:560001 of https://codereview.chromium.org/1403293003/ ) Reason for revert: Reverting the CL as the Android Aura project has been cancelled. Also removing menu_config_android.cc which was added in https://codereview.chromium.org/1477253002. Original issue's description: > Introduce AndroidFocusRules and NativeWidgetAndroid > > NativeWidgetAndroidis very similar to NativeWidgetAura. It > owns a WindowTreeHost and FocusController which initialized > from AndroidFocusRules. Aura on Android should use this > native widget for top level windows. It should create and host > the Widget in a native Android window. > > BUG=507792 > > Committed: https://crrev.com/31db6ee3532c748f40d2ae00514b5d91031d78e7 > Cr-Commit-Position: refs/heads/master@{#360645} TBR=sadrul@chromium.org,sky@chromium.org,bshe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=507792 Review URL: https://codereview.chromium.org/1639003002 Cr-Commit-Position: refs/heads/master@{#371918}
-
kojii authored
This patch is another effort to make Character::isCJKIdeographOrSymbol faster. The previous CL[1] made it faster by ~90% for codepoints below U+2020, but codepoints abvoe U+2020 were not as fast. This CL makes all codepoints faster, as fast as ICU functions. Before After Improve ICU All 2569 => 292 88% 298 ASCII 68 => 68 0% 160 Han 2958 => 263 91% 344 Hira 258 => 11 95% 14 Arabic 37 => 32 13% 44 * # of code points and iterations vary by rows. The previous CL[1] clarified that binary search is not as fast as ICU functions such as uscript_getScript(). This patch changes to use UTrie2, which is the data structure ICU property functions use. In addition in this patch: * U+2763 and U+2764 are added as requested by drott@. * Character::isUprightInMixedVertical() was switched to UTrie2 too. * Character::isCJKIdeograph() was removed because it is no longer used. [1] https://codereview.chromium.org/1545073002 BUG=571943 Review URL: https://codereview.chromium.org/1541393003 Cr-Commit-Position: refs/heads/master@{#371917}
-