- 28 Nov, 2019 40 commits
-
-
Liquan (Max) Gu authored
In the new bottom-sheet based Payment Handler UI, the Payment Request UI is currently obstructing the PH UI. This is because PR UI is a Dialog, and the PH UI is a widget on the ChromeActivity - Dialogs displayed on the top graphic layer of their activity. To solve this issue, this CL change to hide the PR UI when opens a PH UI, and reshow the PR UI when hides the PH UI. The way to implement this behavior is to create a coordinator responsible for coordinating the display of both UIs, so that: * at most one of PH UI, PR UI is displayed at any moment * PH UI is prioritized over PR UI * the coordinating mechanism is robust to the external factors, e.g, a timeout event tries to show the PR UI when it's not supposed to be shown. As a side issue this CL solves, clicking the PR UI's "Pay" after hiding the PH UI used to fail. This was because the PH UI reference wasn't cleaned up when hiding. This CL adds a cleanup callback on PH UI closed to solve the issue. Bug: 999196 Change-Id: Ic602378cc30e93d1ba318a55006100feab7eac50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924600Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719994}
-
Renato Silva authored
Implements the sticky footer gradient for OOBE screens on Chrome OS. Adds the behaviour 'CrScrollableBehaviour' to oobe-dialog and make its 'top-scroll-container' 'scrollable'. Bug: 1017621 Change-Id: Ieb0a62e1cf5054cf461addaa8d493a762334a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916872 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719993}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/241ab903..033be28e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I728f191596ee898fa11639c7846ed3c6ae8e7886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719992}
-
David Roger authored
This CL reverses part of the change introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 The reason is that we don't want the pill to stay open while the password bubble is displayed, as the user may mistakenly believe that their password is uploaded to their google account. TBR=pbos, tangltom Fixed: 1027112 Change-Id: I7bdbc4a2020ba3511f2379a737146e7b61458551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942332 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719991}
-
Ewann authored
- Adds downloads action and icon to tools menu that opens Downloads folder. _ Adds keyboard shortcut to open Downloads. Bug: 1013572 Change-Id: I820298c1d3800ea86aef401ac1fdcf9d8eeed10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901075 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719990}
-
Alex Clarke authored
Without this GPU process chain crashes trying to load ExternalBeginFrameSourceAndroid. Change-Id: I011bdd517167e622d04ba9e65f8bd7d283811b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942338 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719989}
-
Hiroki Nakagawa authored
This is a follow-up CL for the previous review comment: https://chromium-review.googlesource.com/c/chromium/src/+/1939157/5/content/browser/service_worker/service_worker_container_host.cc#70 ServiceWorkerContextCore::container_host_by_uuid_ contains the pairs of service worker client UUID and a rawptr to ServiceWorkerContainerHost. This map is used only for service worker client APIs, so we don't have to put ServiceWorkerContainerHost for service worker execution contexts into the map. This CL removes the case. Also, the client UUID is specific to service worker clients, not for service worker execution contexts. This CL stops assigning the client UUID to ServiceWorkerContainerHost for service worker execution contexts. Bug: 931087 Change-Id: Ia4cba861add33083c977845d60ec41c51db685e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941532 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719988}
-
Juan Antonio Navarro Perez authored
This makes it easier to transfer the state from one workstation to another, without having to fetch again the results of all past pinpoint jobs. Bug: 1029039 Change-Id: I83eebe5d65cdda80b2f9255a584dd86ecd40f7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942047Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719987}
-
Chris Sharp authored
This reverts commit b2703ae9. Reason for revert: The test is very flaky on linux-chromeos-google-rel Original change's description: > [Extension SW] Enable UninstallSelf test for Service Workers. > > With SW lifetime fix CL > (https://chromium-review.googlesource.com/c/chromium/src/+/1832714), > this test should not fail/flake anymore. This is > also evident as retrying the test thousand times locally doesn't > fail. > > Bug: 1003597 > Change-Id: I31f467b10e90e10835f60ebedf6320d40cc7b864 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933410 > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719756} TBR=lazyboy@chromium.org,dbertoni@chromium.org Change-Id: Ia1747006ad1c1fb33dd3726a987b3cdbb0a9daf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942810Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719986}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b1980c87d08..455af892685f git log 8b1980c87d08..455af892685f --date=short --first-parent --format='%ad %ae %s' 2019-11-28 lalitm@google.com trace_processor: fix filtering on long and string and add tests 2019-11-28 treehugger-gerrit@google.com Merge "TrackEvent: Start using boot time where available" 2019-11-28 treehugger-gerrit@google.com Merge "TrackEvent: Add support for raw debug annotations" Created with: gclient setdep -r src/third_party/perfetto@455af892685f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:145214864 Tbr: perfetto-bugs@google.com Change-Id: Iefddb1afac86a5a8635f8fb70a6f4cbc3399f6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719985}
-
Jiajie Hu authored
Bug: None Change-Id: I91ead42f4a6bc96d55ef369da9c9770d9de4f515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941687 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b55a5e8. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I50f3ca3dc6c4f3131fbff9b545147a72cee7223e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942447Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719983}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I094c47a428ad3fb0d906ef2b265cc2576821063b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930568Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719982}
-
Mark Cogan authored
The file names for many files in the manual_fill directory didn't follow the style guide. Files should have the same name as the main interface declared in the header (translating camel case to snake case), and categories should use the +CategoryName naming. This CL renames .h files based on the current class names; .mm and unit test files are updated to match. Change-Id: Iedced231f20df181b2286bef6148cd53d1f98357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942333 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719981}
-
Corentin Wallez authored
This reverts commit 2d5b633a. Reason for revert: Causes this to fire: [1028:3416:1127/151100.479:FATAL:skia_output_surface_impl.cc(770)] Check failed: (thread_checker_).CalledOnValidThread(). Original change's description: > SkiaRenderer: Fix subtle use after free with WeakPtr > > SkiaOutputSurfaceImpl owns the SkiaOutputSurfaceDependency. After Impl > goes out of scope, there is no more Dependency. We reference the > Dependency when we call CreateSafe{Once,Repeating}Callback for things > like presentation feedback callbacks. It is possible for presentation > feedback to occur after Impl is gone, in which case we can no longer use > Dependency. > > Bug: 1020699 > Change-Id: Iedb37a444358e4c543afbb8d8da5907d6b290b7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936889 > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719744} TBR=backer@chromium.org,kylechar@chromium.org Change-Id: Ia092cdbd191648549381843080a01e53f53f1c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942342Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719980}
-
Alex Ilin authored
This CL adds support to OAuth2MintTokenFLow for a new OAuth extensions consent flow. To start the new flow, Gaia's OAuth2 IssueToken API returns "remoteConsent" value for the "issueAdvice" key. In that case, the response should include "resolutionData" dictionary containing a resolution url and browser cookies. OAuth2MintTokenFlow class parses the response into a RemoteConsentResolutionData struct and passes it to OAuth2MintTokenFlow::Delegate to continue the flow. The new delegate method will be implemented in future CLs. Bug: 1026237 Change-Id: Icbb2b2a6607b4af85139731c5a753f344202e24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924473 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/00b1e38f3b09..0ee91fc0a1c8 git log 00b1e38f3b09..0ee91fc0a1c8 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 cwallez@chromium.org Vulkan: Choose correct libvulkan on Android 2019-11-28 cwallez@chromium.org Vulkan: Don't require TRANSFER for universal queues 2019-11-28 cwallez@chromium.org Allow compilation of Dawn on Android Created with: gclient setdep -r src/third_party/dawn@0ee91fc0a1c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3d87517f5c20dfba2b5f30e6954868e7a487eb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2e8e6e030c9..7694024878c8 Created with: gclient setdep -r src-internal@7694024878c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:none Tbr: jbudorick@google.com Change-Id: Ifebd1c24027f52c980b23e491aeeb2f1f58a2097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942067Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719977}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7fd3ad466b4d..6ebed5428e4e git log 7fd3ad466b4d..6ebed5428e4e --date=short --first-parent --format='%ad %ae %s' 2019-11-28 xiaoxuan.liu@arm.com Add arm64 to libpng build configuration. Created with: gclient setdep -r src/third_party/angle@6ebed5428e4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Idc99cac1ffeb1d77b36ef6d03612b28b97904e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942527Reviewed-by:
-
Chris Sharp authored
This reverts commit 702cbe72. Reason for revert: The modified tests broke on linux-chromeos-google-rel Original change's description: > Add HTTPDangerWarning experiment to field trial testing config > > Bug: 1027626 > Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719730} TBR=bcwhite@chromium.org,holte@chromium.org,carlosil@chromium.org,livvielin@chromium.org Change-Id: I1f1812c6dcdc8d78c505e39c8a14440279ae0111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942808Reviewed-by:
-
Antonio Gomes authored
.. instead of base's RefCountedThreadSafe. BUG=787254 R=guidou@chromium.org Change-Id: Ie5e62f2920814444abf5ce4fa28855963b6319bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940928 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719974}
-
Olivier Robin authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/8e8b719e061c..4695792710cf git log 8e8b719e061c..4695792710cf --date=short --no-merges --format='%ad %ae %s' 2019-11-25 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-11-14 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-11-13 galiak@google.com Merge branch 'release-candidate' into stable 2019-11-08 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-11-07 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-11-06 galiak@google.com Merge branch 'release-candidate' into stable 2019-11-01 featherless@google.com Merge branch 'release-candidate' into stable 2019-10-30 yarneo@gmail.com v93.2.0 (#8686) 2019-10-30 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-28 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-25 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-10-23 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-21 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-10-16 andrewoverton@google.com Merge branch 'release-candidate' into stable 2019-10-09 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-08 yarneo@gmail.com Merge branch 'release-candidate' into stable 2019-10-07 featherless@google.com Merge branch 'release-candidate' into stable 2019-10-04 randallli@randallli-macbookpro2.roam.corp.google.com Merge branch 'release-candidate' into stable 2019-09-24 rsmoore@google.com Merge branch 'release-candidate' into stable 2019-09-23 randallli@google.com Merge branch 'release-candidate' into stable 2019-09-20 wenyuz@google.com Merge branch 'release-candidate' into stable 2019-09-19 bryanoltman@google.com Merge branch 'release-candidate' into stable Change-Id: I159aabff99fcfc7037cf51f431b4d858ca233437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940173Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719973}
-
Jan Wilken Dörrie authored
This change modifies the const overload of base::Value::GetList() to return the newly introduced base::CheckedContiguousRange() instead of base::span. Furthermore this change updates callers to use this new return value and performs some minor simplifications. TBR=treib,stevenjb,blundell,benwells,noyau,agl Bug: 990059 Change-Id: Iaf4577820fc579872d12d403cf8dd1aa9425b939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915759 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719972}
-
Florent Castelli authored
Those parameters are soon to be removed in WebRTC and shouldn't be referenced from Chrome anymore. Bug: webrtc:7580 Change-Id: I68d11d9f77657a39f531027b062a513a3d3fee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940155Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719971}
-
Eric Seckler authored
Given his contributions to system tracing this feels justified :) Change-Id: I2e0127426be0fb713a8f703eba1c5d3058ea4bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942727 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Bug: b/129546015, b/129545535 Change-Id: Ie680314181f7cabcacc54818184bc41d9c068440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942048Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719969}
-
Greg Thompson authored
Unregistering ends up posting tasks to perform cleanup in the Encryption db. Let these tasks run during TearDown so that all files have been closed by the time the test fixture's ScopedTempDir is torn down. BUG=546640 Change-Id: Iaea6142c74cf4db65809403ecc681ebd1243ddb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942427 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719968}
-
David Roger authored
This reverts commit 896db5d1. Reason for revert: as this is intended to be cherry-picked on beta, we want to minimize risks. After discussion we decided to go for an even smaller change, to be extra safe. Original change's description: > [Identity Pill] Don't freeze the animation during password bubble > > This CL reverses part of the change introduced in: > https://chromium-review.googlesource.com/c/chromium/src/+/1826678 > > The reason is that we don't want the pill to stay open while the > password bubble is displayed, as the user may mistakenly believe that > their password is uploaded to their google account. > > TBR=pbos > > Fixed: 1027112 > Change-Id: I77bbcb8793369579e96597bb6e72be89e852227b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940238 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719949} TBR=droger@chromium.org,pbos@chromium.org,tangltom@chromium.org Change-Id: Ice039caa9f1592a629148d0df4de5f92a9dffbc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942430Reviewed-by:
-
Igor authored
The powerwash was forbidden for enrolled devices initially to fix an enrollment escape bug where users could revert to older Chrome OS version and apply the weaknesses from the old version. After this change lands, powerwash will be allowed for enrolled devices in the following cases: 1 - Admin didn't set any value for the policy powerwash_allowed 2 - Admin set the powerwash allowed policy value to true 3 - Admin set the powerwash allowed policy value to false and the value of policy allow_tpm_firmware_update to true and the device needs to update the tpm firmware. In case of point 3, the powerwash is allowed only to explicitly update the tpm firmware. At the same time, the option to powerwash and revert remains disabled for enrolled devices. The CL from session manager to allow this on Chrome OS side: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1924409 BUG=chromium:923296 TEST=Check that ctrl+shift+R brings powerwash screen, and second press of the keys doesn't bring the "powerwash and revert" screen. Change-Id: I870a2c59c6989d041ad58dddf2c8ae40f20d94d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924193Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719966}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6cbbaee824c4..8b1980c87d08 git log 6cbbaee824c4..8b1980c87d08 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 ilkos@google.com Merge "Add statsd subscription id to trace metadata" 2019-11-28 ilkos@google.com Fix cost estimation for single row Created with: gclient setdep -r src/third_party/perfetto@8b1980c87d08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:145338821 Tbr: perfetto-bugs@google.com Change-Id: I41bcb3df478967c0a78a4bac3066c03c27580749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942032Reviewed-by:
-
arthursonzogni authored
This CL: 1) Align the two ContentSecurityPolicy struct in between content and network::mojom 2) Add a content::ContentSecurityPolicy constructor from a network::mojom::ContentSecurityPolicy 3) Add several TODO for the frame-ancestor CSP checked out-of-blink. This allows the future follow-ups: 1) Replace content CSP by network::mojom CSP for every mojo IPC. 2) Remove (gradually) every content CSP by the network::mojom ones. Change-Id: I1b1e0658f77ce3141d263d7de09272d225a4f756 Bug: 1021462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926141 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719964}
-
Alex Clarke authored
There are no current plans to run WebLayer on desktop. We currently build it there to ease development. Change-Id: I725ca8a6da7011db06e25c0adb1f66332b6d1486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940268Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719963}
-
sczs authored
- Adds a public flag to SaveCardTVC (supportsEditing), if YES then cardholder name, expiration month and year will be editable. - Implements updateSaveCardButtonState which checks the correctness of the Data: No empty cardholder name, and a valid expiration date. meaning that the year is the current one or older, and the month has a valid value for the selected year. - If one of the previous check doesn't pass then the Save Card button is disabled. Bug: 1014652 Change-Id: I61625a504a7da9617f842436862d58a32871882d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932799 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#719962}
-
Thomas Tellier authored
Bug: 900351, b/145275297, 1025736 Change-Id: Ic00d70ff5521ca9b9f10eead8fab17c1d590e23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939790 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#719961}
-
Anton Bikineev authored
This gives the following advantages over the existing binary tree: 1) Improved cache locality. When performing stack scanning the whole map can be held in memory and no indirections need to be performed. 2) The map is always balanced, whereas the binary tree can become unbalanced, e.g. if mmap happens to return memory in anscending order. This improves stack scanning by another 8% (after bloom filter). The use of base::flat_map implies that insertion and deletion of page regions is O(n), but since the value_type is trivially copy-constructible, this reduces to simple memcpy. Please note that insertion/deletion only happens when a new page region is allocated/deallocated, so this is not a frequent operation. In facebook_infinite_scroll story only up to 30 regions are allocated. Change-Id: I865495cf0288d6763ff1970043e4951d08de32b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940187 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719960}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dafa00edc4b3..b97d4ceb42b4 git log dafa00edc4b3..b97d4ceb42b4 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 fancl@chromium.org Fix showing wrong revision in bisect Created with: gclient setdep -r src/third_party/catapult@b97d4ceb42b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029025 Tbr: rmhasan@google.com Change-Id: I26226176cb6f5cb48e08ea5c5a4c81b40392531e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941084Reviewed-by:
-
Maggie Cai authored
Currently the scroll view has a max size, while the label button lives in the scroll view doesn't have a max size. When the font size is larger than expected, the label button view will become higher than the scroll view, which generates a scroll bar. This CL changes the scroll view height settings to fix this situation. BUG=959671 Change-Id: I651934e84e4d96123b026f31d31825f231d9d9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939007 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719958}
-
Peter Marshall authored
- Change how protocol messages are dispatched to/in the renderer. Previously the browser process would send 'interrupting' messages using a different DevToolsSession, io_session_. This mojo channel was bound using a task runner on the IO thread in the renderer process, meaning messages would still be processed even when the main thread was blocked. The IO thread would then post a task to the InspectorTaskRunner, causing it to interrupt V8 execution and run the posted task. To simplify this as much as possible, the browser now always uses the io_session_, but the IO thread will post a (non)interrupting task as appropriate for the message. This removes the need to keep the list of interrupting tasks in sync across the browser/renderer. Messages in-transit now always go via the IO thread and get posted to the InspectorTaskRunner, meaning pending messages can be tracked clearly using tracing, rather than sitting in a mojo channel somewhere waiting to get processed. - Add a new task queue for interrupting tasks only. Previously during an interrupt callback, we would run all tasks in the task queue, which could cause tasks that we not meant to be interrupting to be run during an interrupt. Now we run all tasks only from the new queue. - Remove IgnoreInterruptsScope. This was mistakenly applied to all running tasks during a refactoring. There used to be two ways to run tasks, one was refactored to call the other, but then they both used this interrupt scope. We actually don't need it at all because we now only run 'interrupting' tasks during interrupts rather than flushing the entire queue, which might contain non-interrupting tasks. - Remove the use of IgnoreInterruptScope in LocalWindowProxy::Initialize. The comment there doesn't apply now that we ensure we don't run non-interrupting tasks during interrupts. We don't have any calls that can cause JS to run in the ShouldInterruptForMethod list, so no JS will run there. - Add trace events to show how protocol messages are dispatched in the renderer process. These were really useful for debugging all of these issues. - Remove InspectorTaskRunner::IsRunningTask which was not used. Remove all the associated state handling around running_task_. - Remove InspectorTaskRunner::WaitForAndRunSingleTask which was not used. Remove the condition variable and all the handling for it as it was only used from this unused method. Bug: 1010534, 992560 Change-Id: I58c9193ecd1fc784cda22b054a9c5b7bc2f09969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926588Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719957}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9cce7d1..241ab903 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie9a867ada4b13243a569a4b93a7db4eced30a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941373Reviewed-by:
-
Mohamed Amir Yosef authored
This class encapsulates the logic for updating/saving for Butter for Passwords efforts. Change-Id: I03ac490ad272576f4613df172a333b2c97a01919 Bug: 1012203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876409Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#719955}
-
