- 01 Apr, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0359d522b7e2..1ca62263a630 git log 0359d522b7e2..1ca62263a630 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 khokhlov@google.com Write telemetry traces in proto format: standalone verion; changes to existing files Created with: gclient setdep -r src/third_party/catapult@1ca62263a630 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944418 TBR=sadrul@chromium.org Change-Id: Ie4338c434065950929f5602bba22dae193ab8b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646276}
-
Guido Urdaneta authored
Bug: 921006 Change-Id: I152740931412264a669836d13622bde19fce5ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547690Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#646275}
-
Michael Lippautz authored
Remove the toggle for unified heap. Without this flag there is no way to run a GC using wrapper tracing anymore. The removal just sets branches to false and removes immediate unused code. Followup changes remove the rest of the wrapper tracing infrastructure. Bug: 843903, 943097 Change-Id: Id5ef09a7fff3b23c7963007587a78c745e682c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537104Reviewed-by:
-
Mikel Astiz authored
This is part of a larger effort to make SyncableService::WaitUntilReadyToSync() pure and audit all datatypes. PasswordSyncableService doesn't need to do anything because the password store is guaranteed to be ready at all times. This CL was uploaded by git cl split. Change-Id: I2a13aa9f2a1c99eeb8002c88f83a2bcd7e51c99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545299 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#646273}
-
Mikel Astiz authored
The codepath is unreachable because we don't exercise it in the old, directory-based architecture. This datatype hasn't been integrated into pseudo-USS, so there's no need to implement the wait. This CL was uploaded by git cl split. R=mamir@chromium.org Change-Id: Iaf25494c7b0bad7d4a2e48670b501c9e2451e9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545298 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1be2ece7dd03a4b23412cd47843eed5fe46ed24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546180Reviewed-by:
-
Jérôme Lebel authored
With unity, sync settings is replaced by google services settings view. Bug: 939783 Change-Id: I88b0cffac014569a044642fd30d2baae44b5c409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545389Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#646270}
-
Lowell Manners authored
With this change, AccountFetcherService is now constructed only when creating an IdentityManager, eliminating the need for AccountFetcherService factories. Change-Id: I3da6ebb100706998884c5f77adc1a959e6ded1cb Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538429Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#646269}
-
Lutz Justen authored
Fixup URLs before checking them. This catches cases like "example.com", where we should just add "http://" instead of rejecting them. BUG=b:112186030,chromium:946485 Change-Id: I4f2e994c197aa69ceb30154f555af9199088cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545406 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#646268}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b3d9b94e611..dfe4cdc105a9 Created with: gclient setdep -r src-internal@dfe4cdc105a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: Ifcb6389d5060270b533d77ffb415c86736d8d3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546936Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646267}
-
Edin Kadric authored
Tested on Mac, including with RTL UI. Screenshot attached to associated bug. Bug: 947187 Change-Id: I1950b1a3ad5db9f3aff1def140f992ee38236ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544242Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#646266}
-
Mikel Astiz authored
The codepath is unreachable because we don't exercise it in the old, directory-based architecture. This datatype hasn't been integrated into pseudo-USS, so there's no need to implement the wait. This CL was uploaded by git cl split. R=melandory@chromium.org Change-Id: Idd75a1dc27d097ea9620a1ea5dc9e6d9952f923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545391 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#646265}
-
Harald Alvestrand authored
Fix to land: https://webrtc-review.googlesource.com/c/src/+/130493 Bug: chromium:948055 Change-Id: Iba453bd1878fc194dac048fe7378087af120bb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546303 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#646264}
-
Armando Miraglia authored
Prior to this CL, constraints processing treated the remote APM the same way it treated the APM running on the renderer process. This was incorrect because the audio stream provided by the remote APM has the the same audio parameters as the underlying microphone/device, while the APM running on the renderer process always uses channel count 1 and a predefined sample rate. Bug: 937294 Change-Id: I2e13514fa45af906658532a088bd158f15ee6ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496998 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#646263}
-
Olya Kalitova authored
Changes to PluginVm setup flow UI according to the spec provided: * Layout with proper margin and insets * Correct fonts * Correct messages color * Image of right size Test: browser_tests --gtest_filter="PluginVm*" Bug: 931703 Change-Id: Ia9c7d5c81e06e4525938bc5282c79b550cc1fcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538504 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#646262}
-
Joonghun Park authored
Even when there's no box, according to spec change in https://github.com/w3c/csswg-drafts/issues/1436, computed value of float with absolulte position should be "none". Bug: 903275 Change-Id: I7df8eb39eb4c5f22cadbfdbe7a96227eb61a09b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546732Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: hyunjune kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#646261}
-
Ehsan Karamad authored
The test should pass now after crrev.com/c/1407596. TBR=wjmaclean@chromium.org Bug: 659750, 918784 Change-Id: Ic71e2524804fd01dc7ee7e93af988465db20c95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547296Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#646260}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/89cd0c045035..4cd433ed5f2c git log 89cd0c045035..4cd433ed5f2c --date=short --no-merges --format='%ad %ae %s' 2019-04-01 titovartem@webrtc.org Switch routing from dest endpoint id to dest ip in network emulation layer 2019-04-01 danilchap@webrtc.org Move TaskQueueFactory from Call::Create parameter to CallConfig 2019-04-01 alessiob@webrtc.org Add PFFFT to generate_license 2019-04-01 danilchap@webrtc.org Revert "Move TaskQueueFactory from Call::Create parameter to CallConfig" 2019-04-01 danilchap@webrtc.org Move TaskQueueFactory from Call::Create parameter to CallConfig 2019-04-01 nisse@webrtc.org author_line_count.sh: Move user arguments last 2019-04-01 danilchap@webrtc.org Propagate TaskQueueFactory to AudioDeviceBuffer 2019-04-01 srte@webrtc.org Using TimeController for Scenario test framework 2019-04-01 nisse@webrtc.org Delete VCMJitterBuffer::IncomingRateStatistics 2019-04-01 nisse@webrtc.org Delete unused constructor arguments from VCMJitterBuffer 2019-04-01 nisse@webrtc.org Delete unneeded direct includes of common_types.h Created with: gclient setdep -r src/third_party/webrtc@4cd433ed5f2c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d130bdab5e095c333e886a96f2966c748057cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546178Reviewed-by:
-
Philipp Hancke authored
adds a timestamp to the logging of the getUserMedia call BUG=824688 Change-Id: Iebd6cc163befa76f9562a37c11d4977f578f1926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546101Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#646258}
-
Carlos Caballero authored
Start getting rid of references in preparation of getting completely rid of MessageLoopBase Bug: 891670 Change-Id: Iead4787566297c1534be21c4ad27ab551719603a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538178 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#646257}
-
Stephane Zermatten authored
Before this patch, when, during an AA prompt action, Chrome would crash when users click on a link that opens a new window from within CCT. This happened, because the Controller would call the UIDelegate during the shutdown procedure, after calling WillShutdown, which the contract of UIDelegate explicitly forbids. This patch guarantees that no UIDelegate is called after WillShutdown and ignores attempts to switch the controller state away from the STOPPED state. This is a workaround. It is meant to be easy and safe to cherry-pick. The proper fix would be to shutdown immediately as part of b/128300038 Bug: 947403 Change-Id: I828eb7e53a1c789a867052b9df95b90d2b253cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546093 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#646256}
-
Tien Mai authored
Downloaded pictures are now only read accessible for EVERYONE and fully accessible for administrators. This prevents any user from changing the profile picture unexpectedly. Bug: 939013 Change-Id: I982e6085f4fab2ca684b0ccdf5441fb201dd361c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529475 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#646255}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5bfb2289. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 6f2e9bd4 "webrtc wpt: add test for ice disconnection" be4bce5d "[WPT] Merge subresource scripts into common/security-features" d1ac10ff "Revert "webrtc wpt: add test for ice disconnection"" b6a550be "Gardening: dedicated-worker-options-credentials.html is slow." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Iafb7a7b0e631ef5f9ee234c5b8a70ae306b9dadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547297Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#646254}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/597b51d9f8a2..6b3d9b94e611 Created with: gclient setdep -r src-internal@6b3d9b94e611 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org Change-Id: I3e25b1a27a574c92170b9f68ff21a1a2b95b3a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547139Reviewed-by:
-
Carlos Caballero authored
Soon there will be multiple queues with different priorities, so the trick of posting a task that quits a run loop currentlyl in use in test_utils.cc will no longer work. In preparation for that this patch add a better implementation of the same functionality. Bug: 863341 Change-Id: I643e22a491145a3bae00d06ae9164a450f501298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541251Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Eero Häkkinen authored
This aligns the IDL file with the spec and simplifies the implementation because hand written type checking is not needed. Change-Id: Ie2cdb6f2cbbc8d4b85af607fb0071ee57baaa695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546292Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#646251}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5b63b1f34a1b..0359d522b7e2 git log 5b63b1f34a1b..0359d522b7e2 --date=short --no-merges --format='%ad %ae %s' 2019-04-01 perezju@chromium.org [Telemetry] Reuse http and websocket DevTools connections Created with: gclient setdep -r src/third_party/catapult@0359d522b7e2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945876 TBR=sadrul@chromium.org Change-Id: If55ecec1e179e1dabe8ec8c10fa92ac85b289d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547138Reviewed-by:
-
Mikhail Khokhlov authored
This is a step in relanding https://chromium-review.googlesource.com/c/catapult/+/1536123 Bug: 944418 Change-Id: Ia995a9a90e3da97e908ebb0382340d1ae368e159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545920Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#646249}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/inspector, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib6bfbac4fa16484e43ba85b4effbc9706f49bbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546747Reviewed-by:
-
Michael Lippautz authored
Feature is enabled by default and old infrastructure will be removed. Bug: 843903, 943097 Change-Id: I83737a6c347f24ce50dad1329bb3df3f80681826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533874 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Alex Clarke authored
This should help fix problems with the X11 and Ozone native clipboard API where we want to wait with a timeout for an OS callback but we don't want chrome tasks to run. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1545393 I significantly increased the duration to the delayed tasks that are not meant to fire in RunLoopTest which should fix the mac flake. TBR=dcheng@chromium.org, skyostil@chromium.org Change-Id: I5eabe60b6bf49f1f35bcdbc9fd089543d094df87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547513Reviewed-by:
-
Bo Liu authored
In the NOTIFICATION_RENDERER_PROCESS_CLOSED call, some webview apps can synchronously create a new WebContents and load a page into it. This breaks content's internal tracking of IPC state which causes the new renderer to crash again, causing a crash loop. The root cause is RFHI::OnRenderProcessGone resets the mojo connection tracking in the new WebContents, which is wrong because the new WebContents/RFHI was never connected to the old renderer process. Fix this by somewhat reducing reentrancy by moving NOTIFICATION_RENDERER_PROCESS_CLOSED after RFHI::OnRenderProcessGone to avoid this situation. Bug: 946758 Change-Id: I7be5a66631688dfb9ed77ef30b518e3149c09af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545700 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#646245}
-
Jessica Tallon authored
This works by looking up the top most frame and emitting the signal on the ATK_ROLE_FRAME (kWindow). It also ensures that we're firing the event when the tab changes too. Bug: 938272 Change-Id: I891611a7841bbec1e2196ccb57cde7c0fce28ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528248 Commit-Queue: Jessica Tallon <jtallon@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#646244}
-
Friedrich Horschig authored
This CL makes every part of a subcomponent package-private which isn't part of the public interface as defined in its coordinator. The main change required to do this, was to refactor tests which have used inspections of subcomponents to verify states. As side-effect, some methods could be dropped which have only been used in tests. TBR: peconn@chromium.org TBR Reason: Wrong annotation in @IdRes changed to @LayoutRes. Bug: 945314 Change-Id: I3d70caffbfc63f2bd1f672e1093a37005fc64f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543391Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#646243}
-
Lutz Justen authored
Add messaging to explain what standard schemes are. We had support tickets where admins didn't understand that they were missing http://. BUG=b:112186030,chromium:946485 Change-Id: If043f4fe84dc473a7f4e10a62aabf1071c9ea21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545405Reviewed-by:
-
Stephane Zermatten authored
Before this change, the reason behind an error that happened in WebController was always lost, as all methods would return a boolean, either true or false. This makes it hard to debug errors, as many different errors end up being reported as OTHER. With this change, the WebController methods can return a ProcessedActionStatusProto, which ends up being included into the RPC response, in most case, allowing WebController to let the server know whether the error failed because the element was not found, or for other reasons. This change also add new client status code, which correspond to errors in WebController. This change introduces a ClientStatus C++ type, which is, for now, just a wrapper for ProcessedActionStatusProto. This prepares the way for adding more debugging information into the status, which can be forwarded to the server, such as details about clicks. BUG=b/129387787 Change-Id: I9df154f51401aa52a84d6b8c80c6c7ad02dc61c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543772 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Igor authored
Currently we support two values for the policy: ALWAYS and ARC_SESSION. The class responsible for the policy is subscribed to observers to be notified when user login state changes and when arc session starts. Depending on the policy value, it might decide to request cryptohome to lock the device to single user mount. Bug: b:77799573 Test: Manual and unit tests CQ-DEPEND=CL:1489311 Change-Id: Ie75e382be048560331393af245b7ea6b58761ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516372Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#646240}
-
Adam Rice authored
This reverts commit 01b3aaef. Reason for revert: Causing top browser crash. See https://crbug.com/947942. Original change's description: > WebRequestProxyingWebSocket: Wait for renderer to close mojo > > WebRequestProxyingWebSocket actively tore down mojo connections in > response to normal WebSocket termination. This led to race conditions > where the error for the teardown would be reported to JavaScript before > the correct termination reason. > > Wait for the render process to tear down mojo connections for normal > WebSocket termination. This ensures the correct termination reason is > reported to JavaScript. > > BUG=937790 > > Change-Id: I747224ff77bd17b8ef5bff71d743a66cad5da79d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508475 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645705} TBR=ricea@chromium.org,rockot@google.com,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937790 Change-Id: Ided22a241866e24c57f261a8244c3e5ccbe8db98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547477Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#646239}
-
Javier Ernesto Flores Robles authored
Bug: 942002 Change-Id: Idb2d7364d20f3b058596f110c1a4951e0fb3f2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546092 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5c9ffbb3ca236b4be997ade71714b0556bafdb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547140Reviewed-by:
-
