GitLab

1) Being a ref counted class
Previously, FileBrowserEventRouter was a ref counted class, but the weak
pointer was also used, which doesn't make much sense. Being a ref counted
class was bad, as lifetime of FileBrowserEventRouter was unclear, and
FileBrowserEventRouter could outlive things like DBusThreadManager and
PrefService in rare cases, which caused crash at shutdown.

2) Use of a mutex lock
The lock was used to protect |file_watchers_|, which was accessed from FILE
and UI threads, which should be avoided. Interaction between FILE and UI
threads were also hard to read.

BUG=227477,227483
TEST=Open Downloads in Files.app. Download a file to Downloads. Confirm that the new file appears in Files.app immediatley.

Review URL: https://codereview.chromium.org/13776005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192993 0039d316-1c4b-4281-b951-d872f2087c98

This renames some "level" variables to "state" to make it
more clear that they don't directly map to the API's "level"
enum.  It also registers chrome.runtime.onStartup and
chrome.windows.onCreated (to work around onStartup apparently
not firing on Chrome OS) listeners and switches from
localStorage to chrome.storage.local.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/13493019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192992 0039d316-1c4b-4281-b951-d872f2087c98

- better to focus on entries rather than the specific settings item
- scroll to the settings item when focus has moved out of the scroll view
- EntryView keeps the same margin both left and right
- resize the scroll contents when the window is resized

BUG=196804, 226678
R=dharcourt@chromium.org, dewittj@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13544009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192991 0039d316-1c4b-4281-b951-d872f2087c98

Fixed memory leaks in ScreenshotTakerTest. Updated suppression files.
Ran valgrind and heapcheck on my desktop.

BUG=227271
TEST=manual
unit_tests --gtest_filter='ScreenshotTakerTest.*'

Review URL: https://chromiumcodereview.appspot.com/13801010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192987 0039d316-1c4b-4281-b951-d872f2087c98

This bug is caused by single trailing dot trimming from the input.
Fixed it by forbidding a pattern if canonicalization is not idempotent, i.e. the pattern canonicalized twice differs from the pattern canonicalized once.

BUG=180514


Review URL: https://chromiumcodereview.appspot.com/13251012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127135
TEST=None


Review URL: https://chromiumcodereview.appspot.com/13638032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70818

Review URL: https://codereview.chromium.org/13812005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192982 0039d316-1c4b-4281-b951-d872f2087c98

In preference to https://codereview.chromium.org/13699002/

As it's only the secondary widgets (not the Frame), it appears
relatively safe to use CloseNow to avoid the closing animation.

R=sky@chromium.org
BUG=226716

Review URL: https://chromiumcodereview.appspot.com/13770008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192981 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13728003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173944


Review URL: https://chromiumcodereview.appspot.com/13637009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192979 0039d316-1c4b-4281-b951-d872f2087c98

Use GetStorageInfoForPath to get volume size.

R=thestig@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/13524003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192978 0039d316-1c4b-4281-b951-d872f2087c98

The older interface assumes an implicit relationship between a URLRequestContext
and its delegate.  This interface has been deprecated in favor of making the
network delegate explicit.

BUG=146587


Review URL: https://chromiumcodereview.appspot.com/13079008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192977 0039d316-1c4b-4281-b951-d872f2087c98

Cryptohome now supports including a SignedPublicKeyAndChallenge embedded
in a challenge response.  The new options parameter allows a caller to
request that this be included.

BUG=chromium:219965
TEST=chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/13638022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192976 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for replacing the various IOBuffers used for reads/writes
with a single SpdyBuffer class.

Replace the priority queue of SpdyIOBufferProducers with a SpdyWriteQueue object,
which is an an array of FIFO queues binned by priority.
The priority queue was looking only at priority and so was not guaranteeing
FIFO behavior among producers with the same priority.

Remove the frame queue in SpdyStream and instead have it use the session's
write queue directly.

Remove unused fields from SpdyIOBuffer and clean it up.

Propagate and handle errors from SpdyCredentialBuilder::Build.

Rename SpdyIOBufferProducer to SpdyFrameProducer, have it return a SpdyFrame,
clean up its interface, and move the stream-activating logic out of it.

Replace uses of std::list with std::deque.

Steamline logic in SpdySession that deals with the write queue.

Convert some raw pointers to scoped_ptr<>.

BUG=176582

Review URL: https://codereview.chromium.org/13009012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192975 0039d316-1c4b-4281-b951-d872f2087c98

Delete duplicated tests (they were moved to ApiTestsAudio).

BUG=224249


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192021

Review URL: https://chromiumcodereview.appspot.com/13464016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192973 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a search and replace for -webkit-box -> -webkit-flex,
and some related properties.

I have tested that the UI still looks correct, although I couldn't find
out where connection-history-options is used.

R=jamiewalch@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/12847005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175012


Review URL: https://chromiumcodereview.appspot.com/13543007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=218270


Review URL: https://chromiumcodereview.appspot.com/13529009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192970 0039d316-1c4b-4281-b951-d872f2087c98

Make the pnacl component place files in a profile-specific directory
for chromeos.  We don't want to share data between users on
chromeos because of questions about integrity of these files.
This adds a notification watcher and will re-register pnacl with
a different version whenever the user logs into
a different account.

Files are installed to a stateful partition, which should
be okay.  The stateful partition is mounted no-exec, but
the pnacl files are not typical executables.

This is a temporary solution to help with testing out PNaCl on chromeos.
We will need to find a different solution later that does
not involve multiple copies, one for each user.

BUG=221381
TEST= manual with:

1) export GYP_DEFINES="chromeos=1"
2) build
3) out/Release/chrome --enable-pnacl --enable-nacl --user-data-dir=/tmp/temp_profile_chromeos --login-profile=user --login-manager
4) wait 20 seconds and see /tmp/temp_profile_chromeos/test-user/pnacl/0.0.0.5 show up

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192415

Review URL: https://codereview.chromium.org/13071002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192969 0039d316-1c4b-4281-b951-d872f2087c98

Also, add an option 'chrome-version' to run_all_tests.py so that we can run tests on a specified version of chrome.
And disable one failed java test on Win7.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13827002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181072


Review URL: https://chromiumcodereview.appspot.com/13293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192965 0039d316-1c4b-4281-b951-d872f2087c98

FileSystemURL::virtual_path is a superficial path specified by the user of
FileSystem API. It does not necessarily denote the 'virtual path' of Drive
files like drive/foo.txt, when the Drive filesystem is mounted onto of
another filesystem (e.g., onto an isolated filesystem). Basically,
virtual_path() should never be directly used inside the Drive filesystem.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/13767002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192962 0039d316-1c4b-4281-b951-d872f2087c98

O1D is a replacement for O3D. We want to support it on cros as well as
win/mac/lin, so we've written a ppapi implementation of it.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192961 0039d316-1c4b-4281-b951-d872f2087c98

It was caused by -menu getting called before the view got added to the
window, which was creating the C++ controller with a nil NSWindow.
(This was being done by the localizer inspecting the view.)

Add an early return in that case - so the menu only gets created once
the view is attached to the window.

BUG=227388
TEST=As per bug.

Review URL: https://chromiumcodereview.appspot.com/13801018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192958 0039d316-1c4b-4281-b951-d872f2087c98

This padding was in some previous versions but got lost somewhere along
the way. This change restores it so there are always at least 12 pixels
between the baseline of the last line of text and the bottom of the card
or the image below the text. This will be true for WebKit, simple,
basic, and image notifications but also for list ones.

Note that although there will be exactly 12 pixels of space on Windows,
there will be 13 pixels On Chrome OS because different fonts are used
there, and also that if the Chrome OS system font changes that number of
pixels may change slightly.

This change also makes the padding between the top of notification
text and the notification card be 12 pixels, as it was designed to be.
It had somehow become 11 pixels.

BUG=225871
TEST=Bring up a notification, take a screenshot, and count pixels.

Review URL: https://chromiumcodereview.appspot.com/13560002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227332
TEST=Drag-drop operations on Win Aura shouldn't crash the renderer or hit asserts


Review URL: https://chromiumcodereview.appspot.com/13523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192954 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13804003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192953 0039d316-1c4b-4281-b951-d872f2087c98

This allows packaged applications to launch windows
already into a fullscreen, maximized, or minimized state.

Design doc: https://docs.google.com/a/google.com/document/d/1__SPIxd_sFVYFNdP55CouE-p61uLOWEL-X-2TEOJFdY/edit

BUG=163626

TEST=Manual testing is appropriate as this functionality is tightly coupled with operating system functionality and related automated tests have always been disabled flaky. Please use the window-state sample: https://github.com/GoogleChrome/chrome-app-samples/tree/master/window-state.

Review URL: https://chromiumcodereview.appspot.com/13609003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/13524005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124671, 161008


Review URL: https://chromiumcodereview.appspot.com/13560016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192950 0039d316-1c4b-4281-b951-d872f2087c98

The code to handle cache clearing didn't land in time for the M27
branch so it has been decided to disable this feature for M27.

This patch will be rolled back after it lands on the M27 branch.

BUG=228989


Review URL: https://chromiumcodereview.appspot.com/13800013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192949 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes most of the problems with the allow/block flow:
 - removes got_user_gesture
 - uses the redirect list for URLs instead of recording them every time
 - better identifies when the user has clicked on a link and when the page
   was redirected.

R=bauerb@chromium.org
BUG=168772
TEST=browser_tests --gtest_filter=ManagedModeBlockModeTest.*


Review URL: https://chromiumcodereview.appspot.com/13533017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192948 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13771017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192947 0039d316-1c4b-4281-b951-d872f2087c98

1. Device changes may cause an already in process stream creation
to use the wrong buffer size => CHECK() failure.

2. Low latency stream Open() failure causes AudioOutputResampler
to fall back to a high latency buffer size, which will cause a
stream to be created with the wrong buffer size => CHECK() failure.

Fixing 2 has the added advantage of removing an extra useless hop
between stream Open() failure and switching to a fake audio output
device.

BUG=225249
TEST=audio works.


Review URL: https://chromiumcodereview.appspot.com/13390010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192946 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 44867738.

Review URL: https://codereview.chromium.org/13529032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192945 0039d316-1c4b-4281-b951-d872f2087c98

When starting with --wait-for-debugger command line option, it's ending
up in a busy loop waiting for a variable to be changed. Change that busy
loop from a macro to a function. It avoids having to step on instruction
level to find the right stack frame before the variable is visible.


Review URL: https://chromiumcodereview.appspot.com/13597005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192944 0039d316-1c4b-4281-b951-d872f2087c98

The URL for Chrome OS file manager extension is checked
separately for now. But this must be done in IsTranslatableURL()
at once.

BUG=none
TEST=unit_tests

Review URL: https://codereview.chromium.org/13770003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140402
TEST=NONE; Test logs don't spew this NOTIMPLEMENTED.
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13759002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155363
R=msw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/13602010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192941 0039d316-1c4b-4281-b951-d872f2087c98

This function was used in only one place and that place was wrong.

The implementation was long and complicated on Windows, and long and
complicated and copied verbatim from elsewhere with 3 lines different on Posix.

The place it was used was in the proxy launcher when copying the profile. It's
not clear to me why we wouldn't want the profile files in the filesystem cache
when running tests. Quite the opposite, we want the tests to run as fast as
possible.

The only place this should matter is in the startup tests. And the startup
tests do things to the profile after it gets copied that should page some files
back in! This adds another step to the startup tests to evict the profile files
for cold startup tests only.

This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here.

patch from issue 13394003

Review URL: https://codereview.chromium.org/13646016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192940 0039d316-1c4b-4281-b951-d872f2087c98