GitLab

ViewTest.RecreateLayers creates a layer hierarchy that includes child
widgets and pulls an aura dependency into view_unittest.cc.

This CL moves the test into a new file - view_unittest_aura.cc to
isolate the aura dependency and allow view_unittest.cc to compile on
MacViews.

After this, an additional 56 views_unittests are compiling (39 pass).

BUG=378134
TEST=views_unittests

Review URL: https://codereview.chromium.org/329473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276534 0039d316-1c4b-4281-b951-d872f2087c98

Move search_engine_type.h from chrome/browser/search_engines to components/search_engines
Move prepopulated_engines* to components/search_engines

TBR=asvitkine@chromium.org for the comment fix in tools/metrics/histograms/histograms.xml
BUG=371535
TEST=git cl try

Review URL: https://codereview.chromium.org/330433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276533 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276532 0039d316-1c4b-4281-b951-d872f2087c98

Python 2.7.x includes pySerial version 2.5 as a distribution package. This conflicts with
our repository version of pySerial i.e. 2.7. The submodule serial.tools.* was included in
pySerial after 2.6 as per [1].

The utility function util.AddDirToPythonPath(...) appends the path at the end of the path
list. Due to this, the python interpreter picks up the pySerial library from system include
path at /usr/lib/python2.7/dist-packages/serial. This CL modifies AddDirToPythonPath(...) API to always prepend the path.

[1] http://pyserial.sourceforge.net/pyserial_api.html#module-serial.tools.list_ports

NOTRY=true

Review URL: https://codereview.chromium.org/321773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276531 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/5713352a64936428d37a721382d021f4a9002172..b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749
TBR=scroggo@google.com
NOTRY=true
BUG=

win_chromium_64 sync failure unrelated to this CL
NOTRY=True

Review URL: https://codereview.chromium.org/328163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276530 0039d316-1c4b-4281-b951-d872f2087c98

TODO and should address the dead isolate issue in bug 382179.

BUG=382179
R=rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/327953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382675
NOTRY=True

Review URL: https://codereview.chromium.org/334533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383491
R=mukai@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276527 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=fmalita, robertphillips

BUG=crbug.com/383435

Review URL: https://codereview.chromium.org/327293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276526 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: https://codereview.chromium.org/326123003/

BUG=382178
NOTRY=true
R=msw

Review URL: https://codereview.chromium.org/323403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276525 0039d316-1c4b-4281-b951-d872f2087c98

Add an interface to allow embedders to navigate embedded views.
This only supports local/pushState-style navigation right now.

BUG=
R=darin@chromium.org, davemoore@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/327523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276521 0039d316-1c4b-4281-b951-d872f2087c98

Patch 2 in the series of renaming WebFontFamily to WebFallbackFont,
at the same time, fixing the sandbox support IPC to transmit filename
and ttcIndex. Depends on step 1 of the rename, r175858 in Blink.

BUG=382411
R=eae,behdad,jln,piman

Review URL: https://codereview.chromium.org/327633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276520 0039d316-1c4b-4281-b951-d872f2087c98

RenderingHelper is now responsible for controlling the rendering fps. There is no need for the ThrottleVDAClient to do the same thing.

BUG=None
TEST=Run the program on peach-pit

Review URL: https://codereview.chromium.org/294663006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276519 0039d316-1c4b-4281-b951-d872f2087c98

This makes the way that we invoke dex more consistent (and easier to
change).

Review URL: https://codereview.chromium.org/317423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276518 0039d316-1c4b-4281-b951-d872f2087c98

Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked.

Existing implementation calls SetScreenOrientationForTesting and sends screen
orientation events even when the test screen orientation is locked.

BUG=162827

Review URL: https://codereview.chromium.org/302553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276517 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276505 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/329923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276503 0039d316-1c4b-4281-b951-d872f2087c98

Also add test coverage of SPDY network changes with created streams.

BUG=382553
R=rch@chromium.org

Review URL: https://codereview.chromium.org/328823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276495 0039d316-1c4b-4281-b951-d872f2087c98

> Redirect HTML resource bytes directly to parser thread (Chrome side)
> 
> Blink side: https://codereview.chromium.org/100563004/
> 
> Note: This can't land until the Blink-side has landed.
> 
> R=jamesr@chromium.org,jam@chromium.org
> BUG=277886
> 
> Review URL: https://codereview.chromium.org/109283006

TBR=oysteine@chromium.org

Review URL: https://codereview.chromium.org/326403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276494 0039d316-1c4b-4281-b951-d872f2087c98

Re-enable disabled test after fix at r276488.

> out-of-process too

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/327353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276492 0039d316-1c4b-4281-b951-d872f2087c98

Fixed by https://src.chromium.org/viewvc/chrome?view=rev&revision=276488
Re-enabling test.

> Disable PPAPINaClNewlibTest.TrueTypeFont temporarily
> 
> TBR=ccameron@chromium.org
> BUG=382729
> 
> Review URL: https://codereview.chromium.org/325963002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/330543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276490 0039d316-1c4b-4281-b951-d872f2087c98

This was turned off when DirectWrite is on, however pdf still needs
access to them in process.

R=jschuh@chromium.org
TBR=jam@chromium.org, jschuh@chromium.org
BUG=383227

Review URL: https://codereview.chromium.org/331463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276488 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276480 0039d316-1c4b-4281-b951-d872f2087c98

Revert of NaCl: Update revision in DEPS, r13309 -> r13318 (https://codereview.chromium.org/324353002/)

Reason for revert:
The change appears to have broken http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=68537.

Original issue's description:
> NaCl: Update revision in DEPS, r13309 -> r13318
> 
> This pulls in the following Native Client changes:
> 
> r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything.
> r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources.
> r13312: (mcgrathr) Disable seccomp-bpf tests under ASan
> r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests
> r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build
> r13315: (dyen) Python logging now organized to use loggers instead of global variables.
> r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13317: (jfb) Update revision for PNaCl r13281->r13311
> r13318: (jfb) Update revision for PNaCl r13311->r13316
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276475

TBR=bradnelson@google.com,mseaborn@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/326383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/323223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276478 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276477 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Appears to have a memory leak. See:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954

Original issue's description:
> Use labels to display views tab titles.
> 
> Add a Label view to Tab for displaying the title.
> Remove Tab::PaintTitle, bounds and font members.
> Remove unnecessary Tab::Get[Title|Icon]Bounds helpers.
> Update the text on Tab::SetData, not during paint.
> Use gfx::DirectionalityMode, remove the Label enum.
> 
> Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment.
> Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD.
> Always flip left/right in Label::SetHorizontalAlignment.
> Have Tab and MessageBoxView use ALIGN_TO_HEAD.
> 
> Update comments and tests, related minor cleanup.
> 
> TODO: Make Label cache RenderText objects.
> TODO: Make RenderText support ALIGN_TO_HEAD.
> 
> BUG=240037
> TEST=No visible Views tab title changes.
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276450

TBR=sky@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=240037

Review URL: https://codereview.chromium.org/327273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276476 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything.
r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources.
r13312: (mcgrathr) Disable seccomp-bpf tests under ASan
r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests
r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build
r13315: (dyen) Python logging now organized to use loggers instead of global variables.
r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13317: (jfb) Update revision for PNaCl r13281->r13311
r13318: (jfb) Update revision for PNaCl r13311->r13316

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/324353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276475 0039d316-1c4b-4281-b951-d872f2087c98

Since ExtensionRegistry provide canonical way, use ExtensionRegistry instead.

R=kalman@chromium.org, xiyuan@chromium.org
BUG=374353
TEST=unit_tests

Review URL: https://codereview.chromium.org/323763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276474 0039d316-1c4b-4281-b951-d872f2087c98

If a SourceBuffer::Remove() call removed the GOP that is currently being
appended, an incorrect start timestamp would be used when the next GOP was
appended. This ultimately led to a crash if a followup Remove() call
ended up deleting the range. This change fixes the code that determines
the start timestamp for the range created for the second GOP.

BUG=382815
TEST=SourceBufferStreamTest, Remove_WholeGOPBeingAppended

Review URL: https://codereview.chromium.org/324223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276471 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/307483002/ that adds the new resources.

BUG=372812, 310640

Review URL: https://codereview.chromium.org/309643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276470 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove some former OWNERS so they don't get tapped for reviews on random patches. But we still love you guys!

NOTRY=true

Review URL: https://codereview.chromium.org/331493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276469 0039d316-1c4b-4281-b951-d872f2087c98

This CL merges the unittest suites in
//chrome/browser/metrics/metrics_log_unittest and
//components/metrics/metrics_log_unittest, putting all of the unittests into
the latter and eliminating the former.

BUG=382549
TBR=thakis

Review URL: https://codereview.chromium.org/327523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276468 0039d316-1c4b-4281-b951-d872f2087c98

This function indirection is no longer necessary, and I was getting frustrated
by having the type signature of LaunchSelLdr twice in the source. I came across
this in an experimental CL modifying LaunchSelLdr to also receive information
for the user nexe.

BUG=333950
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/322403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373637
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/322753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276465 0039d316-1c4b-4281-b951-d872f2087c98

In my CL for sending Show/Hide to all frames on a page (https://codereview.chromium.org/298283003), I used the RWH for each RenderFrameHost in the tree. This missed the fact that an interstitial page will be overlayed and not part of the frame tree in WebContents.

BUG=381439

Review URL: https://codereview.chromium.org/321253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276463 0039d316-1c4b-4281-b951-d872f2087c98

MemorySanitizer complained when those values were sent over IPC.

BUG=383363
R=kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/327293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276462 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276458 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175917:175949&mode=html
TBR=yhirano@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/322363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276457 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=383408

Review URL: https://codereview.chromium.org/334443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276456 0039d316-1c4b-4281-b951-d872f2087c98