- 03 Sep, 2020 40 commits
-
-
Michele Mancina authored
Bug: b/157457785 Change-Id: I405f33df3d48af3a83edfd58ebf6bb8fe29c08fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390644Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#804156}
-
Koji Ishii authored
This reverts commit 8ecd46b9. Reason for revert: Increases memory usage on 32 bits Original change's description: > Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing > > This patch changes |NGInlineNode::ShapeText()| not to reuse > |ShapeResult| for text with CSS property "letter-spacing" because we > modify |ShapeResult| directly to apply letter spacing. Thus, letter- > spacing is applied more than once on reused portion of |ShapeResult|. > > Bug: 1124446 > Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804147} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: I2fbb377d000fa3944b5902043ae8796dedd9119c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390615Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804155}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f76c76d25df8..3649c2a8b0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1116650,chromium:897470 Tbr: shimazu@google.com Change-Id: If890693c473d4bb641d6b96a59dd53af8491c72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804154}
-
Benoit Lize authored
glibc used to allocate memory using __libc_memalign(), and free it with free(). This imbalance means that our allocators are asked to free() data they didn't allocate. To make sure this doesn't happen, intercept the internal libc symbols. This was already done for tcmalloc, but not for PartitionAlloc. Extend it to PartitionAlloc, and add a test. Also document the issue more clearly in the files. This is required for PartitionAlloc Everywhere. Bug: 998048 Change-Id: I0852fc87f92f97de93aba130b2416926aa71d873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386717Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804153}
-
Camillo Bruni authored
Move the erroneously placed Microtask checkpoint from V8ScriptRunner::EvaluateModule to ModulatorImplBase::ExecuteModule. This CL affects the ordering around module script evaluation, especially between microtasks and Window/WorkerGlobalScope error events. This CL is a preparation to make the top-level await implementation simpler and more spec-conformant: https://crrev.com/c/2228881 Additionally we fix the evaluation-order-2-import-worker.mjs test expectations to be spec compliant. Bug: 1022182, 1096455c, 1114034, v8:9344 Change-Id: I0f6d510b62310d9342fea30ff8ed6cbe37349cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339658 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#804152}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599089820-64812fa7a88dc8607ac3baec5789a7fcb10cfda3.profdata to chrome-mac-master-1599112620-f359a51daebae2f754df062494b1fdebe13ff3bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I83e8fb9c57a0e3cb6054e08ffe8b66c74f1816b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804151}
-
Alice Wang authored
This CL refactors AccountPickerBottomSheetTest by extracting the method clickContinueButtonAndWaitForErrorSheet() and add two more checks in checkCollapsedAccountList() method. Bug: 1121536 Change-Id: Id7a890ad66b244ea171c7a24d583c402600fca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383029Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804150}
-
Irina Fedorova authored
This CL renames CompromisedCredentialsManager class to InsecureCredentialsManager and renames its methods. We need these changes as we want to repurpose this credentials manager to work with both weak and compromised credentials. Bug: 1119752 Change-Id: I533561b1212d8e55022e324dffa5c916b7e73d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387098 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804149}
-
James Vecore authored
This change makes the Nearby Share keyed service only start for 'PrimaryProfiles' on chromeos and adds some additional profile oriented logging for debugging process manager profile issues. Change-Id: If239b038627c343bbf5848e9a4ab1f5aed498f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391905Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#804148}
-
Yoshifumi Inoue authored
This patch changes |NGInlineNode::ShapeText()| not to reuse |ShapeResult| for text with CSS property "letter-spacing" because we modify |ShapeResult| directly to apply letter spacing. Thus, letter- spacing is applied more than once on reused portion of |ShapeResult|. Bug: 1124446 Change-Id: I8f0f45f613c872649e46fe96e031e9532a05bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390927 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804147}
-
Devlin Cronin authored
Composition is preferred over inheritance in general, and this also avoids multiple implementation inheritance (which is strongly discouraged by style) in two test suites. Also rename the Mixin to be "Helper". https://google.github.io/styleguide/cppguide.html#Inheritance Bug: None Change-Id: Ie4ab266baf55d7964ec2cbd06d372aa74ecadca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389415 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804146}
-
chrome://multidevice-internalsRegan Hsu authored
* Users can now set 2 tab model metadatas. * If any fields are empty, the url metadata will be treated as nullopt. * 3rd and 4th tabs will be added later. Screenshots https://screenshot.googleplex.com/AwV2evHm2c7QCMU https://screenshot.googleplex.com/6q7tXZFAH3K8pSL https://screenshot.googleplex.com/7rgRSDiU2EqKwXE https://screenshot.googleplex.com/7mJtxtdg3GrDF6q Bug: 1106937 Change-Id: I20872614efa1caa889267c1b01d4406255c60be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391647 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804145}
-
Paula Vidas authored
This CL adds a field to device info specifics for a list of data types for which the device wants to receive invalidations. The list will be used by the sync server to send invalidations for only those types. The data types are obtained from SyncInvalidationsService. Bug: 1102312 Change-Id: Ia85f2b523d1f9adeef84dc4562d1bd525615e368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387113Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#804144}
-
Sergey Abbakumov authored
This CL fixes media_unittests in a component build. The issue was a duplicate global feature object since media_switches.cc is inside a source set. Bug: 1123898 Change-Id: I97f18f166af4da4924ec191de6c183426e942aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387578Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Abbakumov <sabbakumov@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#804143}
-
Hiroshige Hayashizaki authored
This CL checks that worker.onerror event's `message` field contains the original exception's message, "TypeError", etc. This is a regression test for crbug/590219, where Chromium set the message to just "Uncaught ". This CL also refactors `exception-in-onerror.js` and renames it to `throw.js`, to share it from multiple test files. Bug: 590219 Change-Id: I7184eba7a9a6a7f08b1ef6eed95bc49adb91fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368621 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804142}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46877765c47c..96dcbc6eb372 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4e00e7540aa0aca4d0f01deb432a1e948ed47ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392375Reviewed-by:
-
Klaus Weidner authored
The previous workaround for WebXR DOM Overlay mode from https://crrev.com/c/2378653 didn't work consistently due to a race condition. CompositorView's notifyWillUseSurfaceControl is asynchronous, so it's possible that initNativeCompositor will be using the OPAQUE surface even though a later call to canUseSurfaceControl() returns true and getSurfacePixelFormat() returns TRANSLUCENT. In this case, continue with the normal requestSurface path. Bug: 1123951 Change-Id: I612b24bcdeb8b45fb33c6d94481e6b2ab63c74c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386331 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#804140}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ade98316c21..c60774bed06c 2020-09-03 danilchap@webrtc.org Delete RTPFragmentationHeader as no longer used 2020-09-02 deadbeef@webrtc.org Default streams: don't block media even if on different transceiver. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I39029e00fbf7956c52de83996896b8993d9920bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84bd9dade9cb..cba9bbbed68f 2020-09-03 syoussefi@chromium.org Vulkan: Fix resolve-with-subpass retaining resolve attachment 2020-09-03 syoussefi@chromium.org Vulkan: Remove accidental padding in push constants If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1124379 Tbr: cwallez@google.com Change-Id: I0fd8f8fefc572febcba757f6d6ed5f72859875a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391862Reviewed-by:
-
Gavin Williams authored
The histogram Printing.CUPS.UsbSetupSource expired in M85. This needs to be extended as this histogram still gives valuable data. Bug: 1089321 Change-Id: If56cf2004b53530b6d5e10ec043cc01ddd482dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391732Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#804137}
-
Makoto Shimazu authored
Tbr: mlamouri@chromium.org No-Try: true Bug: 1124352 Change-Id: Icd33fe6153b2659cf7ea0e4ded327ecdd0ceff84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390610Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804136}
-
Chih-Yu Huang authored
Originally, we rely on ARC side to determine if the playback is secure or normal by passing a flag at initialization. But we could get the information from the input buffer directly. In this CL, we determine if the playback is secure by querying ProtectedBufferManager with the first input buffer. If we can get the corresponding protected buffer, then we consider the playback as secure. Otherwise, we consider it as normal playback. BUG=b:153608694 TEST=play sintel at Google Play Movie on rammus-arc-r Change-Id: I0e30ca169a36223b9d82854f3382303a68c1ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377040 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#804135}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/683beccf6776..7571f9e49024 2020-09-03 johnstiles@google.com Replace 'typedef xxxxx INHERITED' with 'using INHERITED = xxxx;'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I60377e2dc95e384ed03fda5958d1300c4f6d12af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391052Reviewed-by:
-
Kent Tamura authored
* Fold it into LayoutBox like other form control elements. * Introduce IsSliderContainer() to share identical code between LayoutBox and LayoutTheme. * Move kDefaultTrackLength from LayoutSliderContainer to SliderIntrinsicInlineSize() in layout_box.cc This CL has no behavior changes. Bug: 1040826 Change-Id: I70bb3c67a1fbdc40502e36ca68d890719fc02f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392280Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#804133}
-
Arnaud Mandy authored
These files need to be accessible when running wpt outside chromium environment. see: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#mojojs This is the first step towards making these tests pass outside the Chromium CI Bug: 1123988 Change-Id: Ie151810cdd55e474857670e092a8e036923a8e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390202Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#804132}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ffd1d826be3..46877765c47c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I79a8129c51cc460316fe6281b83551c3d3e8992b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392261Reviewed-by:
-
Hesen Zhang authored
Bug: 1096224 Change-Id: Ic697d934bc1975ef45f446a9bfc3acd713b385cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389540 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804130}
-
Makoto Shimazu authored
This reverts commit 69caa3d0. Reason for revert: AccessibilityFocusHighlightBrowserTest.FocusAppearance looks failing. https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/37326 Original change's description: > Reland "Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest" > > This is a reland of b89144a4 > > Original change's description: > > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > > > AX-Relnotes: n/a > > > > Bug: 1114959 > > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Joey Arhar <jarhar@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803007} > > TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org > > Bug: 1114959 > Change-Id: I1997496df505691103568989a9cbfaa38e4e9b0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388025 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804034} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,aboxhall@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I28f6ebeabe7204a329ff6fd4f42b87312ff9829e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390586Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/c03c18e7fe..930fbec75b Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/c03c18e7fe..930fbec75b Bug: None Change-Id: Ife0309227c5970506a08fa96db6bd79b2e7f8bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391082Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#804128}
-
Kent Tamura authored
This doesn't change rendering behavior, but changes |getComputedStyle(element)['appearance']| results. The new behavior matches to Firefox. Bug: 965432 Change-Id: Id354dd63f0034f2863f594aaf653c624123979b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389880 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kalvin Lee authored
This change implements PpdProvider::ResolvePpdLicense(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdProviderTest.ResolvePpdLicense' Change-Id: I649397270fa45b809f8039fdee7808b55621a8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355008 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#804126}
-
Yuichiro Hanada authored
The mojo call is connected to InputConnection.setComposingRegion() in Android side. Bug: b:163013722 Test: components_unittests Change-Id: I4dd9d76f8788fb76e649fd8418c84ef56c8cc6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352453 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#804125}
-
Meredith Lane authored
AX-Relnotes: N/A Bug: 1025300 Change-Id: I2ec0d66d0d7df2a2d618029e1fc496b642532d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391941 Auto-Submit: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#804124}
-
Jit Yao Yap authored
This CL updates Remote Apps so that the App List is dismissed when launching the app from the context menu. Bug: 1101208 Change-Id: Ic52f2e81bfd458ff3b68db65f14e0188617b2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388285 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804123}
-
evliu authored
This CL updates SODA to take in a path to the language pack direcotry instead of a path to the dictation.ascii_proto config file. SODA will instead choose the appropriate config file to use within the language pack directory. Google3-side changes: cl/326259391 Bug: 1124367 Change-Id: I3ec52682a1d22afe9077a9ddfdb02c054319fa14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391283Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#804122}
-
mhasank authored
session_manager_client uses observer_list which allows reentrancy by default i.e. it allows adding more subscribers while it is firing the events on the observers. One event that causes the problem is when the container is shutdown. When the user is attempts the retry of opt-in flow then we first shutdown the container and then restart the flow by creating a new container. However, when we create a new container, another subscriber is added to session_manager_client and it has not yet completed firing the ArcInstanceStopped event so the new container also is incorrectly detected as shutdown. With this change, we are going to safely invoke the observers and ignore the new subscribers during invocation of events. Currently there are five consumers of the observer interface 1. login_display_host_webui.cc implements OnLoginPromptVisible and plays a sound 2. arc_session_manager.cc implements OnLoginPromptVisible and starts a mini instance. 3. owner_settings_service_chromeos.h implements OwnerKeySet and reloads keys 4. device_settings_service.h implements OwnerKeySet and PropertyChangeComplete and reloads settings 5. arc_container_client_adapter.cc implements ArcInstanceStopped where the problem was occurring initially From the code inspection it is clear that the change should not cause any regression since we're not relying on the same event being fired while handling the event in question for the same instance of container. BUG=b:164816080 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ic820d4f014d5890c68aef99512e38de5acfb0279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381050Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#804121}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7f5e0320..4cac73d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf61f3231a9124373a6f2e548a4931c84988193c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390519Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804120}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3c0e0582acfa..75690ce7ef4a 2020-09-03 sugoi@google.com DescriptorPool error fix 2020-09-03 sugoi@google.com Only use clang specific directives when clang is used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1122889 Tbr: swiftshader-team+autoroll@google.com Change-Id: I430b5305489aeb1087aab664a82cb032bc339292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391834Reviewed-by:
-
Kalvin Lee authored
This change modifies ParseForwardIndex() to account for the presence of licenses in forward index metadata. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: I6af51413dc26d7a8cb213a5bee8be35332b4f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354908 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
MouseEvent.movement() stores the platoform-dependant "Raw mouse motion" values, as reported by hardware. It is currently only available on windows. Support for the value is indicated by the presence of the flag EF_UNADJUSTED_MOUSE. In this CL, we add support for this on CrOS. We intend to use this in order to improve the relative pointer handling in Exo, which requires unaccelerated mouse motion (and currently we only have access to accelerated motion). This change is only implemented for CrOS (for now) because: 1) previously it was only implemented for windows, so cross-platform is not a hard requirement. 2) For our use case, the intended user is zwp_relative_pointer.cc, which is only compiled for CrOS. Bug: 957455 Change-Id: I9b6ca1740dcfb6aaba60c32f268270b3b0d386a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277694Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#804117}
-
