- 17 May, 2018 40 commits
-
-
Reza.Zakerinasab authored
TBR=ccameron@chromium.org Bug: 843401 Change-Id: I455a0147729a473f95c9b9408fdfd4540240a81f Reviewed-on: https://chromium-review.googlesource.com/1064018 Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559531}
-
Yutaka Hirano authored
We basically use request completion time recorded in the render process to calculate responseEnd defined in Resource Timing API. This is problematic because the renderer main thread can be blocked for a long time, and that is confusing users of devtools and Resource Timing API. This CL changes how to calculate responseEnd. With this CL, it will be calculated based on the completion time recorded in the browser process. Bug: 824155, 835502, 843440 Change-Id: I990da586a86c420d21a8115d13e840f7c29d462e Reviewed-on: https://chromium-review.googlesource.com/1053849Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#559530}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=kbr@chromium.org, thakis@chromium.org Change-Id: Ia3735e9ce17759f62b823eb5df3907f00547786c Reviewed-on: https://chromium-review.googlesource.com/1063833 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559529}
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=kbr@chromium.org, thakis@chromium.org Change-Id: I6bbb04f101ce72636ba0d9c151551a42b0480281 Reviewed-on: https://chromium-review.googlesource.com/1063756 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5cc09ffc..ae4ee999 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id8d80176f1726e7f8f2352adf8379fee263c23fc Reviewed-on: https://chromium-review.googlesource.com/1064171Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#559527}
-
Douglas Creager authored
This patch separates ReportingPermissionsChecker class in two, making it clearer which parts belong on the UI and IO threads. The Profile creates an instance of the UI class on the UI thread, and then creates a subsidiary IO instance, which is how ChromeNetworkDelegate actually performs permissions checks. The IO instance as a WeakPtr to the UI instance, since it must delegate to the IO thread to actually perform the check. If the Profile starts tearing down itself (and by extension, the UI instance), the WeakPtr will be invalidated. But importantly, the IO instance will still be well-formed, in case the network delegate is trying any outstanding permissions checks. Bug: 704259 Change-Id: I2b8d437c835a00a90d59aa7e3f39a49d83f511f2 Reviewed-on: https://chromium-review.googlesource.com/1059455 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#559526}
-
Bence Béky authored
Change-Id: I719ea936ce488c7f29c636be6d4892f3a2691170 Reviewed-on: https://chromium-review.googlesource.com/1064013Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#559525}
-
danakj authored
Pass in a context for PrepareSendToParent(). Do ShallowFlushCHROMIUM() directly at the callers of FlushPendingDeletes() instead of going through ResourceProvider. And Finish() after destroying the LayerTreeResourceProvider instead of in the destructor. R=piman@chromium.org, chrishtr Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic303e296a1c5eacb2b05a7134fb3e919ebd32a32 Reviewed-on: https://chromium-review.googlesource.com/1062591 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559524}
-
Denis Kuznetsov authored
Bug: 827323 Change-Id: Iab50342f157c7f77b6df1d6e0748f78de5d55387 Reviewed-on: https://chromium-review.googlesource.com/1047210Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559523}
-
James Cook authored
It is never used. Also remove support for running as a standalone binary, which is also unused. This is more cleanup before landing tests. Bug: 840380 Test: compiles, chrome --show-taps-app works with and without mash Change-Id: Ib6c8e07ca12d1e12072f9af210355be7a12a2a86 Reviewed-on: https://chromium-review.googlesource.com/1062949Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#559522}
-
Kevin McNee authored
As with gesture-pinch-zoom-scroll-bubble.html, it can fail as well as crash. Bug: 787924 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib8adbfaed9a25c49026d1c969f81b49b62c29c14 Reviewed-on: https://chromium-review.googlesource.com/1062214Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#559521}
-
Julian Pastarmov authored
This is supposed to only be used for policies that never saw the light of day but occupy an id. In this case the id has to be kept empty but we don't have to drag a ton of useless code around. BUG=842342 TEST=Manual presubmit tests. Change-Id: Ib07a266be1ad35ed291ac08cf881c6d69b6c22f1 Reviewed-on: https://chromium-review.googlesource.com/1063726 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#559520}
-
Christian Dullweber authored
Migrate SubresourceFilterContentSettingsManager to the new OnUrlsDeleted method and improve deletion of the setting that stores whether the ui has been shown to only be deleted if all urls of an origin have been have been removed. Bug: 839798 Change-Id: I74a9ec6206a07f5925eee8de2a0790976aa09221 Reviewed-on: https://chromium-review.googlesource.com/1063727Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#559519}
-
Tim Volodine authored
This ensures that any metrics recorded before the native library is loaded and intialized are also actually committed. (e.g. this would ensure that UMA like Android.WebView.Startup.CreationTime.Stage1.FactoryInit is properly recorded and available for analysis in dashboard) BUG=817644 Change-Id: I3067842f34513912b9cd2e6ade91d7fc2aa24b34 Reviewed-on: https://chromium-review.googlesource.com/1061529Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#559518}
-
Aldo Culquicondor authored
Getter and setter provided are in tex coordinates Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ic5dbe403a44b28cce4e5c35a0690c501f62c168d Reviewed-on: https://chromium-review.googlesource.com/1062366 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#559517}
-
Max Moroz authored
- Entry regarding coverage missing for some *_fuzzer.cc files. - Note regarding coverage from child processes from the browser. TBR=inferno@chromium.org Bug: 821617,834781 Change-Id: I69a645e3b311ac9c160d878afd518706b3a000fe Reviewed-on: https://chromium-review.googlesource.com/1063995 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#559516}
-
Alexandros Frantzis authored
Add support for using the plane overlay fences provided by the GbmSurfaceless::ScheduleOverlayPlane() method to synchronize display of overlays in Ozone-DRM. This also involves implementing the GbmSurfaceless::SetUsePlaneGpuFences() method to control whether the provided fences are used instead of the internally constructed EGLSyncKHR object. Since the PendingFrame in GbmSurfaceless owns (through GLSurfaceOverlay) the fences used for that frame, some refactorings where required in the frame submission code to keep the PendingFrame alive until the frame is complete. Bug: 828393 Test: ozone_demo --use-gpu-fences on Ozone-DRM Change-Id: Id48485c55d7a31b01858ed5dbbf45815ac54c621 Reviewed-on: https://chromium-review.googlesource.com/1021514 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. (This also enables it on a Windows and some Cast bots; it probably passes on those too.) Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=kbr@chromium.org, thakis@chromium.org Change-Id: I28c59b515fbbd757783ab7c8f54f84557b9c0c67 Reviewed-on: https://chromium-review.googlesource.com/1063729 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Hans Wennborg authored
These tests do pass on some bots, e.g. [1], and it's not clear why they were being excluded. If there's a legitimate reason for them not to run on Android, let's figure it out and get a bug filed. Sheriffs: if this causes the tests to start failing on Android bots, please file a bug with information about the error, put the exclusion back and reference the bug. (This also enables the test on two chromiumos bots. Presumably it passes there too.) Bug: 842698 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343 R=kbr@chromium.org, thakis@chromium.org Change-Id: I4f3febe1247d12a3a19f4f1455bc8c841af52628 Reviewed-on: https://chromium-review.googlesource.com/1063830 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This allows running with the audio service in and out of process. Bug: 843961 Change-Id: I205c1b78997f5cdf40705b8100d90fb08e176fd5 Reviewed-on: https://chromium-review.googlesource.com/1064063 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559512}
-
Rob Buis authored
Exact same test is contained in WPT: wpt/css/cssom/cssom-setProperty-shorthand.html Change-Id: I930f6b9f1c43200392d7c9d120a5d9e58bd44b32 Reviewed-on: https://chromium-review.googlesource.com/1064065 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559511}
-
Guido Urdaneta authored
This allows running with the audio service running in and out of process. Bug: 843961 Change-Id: Id756240c3e3dd3d45d4477f5ff85a35b7d13356c Reviewed-on: https://chromium-review.googlesource.com/1064057 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#559510}
-
Benoit Lize authored
The entry point to the preconnect predictor is in WarmupManager, that correctly handles both the current and new predictors. Initialization still needs to be triggered for CustomTabs, as it otherwise happens after the first page load, which is too late for mayLaunchUrl() to be effective. Bug: 817784 Change-Id: I8dd9a7d41a508954151f7700d2e3fffa9ceb0320 Reviewed-on: https://chromium-review.googlesource.com/1059127 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559509}
-
Finnur Thorarinsson authored
It may have unwanted side-effects in the Action Center and is really a benign failure. Bug: 841475, 837796, 734095 Change-Id: I61cc2736742a50de72fd5a5b9c87ae233ff9a5f0 Reviewed-on: https://chromium-review.googlesource.com/1061414 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#559508}
-
stkhapugin@chromium.org authored
Replaces LeftViewProvider abstract class with an ObjC protocol. Makes LocationBarLegacyView support it directly. This immediately allows cutting the LocationBarControllerImpl middleman for left images, and also allows an ObjC object to accept left images with UI Refresh. Bug: 818637 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id02fae26c98c8c2b2336728723c45194e9470694 Reviewed-on: https://chromium-review.googlesource.com/1057673Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559507}
-
Vadym Doroshenko authored
Other possible username feature was not launched and now Password Manager UI moved in completely different direction (manual fallbacks etc). Since this feature would intervene with the current refactoring it is time to remove it. Removing is done according to comment: https://bugs.chromium.org/p/chromium/issues/detail?id=188908#c9. PasswordForm::other_possible_usernames is left, since it's used for sending username correction votes, all other parts of other possible username feature are removed. Bug: 831123, 188908 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1650d8c37e5c03b20440f002ae7248d3fab40bc7 Reviewed-on: https://chromium-review.googlesource.com/1054674 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559506}
-
Gauthier Ambard authored
The tools menu disabled elements had the standard blue color. This CL makes sure that they have the correct grey color. Bug: 843939 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddbd9e8ea33d329cd5552d77d3acd54db9b5473a Reviewed-on: https://chromium-review.googlesource.com/1064050Reviewed-by:
-
chrome://histogramsMathieu Perreault authored
Now a WebUI message handler. Still keeps the same UI for now, but has potential to be more (see earlier patchsets) Bug: 809820, 788270 Change-Id: I9e2de72540f152ad367098d8255492378bbb28a3 Reviewed-on: https://chromium-review.googlesource.com/890627Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559504}
-
Hajime Hoshi authored
This PR changes these functions to return TaskQueueWithTaskType - MainThreadSchedulerImpl::DefaultTaskRunner() - MainThreadSchedulerImpl::InputTaskRunner() - MainThreadSchedulerImpl::IPCTaskRunner() - IdleHelper::IdleTaskRunner() so that we can know the task types posted to these main-thread task queues, which didin't have any task-type information. Bug: 841172 Change-Id: I7c463437af1dd5478cbbfd39bdc1626ef2e5c3b3 Reviewed-on: https://chromium-review.googlesource.com/1063670Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559503}
-
Philip Jägenstedt authored
https://github.com/w3c/web-platform-tests/pull/10985 changed lint.py and wpt-importer is now failing because of it: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17652 chromium.patch did not apply cleanly, so the changes had to be rebased on the new wpt version. This was much easier within the wpt repo itself, so the patch is changed to apply within the repo. Bug: 843799, 843945 Change-Id: I1ed9895b2461243c38fea552706960a3b99db2b6 Reviewed-on: https://chromium-review.googlesource.com/1061458 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#559502}
-
Bruce Dawson authored
For Windows component builds it is necessary to explicitly share nested classes if those need to be visible outside of the DLL. This change adds such an export in order to get Chromium Windows builds with Perfetto enabled to build. Change-Id: Ia03383a641425e1eb690bb1f0a539473c83f9a32 Reviewed-on: https://chromium-review.googlesource.com/1063870 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#559501}
-
Olga Sharonova authored
Bug: 832666 Change-Id: I2f8104042ba7320998b306f7fdda05af9cf67086 Reviewed-on: https://chromium-review.googlesource.com/1064090Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e50cee06e2ae..c594085d996e $ git log e50cee06e..c594085d9 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 perezju [soundwave] Fix issue with timeseries with missing commit position 2018-05-16 perezju [soundwave] Log exceptions raised by workers Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I538e928e079d8048d30113dd21516f6b1099f036 Reviewed-on: https://chromium-review.googlesource.com/1063990 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559499}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/84d0e6526470..be1ac951607e $ git log 84d0e6526..be1ac9516 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 yunlian Test ThinLTO on peach_pit 2018-05-16 dgarrett chromeos_config: Remove trybot_list. 2018-05-14 achuith cros_run_vm_test: Introduce Run() 2018-05-04 bmgordon cros_sdk_lib: Move chroot functions out of cros_build_lib Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:None,chromium:828749,chromium:809634 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8d7668d4891451a613c52552f203a10c0dbc17f6 Reviewed-on: https://chromium-review.googlesource.com/1063991Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559498}
-
Max Morin authored
This allows us to test both "out of process audio service" and the current code on the waterfall. Bug: 843961 Change-Id: I2b20ffb821c6f1dc01ddbc45365f82e12a87a987 Reviewed-on: https://chromium-review.googlesource.com/1063753Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559497}
-
Finnur Thorarinsson authored
This reverts commit 02a5799e. Reason for revert: Consistent failure of zoom-foreignObject.svg test on Windows 7. See list: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/ Original change's description: > [ForeignObject] Paint foreign objects during the foreground phase of normal-flow > descendants. > > When <foreignObject> was made a stacking context, it also had the side-effect of > painting it at the same time as positioned elements. This is a change to painting > order and caused a regression. Instead, implement a new mechanism by which a > "replaced normal-flow stacking" element paints during the foreground phase > of the LayoutObject paint tree walk. > > This is used for now just for <foreignObject>, but may be applied to other > replaced elements such as iframes or embedded objects in the future. > > Bug:842668 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I450944986abfb6610084444abf2724e7406145cf > Reviewed-on: https://chromium-review.googlesource.com/1060333 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559401} TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org Change-Id: I6742e134dae28a31bcb80fd13eccbc83d03ef332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1064150Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#559496}
-
David Bokan authored
To make implicit root scrollers promote and demote more reliably we need to separate the notion of being a valid candidate from being a valid root scroller. Currently, we build a list of candidates at layout that we restrict to only valid implicit root scrollers. When layout is finished we evaluate this list to determine which of the elements will be promoted. Those that are no longer valid are removed from the list. Unfortunately this doesn't work too well since validity can change for non-local reasons. For example, a parent may change its transform, making its child viewport-filling. Thus, to make this work we'd have to reevaluate candidates and validity everytime virtually anything on the page changes. This patch changes this method to make any currently scrollable element a valid candidate. The list of candidates is maintained by listening to PaintLayerScrollableAreas for when they become scrollable (allow scrolling and have overflow), rather than hooking into layout for every object. This list should be fairly small but it's more stable over the life of a page so we can be more confident it truly contains all the candidates we care about when we get to reevaluating which, if any, should be promoted. Bug: 838683 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6d5c3d876d885fec638b46e992f3026e418737b7 Reviewed-on: https://chromium-review.googlesource.com/1038648 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559495}
-
Ioana Pandele authored
The password export operation saves a temporary file containing passwords locally, in order to pass the data to the consumer app. There are cases in which the file is not removed when the export finishes. Deleting these temporary files when passwords are removed from local storage (keychain) ensures that they are not persisted on the device past their intended removal. Bug:842127 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0e965b41a726240714d209646a9394a35995f9e7 Reviewed-on: https://chromium-review.googlesource.com/1047869 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL passes the "destination"[1] parameter through module loaders. This enables workers/worklets to specify a unique destination defined in each spec. Before this CL, any module scripts are loaded with the "script" destination. After this CL, top-level and descendant module scripts for dedicated workers are loaded with the "worker" destination, top-level and descendant module scripts for documents and dynamic import() are still loaded with the "script" destination though. Module scripts for worklets also must be loaded with their own destination defined in each worklet spec (e.g., "paintworklet"), but such destinations haven't been added yet and the "script" destination is still used. Shared workers and service workers haven't supported module loading yet. Subsequent CLs will address them. Regarding detailed changes, this CL adds the "destination" parameters to components for module loading, stops ScriptResource overriding the "destination", and uses the given "destination" instead. Note that, in Chrome, WebURLRequest::RequestContext enum[2] represents the "destination". [1] https://fetch.spec.whatwg.org/#concept-request-destination [2] https://chromium.googlesource.com/chromium/src/+/a204023d46bc02634f1c6f164cae99d327d53b86/third_party/blink/public/platform/web_url_request.h#73 Bug: 842566 Change-Id: Ib777fcc28de62e1c348ef5c79f97079e5399abaf Reviewed-on: https://chromium-review.googlesource.com/1058734 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#559493}
-
Patrik Höglund authored
The enable_webrtc gn variable has been removed, so ENABLE_WEBRTC is always true now; we may as well remove it. Bug: chromium:800653 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie739a5ddb740a87f434bb12f8a451cd1040596a5 Reviewed-on: https://chromium-review.googlesource.com/1059408 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559492}
-
