- 19 Jun, 2018 40 commits
-
-
Raphael Kubo da Costa authored
TBR=timvolodine@chromium.org Change-Id: I36020efa88606fa42a29c451f3e66164290ba8a7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106139 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#568429}
-
Jeremy Roman authored
Change-Id: Ie0f12a43cc9321b24820e9a23fe676abf4d2f244 Reviewed-on: https://chromium-review.googlesource.com/1105382Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568428}
-
Justin Cohen authored
Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id441f479a233d0aa1cd6c2761da40819e0be2bc2 Reviewed-on: https://chromium-review.googlesource.com/1105998 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568427}
-
Rune Lillesveen authored
EnsureComputedStyle is used to compute style for display:none nodes in an already up-to-date tree. These instances of EnsureComputedStyle in tests broke when trying out changes for issue 831569. Change-Id: I02cc6babcfe1f2193c47673a6a124385c558594a Reviewed-on: https://chromium-review.googlesource.com/1105992Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568426}
-
Christopher Grant authored
This gives the fade in/out effect on the loading progress bar that 2D UI now has. BUG=853821 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3d07e2ea005c0fbaafb9042a257b3eac4979a4e9 Reviewed-on: https://chromium-review.googlesource.com/1104984 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568425}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72566aa8..7edcaa70 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icbe83637d4e3f122e133c842fb147bf4f07cc4a7 Reviewed-on: https://chromium-review.googlesource.com/1105716Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568424}
-
Jeremy Roman authored
Change-Id: Ib0644da4b7b06b3b7fcb7e43e8706cb071667f99 Reviewed-on: https://chromium-review.googlesource.com/1105391Reviewed-by:
-
A Olsen authored
When generating the .reg template, policies that are strings are properly escaped. And for policies that are dicts - the strings inside those dicts are properly escaped eg: {"quote_of_the_day": "\"I'll be back\" - Arnold"} But then the dict as a whole is wrapped in quotes but not escaped. Eg: "{"quote_of_the_day": "\"I'll be back\" - Arnold"}" Note that this string ends immediately due to improper escaping: "{" This affects three policies (that are included in the REG file): ManagedBookmarks, ExtensionSettings and RegisteredProtocolHandlers. The diff in the generated REG file is available internally here: go/chromeregdiff Bug: 834893 Change-Id: Ied752f1f4fea4fdf3a31706080f0e3e9484060e8 Reviewed-on: https://chromium-review.googlesource.com/1104465Reviewed-by:Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568422}
-
Jochen Eisinger authored
BUG=809444 R=blundell@chromium.org Change-Id: Iea99e6e7809faa2f03702bab7a575c8a6c4e17b8 Reviewed-on: https://chromium-review.googlesource.com/1104421 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#568421}
-
kylechar authored
It looks like support was added to mojo to allow for platform specific IPCs. Update mojom::DisplayClient so that platform specific IPCs are only compiled on that platform. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie495671ef90225fecffe07606bbdad3a35c67f78 Reviewed-on: https://chromium-review.googlesource.com/1102558 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568420}
-
Noel Gordon authored
Now the Quick View browser test suite has been optimized for speed, we can finish off by documenting the Quick View test JS. Two test helpers only lack documentation: document what they do. Comment only change: no change in behavior, no new tests. Bug: 851888 Change-Id: If87c49919cdd3bd51fa35f714130fc74fb84b543 Reviewed-on: https://chromium-review.googlesource.com/1105530Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568419}
-
Mohamed Amir Yosef authored
USS requires atomic writes of sync metadata and native model data to guarantee consistency between both. This patch adds the required functionality to persist the bookmarks sync metadata together with the bookmark model. Two methods are added to the bookmark client that allows encoding/decoding metadata. Bookmark model invokes those methods when writing/reading the stored data respectively. A new keyed service is introduced that owns the BookmarkModelTypeProcessor such that there is a run-time dependency from the bookmark model on the new service. This ensures that the metadata stored in the processor outlives bookmark model and hence would be available whenever the bookmark model needs to be persisted. Bug: 516866 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0e24ebf712d3b83130b0338ed72ffb833a78830f Reviewed-on: https://chromium-review.googlesource.com/1094876 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568418}
-
Marc Treib authored
This reverts commit 0d53513f. Reason for revert: Flaky tests, see bug Bug: 854143 Original change's description: > Headless: don't run unload hooks upon web contents close. > > Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05 > Reviewed-on: https://chromium-review.googlesource.com/1105041 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568213} TBR=dgozman@chromium.org,pfeldman@chromium.org,eseckler@chromium.org Change-Id: I252909f78e6d33b98819f6510f780997327a6901 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106077Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568417}
-
Oskar Sundbom authored
Leave portless devices alone. Bug: 853693, b/79580580 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0e505b0f87fdb2b416ca080ad104ea6710e2ec6a Reviewed-on: https://chromium-review.googlesource.com/1104433Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568416}
-
Emilio Cobos Álvarez authored
It's already in a block with if (pseudo_id == kPseudoIdFirstLetter). Just a nit I noticed while seeing the patch for issue 853551. Bug: 853551 Change-Id: Ib4fadc46497c2ed4142f88f9d57938273acf622d Reviewed-on: https://chromium-review.googlesource.com/1105831Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#568415}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b8d38118. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19925 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-conditional yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: Icae359d0cf4f6c466463821019e4b41647aff942 Reviewed-on: https://chromium-review.googlesource.com/1105837 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568414}
-
Raphael Kubo da Costa authored
Commit b47442dc ("viz: Determine fallback strategy in SurfaceAggregator") simplified the code in SurfaceLayerImpl::CreateSurfaceDrawQuad(), but ended up with a construct like this: viz::SharedQuadState* foo = foo = bar(); Simplify the assignment and make it more readable. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88560e1acd1766d4f1676c2aa90b18be32971a60 Reviewed-on: https://chromium-review.googlesource.com/1105829 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568413}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f13bae2df0b8..5ecb02850aa4 git log f13bae2df0b8..5ecb02850aa4 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWaitForElement on Mac Created with: gclient setdep -r src/third_party/catapult@5ecb02850aa4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852931 TBR=sullivan@chromium.org Change-Id: I02d4be752592d1569f0d182fae6dd200df309b71 Reviewed-on: https://chromium-review.googlesource.com/1105102Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568412}
-
Alan Cutter authored
Differences between ComputedStyle for background-image and -webkit-mask-image properties may be due to the StyleImages having different CSSValue instances rather than being different by semantic value. This CL disables the base ComputedStyle equivalency check if either of these properties detect a difference as they can produce false positive assertions. As part of this the FontFaceCache bypass of the base ComputedStyle optimisation was reworked into a bypass of the ComputedStyle check instead for consistency and to allow the optimisation to proceed where it is technically valid to do so. Bug: 781461 Change-Id: I4c28c500819fb75da27130c147f2fbfde2ac93da Reviewed-on: https://chromium-review.googlesource.com/1080366Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#568411}
-
Balazs Engedy authored
TransportListView displays a list of transports over which the user can access security keys. Bug: 849323 Change-Id: Id445b7fea711f8b3e482588cc3d6213e3221d3be Reviewed-on: https://chromium-review.googlesource.com/1097775 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#568410}
-
Egor Pasko authored
The header should be set for all requests originating from nostate-prefetch, main resource, all redirects and all subresources. Using base::BindRepeating in new tests because of presubmit warning, also switched similar tests to it for consistency. Bug: 796855 Change-Id: I90614fac595f2dbc087a6ac99f54e2fc7d37f89a Reviewed-on: https://chromium-review.googlesource.com/1104692 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#568409}
-
Adam Rice authored
The only changes in this reland are to add additional Slow expectations, since two of the layout tests are very slow on MSAN bots. See crbug.com/853977. Originally reviewed at https://chromium-review.googlesource.com/c/chromium/src/+/1097047. Original description: CallExtraOrCrash is a function to call into V8 Extras and crash if it fails. Unfortunately, calling into V8 Extras can fail under normal conditions such as stack overflow and Worker destruction, causing a lot of unnecessary crashes. Remove CallExtraOrCrash. This is a stopgap change designed to be mergable to version 68. It avoids major code restructuring but as a result lacks robust encapsulation. The general strategy is to pass a boolean pointer to functions in ReadableStreamOperations that call into V8 Extras. If the internal call fails, the boolean is set to true, and the call returns a default value. BodyStreamBuffer keeps the boolean as member variable. Once a call to a V8 extra function fails, the boolean is set and no more calls will be made. This is to avoid us taking action based on information that is incorrect. For Tee() and the from-stream version of the BodyStreamBuffer constructor, we use an ExceptionState object instead. In these cases, it is straightforward to pass through ExceptionState object from the Blink bindings. This allows the failure to be propagated safely back to Javascript. Conversely, DefaultReaderRead() has been switched from using ExceptionState to using an error-signalling bool. This is because its callers do not have access to a real ExceptionState object. Previously callers used a NonThrowableExceptionState, but this was not suitable as DefaultReaderRead() can throw. BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so some degree of encapsulation has been retained. 7 new layout tests exercise each of the deterministically reachable crashes, using stack overflows. Because they depend on stack layout and whether DCHECKs are enabled, they only hit the crashes in particular environments. TBR=yhirano@chromium.org,yukishiino@chromium.org Bug: 829790, 849312, 853977 Change-Id: I308ee14ba063f25742eae3cb4c889c3bd50b38d3 Reviewed-on: https://chromium-review.googlesource.com/1105678Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#568408}
-
Philipp Hancke authored
removes assertions that (unneccesarily) assume getUserMedia returns something else than what was requested BUG=836871 Change-Id: If8f52f259ea924bdc9ac68a854c34188f3f56cda Reviewed-on: https://chromium-review.googlesource.com/1105528Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#568407}
-
Hajime Hoshi authored
This reverts commit 18a428ba. Reason for revert: We realized that EventQueueImpl (after merged with MediaElementEventQueue) : target is not 1:1. Instead of EventQueueImpl with a target, each event should have its target. Original change's description: > Add EventQueueImpl::target_ > > This CL is a continuation of > https://chromium-review.googlesource.com/c/chromium/src/+/1088356. > > This CL gives an event target to EventQueueImpl and use it instead of > event->target() so that we can have EventQueueImpl and > MediaElementEventQueue with the same structure. > > Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# > > Bug: 846618 > Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e > Reviewed-on: https://chromium-review.googlesource.com/1098736 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567220} TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846618 Change-Id: Ic2f63364ec2d76d3aef51432d9e4c1258034c867 Reviewed-on: https://chromium-review.googlesource.com/1105653Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Marc Treib authored
The recently-added virtual/user-activation-v2/ needs the same expectations as other suites. While we're here, also update the bug numbers. TBR=mustaq@chromium.org NOTRY=true Bug: 828506 Change-Id: Ic1e7b0e394f1eb93fc265bc17b53eed40aa1b605 Reviewed-on: https://chromium-review.googlesource.com/1105980Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/024eeff4215d..790da37b72f9 git log 024eeff4215d..790da37b72f9 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 saza@webrtc.org Fuzz AEC field trial killswitches 2018-06-19 saza@webrtc.org Remove non-API beamformer references Created with: gclient setdep -r src/third_party/webrtc@790da37b72f9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6481f93beab31e8ef1e437ac25f7dc7114df6662 Reviewed-on: https://chromium-review.googlesource.com/1105103 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568404}
-
Hajime Hoshi authored
We realized that MediaElementEventQueue : target is not 1 : 1. Then, Having MediaElementEventQueue own a target doesn't make sense. This CL enforces to set a target of an event before enqueuing and use it when dispatching. Bug: 846618 Change-Id: Iacc19e6c55040fe05e4883fa33f570b3424650e0 Reviewed-on: https://chromium-review.googlesource.com/1105803Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
David 'Digit' Turner authored
This CL adds a new GN template to specify a set of Android resource files generated by another target's action. The generated files must be stored by the action into a zip archive, with a layout similar to standard Android res/ folder (but note that the archive should not have a top-level res/ directory). + Update java_strings_grd(), java_strings_grd_prebuilt() and jinja_template_resources() to use it. BUG=846633 R=agrieve@chromium.org, estevenson@chromium.org, jbudorick@chromium.org Change-Id: Ibb0ec100d0922ac1ec3155f4577f40136f233b0b Reviewed-on: https://chromium-review.googlesource.com/1104355 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568402}
-
Sylvain Defresne authored
Some client of SigninManagerFactory uses the GetForProfileIfExists method to get the instance without creating it. Add the same method to IdentityManagerFactory. Bug: none Change-Id: I84323808e555c8558576ba614a1b4c6057b2a074 Reviewed-on: https://chromium-review.googlesource.com/1100757Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568401}
-
Ulan Degenbaev authored
This CL adds a new infobar and a new tab helper. The infobar shows a message "The web page was reloaded because it ran out of memory." when a tab running in a bloated renderer is reloaded by the resource coordinator. The resource coordinator notifies the tab helper using a new WillReloadPageWithBloatedRenderer method in WebContentsObserver. After receiving this notification the tab helper shows the infobar on the subsequent DidFinishNavigation event. Bug: 808143 Change-Id: Id32d38cd6f45b30896696026fb71549eb7a570ac Reviewed-on: https://chromium-review.googlesource.com/1072474 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#568400}
-
Ivan Sandrk authored
Bug: chromium:833188 Change-Id: Ie5b219d8af790372e8cdd78d012cd6dce4977ac6 Reviewed-on: https://chromium-review.googlesource.com/1098930 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568399}
-
Nico Weber authored
Change-Id: I96766521324749040f483e18cab94ba96d84daae Reviewed-on: https://chromium-review.googlesource.com/1105523Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The metric tracks the size of all objects allocated in V8 and it is similar to the existing Memory.Experimental.Renderer2.V8 metric. The difference between the two metrics shows fragmentation of V8's heap. The naming scheme is chosen similar to the existing BlinkGC and BlinkGC.AllocatedObjects metrics. Bug: 852415 Change-Id: Id1addec3bc0e09b3a16a16afbec0a634e5c26fe5 Reviewed-on: https://chromium-review.googlesource.com/1101020Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568397}
-
Findit authored
This reverts commit 8828e090. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 568352 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4MjhlMDkwM2U4Y2QxNzIyZDE0ZjI3Zjg3YjgxYTllZWQxOGQ1NWMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7673 Sample Failed Step: chromeos_unittests Original change's description: > [CrOS MultiDevice] Implement PendingConnectionManagerImpl. > > This class creates one ConnectionAttempt per ConnectionAttemptDetails > requested; if more than one request shares the same > ConnectionAttemptDetails, a single ConnectionAttempt attempts a > connection for all associated requests. > > If a ConnectionAttempt successfully creates a channel, this class > extracts client data from all requests to the same remote device and > alerts its delegate, deleting all associated ConnectionAttempts when it > is finished. > > Bug: 824568, 752273 > Change-Id: If9790549157919209e3e96f4a0b11d04fda2870c > Reviewed-on: https://chromium-review.googlesource.com/1103669 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568352} Change-Id: Idd35a8b968324aafbf283868ff79fa49d9f879e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824568, 752273 Reviewed-on: https://chromium-review.googlesource.com/1105897 Cr-Commit-Position: refs/heads/master@{#568396}
-
Marc Treib authored
This reverts commit c45ec0a7. Reason for revert: Seems to have broken services_unittests on Android CFI, see: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/1747 Note that the bot says it timed out, but looking at the failed shard, GeolocationProviderTest.OnPermissionGrantedWithoutObservers and .StartStop fail with: I 212.843s run_tests_on_device(00f19e674463a218) [ RUN ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers I 212.843s run_tests_on_device(00f19e674463a218) ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:177: Failure I 212.843s run_tests_on_device(00f19e674463a218) Value of: provider()->user_did_opt_into_location_services_for_testing() I 212.843s run_tests_on_device(00f19e674463a218) Actual: true I 212.843s run_tests_on_device(00f19e674463a218) Expected: false I 212.843s run_tests_on_device(00f19e674463a218) Stack trace: I 212.843s run_tests_on_device(00f19e674463a218) #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599 I 212.843s run_tests_on_device(00f19e674463a218) #01 0xde0321af /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014311af I 212.843s run_tests_on_device(00f19e674463a218) #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3 I 212.843s run_tests_on_device(00f19e674463a218) I 212.844s run_tests_on_device(00f19e674463a218) [ FAILED ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers (32 ms) I 212.844s run_tests_on_device(00f19e674463a218) [ RUN ] GeolocationProviderTest.StartStop I 212.844s run_tests_on_device(00f19e674463a218) ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:183: Failure I 212.844s run_tests_on_device(00f19e674463a218) Value of: provider()->IsRunning() I 212.844s run_tests_on_device(00f19e674463a218) Actual: true I 212.844s run_tests_on_device(00f19e674463a218) Expected: false I 212.844s run_tests_on_device(00f19e674463a218) Stack trace: I 212.844s run_tests_on_device(00f19e674463a218) #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599 I 212.844s run_tests_on_device(00f19e674463a218) #01 0xde0323b7 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014313b7 I 212.844s run_tests_on_device(00f19e674463a218) #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3 I 212.844s run_tests_on_device(00f19e674463a218) I 212.844s run_tests_on_device(00f19e674463a218) [ FAILED ] GeolocationProviderTest.StartStop (29 ms) Original change's description: > Move geolocation unittests from //device to //services > > This is one step of "moving //device/geolocation into //services". > > BUG=800659 > > Change-Id: I041329923b2cbedab1afd51cc865b278a6a1523a > Reviewed-on: https://chromium-review.googlesource.com/1100694 > Reviewed-by: Ben Chan <benchan@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Ke He <ke.he@intel.com> > Cr-Commit-Position: refs/heads/master@{#568322} TBR=stevenjb@chromium.org,benchan@chromium.org,rockot@chromium.org,ke.he@intel.com Change-Id: I6527e0a42788d033ff8047b9d38ff16102050a55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800659 Reviewed-on: https://chromium-review.googlesource.com/1105877Reviewed-by:
-
Rune Lillesveen authored
::before, ::after, and ::backdrop should be created during style recalc, or they will be created from AttachLayoutTree() if parent needs to create its layout box. ::first-letter is still special because its creation depends on the layout tree and it needs to be constructed in RebuildPseudoElementLayoutTree for the case below when #outer has a ::first-letter, #inner is initially display:none and changes to block: <div id=outer><div id=inner>Text</div></div> This fixes crashers after: https://crrev.com/2d21d004fa5157a1c4409b19e2f808001d026304 Bug: 852396, 853551 Change-Id: Ib58e211defe44a5d2ca04222be5eeb6aecfa59af Reviewed-on: https://chromium-review.googlesource.com/1105055Reviewed-by:
-
Vaclav Brozek authored
Username predictions list text field from a form in a descending likelihood that they are usernames. The predictions are obtained by running a classifier (locally) on the DOM tree containing the form. They are represented as a vector of unique renderer ids of the identified fields. This CL makes the username predictions part of FormData and teaches the new FormData -> PasswordForm parser to use them. FormData serves both address autofill and password autofill, yet username predictions are only relevant to the latter. In this sense, password autofill is polluting the struct for address autofill. However, given the close relationship between the predictions and the actual FormFieldData they refer to, and given the not-so-high overhead of passing around an empty vector (compared to the overall size of FormData), encapsulating the predictions with FormData was chosen as the approach to go with. Bug: 845426 Change-Id: I92ca2eb8d2a24d08541e4878a0732092a473c74f Reviewed-on: https://chromium-review.googlesource.com/1101027 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#568393}
-
Marc Treib authored
TBR=thakis@chromium.org NOTRY=true Bug: 807465 Change-Id: I217899e452758bd531eb800b3ed8ae761f8af4d7 Reviewed-on: https://chromium-review.googlesource.com/1105826Reviewed-by:
-
Sylvain Defresne authored
IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert NTPResourceCache to the new API. Bug: 798408 Change-Id: Ia94e15dd8b50f546a9d6b02957dfefe9d40105e0 Reviewed-on: https://chromium-review.googlesource.com/1097332Reviewed-by:
-
Kinuko Yasuda authored
ResourceLoadScheduler (as a code infra) is already in use for the renderer-side resource scheduler, and is also a basis for stopping loading feature that is gated by other feature flags. This change isolates the ResourceLoadScheduler flag (as a flag) to make it affect only for background throttling, so that separate features built on top of ResourceLoadScheduler can be enabled independently. R=ksakamoto@chromium.org, toyoshim@chromium.org Bug: 837771 Change-Id: I346faf192ff93f2441fe5ed6a82212e76bd34b78 Reviewed-on: https://chromium-review.googlesource.com/1105202Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568390}
-
