Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Jul, 2017 5 commits
    • Changwan Ryu's avatar
      Avoid flicker in the new omnibox inline autocomplete · 880dcbe6
      Changwan Ryu authored 
      The user may see flickering of autocomplete text if onDraw() is called
inside keyboard app's batch edited IME operations.

For example, consider the following sequence of events:

1) beginBatchEdit()
2) commitText()
3) onDraw()
4) endBatchEdit()
5) onDraw()

With current implementation, onDraw() at step 3) and onDraw() at step 5)
may see different getText() because we remove span at beginBatchEdit()
and does not add a new one until endBatchEdit().

In order to ensure that span is added at the end of every IME operation,
even including beginBatchEdit(), the current internal calls to
beginBatchEdit() and endBatchEdit() have been separated out as
onBeginImeCommand() and onEndImeCommand(), respectively. And then
beginBatchEdit() and endBatchEdit() will simply increment / decrement
batch edit count inside these new IME command guards.

And we remove / add span in the IME command guards even when they are
not the outermost ones, to ensure that onDraw() can see the span when
necessary.

Note that notification is not affected thanks to the count guard.

BUG=539536

Change-Id: Ia1f044dd3c2669658dd363e4375f841c9c448f37
Reviewed-on: https://chromium-review.googlesource.com/568914Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Reviewed-by: default avatarAlexandre Elias <aelias@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486169}
      880dcbe6
    • Quinten Yearsley's avatar
      Simplify TestImporter to use LocalWPT to fetch wpt · 2782b490
      Quinten Yearsley authored 
      Now that (1) csswg-test is merged into wpt, and (2) the importer is
given GitHub credentials, it can now be simplified and can reuse the
LocalWPT functionality.

Change-Id: I2f84ceee5f7263cd7ec56cb0dc6d474079dde8d5
Reviewed-on: https://chromium-review.googlesource.com/566060
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: default avatarJeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486168}
      2782b490
    • luoe's avatar
      DevTools: disable spellcheck for inputs by default · c9043ebe
      luoe authored 
      BUG=739258

Review-Url: https://codereview.chromium.org/2972943002
Cr-Commit-Position: refs/heads/master@{#486167}
      c9043ebe
    • scottchen's avatar
      MD Extensions: Show messages for no extensions, and for no search results · 1fcd56bd
      scottchen authored 
      This CL adds messages to tell users when there are no extensions installed, as well as when their search filtering yields no results.

BUG=729863
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2974583003
Cr-Commit-Position: refs/heads/master@{#486166}
      1fcd56bd
    • Wez's avatar
      Update the enable_frame_pointers logic for ChromeOS. · 5cddc222
      Wez authored 
      Now that we have a patch for the ARM A12/A17 errata, it is safe to try
building ARM Thumb without frame-pointers again, since we don't need
them.

We leave frame-pointers enabled in ChromeOS for 64-bit.

The Windows case is tweaked to use current_cpu rather than target_cpu,
and the Android case is explicitly gated on is_android.

Bug: 740806, 711784
Change-Id: I2fff46d1a3a8d78d12c389f95a20acf54013318d
Reviewed-on: https://chromium-review.googlesource.com/567608
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486165}
      5cddc222
  3. 12 Jul, 2017 35 commits