- 24 Jul, 2018 40 commits
-
-
Ned Nguyen authored
In this first attempt, we retry upload the whole perf dashboard data (JSONnizable) for any recoverable error. Subsequent CL may improve this further by splitting up the perf dashboard data to small parts and only try to reupload the parts which the upload failed. This CL also increase the expiration of the oath token generated for each perf benchmark's data to 30 minutes (used to be 1 minutes by default) Bug: 864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If4cb959cc62c5da3baa4a36a5ae91c10ca6d4d02 Reviewed-on: https://chromium-review.googlesource.com/1148228 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577682}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/06235df9ff91..ddd6e8746851 git log 06235df9ff91..ddd6e8746851 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 jmadill@chromium.org Vulkan: Suppress 3 failing blit tests on Pixel 2. Created with: gclient setdep -r src/third_party/angle@ddd6e8746851 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I80ab5a032e4ce8b54f968d63ecc0ff8e255da3dd Reviewed-on: https://chromium-review.googlesource.com/1147956Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577681}
-
Xing Liu authored
The CL changes the gear icon to use the material asset. Bug: 864867 Change-Id: I8f37ec3c15a7173b703d88be7a1a7770398eb83b Reviewed-on: https://chromium-review.googlesource.com/1148892Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577680}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/aebc9e5205dc..fa95e2a7489d git log aebc9e5205dc..fa95e2a7489d --date=short --no-merges --format='%ad %ae %s' 2018-07-24 thomasanderson@chromium.org Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain"" Created with: gclient setdep -r src/native_client@fa95e2a7489d The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ic8df81877221d9f2148f7cb6b45f16490da5f86b Reviewed-on: https://chromium-review.googlesource.com/1147916Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577679}
-
Annie Sullivan authored
Bug: 867066, 867068, 867072, 867075, 867079 Change-Id: Icfc04b761cd6cf43480385f5c838bfb69c039931 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1148945Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#577678}
-
Philip Rogers authored
Backdrop filters are not supported today. This patch makes this clear in the BlinkGenPropertyTrees expectations file so folks do not spend time fixing the tests. Bug: 854189 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I206c40841c9a1992d122206073afa10dd0953625 Reviewed-on: https://chromium-review.googlesource.com/1148896Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577677}
-
Oystein Eftevaag authored
BackgroundTracingManagerImpl::GenerateMetadataDict was checking IsAllowedFinalization() which blocks every preemptive report from getting this metadata added, as it sets a 7-week cooldown on new reports just prior to this. R=etienneb@chromium.org Change-Id: I3bc44958a304397e4eb6a2db66432ec45454d6f0 Reviewed-on: https://chromium-review.googlesource.com/1148776Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577676}
-
Quan Nguyen authored
Bug: 863620 Change-Id: I2d9cef017c3c8c4c2feee99bc4f6913baf11c320 Reviewed-on: https://chromium-review.googlesource.com/1145686 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#577675}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a4e60bb8f49..642c7b758944 git log 6a4e60bb8f49..642c7b758944 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-24 ethannicholas@google.com fixed geometry shaders when canUseFragCoord is false 2018-07-24 caryclark@skia.org handle failing pathop tests Created with: gclient setdep -r src/third_party/skia@642c7b758944 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859705 TBR=benjaminwagner@chromium.org Change-Id: Id2d15a495b85a2c515b0c84b3ca1cd2993fff570 Reviewed-on: https://chromium-review.googlesource.com/1147915Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577674}
-
Oriol Brufau authored
[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /chrome/browser/ Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /chrome/browser/. This should fix bug 866783, resulting from a previous replacement of prefixed properties only in /ui/webui/, because /chrome/ still uses prefixed properties and the inconsistency broke some CSS mixins. Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I73837ed67359b332dfe354d8902a6eff7ed7fede Reviewed-on: https://chromium-review.googlesource.com/1148579Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#577673}
-
Ryan Hamilton authored
Extract QuicServerSessionBasePeer to its own file so that GfeQuicServerSessionPeer does not need to be a friend of QuicServerSessionBase. Change-Id: I8d0b2743f903f3fdfaa06346a9f006fccf78e622 Reviewed-on: https://chromium-review.googlesource.com/1148688Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577672}
-
Edward Jung authored
Bug: 846473 Change-Id: I11e7e6c52cb158c4d2c815cbfab81f0f596317e5 Reviewed-on: https://chromium-review.googlesource.com/1127024 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577671}
-
David Quiroz Marin authored
Some fonts do not set values for all baselines (hanging, ideographic), and in those cases we're setting 0, which is a valid value. This new interface getBaselines(), returns a dictionary with the set baselines and their values. Bug: 277215 Change-Id: Ie94c74d1c95c7205ed47acaed589ae965f0e32f6 Reviewed-on: https://chromium-review.googlesource.com/1141084Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577670}
-
karandeepb authored
This CL removes the unused method Warning::CreateNetworkConflictWarning. It seems to have been introduced in r167673 without any usages. BUG=111700 Change-Id: I4f209bbcabafd0f19203f970dab8341c97a256eb Reviewed-on: https://chromium-review.googlesource.com/1148170Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577669}
-
Fady Samuel authored
This reverts commit 7dc41be6. Reason for revert: activation_dependencies() can change while iterating on updating deadlines or activating late surfaces. Original change's description: > Surface Synchronization: Simplify SurfaceDependencyTracker > > Prior to this CL, SurfaceDependencyTracker read activation_dependencies > from the pending CompositorFrame's CompositorFrameMetadata. This meant > that it had to look up already resolved dependencies. It's more efficient > to use the remaining dependencies set tracked in Surface directly. The code > is also more compact and easier to read. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I97acf5637fd92eaa6485f15601582dc75dd69c35 > Reviewed-on: https://chromium-review.googlesource.com/1148226 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577544} TBR=fsamuel@chromium.org,kylechar@chromium.org,samans@chromium.org Change-Id: I1f3ef525f1de8fab329d86507269ee26b6239675 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1148607Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577668}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c9f1234b1982..315f94a09617 git log c9f1234b1982..315f94a09617 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 tsepez@chromium.org Rename JS_{METHOD,PROP} to JSE_{METHOD,PROP} Created with: gclient setdep -r src/third_party/pdfium@315f94a09617 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6f56ba1a620c7f5af48ff1733c44eeb9e5096729 Reviewed-on: https://chromium-review.googlesource.com/1147914Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577667}
-
Robert Sesek authored
This will eventually allow us to remove all XIB files after MacViewsBrowser is fully launched. This also now instantiates and leaks the AppController directly, rather than it being a top-level object in the NIB. Bug: 832676 Change-Id: I1c8ebdff45a92d4aee0f2a8b253274c03a76611c Reviewed-on: https://chromium-review.googlesource.com/1147157 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577666}
-
Takumi Fujimoto authored
Disable the "Stop" button after it's clicked, so that the user doesn't click on it repeatedly. The button becomes enabled again when there is a model update, or if the user clicks on a sink. When the stop button is clicked for a sink, the sink enters DISCONNECTING state for that dialog, until its route is removed. Bug: 848975 Change-Id: I0acde957053a445fce6bb24cdb54c5e30dd45587 Reviewed-on: https://chromium-review.googlesource.com/1123326 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577665}
-
Rune Lillesveen authored
Pseudo elements match the features of its originating element. We were pushing the selector filter too early causing fast rejection glitches when matching selectors for pseudo elements. Change-Id: I04bc1d7e681ecd6c851bdb3820a9950003e0821d Reviewed-on: https://chromium-review.googlesource.com/1148201 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#577664}
-
Sergey Ulanov authored
Now ContextProvider will run Context process with --disable-gpu. GPU process doesn't work correctly on Fuchsia yet. Bug: 850743, 867052 Change-Id: Ifde22a36beb69f187be07b7fd075a0f8d807bcdf Reviewed-on: https://chromium-review.googlesource.com/1147550 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577663}
-
Ian Vollick authored
This hard-coding should no longer be required. Bug: 839191 Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843 Reviewed-on: https://chromium-review.googlesource.com/1147706 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577662}
-
Ian Vollick authored
Classes in vr_android use types from vr_common. Bug: None Change-Id: I443c169ab0cc4e4914f12f6af7f73b2abf895fac Reviewed-on: https://chromium-review.googlesource.com/1148808Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577661}
-
Xing Liu authored
This CL enables the download location feature as part of the rolling out process. Bug: 792775 Change-Id: I1f5f18d8eeb5c0d2a75c562672980380f2c11c2e Reviewed-on: https://chromium-review.googlesource.com/1145474 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577660}
-
Derek Cheng authored
This reverts commit 9a33e7f8. Reason for revert: Various layout tests failing since https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/64: * fast/forms/select/select-initial-position.html * fast/parser/001.html * fast/table/backgr_border-table-quirks-collapsed-border.html * fast/table/backgr_border-table-quirks.html Original change's description: > [LayoutNG] Change some tests to standard mode > > This patch changes some tests to standard mode. > > They currently fail in LayoutNG, probably due to quirks mode. > Change them to standard mode to see if they still fail. > > TBR=eae@chromium.org > > Bug: 591099 > Change-Id: Ia41cbc42eb1a114a24c4a13411080ee7fae9cf2e > Reviewed-on: https://chromium-review.googlesource.com/1142048 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576330} TBR=eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 591099 Change-Id: I2dad54f85132c54d7edd603e6692c56a112a9a7a Reviewed-on: https://chromium-review.googlesource.com/1148820Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577659}
-
Tessa Nijssen authored
When the user selects a text suggestion from the SuggestedTextTouchBar, the string returned by AppKit API has the necessary trailing whitespace. Currently, when the current editing word is replaced, AppKit's whitespace is added alongside the existing trailing whitespace. This change includes whitespace after a word or the current cursor position into the editing word range. Then, when the editing word is replaced, or the suggestion's text is placed at the cursor, the existing trailing whitespace is also replaced with the suggestion's trailing whitespace. The EditingWordRangeTest in SuggestedTextTouchBarControllerUnitTests was split into multiple tests. A test case was added, WhitespaceEditingWordRangeTest, to test that editingWordRangeFromText:cursorPosition: properly calculates the editing word range as it moves through non-word characters. Existing test cases were modified to reflect the new behavior with regards to trailing whitespace characters. Bug: 717553 Change-Id: Ie0116fc6802ede203dd2adeb691789fa1e4719f3 Reviewed-on: https://chromium-review.googlesource.com/1147335Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#577658}
-
Jay Civelli authored
Removing wait calls from the privet_http_unittest.cc by posting tasks without delay in tests. Also various other clean-ups. Bug: 840390 Change-Id: Iac7d2cd92fcfba269e5edbf81d6df217b14016b6 Reviewed-on: https://chromium-review.googlesource.com/1146485 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577657}
-
wutao authored
This patch handles the foreign tab update in AppSearchProvider, so that the suggested results can be updated in home launcher. Bug: 843839 Test: manual. Change-Id: I4895cdaa475dcb4eaedebada90629eaff6743857 Reviewed-on: https://chromium-review.googlesource.com/1140522 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577656}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dad47a9531e4..68844342e7b7 git log dad47a9531e4..68844342e7b7 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dgarrett@google.com chromeos_config: Remove many dead boards. Created with: gclient setdep -r src/third_party/chromite@68844342e7b7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If14fc85739dc8e5f787b7c8ae5e60f7b3d258967 Reviewed-on: https://chromium-review.googlesource.com/1147913Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577655}
-
mark a. foltz authored
This completes the work to make the Presentation API mojo service part of the Blink public API. Bug: 817903 Change-Id: I9e9cdc4567bb906640eb0ba68375e023f77305dd Reviewed-on: https://chromium-review.googlesource.com/1145782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577654}
-
Alex Moshchuk authored
The goal of this CL is to do a DumpWithoutCrashing if we ever send a proxy creation IPC to the same renderer process more than once. This shouldn't ever happen, since even if the proxy becomes non-live after a process crash and is later recreated, the IPC should go into a newly respawned renderer process. Bug: 794625 Change-Id: I6df34d2582645c8c398b9f6b6ce9c87ba772591d Reviewed-on: https://chromium-review.googlesource.com/1147483Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577653}
-
Derek Cheng authored
This reverts commit 6ec9b32f. Reason for revert: <INSERT REASONING HERE> svg/as-border-image/svg-as-border-image.html / svg/as-border-image/svg-as-border-image-2.html have been failing since https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/65 Original change's description: > [LayoutNG] Remove spaces before <br> to avoid crbug.com/40634 > > This patch removes spaces before <br> because the images do > not match due to crbug.com/40634, which LayoutNG does not > have the problem. > > TBR=eae@chromium.org > > Bug: 591099 > Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49 > Reviewed-on: https://chromium-review.googlesource.com/1142050 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576333} TBR=eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 591099 Change-Id: Iaeae508ed67354b06beec60704fdb0da5021bd34 Reviewed-on: https://chromium-review.googlesource.com/1148807Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577652}
-
Jeremy Newton-Smith authored
assets/cast_config was being accessed. Bug: Internal 111712809 Test: Verified that file descriptors were no longer being leaked when Change-Id: Ide58d71f9f284255cb1d73f3dadae111875be453 Reviewed-on: https://chromium-review.googlesource.com/1148686Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Jeremy Newton-Smith <jeremyns@chromium.org> Cr-Commit-Position: refs/heads/master@{#577651}
-
Rajesh Mahindra authored
To add the functionality of a reverse proxy to the QUIC server, 2 classes were added: 1. QuicHttpProxyBackend: Implements the interface: QuicSimpleServerBackend to fetch the response from a backend server. Creates a proxy thread and manages an instance of net::URLRequestContext within that thread to make HTTP calls to a backend server. 2. QuicHttpProxyBackendStream: Created on a per-stream basis, manages an instance of the class net::URLRequest to make a single HTTP call to the backend server using the context created by QuicHttpProxyBackend. Run As a Proxy To run the quic_server as a reverse proxy, run with --mode=proxy. The param --quic_proxy_backend_url specifies the backend server from which the response is fetched. For instance, ./out/Default/quic_server \ --certificate_file=net/tools/quic/certs/out/leaf_cert.pem \ --key_file=net/tools/quic/certs/out/leaf_cert.pkcs8 \ --mode=proxy \ --quic_proxy_backend_url=http://localhost R=rch@chromium.org, zhongyi@chromium.org Change-Id: I79b7d66eb6bba9628d99181def004c0a5ea2e214 Reviewed-on: https://chromium-review.googlesource.com/1128323 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577650}
-
Rohit Rao authored
When the previous view controller's title is too long, iOS may choose to label the navigation bar's back button with either the word "Back" or to omit the label entirely. Have EG tests search for the back button using all three potential labels. BUG=863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0 Reviewed-on: https://chromium-review.googlesource.com/1148466 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577649}
-
Toni Barzic authored
External loader that loads extension CRXs from the offline demo resources image mounted by the image loader service. It expects that offline demo resources, in addition to actual CRX files to install, a JSON that maps bundled app IDs to the CRX location and app version (in the same format as for other external extensions, e.g. default Chrome OS apps). Bug: 863162 Change-Id: I88aa544be10d74c1ead10a685bb7fd238f18cdd0 Reviewed-on: https://chromium-review.googlesource.com/1134579Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#577648}
-
Chris Blume authored
A few small typos were recently introduced in some comments. This change fixes those typos. No compiled code changed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e3d1e7224fcab1c18d98ed19fd1d50fa6f640cc Reviewed-on: https://chromium-review.googlesource.com/1147073Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#577647}
-
Sergey Ulanov authored
Previously ComponentControllerImpl::BindToRequest() was called twice, so the Context process was crashing. Bug: 850743 Change-Id: I7fe63558afcf586beb1380ce0d108458e1532f9b Reviewed-on: https://chromium-review.googlesource.com/1147551 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577646}
-
Charlie Andrews authored
Based on a try job launched in the linked bug, this story appears to be passing now. TBR=nednguyen@chromium.org Bug: 657433 Change-Id: Id2351f2dd2f763d695a1256c72f6e5aff53677b0 Reviewed-on: https://chromium-review.googlesource.com/1143446 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577645}
-
Robert Sesek authored
The script is no longer used by the signing pipeline and will be removed in https://chrome-internal-review.googlesource.com/c/654803. Bug: 660598 Change-Id: Ia80e4dfbf186c2142b8aff021e3842f87c44a2ad Reviewed-on: https://chromium-review.googlesource.com/1147472Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#577644}
-
David Black authored
We should not show Assistant UI when the Assistant has been disabled in Chrome OS settings. This reverts a change made in: https://chromium-review.googlesource.com/c/chromium/src/+/1141346 Bug: b:111704810 Change-Id: Ic8ede48f0637efbc7520df7e1223964554055aef Reviewed-on: https://chromium-review.googlesource.com/1146151 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577643}
-