- 17 Oct, 2017 40 commits
-
-
Erik Luo authored
This CL pivots the log management UI to use a tree instead of a list. - Introduces SidebarLevelByUrlGroups, which contain SidebarItems - Adding a single message will let groups create SidebarItem children - Sidebar's applyFilter lets Groups choose which children to apply to Some messages have no 'url' such as evaluations, and will be addressed in a future CL. Counters and styles will be introduced in a followup. Bug: 685283 Change-Id: I0335138c89ba3d4ff81dcbb3a88787e8ac0fa395 Reviewed-on: https://chromium-review.googlesource.com/719389 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509554}
-
Sidney San Martín authored
Bug: 764816 Change-Id: If4737e1f144dab5134d91623ec5dc60fc98270b5 Reviewed-on: https://chromium-review.googlesource.com/723900Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#509553}
-
MinChen authored
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/721801 Bug: 774617 Change-Id: I047740cedf056198743eb439b183ecb3b0ce3158 Reviewed-on: https://chromium-review.googlesource.com/723671Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509552}
-
Victor Costan authored
Bug: Change-Id: Ibeb576ba0d6d4edfbda8dd369682f8c08c494248 Reviewed-on: https://chromium-review.googlesource.com/722288 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509551}
-
Wez authored
The builder was brought up with just base_unittests, but we now have most of our current set of targets compiling for ARM64 as well. headless_shell, content_unittests, media_unittests and skia_unittests are not yet built, due to a dependency on third_party/opus, which is currently broken. Bug: 772031, 775272 Change-Id: I67996585207793243e1bcc900ad89ae4014d5385 Reviewed-on: https://chromium-review.googlesource.com/723582Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#509550}
-
Nico Weber authored
Bug: 774209 Change-Id: Ia95ff7b9bb74d4b69067c121d0a95af96331199e Reviewed-on: https://chromium-review.googlesource.com/723941 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#509549}
-
Tibor Goldschwendt authored
Bug: 774636 Change-Id: Id4a7f00be204ef90fab2c9f365ec546d37d5baa2 Reviewed-on: https://chromium-review.googlesource.com/721578 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#509548}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 TBR=reillyg@chromium.org, kbr@chromium.org, rsleevi@chromium.org, thestig@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I160373c241f64d73e12ca6421d849a23a90f9fff Reviewed-on: https://chromium-review.googlesource.com/723786Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit f3f5e27d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 509533 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YzZjVlMjdkYjE2YmU1NWNhZjY0MmIyMjc0ZjhjZmU2ZWIzOGU0ZjQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder%20%28dbg%29/218396 Original change's description: > Allow Chrome on Mac to recognize multiple MFi gamepads > > Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated > by the GameController framework. When multiple such devices are > connected at once, Chrome fails to properly distinguish them. > > GCController exposes a playerIndex field that defaults to the value > GCControllerPlayerIndexUnset (-1). The application may set this field > to a value between 0 and 3 to signal which LEDs should be lit on the > gamepad. Chrome also uses this field to distinguish gamepads, but does > not set the index to a unique value. This causes the first-connected > gamepad to shadow any other connected gamepads. > > This CL ensures each connected MFi gamepad is assigned a unique player > index up to the OS-defined limit of four. > > BUG=775270 > > Change-Id: Ieb852cadc5ff36f94aa1003de3f2e13538114661 > Reviewed-on: https://chromium-review.googlesource.com/723852 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509533} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=775270 Change-Id: Ie8a0af7a186753a385d138080ddb70815d992ae5 Reviewed-on: https://chromium-review.googlesource.com/724165 Cr-Commit-Position: refs/heads/master@{#509546}
-
Scott Graham authored
Fix comment typo in https://chromium-review.googlesource.com/c/chromium/src/+/721570/, and also enable IndexedDBFactoryTest.DataFormatVersion which should now not flake on Fuchsia. Bug: 771701 Change-Id: I7a67bf762cbf171965cb1f2810100945f685327e Reviewed-on: https://chromium-review.googlesource.com/723562 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#509545}
-
Miao-chen Chou authored
This adds the following histograms and their definitions. [Histograms] - BlueZ.AdapterLost - BlueZ.NumberOfExistingAdvertisements BUG=chromium:724720 Change-Id: I44e8cb0df131efff57582d5bbbda7abe2b16a97b Reviewed-on: https://chromium-review.googlesource.com/722076 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#509544}
-
Mike Wasserman authored
Ash is no longer built on Windows. Also cleanup DragDropControllerTest. Bug: NONE Change-Id: I73b3ce606aca98abc6248f7cf8356c6307a785b6 Reviewed-on: https://chromium-review.googlesource.com/723866Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509543}
-
Jamie Walch authored
Bug: 775582 Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c Reviewed-on: https://chromium-review.googlesource.com/723750 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#509542}
-
Scott Graham authored
Currently fails to compile when using neon opts on Fuchsia. Disable for now, since the ARM64 port is just trying to get to the linking/prototype stage. Bug: 768411, 775272 Change-Id: I7adfa8dd97badb1f20ba38b36b5e438e9a7b1ede Reviewed-on: https://chromium-review.googlesource.com/722262Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509541}
-
Kouhei Ueno authored
This CL introduces "V8.CompileHeuristicsDecision" which records which of the script compilation function got picked, providing more insights about how often V8 {code,parser} cache is {produced,consumed,bypassed}. Bug: 769203 Change-Id: I7b27a1634ee5b1623330acae1ef27bc78f39742e Reviewed-on: https://chromium-review.googlesource.com/720660Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#509540}
-
Nathan Bruer authored
This patch is for code health and to make it eassier for followup patches. Simply makes createFile() in Workspace.Project return a promise instead of a callback. R=lushnikov BUG=None Change-Id: If9e0a8d1e24cb01e3a1cba8188d31d4e2b9f61c5 Reviewed-on: https://chromium-review.googlesource.com/720078 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509539}
-
Sammie Quon authored
Bug: 772201 Test: ash_unittests SplitViewWindowSelectorTest.* Change-Id: I2bd02c4cde73247e1260064035401bf5069150ac Reviewed-on: https://chromium-review.googlesource.com/717264 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#509538}
-
Bruce Dawson authored
blink::anonymous::DictionaryTest becomes ambiguous with blink::DictionaryTest in jumbo builds. This renames DictionaryTest to avoid the ambiguity. Build errors look like: third_party/WebKit/Source\core/testing/Internals.h(408): error C2872: 'DictionaryTest': ambiguous symbol third_party/WebKit/Source\core/testing/Internals.h(53): note: could be 'blink::DictionaryTest' third_party/WebKit/Source/bindings/core/v8/DictionaryTest.cpp(18): note: or 'blink::`anonymous-namespace'::DictionaryTest' Bug: 713137 Change-Id: Id13065afdb406808a6fa3a53b958ae976629d850 Reviewed-on: https://chromium-review.googlesource.com/724000Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#509537}
-
Matthew Wang authored
This is needed to support multiple fallback hosts. BUG=742666 TEST=Modified translator and validator unit tests to include checks for ExtraHosts Change-Id: I3faa20fb5d3f3ca490340527ad0a40a7fe9f837a Reviewed-on: https://chromium-review.googlesource.com/720138Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509536}
-
Reilly Grant authored
These tests were disabled because they relied on the AMD module loading path used by the old Mojo JS bindings. Now that they have been ported to the new Mojo JS bindings the tests should pass. TBR=jam@chromium.org NOTRY=true Bug: 758675 Change-Id: I62474d6bc923f4198c22d3c0096d5ce1d2040ced Reviewed-on: https://chromium-review.googlesource.com/723868Reviewed-by:
-
Mathieu Perreault authored
Fighting code duplication, one function at a time! Bug: None Test: Existing Change-Id: If08bc559e667a6ee1e2a51c1ccb552b76ba0006d Reviewed-on: https://chromium-review.googlesource.com/721344Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#509534}
-
Matt Reynolds authored
Chrome for Mac recognizes "Made for iOS" (MFi) gamepads enumerated by the GameController framework. When multiple such devices are connected at once, Chrome fails to properly distinguish them. GCController exposes a playerIndex field that defaults to the value GCControllerPlayerIndexUnset (-1). The application may set this field to a value between 0 and 3 to signal which LEDs should be lit on the gamepad. Chrome also uses this field to distinguish gamepads, but does not set the index to a unique value. This causes the first-connected gamepad to shadow any other connected gamepads. This CL ensures each connected MFi gamepad is assigned a unique player index up to the OS-defined limit of four. BUG=775270 Change-Id: Ieb852cadc5ff36f94aa1003de3f2e13538114661 Reviewed-on: https://chromium-review.googlesource.com/723852Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#509533}
-
Alex Newcomer authored
In the new app list focus design, whenever the AnswerCard WebView is focused, keys are filtered and sent straight to the webview. To fix this, we do not allow webview to be focused. No functionality is lost in this choice. Also in this CL, fix the Accessibility experience of answer cards by: - Make the SearchAnswerWebView's focus behavior Accessible only. - Make the SearchResultAnswerCardView's focus behavior Accessible only. - Make SearchAnswerContainerView's AX Role "Generic Container" instead of "Button", so chromevox knows to look inside the view for the Answer Card's contents. This focus behavior feels exactly like the old model, and improves ChromeVox's ability to see the WebView's elements, where before they could not be discovered by chromeVox. Bug: 763074 Change-Id: I0543c7fb653c0389eda405679fdfec30795da0df Reviewed-on: https://chromium-review.googlesource.com/722059 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Ben Smith authored
Bug: chromium:709179 Change-Id: I5633885b8479beccb0d455ccf40b5817eb6fe8df Reviewed-on: https://chromium-review.googlesource.com/719460Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#509531}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c81dcd5..1319ba43 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I1cd7868b9524b220963752f529e7041cdf278cba Reviewed-on: https://chromium-review.googlesource.com/723920Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509530}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/363dd988a55c..a0020f987e73 $ git log 363dd988a..a0020f987 --date=short --no-merges --format='%ad %ae %s' 2017-10-17 herb Remove some blur tests on google3 until the flag is removed. 2017-10-17 robertphillips Revert "Add unit test for clear bug" 2017-10-17 liyuqian Fix left shift ASAN problem 2017-10-17 bsalomon Revert "Make GPU backend triangulate rects such that they are rendered as tri strips rather than tri fans." 2017-10-17 mtklein set SkJumper_kMaxStride to 16 2017-10-11 halcanary GPU-CTS Program 2017-10-17 csmartdalton Enable CCPR for volatile paths 2017-10-17 robertphillips Add unit test for clear bug 2017-10-17 kramerb Remove unused variable 2017-10-17 reed Revert[4] "apply codec origin in generator" 2017-10-17 bsalomon Make GPU backend triangulate rects such that they are rendered as tri strips rather than tri fans. 2017-10-14 csmartdalton Add sk_InstanceID 2017-10-17 angle-deps-roller Roll skia/third_party/externals/angle2/ bf90b6032..cc8e2738d (6 commits) 2017-10-17 caryclark fix typo 2017-10-17 herb Use combined three pass code for image blur. 2017-10-17 benjaminwagner [Bazel] Separate OS and CPU dimensions in Skia sources. 2017-10-17 liyuqian Add tests that force a specific CPU scan converter 2017-10-17 reed Revert "Revert "Revert "apply codec origin in generator""" 2017-10-16 liyuqian Handle no stash case 2017-10-17 borenet bin/try: Add support for select Chromium trybots 2017-10-17 robertphillips Fix GrContext::writePixels bug 2017-10-13 halcanary experimental/documentation/gerrit: authentication 2017-10-17 rmistry Update chromium bots in update_meta_config.py 2017-10-16 borenet Add Metal compile bot to CQ 2017-10-16 csmartdalton Remove precision from GrGLSLVaryingHandler 2017-10-16 egdaniel Remove uses of sk_sp when passing around GrVkPipelineState 2017-10-16 csmartdalton Refactor CCPR coverage shaders for a vertex impl 2017-10-16 borenet Add bin/try script 2017-10-16 csmartdalton CCPR: Blacklist all of Intel except on Mac 2017-10-16 reed Revert "Revert "apply codec origin in generator"" 2017-10-16 reed Revert "apply codec origin in generator" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ic97b379fb43fadd6be0d0c2c5c6352c44a4cf52c Reviewed-on: https://chromium-review.googlesource.com/723778Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509529}
-
Bill Budge authored
- Adds an UNSAFE_DEVELOPER_BUILD flag too. Bug: chromium:756050 Change-Id: I17bf8fcfb331f3fa11541fed64e9dae48a1c529f Reviewed-on: https://chromium-review.googlesource.com/714443Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- Change SlimmingPaintV2Enabled guarding raster invalidation code to SlimmingPaintV175Enabled - Let raster under-invalidation checking work for SPv175 Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7f42db48a655dad433d9f02474f2dbf5a38a66ad Reviewed-on: https://chromium-review.googlesource.com/699835 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#509527}
-
James Forshaw authored
This CL contains the implementation of the AppContainerProfile and associated tests. Bug: 760977 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I40e8a5b858ca9ad1f0aa28f9165fbb6bbb1485a8 Reviewed-on: https://chromium-review.googlesource.com/712176Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509526}
-
Benjamin Pastene authored
Might help avoid test flakes when a device gets in a bad state. For instance, https://chromium-swarm.appspot.com/task?id=393cd2e8344b7d10 seems like it woulda passed had the device been given a kick at one point in the run. Bug: Change-Id: Ic30374e83d5e9ce73501709bff46d85912b99eb4 Reviewed-on: https://chromium-review.googlesource.com/722037Reviewed-by:
-
Nico Weber authored
Requires teaching the jumbo scripts about .S files. Also fix some minor formatting issues in the jumbo docs. On my Mac laptop, for release component builds: * increases by 536% (from 3.3s to 21s) incremental build times of 'base', after touching base/strings/string16.cc. * reduces by 65% (from 91s to 32s) full build times of 'base' So this looks like something that's useful for full builds and for playing with compiler flags (which requires full builds), but probably not something for daily development. I suppose that's true of jumbo builds in general. Bug: 775547 Change-Id: I9b5157682ee463e5d60499f4dc8815283a127729 Reviewed-on: https://chromium-review.googlesource.com/721139 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#509524}
-
Lei Zhang authored
Explicitly mention there is no need to check the return value to see if it is a nullptr. Most callers already behave this way. Fix the only caller that does not. Change-Id: Ie56395222719c2a31f4fb1db192ec50b88d1b77b Reviewed-on: https://chromium-review.googlesource.com/722321Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509523}
-
Sergey Ulanov authored
Previosly there were no cross-platforms tests for AudioOutputStream. This CL adds new tests that will run on all platforms. The tests are based on Windows-specific tests in media/audio/win. Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 Reviewed-on: https://chromium-review.googlesource.com/702688 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509522}
-
Fady Samuel authored
Prior to this CL, there were two different IPCs that could change device scale factor in the renderer: ViewMsg_Resize with ResizeParams PageMsg_SetDeviceScaleFactor ViewMsg_Resize included a new LocalSurfaceId when surface synchronization is on but SetDeviceScaleFactor did not. Instead of adding more complexity to PageMsg_SetDeviceScaleFactor, this CL removes it and makes ViewMsg_Resize the one way to update the device scale factor in the renderer. Bug: 672962 TBR: tsepez@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2978c56ca7e5ab67a853ea1f0a16f7071074244a Reviewed-on: https://chromium-review.googlesource.com/721851 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509521}
-
Robert Liao authored
This is a mostly automated refactor. BUG=638327 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I9260d87a5b275ff62b40ac90065abc439b4215c7 Reviewed-on: https://chromium-review.googlesource.com/723591 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
Bug: 766934 Change-Id: I3393513c94c691a8cbbab4134cad7a3567290158 Reviewed-on: https://chromium-review.googlesource.com/723821Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509519}
-
Mitsuru Oshima authored
This is reland of https://chromium-review.googlesource.com/c/chromium/src/+/657258, which I introduced a bug when cleaning up the latest patch set. See the diff between patch set 1(original) and and patch set 2 (fixed) Widget should use enclosing bounds because that's what cc uses. However, Views::OnPaintLayer should use scale-corner-points because that's what view computes its pixel bounds. BUG=731771 TEST=covered by unit test. Also manually tested with 1.25,1.5,1.6,1.75 and 2.x dsf. (see bug for repro step) Change-Id: I61c59e55e42b22d7abf9c7cd2b02307f568354b4 Reviewed-on: https://chromium-review.googlesource.com/723723Reviewed-by:
-
John Heroy authored
This change also explicitly restricts ArcIntentHelperBridge::OnOpenUrl from opening chrome:// URLs. Bug: 718617 Change-Id: I21bf7c812f2405d0bbee74b461ee7fa54c9ede2a Reviewed-on: https://chromium-review.googlesource.com/717336 Commit-Queue: John Heroy <jheroy@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#509517}
-
Findit authored
This reverts commit 96754161. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 509495 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzk2NzU0MTYxMzU4YTUyNTdhOThlOGYyZmM1ZTI1OGQyZWQ4MzU4MTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/33798 Original change's description: > ax_dump_tree > > Standalone executable tool that helps developers view IAccessible2 object trees from any application. > This tool is an alternative to AccProbe, which is buggy, and AViewer, which is not feature rich. > The first version of ax_dump_tree is barebones and simply displays events on console, but has > a lot of room for future expansion (e.g., serve info to a GUI, dump the tree structure etc.). > The tool is similar is use to ax_dump_events. > > As an example of how this makes easier, when there is a bug with NVDA/JAWS in Chrome that doesn't > occur with Firefox, we can look at the object tree emitted by Firefox for the same content. > > The ax_dump_tree tool shares code and formatting with the DumpAccessibilityTree browsertests. > > Use as follows: > ax_dump_tree --pid=[processid] > ax_dump_tree --window=[hwnd] (start with 0x to use hex value) > > Bug: 771747 > Change-Id: I330d2aba8b004e679e9a8d15b1c288ae5460e83e > Reviewed-on: https://chromium-review.googlesource.com/700725 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509495} Change-Id: I884d4ee2b277755da5067557f4b771db0bd3340d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771747 Reviewed-on: https://chromium-review.googlesource.com/724001 Cr-Commit-Position: refs/heads/master@{#509516}
-
https://crbug.com/750901Lukasz Anforowicz authored
Bug: 750901 Change-Id: I488198ec1340c0eb7053a159d7699fc049d3443a Reviewed-on: https://chromium-review.googlesource.com/721599 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
