- 16 Jul, 2020 40 commits
-
-
Ian Kilpatrick authored
When we resolve %-based offsets for a relative position child, if its parent is a flex-item we'll read the constraint-space used to generate this fragment, and resolve the %-based offset using that block-size. I.e. https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/layout_box.cc;l=4521;drc=3f50460dcc4c426eb876cd0a1d2838eb35472e18?originalUrl=https:%2F%2Fcs.chromium.org%2F However flex can have two passes, one without a fixed block-size, and one with. If we can determine ahead of time that these would result in the same fragment we'll hit the cache, but the constraint space would be the one without the fixed block-size. In other words, if a flex-item remained the same size between the measure, and layout passes, a relative position grandchild would resolve its %-based offsets incorrectly. This patch introduces *some* logic from another patch current WIP: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 which got reverted for unrelated reasons. Effectively if we have a %-based grandchild like this, we'll miss the cache, meaning that when we later read the constraint space fixed block-size, it'll resolve against the correct size. Bug: 1106074 Change-Id: I5003e4c0903bda408c45f8fb608ad4106c8f22b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302231 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789058}
-
Rushan Suleymanov authored
Reupload will be performed for bookmarks on any remote update (initial and incremental) for entities which don't have the GUID in bookmark specifics. This CL also applies reflection updates in case if remote entity has no GUID in specifics and the reupload is enabled. It will make possible to reupload bookmarks with populated GUID for single-device clients. The whole new logic is behind the SyncReuploadBookmarkFullTitles feature toggle. Bug: 1104171 Change-Id: I6eaacf70b0fd19ba66caa6f6922883be60a8e342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297429 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#789057}
-
Alex Chau authored
Change CHECK to DCHECK to fix "died but not with expected error" Bug: 1106258 Change-Id: I2b2178148e661411fa1590a126538a6d09b81a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301773Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#789056}
-
Robert Kaplow authored
This will actually trim large logs if they cannot be uploaded right away. I'm not sure this is behavior we want, although I presume logs large enough to hit our limits (looks like 100K currently from metrics_reporting_service.cc) are large enough it probably makes sense to trim. Curious if you think this is risky. After writing this, i considered changing the API such that the trimming call and persisting are seperate. Not sure which is better, but trimming at the time of persisting seems like a reasonable place to do it, so left it this way as it is simpler. Bug: 1098317 Change-Id: Ieb72890d45f8ec3735403f5aa5695e6044df0b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257503 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#789055}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8df59bc74ebb..359283989608 2020-07-16 nisse@webrtc.org Add default values for VideoEncoderFactory::CodecInfo 2020-07-16 nisse@webrtc.org Delete obsolete TODO item 2020-07-16 mirtad@webrtc.org Do not use internal source in video send stream tests. 2020-07-16 nisse@webrtc.org Fix override declarations and delete related TODOs 2020-07-16 landrey@webrtc.org Add constrained high profile level for h264 codec to media_constants 2020-07-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4b7890cd..f831fc29 (788759:788907) 2020-07-15 handellm@webrtc.org Remove rtc::GlobalLock. 2020-07-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bc87af3a..4b7890cd (788656:788759) 2020-07-15 mbonadei@webrtc.org Trigger CI bots. 2020-07-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a29ceb78..bc87af3a (788510:788656) 2020-07-15 handellm@webrtc.org Migrate to webrtc::GlobalMutex. 2020-07-15 danilchap@webrtc.org Add factory to create scalability structures by name 2020-07-15 mirtad@webrtc.org Do not use internal source in H.264 bitstream rewriting tests. 2020-07-15 philipp.hancke@googlemail.com sdp: parse and serialize b=TIAS 2020-07-15 nisse@webrtc.org Reland "Delete PeerConnectionInterface::BitrateParameters" 2020-07-15 nisse@webrtc.org Delete CompositeDataChannelTransport 2020-07-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 812a4946..a29ceb78 (788405:788510) 2020-07-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20d0aa1d..812a4946 (788294:788405) 2020-07-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3e578a0d..20d0aa1d (787863:788294) 2020-07-14 daniel.l@hpcnt.com Use Android Q API to test if MediaCodecInfo is HW Accelerated 2020-07-14 danilchap@webrtc.org Delete legacy cricket::RtpHeaderExtension struct as unused 2020-07-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 432e660d..3e578a0d (787714:787863) 2020-07-13 deadbeef@webrtc.org Check for null before accessing SctpTransport map. 2020-07-13 titovartem@webrtc.org Revert "Delete PeerConnectionInterface::BitrateParameters" 2020-07-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f629a87d..432e660d (787611:787714) 2020-07-13 handellm@webrtc.org Migrate stray leftovers from rtc_base/ and test/ to webrtc::Mutex. 2020-07-13 handellm@webrtc.org Reland "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex." 2020-07-13 adetaylor@chromium.org Add CPEPrefix. 2020-07-13 nisse@webrtc.org Delete PeerConnectionInterface::BitrateParameters 2020-07-13 jleconte@webrtc.org Auto roller: send trooper notifications only when Commit-Queue+2. 2020-07-13 nisse@webrtc.org Delete obsolete method JsepTransport::NegotiateDatagramTransport 2020-07-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 598b0954..f629a87d (787511:787611) 2020-07-11 mbonadei@webrtc.org Inclusive language in DEPS. 2020-07-11 mbonadei@webrtc.org Revert "Test luci.notifier." 2020-07-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f0f21185..598b0954 (787142:787511) 2020-07-11 mbonadei@webrtc.org Reland "Test luci.notifier." 2020-07-11 mbonadei@webrtc.org Revert "Test luci.notifier." 2020-07-11 mbonadei@webrtc.org Add target_sdk_version to rtc_test. 2020-07-10 dminor@webrtc.org Check old_vector_size prior to copying in RTPFragmentationHeader::Resize If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104061,chromium:428099,chromium:895969 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d17e3645667acd0f886ee85f9f4a2194529e042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789054}
-
Xida Chen authored
This CL fixes a use-after-free problem in the ThroughputUkmReporter::ReportThroughputUkm. The root cause of this problem is that the ThroughputUkmReporter is freed when this is getting called. Bug: 1105854, 1100868 Change-Id: I514a8012c10680734e97e14b0e731493e9e4eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300402Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789053}
-
Peng Huang authored
When vkAcquireNextImageKHR() may fail, and then VulkanSwapChian::acquired_image_ can be not initialized. In that case, access it will crash. Fix the problem by checking the SwapBuffers() result before accessing it. Bug: 1106049 Change-Id: Idd400bef93e3bb46267f65a23454784e4f7e6680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300766Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789052}
-
Fergus Dall authored
Bug: None Change-Id: I6c478ef8eaf6493052d8cd6bd701247e410db6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299687 Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789051}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/187489319e76..fade2847b875 2020-07-16 tvanderlippe@chromium.org Add documentation for the usage of devtools_{entrypoint,module,pre_built} 2020-07-16 kprokopenko@google.com [issues] Add source location linking to CSP issues of url violation type. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I72a18503d672e389445d00d6642e8408bc7c4b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789050}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cdb0ce794bb7..59d6160bf267 2020-07-16 ahaas@chromium.org [v8][wasm] Centralize collection of events for wasm metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084929 Tbr: oysteine@google.com Change-Id: Ie36f0542ecea6fbc809c4350fe47bb66522d8eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789049}
-
Aaron Leventhal authored
A disabled element can have the selected state, but it is not selectable. In other words, the current selection state should be exposed, but it is not changeable. This change allows the currently selected item in a disabled container widget to be announced by a screen reader. AX-Relnotes: fix for some Google Form results not being read. Bug: 1027275 Change-Id: I885e4b9e9aad928caf458b6bc7880743b1795452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290890 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789048}
-
Tommy Steimel authored
This CL removes kaleidoscope/internal from the gn check op-out list since the gn issues were fixed in crrev.com/i/3167502 Bug: 1106050 Change-Id: Ib4fcb1064a68950560f342c8010a31093560d0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301591Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789047}
-
Brian Geffon authored
This CL contains two very small helpers, the first which takes a VMA and determines based on its properties if it would be eligible for swapping. The second will return a vector of all VMAs which are swap eligible for a given pid. This will be used in the userspace swap mechanism which is coming in a later CL, this is just split out to make reviewing everything easier. BUG=chromium:1067833 Change-Id: Ic60d65105b20dfa54cf221c92f3406016e68fc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298161Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#789046}
-
Javier Ernesto Flores Robles authored
Remove ios/chrome/app/resources/CredentialProvider.entitlements and add Credential Provider entitlement directly to ios/chrome/app/resources/Chrome.entitlements Add UIRequiredDeviceCapabilities plist key to the extension. Bug: 1106045 Change-Id: I4efe0371788e0a44742419ef2a2432e13a162682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302169Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789045}
-
Elly Fong-Jones authored
This change largely migrates the classes in this directory from the older override-based interface to WidgetDelegate to the newer setter-based interface. Bug: 1075649 Change-Id: Ia82d7684ebc138a49107d9e1ec944f6727850d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275494 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789044}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e4e0146560d..0449293b6768 2020-07-16 taylori@google.com perfetto-ui: Show import errors as icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161404000 Tbr: perfetto-bugs@google.com Change-Id: I5ae0f74b5af9e1fb69f8c494753dcaaf9ba01eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789043}
-
Mohamed Amir Yosef authored
Screenshots: Example 1: https://screenshot.googleplex.com/yWX9dnL5eEK.png Example 2: https://screenshot.googleplex.com/76D3hhLNgOH.png Bug: 1100814 Change-Id: Iaa9bb2f2bbf8af375fa9f18833f9f9113822a795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300385 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789042}
-
Etienne Pierre-doray authored
Not used in active investigations and expiring soon. Bug: 1105064, 1105067 Change-Id: I587e2df361526494c0564ab18470d4d3e131e92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300264Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#789041}
-
Chris Sharp authored
It incorrectly referenced impact inputs, but it only impacts outputs. Change-Id: Ie5e655f1075f75ce12a462df306c1d3a651ef1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298259Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789040}
-
Dylan Cutler authored
This will automatically add instrumentation to this field using web IDL bindings code that will be used to determine whether this API leaks info about users' cross-origin identity. You can see a similar CL which annotates other fields of the navigator interface here: https://chromium-review.googlesource.com/c/chromium/src/+/2290052 Bug: 973801 Change-Id: I6215424b9fd517b97a8d226e966e7d771f30a629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295686 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789039}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I50880834ccdb413ed9a42ebd356c1b725dc77712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789038}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=morlovich@chromium.org Change-Id: I6dc40eacd222ec9d022ee13caf8715c92f619f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298841 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#789037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib0d94a7f3515c86ef8e49933509d65cbe4c0044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789036}
-
Sergey Ulanov authored
Previously decoded image cache size was set to 128MB on all devices that have less than 4GB of memory. It's too high for some devices. Reduce it to 32MB in low-end device mode. This is intended for Fuchsia devices that run in low-end mode. This change doesn't affect Android. Also updated non-Android version of the code to use SysInfo::IsLowEndDevice() instead of checking the flag directly. This change has no affect on systems with more than 512MB of memory, so it shouldn't affect supported desktop systems. Bug: 1106046 Change-Id: I2029d7383fc036a5627370a37b3d66ef1752b481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300329Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789035}
-
Olivier Robin authored
When transitioning to active state, call activity handling with active = NO so URL is stored in startupParameters and is handled later in the function. Bug: 1104042 Change-Id: I8ad6ab404db118b03d62b7f5e3f633ba694c3f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299349Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789034}
-
Andrey Zaytsev authored
RequestGenerator::getNumSignedIn() made an incorrect assumption that it was running on the UI thread. Fixed it to match RequestGenerator::getNumGoogleAccountsOnDevice(), which posts the necessary code to the UI thread. Tested manually by having OmahaBase::getRequestGenerator() return a custom version of MockRequestGenerator and checking "adb logcat". Bug: 1070620 Change-Id: Ib04e34ea0b2d7ca2fc64a209731013e6d43fd09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300384 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#789033}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1b9b53a39576..e28cc55cac22 2020-07-16 tommek@google.com Implementing Queue::WriteTexture in Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7e5866e64de1b54bf235dfd4f6202e26b997246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789032}
-
Chris Sharp authored
Bug: 1018157, 1006822 Change-Id: I1b8d72c079f8cf8be1e4defd543f84738531a244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295714 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789031}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I5b53efc7ebd6b9d870c83c883f59279596a0583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295836Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#789030}
-
Adlai Holler authored
This is part of a larger effort to force users to provide the direct context for image manipulations that need it instead of blindly talking to the context that created the image. See bug for details. Bug: skia:104662 Change-Id: I95709c65abeafcb8b1b126b3af3bb787ae970a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299194 Commit-Queue: Adlai Holler <adlai@google.com> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#789029}
-
Eric Leese authored
Bug: 1094436 Change-Id: If17169c8c629c7ad7f87ba86e1d09f6435cf249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289788 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#789028}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594878809-35ea1154d4590798f7d37522056e8d492cada716.profdata to chrome-mac-master-1594899981-52deb7a5a818691ecf42e5c040aa970329d9defe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I5112b4cff06769ef34e9b55fa022a544db2d35fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789027}
-
Oleh Lamzin authored
Move message_pipe.js to component, so it can be reusable for Media App and Telemetry Extension. Bug: b:159927590 Change-Id: I9ea31e3b8c43ae80e7adeef5958c4ac6411fa376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244251 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#789026}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6d8669ad9a0..187489319e76 2020-07-16 jacktfranklin@chromium.org Reland "Ship new ElementsBreadcrumbs to production" 2020-07-16 kprokopenko@google.com [issues] Update protocol by adding source location to CSP issue details. 2020-07-16 tvanderlippe@chromium.org Move copy_inspector_images to Images/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f89a6e6ce57ea07a1331b283f9fa34985628e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789025}
-
Ramin Halavati authored
Since we are not planning to resurruct incognito CCTs anymore, a TODO for using app's name as OTR profile id is removed. Bug: 1023759 Change-Id: I519414964146c608fc2cbc16d7fa2265acd93eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302190Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#789024}
-
Zhongyi Shi authored
Bug: 1103915 Change-Id: Iefbcfefce800d32f2848bf96b7087af87ab99503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301203 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789023}
-
Aaron Leventhal authored
Accessibility is in a good position to review our changes to these files, which will help increase our velocity. NOTRY=true Bug: None Change-Id: I4d86e3f86637c8c912323af71597efe40db06ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298041Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789022}
-
ckitagawa authored
These tests are blocking a Skia update without a good reason. For now they will be disabled. Swapping out the SkPicture directly is non-trivial due to how we used googlestorage and need to update the stored copy when the test isn't live to avoid issues with bots having out of sync data compared to the test. For now I'm just going to disable all the affected tests. Bug: 1106035 Change-Id: I3db25f37c311e951500ce60abe5d61e0fe0b5ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300277Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#789021}
-
Mikel Astiz authored
No behavioral differences: a new struct (SyncErrorInfo) is introduced to centralize attributes that can be inferred from sync_ui_util::AvatarSyncErrorType and that are relevant when displaying the sync info container. Change-Id: I2318613b265135c57c936575216fcecf8bf8a344 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302030Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#789020}
-
Che-Yu Wu authored
policy, and reporting on non-Chrome OS devices. The existing fields in the requests duplicated by the fields in browser_device_identifier will be deprecated and removed in the future. Due to some sync issues, the proto changes were submitted in crosreview.com/2294659, this CL add comments to explain our plan. Bug: 1104858 Change-Id: I65cedb89bd74b77df5f097c8f6867433b52f734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240354 Commit-Queue: Che-yu Wu <cheyuw@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789019}
-