GitLab

Add one UMA for CrossFadeAnimation smoothness, used in maximize windows,
so that we can evaluate how much improvement we can achieve by forcing
use of render surface.

BUG=708513
TEST=has histogram at local device.

Review-Url: https://codereview.chromium.org/2869263002
Cr-Commit-Position: refs/heads/master@{#472191}

This patch prunes a call site of the deprecated function to improve code
health. The change is safe because it is equivalent to hoisting the layout
update from the deprecated function.

BUG=698633
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2883083003
Cr-Commit-Position: refs/heads/master@{#472190}

BUG=722943
TBR=gab
NOTRY=true

Review-Url: https://codereview.chromium.org/2887893002
Cr-Commit-Position: refs/heads/master@{#472189}

BUG=b:38123645
TEST=First run tutorial is started after voice interaction
  OOBE completed broadcast.

Review-Url: https://codereview.chromium.org/2881283002
Cr-Commit-Position: refs/heads/master@{#472188}

BUG=717085
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2884133002
Cr-Commit-Position: refs/heads/master@{#472187}

Avoids allocating the CSSGlobalRuleSet on html import StyleEngines.

Review-Url: https://codereview.chromium.org/2883003002
Cr-Commit-Position: refs/heads/master@{#472186}

Review-Url: https://codereview.chromium.org/2861373004
Cr-Commit-Position: refs/heads/master@{#472185}

BUG=716658,716656
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888493002
Cr-Commit-Position: refs/heads/master@{#472184}

The DisplayReconfigCallback used by GpuDataManagerImplPrivate was
checking if GPUInfo::gpu's vendor or device had changed. This will
never happen, because GPUInfo::gpu is the primary GPU, not the
active GPU.

Add a GPUInfo::active_gpu() function to return the active GPU, and
make DisplayReconfigCallback use this.

Add more instrumentation to ImageTransportSuraceOverlay's
SwapBuffersInternal function, to allow for a more transparent view
into this function.

BUG=712090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2878163002
Cr-Commit-Position: refs/heads/master@{#472183}

This patch adds a stable id into PaintImage. This is stable in the sense
that if the blink::Image that generated the paint image hasn't changed,
then the id would be the same. It's used in a case where either we have
a partially loaded image that finishes loading or an animated image
ticks to a new frame. In those cases, the SkImage unique id is different
since the contents of the image are different. However, the stable id
should remain the same to indicate that it's a part of logically the
same image.

The primary use for the stable id would be to determine whether the
compositor is allowed to checker the image. Specifically, if we have
ever displayed an image stable id X, then all other images with the
same stable id X are not allowed to be checker imaged.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2873003002
Cr-Original-Commit-Position: refs/heads/master@{#471351}
Committed: https://chromium.googlesource.com/chromium/src/+/ae192fde12e7fba4ac2d8f027037d10c3d0f22a4
Review-Url: https://codereview.chromium.org/2873003002
Cr-Commit-Position: refs/heads/master@{#472182}

Since this benchmark is not scheduled on perf waterfall, we move it to the contrib/
directory & set memory-infra as OWNERS.

BUG=720257

Review-Url: https://codereview.chromium.org/2874033005
Cr-Commit-Position: refs/heads/master@{#472181}

Previously, entering/exiting fullscreen whilst the media controls are
hidden due to inactivity would cause the media controls to briefly show
then almost immediately hide again, resulting in an ugly flicker.

They were shown by HTMLMediaElement::UpdateControlsVisibility (called
from HTMLMediaElement::Did{Enter,Exit}Fullscreen) and then hidden again
by MediaControlsImpl::OnTimeUpdate since ShouldHideMediaControls()
returns true.

(This was often masked by the fact that clicking the fullscreen button
with a mouse results in the mouse hovering over the media controls at
the start of the fullscreen transition, in which case it's ok to show
the media controls. It became particularly noticeable with the recent
video-rotate-to-fullscreen feature, which enters/exits fullscreen
without interacting with the media controls, but it can be reproduced
without that feature as well).

This patch renames MediaControls::Show to MaybeShow and makes it only
show the controls if they won't soon be hidden again.

BUG=717520
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2873493004
Cr-Commit-Position: refs/heads/master@{#472180}

This patch is to improve performance of network panel when a domain url
is very long we crop it in order to make scrolling not lag as much.

R=pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2876623003
Cr-Commit-Position: refs/heads/master@{#472179}

Revert of [Autofill] Enable Autofill UKM by default. (patchset #4 id:60001 of https://codereview.chromium.org/2874413004/ )

Reason for revert:
Failing consistently on
chromium.memory/Linux ASan LSan Tests (1)

See crbug.com/722947

Original issue's description:
> [Autofill] Enable Autofill UKM by default.
>
> BUG=718014
>
> Review-Url: https://codereview.chromium.org/2874413004
> Cr-Commit-Position: refs/heads/master@{#472094}
> Committed: https://chromium.googlesource.com/chromium/src/+/06fc093968064421daf828caf503ef5fafb07cba

TBR=csashi@google.com,mathp@chromium.org,sebsg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718014

Review-Url: https://codereview.chromium.org/2888633002
Cr-Commit-Position: refs/heads/master@{#472178}

This CL replaces the use of the --cr-control-spacing with two variables
--cr--control-label-spacing and --cr-controlled-by-spacing. Those two
distances are now required (by UI) to be different values (20px and 24px
respectively). Removing the old variable and using more explicitly named
variables should help avoid confusion about where each should be used.

BUG=721230
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2886603002
Cr-Commit-Position: refs/heads/master@{#472177}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=qinmin@chromium.org

Review-Url: https://codereview.chromium.org/2868393006
Cr-Commit-Position: refs/heads/master@{#472176}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=waffles@chromium.org

Review-Url: https://codereview.chromium.org/2882633003
Cr-Commit-Position: refs/heads/master@{#472175}

This patch:
* Adds reschedule capability to BackgroundTask and BackgroundTaskScheduler
* Updates all implementations of BackgroundTask
* Adds capability to remove all stored tasks from shared preferences
* Adds a call to reschedule from BTSGcmTaskService.onInitializeTasks
* Adds appropriate tests

BUG=710630
R=nyquist@chromium.org

Review-Url: https://codereview.chromium.org/2814653003
Cr-Commit-Position: refs/heads/master@{#472174}

* Add a ScriptForbiddenScope to FrameLoader::Init(), since script shouldn't ever run in Init(). Simplify some callers of Init() that assume Init() might detach the frame.
* Use WebLocalFrameImpl::InitializeCoreFrame in CreateProvisional(), resolving a FIXME there.

BUG=

Review-Url: https://codereview.chromium.org/2869203002
Cr-Commit-Position: refs/heads/master@{#472173}

Stack traces are presented as DEBUG:I, but the previous logcat filter
does not include such logcat.

In this cl, we are including DEBUG:I into the logcat.

BUG=721811

Review-Url: https://codereview.chromium.org/2882793002
Cr-Commit-Position: refs/heads/master@{#472172}

The change in https://codereview.chromium.org/2743253006 stops the Mac
memory pressure monitor from checking the current pressure level
directly on each call to GetCurrentPressureLevel(). However, if the OS
sends a pressure change notification, callers of
GetCurrentPressureLevel() may receive the old pressure level. This cl
fixes the race condition by forcing an internal pressure level update
upon receiving a pressure level change notification from the OS.

R=brettw@chromium.org,mark@chromium.org
BUG=720924

Review-Url: https://codereview.chromium.org/2877573002
Cr-Commit-Position: refs/heads/master@{#472171}

This CL renames the 'name' field to 'mojom_name' on various classes, and introduces Stylizer to map 'mojom_name' to 'name' which now means the stylized name.

The default Stylizer just sets 'name' to the same value as 'mojom_name'. A follow-up CL will add a JavaScriptStylizer.

BUG=718614

Review-Url: https://codereview.chromium.org/2888503002
Cr-Commit-Position: refs/heads/master@{#472170}

This fixes an ODR violation (multiple definitions of a class named
download::MockObserver), and should fix a test failure on the CFI
Linux bot.

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/8068

R=xingliu@chromium.org

Review-Url: https://codereview.chromium.org/2888433004
Cr-Commit-Position: refs/heads/master@{#472169}

BUG=706118

Review-Url: https://codereview.chromium.org/2877073002
Cr-Commit-Position: refs/heads/master@{#472168}

This CL is a follow up to https://crrev.com/2877273002, where tests
could not be renamed due to some platforms' file systems being case
insensitive.

Here we Rename a few tests:

- getphotocapabilities.html => getPhotoCapabilities.html
- setoptions.html => setOptions.html
- takephoto-with-photosettings.html => takePhoto-with-PhotoSettings.html
- takephoto.html => takePhoto.html

**No new code.**

TBR=emircan@chromium.org

Bug: 718765
Change-Id: I4dc03a95a86a43a4422f3d2311ed163322d656ba
Reviewed-on: https://chromium-review.googlesource.com/506506Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472167}

BUG=701939

Review-Url: https://codereview.chromium.org/2872933003
Cr-Commit-Position: refs/heads/master@{#472166}

It had been flaky after https://codereview.chromium.org/2872423002/
which defined PaintInvalidationReason::kImage for invalidations
caused by image change. The test sometimes produced "full" and
sometimes produced "image" as the invalidation reason of the image.
The flakiness might be because of arbitrary timing of image animation.

- Add image onload handler to start the test;
- Advance image animation twice to avoid flakiness.
- Convert it into a ref test.
- Increase the size of the image to avoid the layout from being
  affected by different font sizes on different platforms.

BUG=722131

Review-Url: https://codereview.chromium.org/2882873002
Cr-Commit-Position: refs/heads/master@{#472165}

Mocks are here https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZfSHzqDNTRuU/files/MCFvOc4T9u7Awmru3H3e7QDjwMSJbxAVNpw. (page 11/12)

Moves setup pin error/warning message inside pin keyboard element.Have not received positioning/sizing details. But this CL covers the functionality.

Screenshots:
https://screenshot.googleplex.com/qsWXoWteyDr

TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest.*
BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848483002
Cr-Commit-Position: refs/heads/master@{#472164}

Removes problematic usage of iron-a11y-keys and replaces it with a
simpler on-keypress handler.

Also fixes a bug.

BUG=721256
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=MANUAL

Review-Url: https://codereview.chromium.org/2882143003
Cr-Commit-Position: refs/heads/master@{#472163}

SizeInfo.symbols is now Clustered() by default.
SizeInfo.raw_symbols is now a SymbolGroup rather than a list.

Clustered() now uses GroupedBy() and cluster_symbols.py is no more.

BUG=681694

Review-Url: https://codereview.chromium.org/2885073002
Cr-Commit-Position: refs/heads/master@{#472162}

This is currently implemented for Group by Product only and hidden behind
an experiment.

BUG=718655

Review-Url: https://codereview.chromium.org/2882343002
Cr-Commit-Position: refs/heads/master@{#472161}

This CL adds the origin url to the notification body (if one exists),
similar to how Chrome notifications do currently.

This is one of the requirements specified in [1] (Google only).

[1] https://docs.google.com/a/google.com/document/d/1cqXPpIyCf1RaEYx9XCPjZbO6U5oDeyslajznnG9wd_U/edit?usp=sharing

BUG=676220
R=peter@chromium.org,thestig@chromium.org
TBR=mukai@chromium.org

Review-Url: https://codereview.chromium.org/2876603004
Cr-Commit-Position: refs/heads/master@{#472160}

Previously, Enter keypresses on the close icon could trigger the
whole dialog's default Enter handler.

This CL prevents that.

BUG=719387
TEST=MANUAL
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2884113002
Cr-Commit-Position: refs/heads/master@{#472159}

go/phishguard-uma

BUG=720172

Review-Url: https://codereview.chromium.org/2869253002
Cr-Commit-Position: refs/heads/master@{#472158}

Pre-requisite to suppress message_loop.h from run_loop.h (issue 703346).

A similar include fix for message_loop.h was done in r471412 but some
targets are the removal as it looks like they properly didn't need
message_loop.h but were relying on it to get task runner includes...

The reasoning for this is the same as was once done in https://codereview.chromium.org/2443103003
(it was then done only on targets that failed to compile instead of via script):
scoped_refptr<Foo> requires full type of Foo to be defined not just fwd-declared.

Script used:

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  if not 'TaskRunner' in content:
    return False

  # Assume fwd-decls are correct in first pass.
  if 'class TaskRunner;' in content:
    return False
  if 'class SequencedTaskRunner;' in content:
    return False
  if 'class SingleThreadTaskRunner;' in content:
    return False

  # Using base:: prefix ensures we don't match fwd-decls and other things.
  # Will require a few fixups for missing includes in //base proper.
  # Complex prefix in regex attempts to skip comments.
  matches = re.compile(r'(private:|protected:|public:)|(\n *[^/\n][^/\n][^/\n]*base::(Sequenced|SingleThread)TaskRunner\b(>&|\*)?)', re.DOTALL).findall(content)

  if not matches:
    return False

  # Ignore instances in private sections (probably members or worst case methods
  # only used by impl which must include header already).
  in_private_section = False

  found_task_runner = False
  found_sequenced_task_runner = False
  found_single_thread_task_runner = False
  for match in matches:
    if match[0] == 'private:':
      in_private_section = True
      continue
    if match[0] == 'protected:':
      in_private_section = False
      continue
    if match[0] == 'public:':
      in_private_section = False
      continue

    # Otherwise match[0] was empty and we have a match[1] for the main thing.
    assert not match[0]

    # Only want to add the include if we don't have a match[3] (which indicates
    # this match is for a ref or a pointer).
    if match[3]:
      continue

    # Not a ref nor a pointer, count it if not in a private section, match[2]
    # tells which TaskRunner type it is.
    if not in_private_section:
      if not match[2]:
        found_task_runner = True
      elif match[2] == 'Sequenced':
        found_sequenced_task_runner = True
      elif match[2] == 'SingleThread':
        found_single_thread_task_runner = True
      else:
        assert False

  updated_content = content

  if found_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/task_runner.h")
  if found_sequenced_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/sequenced_task_runner.h")
  if found_single_thread_task_runner:
    updated_content = refactor_lib.AddInclude(file_path, content, "base/single_thread_task_runner.h")

  if updated_content == content:
    return False

  # Write updated file
  refactor_lib.WriteFile(file_path, updated_content)

  return True

TBR=gab@chromiu.org
BUG=703346
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884763002 .
Cr-Commit-Position: refs/heads/master@{#472157}

Now that change to expose resources to Robolectric tests has
landed, I wanted to update the documentation to point out to
people they need to specify "package_name" GN variable to get
it to work (since that is definitely not obvious).

You can also (theoretically) now specify the AndroidManifest.xml
file to Robolectric (Robolectric will grab the package name from
there). However, no tests currently do this.

Review-Url: https://codereview.chromium.org/2882243003
Cr-Commit-Position: refs/heads/master@{#472156}

This sets a preferred size which will override the one provided by the
layout manager or a subclass's GetPreferredSize override. It also
renames the override-able function to CalculatePreferredSize and makes
it protected. Eventually all GetPreferredSize overrides should be
renamed.

This patch also gives precedence to LayoutManager::GetPreferredSize
over View::CalculatePreferredSize, although this distinction probably
rarely crops up.

BUG=none

Review-Url: https://codereview.chromium.org/2881183003
Cr-Commit-Position: refs/heads/master@{#472155}

Move document.fonts to a mixin instead of partial interface.

Per spec: https://drafts.csswg.org/css-font-loading/#font-face-source

BUG=722511

Review-Url: https://codereview.chromium.org/2884053002
Cr-Commit-Position: refs/heads/master@{#472154}

The separator is positioned based on the layout of the label. Previously
we forgot to account for the width of the separator when laying out the
label, so in effect the label was 1dip too wide and the separator was
1dip too far to the right.

This only affects DSFs <2.

BUG=721741

Review-Url: https://codereview.chromium.org/2883843004
Cr-Commit-Position: refs/heads/master@{#472153}

Fixed IAccessible::accNavigate for NAVDIR_NEXT and NAVDIR_PREVIOUS when start object was a simple child and added extensive tests.

BUG=722148
R=dmazzoni@chromium.org, dougt@chromium.org
TESTED=unit tests, NVDA's navigator object cursor

Review-Url: https://codereview.chromium.org/2877313003
Cr-Commit-Position: refs/heads/master@{#472152}