- 20 May, 2019 40 commits
-
-
Mihai Sardarescu authored
This CL updates the bookmarks earl grey test to run with unified consent feature enabled. It also adds the bookmarks earl grey tests to the list of tests that are run on the unified consent enabled bot. This CL also fixes the test testSignInPromoWithWarmStateUsingPrimaryButton that was actually tapping the secondary sign-in button (not the primary one), and thus was a duplicate of testSignInPromoWithWarmStateUsingSecondaryButton. Note: There are a significant number of earl grey tests for bookmarks, so this CL will significantly increase the time it takes to run the tests on the ios-simulator-full-configs bots. However the unified consent enabled bot is temporary and the current plan is to remove it once unified consent feature is enabled by default. Bug: 960260 Change-Id: I6a998fb29b1dd352c37dcc9ace516a0254b804e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617513 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#661347}
-
Yi Su authored
This CL moves WKNavigationDelegate.didReceiveServerRedirectForProvisionalNavigation from CRWWebController into CRWWKNavigationHandler. CRWWebController.didReceiveRedirectForNavigation:context is also moved into CRWWKNavigationHandler and temporarily exposed as a public method. It will be removed when WKNavigationDelegate.didCommitNavigation is moved into CRWWKNavigationHandler. Bug: 956511 Change-Id: I27e8d994544a1e54bdf46a39e3114b1195064296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617827Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661346}
-
Jordan Demeulenaere authored
* Before: https://screenshot.googleplex.com/hmVvTEU3Bg7.png * After: https://screenshot.googleplex.com/Cp3bg0Wqt7m.png Screenshots: Change-Id: I3c3563eb895fde6a0fd86ab25625eb68aa0ce598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617828Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#661345}
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. Bug: 959157 Change-Id: I0fd318d8034fb1294336f7534eb672fd1faeb084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611996Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#661344}
-
Eugene But authored
README says: "This directory contains API to search for text on a web page. This directory does not support any UI API except content highlighting." Bug: 942244 Change-Id: I8e683ac1a99783becf39fbc7f8bd61017c017641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619209 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#661343}
-
Vadym Doroshenko authored
This CL reproduces the same behaviour with NewPasswordFormManager as for PasswordFormManager. Bug: 831123 Change-Id: I7ade6f857adfb1d4ec09a8a4333f4e90e9e485b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619688Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#661342}
-
Robbie Gibson authored
There are two areas to improve our flag handling. First, the default iOS keyboard replaces two dashes with an em dash, so typing that in as a flag is difficult. Second, all flags start with dashes, so the code can fallback to add them if they don't exist. Bug: 964930 Change-Id: Ifeee11343381b7a8587499512fab1c3f78ba7548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617839 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#661341}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9dfd4b835807..47741f05043a git log 9dfd4b835807..47741f05043a --date=short --no-merges --format='%ad %ae %s' 2019-05-17 kpet@free.fr Validate OpenCL memory and addressing model environment rules (#2589) 2019-05-16 33432579+alan-baker@users.noreply.github.com Validate construct exits (#2459) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@47741f05043a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I5d89ae5309cd8d3a201ffb88a62ae722719cf646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661340}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6e384fef6c0f..27ec91958501 git log 6e384fef6c0f..27ec91958501 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 johnkslang@users.noreply.github.com Merge pull request #1768 from ShabbyX/enable-opt 2019-05-16 johnkslang@users.noreply.github.com Merge pull request #1767 from dneto0/update-spirv-headers Created with: gclient setdep -r src/third_party/glslang/src@27ec91958501 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I25856edfeee1b584aa9a0363f4fb686e13789eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619655Reviewed-by:
-
Clemens Arbesser authored
This fixes a bug where the AA payment request would sometimes show two dividers between sections, resulting in a thicker divider than intended. Before: https://screenshot.googleplex.com/WhYYQmeOTsX.png After: https://screenshot.googleplex.com/noR3SYyy2ts.png Bug: 806868 Change-Id: I94fc47d92c7f46a488d65c64f29e13e137b131d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619790Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661338}
-
Juan Antonio Navarro Perez authored
This benchmark is no longer used and was replaced by the analyze_metrics_ct.py script. Also removing no longer used dependencies: - LocalTraceMeasurement, a TimelineBasedMeasurement only used by this benchmark; - CTBrowserLessPageSet; and - SharedBrowserlessStory. Bug: 840428 Change-Id: I3f681c168ce3e46a8b51bfc49ae781b3b871add5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619806 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#661337}
-
Robert Sesek authored
This will copy KeystoneRegistration as a versioned framework now, whereas previously the script removed the versioned symlink structure. Bug: 955936 Change-Id: Ida89ce2add6f01712b271f228399817b8b98c19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603663Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661336}
-
Bruno Santos authored
This interface will be expanded to proxy calls to IdentityAcessor so that we have more control over what is called and be able to record metrics. Bug: 927809 Change-Id: Ifb33c170b17b8ab7e3dbcb89a5fc47288f73814a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615441Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#661335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86c236cc. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" c4fa33ec "CSS: WPT for scroll-padding computed value" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I611f3371be6c1db3395df3709480fd241b005819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619206Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661334}
-
Sergio Villar Senin authored
WebThreadSupportingGC is mostly wrapping blink::Thread. Code should use scheduler::WorkerThread instead. The first step consists in moving MemoryPressureListenerRegistry's RegisterThread/UnregisterThread() to WorkerThread. In order to do that we have to add a new thread creation parameter to decide whether or not the new thread will support garbage collection or not. Bug: 961743 Change-Id: I662cd31f24f8dc2d47697ff026251b80b31cbe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611985 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661333}
-
Antonio Gomes authored
This CL is the second step to Onion soup content/renderer/media_capture_from_element/. At this time, html_video_element_capturer_source.cc|h|unittest are moved. It was preceded by the following preparation CLs [1], [2] and [3]. [1] crrev.com/c/1612104 [2] crrev.com/c/1611781 [3] crrev.com/c/1617324 Notes: - CL moves media::AddVideoTrackToMediaStream() to be a helper function in /blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc. Reason: It was only used there. - After Onion souping html_video_element_capturer_source.cc, the CL removes the respective blink::Platform::CreateHTMLVideoElementCapturer hook. - Some banned base::Bind calls were replaced by their respective Blink counterparts. - The use of base::GenerateGUID was replaced by Blink's CreateCanonicalUUIDString. - Use of ScopedTaskEnvironment is not needed anymore, hence removed. BUG=787261,714018 Change-Id: Ia9f040d7477fedebb3497bcb35fc08de191ef73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617325Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7676d01d0f8b..5009f37bf713 git log 7676d01d0f8b..5009f37bf713 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com perfetto-ui: Update npm packages Created with: gclient setdep -r src/third_party/perfetto@5009f37bf713 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If2d57fb8f7bc07213db0ceecc42f5234fd2e79c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619651Reviewed-by:
-
Mihai Sardarescu authored
This CL updates earl grey tests to work with Unified Consent feature enabled on iOS. It also runs all first run ui earl grey tests on the ios_chrome_unified_consent_egtests bot. Bug: 960260 Change-Id: I537e2c3b3c8b096d7ca0acb600eb362cbca38c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609905Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#661330}
-
mrefaat authored
This CL: 1- Replaces TabModelObserver by WebStateListObserving protocol and implements DidRemoveWebState in MainController. 2- Changes the BrowserViewWrangler to take a WebStateListObserving Delegate instead of TabModelObserver, and use a separate observerBridge to track the delegate observer. Bug: 911350 Change-Id: I627df2fe7b76fd298a2c52b5f41e053b2146bc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600261 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af03ff75d3a7..6fbc2c914856 Created with: gclient setdep -r src-internal@6fbc2c914856 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I22488da93328a4a24c2c4c318eb357e5b412c91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661328}
-
Kent Tamura authored
Add support of disabledFeatures=['shadow'] in a custom element definition. It disables Element.attachShadow(). Specification PR: https://github.com/whatwg/dom/pull/760 The behavior is behind "ElemnetInternals" runtime flag. Bug: 905922 Change-Id: Ib950883b5c995945eb60bf9b92c715ad3996dfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609022 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#661327}
-
Tsuyoshi Horo authored
I submitted crrev.com/c/1619582 before fixing misspelling. TBR=ksakamoto@chromium.org Bug: 935267 Change-Id: I7611ccabbf05bbc6d7139efde3a1275537abf16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619592Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661326}
-
Fredrik Söderquist authored
Change-Id: Ibed70c17d5ba2bb9a9073e5b6174896744064a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619689 Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#661325}
-
Robbie Gibson authored
This CL adds the G icon as a fallback icon for answers with no more specific icon. It also renames the "currency" imageset to "stock" as that icon is actually used for the stock price suggestion, not the currency conversion suggestion (which uses the "conversion" icon). Bug: 963860 Change-Id: I446a07cbab6b1a5ab0a38629947d09e17522499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614219 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661324}
-
Mathias Carlen authored
Before this patch, we kept adding new observers to the list of cache data observers when closing the app (without the app being destroyed). Resuming the activity by triggering another run would reuse the existing profile cache and the default profile image was shown. This patch introduces a destroy() function to the header coordinator so that it can clean up internals when we go out of scope. In particular it removes the profile data observer registered in the constructor. Bug: b/132379462 Change-Id: I96c473b6748bd8b7105cab58bfdb497411e6f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609779 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adf1af3d. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib989922e053045fad4fc79be505077aac5d4d6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619334Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/866576d99019..7676d01d0f8b git log 866576d99019..7676d01d0f8b --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com Merge "perfetto-ui: Remove search" Created with: gclient setdep -r src/third_party/perfetto@7676d01d0f8b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I93a2e10c1cd8e6ce85d06d1ed0aa326a7271f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619645Reviewed-by:
-
arthursonzogni authored
It used to return the routing_id of the RenderFrameProxyHost for which a RenderFrameProxy was initialized. This is a bit arbitrary and as a result, among 6 callers, nobody was using it, except BrowserPluginHost. It is probably better to return nothing instead. Bug: None. Change-Id: Idcc46d469f3eae53cabd5d09fa29636165804b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614177 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#661320}
-
chrome://flags#enable-sxg-subresource-prefetchingTsuyoshi Horo authored
Bug: 935267 Change-Id: Ibec8974f52a703ac3930517ce3a9de0bfb13f94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619582Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661319}
-
Koji Ishii authored
Following r659675 (crrev.com/c/1612219), this patch guards |FirstLineBoxTopLeft()| from when the layout tree is dirty. Normally, all calls are limited to only when layout is clean. However, scroll anchoring reads fragment data from dirty tree after r660998 (crrev.com/c/1615680). Ideally, we'd like to guard |FirstInlineFragment()| instead. This aligns the concept of r659675, but ~10 tests in AX and scroll anchoring depends on reading dirty trees. This indicates that there are cases where we want to read dirty trees. What to do more for reading dirty tree is for future investigations. Bug: 964619, 963103, 964854 Change-Id: I7ed4f9aac554f27ab8c2848a6d0b09a1e070215e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619512 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#661318}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b6e788f138b..af03ff75d3a7 Created with: gclient setdep -r src-internal@af03ff75d3a7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I7ed0197f739bc9b614837a9c73e5704a2b755ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619643Reviewed-by:
-
Eric Willigers authored
'left' and 'right' values for the 'text-underline-position' property shipped in M71. https://www.chromestatus.com/features/5749634488074240 The flag TextUnderlinePositionLeftRight has been enabled since https://chromium-review.googlesource.com/1226485 BUG=313888 Change-Id: I893bbc0d402439a092c96d39b629dd8c94627622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616832Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#661316}
-
Eric Willigers authored
Inheritance, parsing and computed value tests for background-position-x, background-position-y https://drafts.csswg.org/css-backgrounds-4/#background-position-longhands BUG=964885 Change-Id: I55630b41918557be536f28e3eb640bb3fc803c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614007 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661315}
-
Yoshifumi Inoue authored
This patch converts use-after-tree to CHECK() by changing Element#innerText to cause CEHCK() instead of DCHECK in StringView constructor to avoid use-after-tree. Note: We are not sure of root causes both use-after-free tree and wrong StringView constructor call. Bug: 964464 Change-Id: If4d289c8f6fe4072c1869553cd952d0c153a3369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619510Reviewed-by:
-
Ren-Pei Zeng authored
The size of SharedMemoryHandle is now checked when mapping, so we should pass correct buffer sizes in JEA. Bug: b:133119111 Test: Take picture and check HW encoding works from /var/log/messages. Change-Id: I30c95e85a329f95083ae16cf3383ff3377e53409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619517Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661313}
-
Takashi Toyoshima authored
UMA_HISTOGRAM_COUNTS_10000 was to small for measuring total memory pressure in bytes. 10M or larger range would be preferable. Bug: 961602 Change-Id: I4e94ca973d65a74860cd16a0d424e1ea128a39b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619452 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#661312}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82728b140ee0..866576d99019 git log 82728b140ee0..866576d99019 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com Merge "perfetto-ui: Replace query with fast version" 2019-05-20 taylori@google.com Merge "perfetto-ui: Fix performance issue when opening panels" Created with: gclient setdep -r src/third_party/perfetto@866576d99019 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I99aabbc59f9025dabf2e888c46a9d68e4ced3a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619644Reviewed-by:
-
Eric Willigers authored
https://drafts.csswg.org/css-logical-1/#propdef-inset-block Change-Id: I32ba1428ab52ce8003add1fb5b0b4d4d17cfea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615402Reviewed-by:
-
Peter K. Lee authored
Change-Id: I6dedc52a8f0eb4ff4bd0186158485bd15671e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618316 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed2255b4ea13..f4c66ccafcb7 git log ed2255b4ea13..f4c66ccafcb7 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 06de90c66c18..70958d15db70 (8 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5ca9f956..4dc9df3b (533 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ab1e2b49fe88..7ab65834bc02 (24 commits) Created with: gclient setdep -r src/third_party/skia@f4c66ccafcb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ic5e8c89c1215cd0d85c5834056a0bc682dd087b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619551Reviewed-by:
-
