- 13 Jul, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594640123-15dad8eca9e1c0a172946dc66975935b724f3416.profdata to chrome-win32-master-1594648594-97cb9ce3cb39a74bf15fa7f9f08c38efdf753597.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2976d1e5c6f7d71b82075a94d908f20cb721ade7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787779}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4181.3-1594028802-benchmark-85.0.4183.18-r1 to 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9dcb68260fc4e2b2c2c32c74b0915cd9fd631865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295420Reviewed-by:
-
Peter Kotwicz authored
This CL changes the PathUtils#getDownloadsDirectory() strict mode comment to be less urgent given that fixing this is a low priority BUG=508615 Change-Id: Ib0a7abf4f4d3a4ac6bb03889381c6ea879102473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288190Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787777}
-
Andrew Grieve authored
It's really unusual to have a template that does not result in a target with name=target_name. In this case android_test_apk() was appending "__apk" for no apparent reason. Change-Id: I0867622ff27962aebc1c64c12a57c8ab0925d6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293216 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Jeffrey Young authored
Enable AmbientPhotoViewTests, check position and size of images. Move AmbientBackgroundImageView into own file. Add ID to ambient views for easier testing. Bug: b/158617675 Change-Id: I5d0b29b574a9d186d54649134d0b42eb59ae999a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277460 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#787775}
-
Ramya Nagarajan authored
Bug: 862753 Change-Id: Ia78ef91e67e9ffec0b601c78967586a0d54a9666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295299 Auto-Submit: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787774}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I2ee8464f181f6bef88fed19e8b34cff507dd8691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293455Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#787773}
-
Bruce Long authored
Since Windows platform dictionary support is determined asynchronously, some means is needed to assure that the first preferred language initially has spellchecking enabled after first run in the case where the language has Windows platform spellcheck support but not Hunspell support. Before introduction of delayed initialization of the spellcheck service, this was performed in the method SpellcheckService::InitWindowsDictionaryLanguages AFTER the list of platform-supported dictionaries was retrieved. But with the service initialized on demand, there is no guarantee that during first run a user will do anything spellcheck related, so the service may not be initialized in the first browser session and the primary preferred language thus may not be enabled for spellchecking. The fix is to change the logic so that the primary preferred language is always enabled for spellchecking by default during first run. The first time the spellcheck service is initialized the language will be disabled for spellchecking if it has no platform or Hunspell support. This also fixes an issue for embedders such as Electron that depend on the Chromium SpellcheckService implementation but do not want to take a dependency on first_run. Bug: 1064351 Bug: 1090030 Change-Id: I6efcf839b0ec545f20c2f23e26195dbebe1eeb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292866Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#787772}
-
Benjamin Beaudry authored
Because the OOF-positioned elements are laid out after the fragmentainers in a fragmentation context, we need a way to insert them inside of an already laid out fragmentainer. This CL introduces a fragmentainer "mutable copy" to which we can append NGLayoutResults without a relayout. Once we append the resulting fragment to the "mutable copy", we replace the original by this one in the NGContainerFragmentBuilder. Bug: 1079031 Change-Id: I40610943f591575ab631f24d6a2b3f9e363a46af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252927 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#787771}
-
Xiang Ji authored
Purpose: Most Windows 10 used in Enterprise are currently on 1809 (https://docs.microsoft.com/en-us/windows/release-information/), which is mapping to Windows Server 2019 (Long-Term Servicing Channel) (https://docs.microsoft.com/en-us/windows-server/get-started/windows-server-release-info). Validation: https://ci.chromium.org/p/chromium/builders/try/win-celab-try-rel/134? Change-Id: Ie337c2c140360934b735af584552e2f5658a1d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281469Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#787770}
-
Christian Dullweber authored
Add OWNERS files for page_info related Android code and point to components/page_info/android/OWNERS. Change-Id: Ie335e6c6ab76f06546e1087df9c7b0a62b9b868d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292250Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#787769}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/fdad1302b17b..15f98cdafa04 2020-07-13 dneto@google.com Add CMake support for buildint Tint in third_party (#1090) 2020-07-13 dneto@google.com Roll-deps: effcee trunk is "main" now (#1096) 2020-07-13 jiajie.hu@intel.com Improve how GN finds auto-generated SPIRV-Tools headers (#1101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I10c55dadc2e9ce1c94e68fdedf9065a45aee677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295137Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad65826a2ab1..522b34c810c5 2020-07-13 amaiorano@google.com Android: build against llvm-10 instead of llvm-7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib9c281e9a7bd511e18c0cf19363c243a4c628912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295127Reviewed-by:
-
Mugdha Lakhani authored
WebLayer instrumentation tests are running into a crash on Android L because of this bug. Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874898590093626928/+/steps/weblayer_instrumentation_test_apk_on_Android_device_Nexus_5/0/logs/Deterministic_failure:_org.chromium.weblayer.test.ExecuteScriptTest_testBasicScript__status_FAILURE_/0 This CL implements a workaround. Bug: None Test: weblayer_instrumentation_test. Change-Id: I082ecadaaa4cbc21b8064b59534aea4d16c31813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294867Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#787766}
-
Xianzhu Wang authored
The paint invalidation cases depended on visual rect either were also triggered by other changes, or could be achieved by checking other changes. This enables us to remove visual rect calculation from PrePaint, and remove an obstable of integrating FragmentData and LayoutNGFragmentTraversal. Bug: 1104064 Change-Id: Ibf108567af6ca776036bee39f624e4eaa011bd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291266 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787765}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/570934c3dab2..c4187c19b8f8 2020-07-13 qyearsley@chromium.org Rename whitelist/blacklist to allowlist/denylist in Perf Dashboard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: I8d3c7e766d2f53806b42cc2259f20e8770371cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295222Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e7bc3075505..85cf057d6c80 2020-07-13 aninditaghosh@google.com Add execute_query corresponding to /query endpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibddf5abeb264d3fc20e7d3617452ec572df87fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295131Reviewed-by:
-
James Cook authored
Previously, select file dialogs opened from lacros-chrome had an empty RoutingID. This caused console errors, and also meant only one dialog could be open at a time. Give each dialog instance a unique ID. For now, this is just an monotonically increasing integer. Longer-term it will be a window ID provided from the lacros-chrome process. This will also allow proper window stacking -- that doesn't work yet. The method SelectFileWithFileManagerParams() already has 9 arguments. Rather than adding more, consolidate all "owner window" information into a struct. This CL requires deps from //c/b/chromeos to //c/b/ui/views for SelectFileDialogExtension, similar to //c/b/chromeos/arc/fileapi. This allows us to avoid polluting the cross-platform SelectFileDialog API with Chrome OS specific parameters. Feature design doc at go/lacros-select-file Bug: 1090587 Change-Id: I52d87c7216fc8a6c6b9eb1ea9c41c23f54f34e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293164Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#787762}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31890e2c37b5..74470aec5185 2020-07-13 adlai@google.com Make GrAsDirectContext public 2020-07-13 johnstiles@google.com Split GrConstColorProcessor into three separate .fp effects. 2020-07-13 johnstiles@google.com Redesign const-color unit test to leverage sk_gpu_test::test_ops. 2020-07-13 mtklein@google.com refactor skvx::if_then_else() 2020-07-13 adlai@google.com Add an arg to SkImage::makeSubset to take a direct context 2020-07-13 herb@google.com remove unused decl from SubRun 2020-07-13 robertphillips@google.com Miscellaneous removal of GrContext usages 2020-07-13 robertphillips@google.com Update some of the dox code to GrDirectContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ibb456f9673bd5406f040da8a1d38a57cb18d43b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295133Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3f891c51471..92ffd40efaac 2020-07-13 xinyi.he@arm.com Vulkan: Disable GL_EXT_robustness extension on Mali 2020-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 44ef9e08c459 to 8726fda3f865 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ic16003c5a025e1f965593914a1f947571b26c713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295129Reviewed-by:
-
Miguel Casas authored
This CL: -Removes references to VP9 profile 1 and 3 of the code since they are not supported by VaapiWrapper. - Splits the large VaapiProfiles test case into one Decoding, Encoding, and JPEG, and adds another case for VaapiWrapper::IsDecodeSupported() static method. - Removes PreSandboxInitialization() from main, and does it instead from the SetUp() method, so it can be centralized and removed from each test case. Verified locally with the fake libva backend (like bots) via LIBVA_DRIVERS_PATH=/home/mcasas/p2/exp/libva-fake-driver LIBVA_DRIVER_NAME="fake" ./out/gn/vaapi_unittest --gtest_filter=*VaapiTest.* (like the bots) and on kohaku. Bug: 1040291 Change-Id: I3543c11c97cdb3717cb96f1a1bb3c46dff5b33bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292813 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#787759}
-
Jeffrey Young authored
then click thumbs down emoji. Bug: b/157520832 Test: open assistant with hotword, run any query, Change-Id: I439339082e84d5234a291787e7be9485fb817827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286954 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
-
Peter Kasting authored
* IWYU for STL headers * Pass TimeDelta by value Bug: none Change-Id: I8e4198a2b1407139f8b6b08d6d0d3daca3c8bb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293285Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#787757}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fce88f57..1a1ffb06 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea7f38a6cddf2bcdda2e4a7eb8344b750c5f6548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295081Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787756}
-
Vasilii Sukhanov authored
Bug: 1049200 Change-Id: If7c081c81b939defd6aaacac2089bda5da3acd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292435Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787755}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I78d31199e84d9393601ee08fe9f0dfc1830e6a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295203Reviewed-by:
-
Ioana Pandele authored
This CL adds a java bridge and its C++ counterpart meant to mediate the communication between the UI displaying information about compromised credentials and the native password check logic. Bug: 1102025 Change-Id: I9c352e5037889f645de8fa10b624fbd2a7a61125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289845 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Greg Thompson authored
https://crrev.com/784428 stopped recursing across junction points when looking for CR_* or chrome_* directories. This CL does the same when deleting within those directories. BUG=1100280 R=forshaw@chromium.org Change-Id: I7a4ef84d9df744cf5d0bd64d51065a571228520d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292395Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#787752}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b1286b32a9f2..c922ffa5d2fe 2020-07-12 wl@gnu.org * builds/unix/configure.raw: Fix inclusion of `ftoption.h'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: If58f617155c015ef0d31af468ad1828d752e911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294177Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787751}
-
Bo Liu authored
If the view of the fragment of a tab is detached from the window (or not created yet), then mark the WebContents of the tab as hidden. This is to provide a somewhat reasonable way for the embedder to manipulate the web hidden state. Also change newly created TabImpl to be hidden on creation to avoid unnecessary state flips. This is purely for efficiency, not for correctness. Left restored tabs alone. Bug: 1096063 Change-Id: Ie8b5da3bef040536b976435c0507462f7f796c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291691Reviewed-by:
-
Wez authored
TBR=bsheedy,chonggu Bug: 1087298 Change-Id: I0541145f8a97cd47f9ad3f8f26ae2171b8c4f9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292261Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#787749}
-
Lily Chen authored
Bug: None Change-Id: Ib03052f12f640ba3c80e11e2674b56e2a8962b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294566 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#787748}
-
Xianzhu Wang authored
Normally we should avoid layout geometry types (LayoutRect, LayoutSize, etc.) outside of layout and paint. We also plan to deprecate them by Physical/Logical geometry types in layout/paint. This can avoid the layout system directly passing a size in logical coordinates to StyleImage. Also keeps consistency with other geometries in StyleImage. Change-Id: I8b8305e5a0377f525de9b3fbbbf288380f36119f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294337 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ebe48cd83a3..85f14941793d 2020-07-13 tvanderlippe@chromium.org Move all_devtools_files to separate gni file 2020-07-13 tvanderlippe@chromium.org Move all_devtools_modules to separate gni file If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097043 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55a1309f030f89dc5b1750a36f19d01b7b45722e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295128Reviewed-by:
-
Xianzhu Wang authored
This is a followup of the physical geometry work one year ago (crrev.com/c/1608088). Change-Id: Iabbb8948a01208c811f1802b5de67fc20d1b3a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294336 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#787745}
-
John Abd-El-Malek authored
In r769725 the threading was changed but I missed updating this one site. Also remove now-unnecessary thread hopping. Bug: 1102087 Change-Id: Iaba9995119ce23fefddfcd597ba94afe76210718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294341 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787744}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id5a6b262f74dea7224ca1cdd69590d378b015848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295202Reviewed-by:
-
Anatoliy Potapchuk authored
To simplify potential debugging of kiosk issues, let's add more logs about state changes in KioskLaunchController. Bug: 1015383 Change-Id: I04a3eed739d46a3762295a8e376bae221965a761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292294 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787742}
-
Xianzhu Wang authored
Some of the rounded border methods do pixel snapping which should be only done for painting or hit testing, so move them into RoundedBorderGeometry under renderer/core/paint. Change the type of the input rect from LayoutRect to PhysicalRect. Rename: - ComputedStyle::GetBorderFor -> RoundedBorderGeometry::RoundedBorder - ComputedStyle::GetRoundedBorderFor -> RoundedBorderGeometry::PixelSnappedRoundedBorder - ComputedStyle::GetInnerBorderFor -> RoundedBorderGeometry::RoundedInnerBorder - ComputedStyle::GetRoundedInnerBorderFor -> RoundedBorderGeometry::PixelSnappedRoundedInnerBorder Fixed ShapeOutsideInfo that should call the non-pixels-snapped version. Change-Id: I57842e9c7b3d277bd3e5201827f1a0b1f136f2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294335 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: -
Dave Tapuska authored
These rects come from the content/common/screen_info.h definition so they can easily be changed to gfx::Rect. (as gfx::Rect has clamping behavior for negative sizes). BUG=1097816 Change-Id: Iad4fe55b36aaa1f8a489066725d24250b868c569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293255Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#787740}
-
