- 02 Jul, 2018 40 commits
-
-
vitaliii authored
Bug: 781765,856583 Change-Id: Ia7feaf1119cc1f2f402646e66c832f656ca55e35 Reviewed-on: https://chromium-review.googlesource.com/1114612Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571859}
-
Deepanjan Roy authored
Delay of an input event is defined as the duration between the hardware timestamp and the start of event processing on the main thread. We report this event once per navigation, and take into account input delays observed in subframes, including OOPIFs. We do not take an input event into account if the page was backgrounded while the input event was queued. Additionally, for UKM, we currently do not take input events into account after the page was first backgrounded, but fixing this requires invasive changes to ukm_page_load_metrics_observer, and will be done in a subsequent CL. UKM Privacy Review: http://bit.ly/input-delay-ukm-privacy Bug: 822412 Change-Id: I1a823a48a1e8d8797ca4ecaa1e19e66c59bf4a2c Reviewed-on: https://chromium-review.googlesource.com/1084058 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#571858}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5a482847e95b..fceaca323345 git log 5a482847e95b..fceaca323345 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 buildbot@webrtc.org Roll chromium_revision f06b8215..c2072685 (571725:571826) 2018-07-02 deadbeef@webrtc.org Removing deadbeef@ from OWNERS files. Created with: gclient setdep -r src/third_party/webrtc@fceaca323345 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ief0394d003f7aa60ae4e843404022719f4ae6cdc Reviewed-on: https://chromium-review.googlesource.com/1121880Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571857}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::GetFirstLetterPart()| as const member function since this function doesn't change state of |LayoutText| for improving code health. This is the follow-up of the patch[1] which introduces |GetFirstLetterPart()| but it didn't mark it as const function. [1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to LayoutNG Change-Id: I5f5781bbde91e1383980afc58e2fcb13e8bfc4c6 Reviewed-on: https://chromium-review.googlesource.com/1122023 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571856}
-
Yoshifumi Inoue authored
This patch changes UA style sheet to make <rp> element has "display:none" to follow the spec[1]. This patch improves pass rate of Element#innerTex spec conformance test to 79 failures to 78 failures. [1] https://html.spec.whatwg.org/multipage/rendering.html#non-replaced-elements Bug: 859416 Change-Id: Ib5f41659d6ff056023dd24946e7c82cc388fba0e Reviewed-on: https://chromium-review.googlesource.com/1122019Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571855}
-
Hannes Payer authored
Change-Id: Ib9a72f4887103709b02919aa3d894b6394dbb30c Reviewed-on: https://chromium-review.googlesource.com/1122128Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571854}
-
Alex Clarke authored
We already know |now| so there's no need to create a new LazyNow. Change-Id: I9a483ecdeb537af3ca883598cfe749da3fe4b1a7 Reviewed-on: https://chromium-review.googlesource.com/1121464Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571853}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kNoPendingResult in: net/socket/ssl_client_socket_impl.cc net/socket/ssl_server_socket_impl.cc This commit solves the issue by renaming the constants to something more file specific. Bug: 772146 Change-Id: I918d551970e249fbb5e0bfadf0ebaeae99ffebcb Reviewed-on: https://chromium-review.googlesource.com/1119916Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571852}
-
Yoshifumi Inoue authored
This patch changes "newlines-around-floating-or-positioned.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: Ic582771158dae7d2eb936d1581aa31bdb7b9cd63 Reviewed-on: https://chromium-review.googlesource.com/1122032Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571851}
-
Yutaka Hirano authored
This reverts commit f2efdfd7. Reason for revert: To see if it's still flaky. Original change's description: > Disable SecurityExploitBrowserTest.InvalidRequestId. > > It's flaky on all operating systems and is affecting the commit queue. > Per comments on related bugs, the test is going to be removed anyway > once Chromium's network service ships. > > BUG=799516 > TBR=mmenke@chromium.org > > Change-Id: I2813e850690ed9b162288abac3e42b3b23d33ad8 > Reviewed-on: https://chromium-review.googlesource.com/866153 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529171} TBR=kbr@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 799516 Change-Id: I9a7fab6e6e1bfe75285a4d6f222b56314b66b9df Reviewed-on: https://chromium-review.googlesource.com/1122096Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#571850}
-
Yoshifumi Inoue authored
This patch changes "inner-text-with-no-renderer.html" to utilize w3c test harness for ease of maintenance. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Change-Id: I108b1225a72517d1afa7402f2c184d7b3e5b1043 Reviewed-on: https://chromium-review.googlesource.com/1122035Reviewed-by:
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and functions with the same name conflict. This happens for the function kParseCertificate defined in: net/cert/internal/ocsp.cc net/cert/internal/parse_certificate.cc This commit solves the issue by renaming the function in net/cert/internal/ocsp.cc. Bug: 772146 Change-Id: I071682c8f330183f637a7985061980b6aa34c93a Reviewed-on: https://chromium-review.googlesource.com/1119911Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8451daabb23d..00d2e8ebcb13 git log 8451daabb23d..00d2e8ebcb13 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@00d2e8ebcb13 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iec55b28e9a97ae22a046299f7d440607b6a33b47 Reviewed-on: https://chromium-review.googlesource.com/1121879Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571847}
-
Matthew Cary authored
Use the underlying handle size when wrapping a legacy shared memory instance. Bug: 849207 Change-Id: Ibbf62ebbea5a95d64d84a0faf2042f639be5b820 Reviewed-on: https://chromium-review.googlesource.com/1118268Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#571846}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4acfae0eb7bce7aaaa32bbb8f487e8d177a251b Reviewed-on: https://chromium-review.googlesource.com/1121973Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571845}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/024a3317597b..483580b38ef1 git log 024a3317597b..483580b38ef1 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tandrii@chromium.org Remove unnecessary de-duplication. Created with: gclient setdep -r src/third_party/depot_tools@483580b38ef1 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If0222adfbfb8e775b71a1fa689d3cdd60a52d71d Reviewed-on: https://chromium-review.googlesource.com/1121878Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571844}
-
Andrey Kraynov authored
Looks like it is possible to move some includes to *.cc files with forwards, and even remove some unused ones. This can simplify compilers's work, for example touching script_function.h header leads to recompiling 4K targets without jumbo builds. No behavior changes. Bug: 242216 Change-Id: Id7aacfa32400fdb150acced4603f591b24db9361 Reviewed-on: https://chromium-review.googlesource.com/1120176 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variable kVlogSetCookies in net/cookies/canonical_cookie.cc and net/cookies/cookie_monster.cc. This commit solves the issue by moving the variable definition to net/cookies/cookie_util.h. Other kVlog variables defined in net/cookies/cookie_monster.cc are also moved. Bug: 772146 Change-Id: I850c27406f687dfffcf682b0957a41ecbeaca291 Reviewed-on: https://chromium-review.googlesource.com/1118382Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571842}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I5974bf3d0576e383f1a1ae0b1163aed94ca88445 Reviewed-on: https://chromium-review.googlesource.com/1119906Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571841}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c58f741..3664662e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibdc4cf9cd7a3a8775ab3dc84c5ebe0dcfacc756d Reviewed-on: https://chromium-review.googlesource.com/1121968Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571840}
-
Kenichi Ishibashi authored
We found that these histograms are not very useful. We would like to remove them because when S13nServiceWorker is enabled these histograms are not recorded for subresource requests, which may be a bit confusing. Bug: 852670 Change-Id: I6a6b036e239cc8d8b5e3475ab325937e9e05cc7f Reviewed-on: https://chromium-review.googlesource.com/1117731 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571839}
-
Taylor Brandstetter authored
Since I'm leaving Google. NOTRY=True Bug: None Change-Id: I4c9d75d20e0168d16b064c661f8f15e9c510a592 Reviewed-on: https://chromium-review.googlesource.com/1121355Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#571838}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: I5275e611d2888dfd608b5770383be0e6453e986a Reviewed-on: https://chromium-review.googlesource.com/1118401Reviewed-by:
-
Yi Su authored
Initial version of text size accessibility feature use some arbitrary scaling numbers for adjusting text size. This CL substitutes those with more precise numbers calculated by fonts' point sizes of text categories. Bug: 836962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id444031cbccfea40c2269792aeef1a3ee8df8670 Reviewed-on: https://chromium-review.googlesource.com/1121236Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571836}
-
Luciano Pacheco authored
This reverts commit cb8862fc. Reason for revert: Flaky test found by Findit crbug.com/859422 method OnLookupAttemptComplete introduced on this CL is shown on the stacktrace. Original change's description: > Cleanup HostResolver timeout/retry tests. > > Instead of relying on sleeping and the actual clock, use a mock > taskrunner to simulate the passage of time. Makes the test more accurate > and stable, and it also speeds things up significantly (~1.5s->60-70ms). > > Also convert ProcTask to use unique_ptr and WeakPtrs instead of ref > counting to more cleanly cleanup the memory on completion instead of > waiting for unused scheduled retries. > > Change-Id: I22b741d8b29d8eb419d125147ef98eba01c658e4 > Reviewed-on: https://chromium-review.googlesource.com/1108078 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570840} TBR=isherman@chromium.org,rkaplow@chromium.org,mmenke@chromium.org,xunjieli@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I788443bc57d8eb9ece8cd572ef0b0e49f48ef793 Reviewed-on: https://chromium-review.googlesource.com/1121977Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#571835}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Change-Id: Ibe313bbf292c269b67782c169af173859c353db7 Reviewed-on: https://chromium-review.googlesource.com/1111482Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#571834}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=derat@google.com Change-Id: Iaaf7dc2de7a61e2e87c2d3156275bdfc65f50c3d Reviewed-on: https://chromium-review.googlesource.com/1121903Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571833}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/34024a7c478c..8451daabb23d git log 34024a7c478c..8451daabb23d --date=short --no-merges --format='%ad %ae %s' 2018-07-02 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@8451daabb23d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8774a362827fedfa2262d627ed23c2c426a99fb8 Reviewed-on: https://chromium-review.googlesource.com/1121877Reviewed-by:
-
Kent Tamura authored
This is a preparation to add a UseCounter in Node::parentNode(). Bug: 859391 Change-Id: I056f60207e000b6f9b1acd6e412444f96a8daee2 Reviewed-on: https://chromium-review.googlesource.com/1121944Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571831}
-
junweifu authored
Original CL got reverted because the Vision.Framework isn't loaded in services unit tests. This is a reland of 4db64ed1 Original change's description: > ShapeDetection: Start the minimum implementation of mojom::BarcodeDetection > > The new implementation is based on Mac OS Vision Framework[1] which recognizes > more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode > detection provider to choose different implementation. > > Split original large CL[2] up in smaller subpatches including this CL. > > [1] https://developer.apple.com/documentation/vision > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466 > > BUG=848182 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng > Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e > Reviewed-on: https://chromium-review.googlesource.com/1107493 > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570336} Bug: 848182 Change-Id: I143f1c2b1977690d50aa4bf4b31d5eda1cb92ece Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1116258Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#571830}
-
Alexei Filippov authored
It should reduce overhead of performance recordings. BUG=849887 Change-Id: Ia3196c7c3a37273b720b82897d04f142868fddea Reviewed-on: https://chromium-review.googlesource.com/1087639 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571829}
-
Kenichi Ishibashi authored
Before this CL we didn't record EventDispatchingDelay_FETCH_SUB_RESOURCE when S13nServiceWorker is enabled because sub resource loading doesn't go browser process. Record the metric in ServiceWorkerSubresourceLoader. Bug: 852668 Change-Id: I3e7b2e833dda9d73f5b09917018e69275f29910c Reviewed-on: https://chromium-review.googlesource.com/1113157 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
tzik authored
EQT (Estimated Queueing Time) used to ignore tasks in a nested loop, that doesn't work well with Cooperative Scheduling, as it runs nested loops extensively. This CL updates the calculation logic to count nested loops and nested tasks into EQT. A nested loop splits the enclosing task to two, and the inner task execution is counted as if it's a toplevel task. The idle time of the nested loop is considered as idle as well for EQT calculation. Change-Id: Ib5397ca19c056d8e96c643c1c0d52be109e95194 Reviewed-on: https://chromium-review.googlesource.com/1075919Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Test has been flaky on different builders. Tbr: alexmos@chromium.org Bug: 859315 Change-Id: Ie8f9c7238a5421baf3d28b075f1079d05fe8d5b4 Reviewed-on: https://chromium-review.googlesource.com/1121998Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/20868003..9c58f741 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib0b2e0b27d7e1cb2c6786ceb61b0b66d9ba95503 Reviewed-on: https://chromium-review.googlesource.com/1121963Reviewed-by:
-
Luciano Pacheco authored
ContextualSuggestionsTest#testScrollPageToTrigger test has been flaky. Tbr: twellington@chromium.org Bug: 859292 Change-Id: I3b6cc237c1771edeff12bbe19c1a85cd8797ef38 Reviewed-on: https://chromium-review.googlesource.com/1121997Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ibb2a660d292018527cb2aafe63af1f06b83c8b80 Reviewed-on: https://chromium-review.googlesource.com/1121965 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571823}
-
Darren Shen authored
Currently when no display is touchable, we show the virtual keyboard on the primary display. According to https://crbug.com/297858, this was just a basic heuristic to get it working. As mentioned in https://crbug.com/303429#c5, forcing the user to change their primary display all the time is not very user friendly. We change this so that when no display is touchable, we show the keyboard on the focused window (if any). Bug: 856613 Change-Id: I4e0524747c54e471607b2b546a3ef663ad215b55 Reviewed-on: https://chromium-review.googlesource.com/1118060 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#571822}
-
Stuart Langley authored
Prints either the team drive id or "default corpus" when logging message from change list loader in the chrome://drive-internals logs. Bug: 849813 Change-Id: I7463d99308f6c9ee30ce27f7e89641a0cf7b9526 Reviewed-on: https://chromium-review.googlesource.com/1121675Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#571821}
-
Stuart Langley authored
Command Run: $ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-nullptr,modernize-raw-string-literal,modernize-make-unique \ -header-filter= \ -fix chrome/browser/chromeos/drive $ git cl format There are no logic changes. Bug: 841659 Change-Id: I6d2e7e6e31a53fb662586b823e9084fc1009a82a Reviewed-on: https://chromium-review.googlesource.com/1121674Reviewed-by:
-
