GitLab

Was reverted in: 54f75614.

Reason for reland: Includes fix for downstream targets.

Change-Id: I2a5f77cdbd40934ae206dd91b2e12e7b5e6553e1
Bug: 986693, 986693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715004Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680307}

Bug: 891908
Change-Id: I1653b11914eb81117a4d9b35e2ef32ec38ed57bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714949Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#680306}

This change observes any time zone changes, recalculates the delay for
the next update check timer and starts it to override the previous
timer.

BUG=924762
TEST=Unit tests.

Change-Id: I7ebd9114a7282b0d03e3d18d4bbe1aaaa252ff2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677555
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680305}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cc6f67d9766..83166a2bdb79


Created with:
  gclient setdep -r src-internal@83166a2bdb79

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com

Bug: None
Change-Id: Ibc0efc9e2ffbab4ea24133f2930543f1a7ab8398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716387Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680304}

https://chromium.googlesource.com/catapult.git/+log/5f7b2c2ad2f2..fbd94ccd66ee


git log 5f7b2c2ad2f2..fbd94ccd66ee --date=short --no-merges --format='%ad %ae %s'
2019-07-24 simonhatch@chromium.org Pinpoint - Make autocomplete box iron-form compatible.


Created with:
  gclient setdep -r src/third_party/catapult@fbd94ccd66ee

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=skyostil@google.com

Bug: chromium:986902
Change-Id: I88fd7bc1cadb3106454c59a7e4f4a4c7f8bfcad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680303}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Please review and LGTM before July 16th or the CL will be
submitted as-is.

Bug: 977050
Change-Id: I229c40799a36ec7eeb212043b0503e7e507b876d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700825Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680302}

Tests can often start sending synthetic events before the renderer has
fully initialized and produced a compositor frame. Before that, the
browser doesn't yet get the geometry information from the renderer and
the gestures  This leads to flaky, tough-to-debug, tests.

This CL makes the first gesture sent by the SyntheticGestureController
wait until the renderer confirms it has produced and presented a
CompositorFrame. By that time, it should be ready to receive events.

This change should make the synthetic gesture API more intuitive and
easier to use. It should hopefully also fix several flakes in addition
to the one linked in this CL.

The fix in scrollbar-button-gesture-target.html is required because the
autoscroll timer begins 250ms after the mouse down. Prior to this CL,
this would pass by accident because the first generated compositor frame
in web tests appears to take a long time (~200ms). Since that would
occur after the MouseDown this test would pass. Now that we force a
frame before the MouseDown the MouseUp happens in 100ms, before the
autoscroll timer expires. We fix this by making the delay exceed the
autoscroll timer delay.

Bug: 897520,951638,985374
Change-Id: Idd63e1f2b999253e0392ae37be4180956119a814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566750
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680301}

This reverts commit 154a7f11.

Reason for revert:
This CL causes MSAN failurse on Linux bot:
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/18180

Original change's description:
> Distinguish between enabling the insecure and secure parts of the async resolver.
> 
> In SECURE or AUTOMATIC mode, we should be able to send secure DoH queries via
> the async resolver regardless of whether the async resolver is enabled for
> sending insecure queries.
> 
> The network service will be updated in a follow-up cl to actually set the
> insecure and secure parts separately; for now support is just being added in
> HostResolverManager.
> 
> Bug: 985589
> Change-Id: Ife79f70897229aadc4f7111c3ce07de47b47a32b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497654
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680069}

TBR=mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com

Change-Id: Iead9c38f35cde1411193550799977f580342ce3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 985589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716392Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680300}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Please review and LGTM before July 16th or the CL will be
submitted as-is.

NOTRY=true

Bug: 977050
Change-Id: I9a24112403d29fa8d81dfdc03a5851679e539799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700620
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680299}

This CL removes data saver tests for dedicated workers from web_tests. They
are covered by DataSaverForWorkerBrowserTest.

The motivation of this change is that the tests depend on
internals.setSaveDataEnable(), but it no longer works after browser-initiated
dedicated worker script loading (PlzDedicatedWorker) is enabled. We already
removed the tests for shared workers for the same reason (PlzSharedWorker).

Bug: 906991
Change-Id: I93775824d2dab398268bf9b3a7a54d5e9d79f74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715729Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680298}

This reverts commit 7faa4bf2.

Reason for revert:
This CL depends on the CL that causes MSAN failures on Linux bots:
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/18180

To revert that CL, let me revert this CL.

Original change's description:
> Configure the insecure and secure parts of the async resolver separately.
> 
> We can now set the secure dns mode to AUTOMATIC and turn the insecure part of
> the resolver off, which will result in the async resolver issuing DoH requests
> and falling back to the system resolver without attempting to send plaintext
> DNS requests itself.
> 
> In a follow up cl, the secure dns mode part of the configuration will be read from
> prefs. For now, we continue to set the mode to AUTOMATIC if there are DoH servers
> specified and to OFF otherwise.
> 
> Bug: 985589
> Change-Id: Ia40cbae1fdd57e19e925e125dcf1e82289220242
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709928
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680161}

TBR=tsepez@chromium.org,ericorth@chromium.org,dalyk@google.com

Change-Id: I0e118abc67bb2b06860894079c5ed509d8179dff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 985589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715265Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680297}

BUG=894780

Change-Id: Ib6066153edf992baf4572113155b95d677ac8af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714265Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680296}

Bug: 986958
Change-Id: I3d7dcf1c736243f73c9333d27175f6740842a6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716005Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680295}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I45851f14cf8653a7818f9b28d5b113ec8da6d730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716295Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680294}

After some attempts of loading our shared library in IME service with
an ime-sandbox type, new process of IME service always crashed.
strace logging:  https://paste.googleplex.com/4705028050780160

Allow clock_gettime will fix that.

Bug: 837156
Change-Id: I4e6bf7a777f57ef8f5184be8c60a59bd2fd7e163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677295Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Auto-Submit: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680293}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1844d6a51cbc..886321015e1d


git log 1844d6a51cbc..886321015e1d --date=short --no-merges --format='%ad %ae %s'
2019-07-24 vapier@chromium.org lint: fix cros-logging-import handling


Created with:
  gclient setdep -r src/third_party/chromite@886321015e1d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I95fe17e8f7591c240fcc911bca6ad3c0bf6ab818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716294Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680292}

Two RunOrPostTaskIfNecessary methods, one in
content/browser/web_package/signed_exchange_devtools_proxy.cc and
one in content/browser/loader/navigation_url_loader_impl.cc,
clash in some extreme (non-default) jumbo builds.

This CL makes one of them more specialized since it was always
called with the same argument, and changes its name.

Bug: 824854
Change-Id: I65f1270ca826235596a846dec935a8ea9b7f624b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713515
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680291}

https://skia.googlesource.com/skia.git/+log/5f240186ecfe..d15571af2e1b


git log 5f240186ecfe..d15571af2e1b --date=short --no-merges --format='%ad %ae %s'
2019-07-23 rmistry@google.com [perf_skottiewasm_lottieweb] Use 3 loops for more consistency


Created with:
  gclient setdep -r src/third_party/skia@d15571af2e1b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=borenet@google.com

Bug: None
Change-Id: I6c3a75b2d406cffed7b35cd9d71761feb2956d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716290Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680290}

This reverts commit afca3680.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 680248 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FmY2EzNjgwOGUxMTIyYzEzZDk2ZjhkMDQyZjA1OGY0NDgxZGZlYzEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Linux/77963

Sample Failed Step: events_unittests

Original change's description:
> Add PalmDetectionFilter and 2 initial implemenations.
> 
> This adds a palm detection filter that interacts with the concept of
> "held" items. The filters will be used in TouchEventConverterEvdev to
> either hold or cancel touches, in addition to the behavior from device
> firmware.
> 
> The two implementations are:
> 1. An always "open" detection, that doesn't mark anything to hold/cancel.
> 2. A simple heuristic that is based on interaction with stylus touches.
> 
> Both implementations have unit tests that cover 100% of the code.
> 
> 
> Bug: 982118
> Change-Id: I9f50b98be434ba5c767d9392c0a470262cf5e603
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708148
> Reviewed-by: Michael Spang <spang@chromium.org>
> Commit-Queue: Rob Schonberger <robsc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680248}


Change-Id: I898da8f080c3b007e542918e74602750044c2af2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 982118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716389
Cr-Commit-Position: refs/heads/master@{#680289}

Android: Delete unnecessary calls to initApplicationContextForTests, CommandLine.init(), and prefs clearing

The base runners now take care of these.

TBR=agrieve  # Trivial refactor to components/

Bug: 441859, 908174
Change-Id: I82d630ddf59b1f2f1a9f802f6853ec8c694bbd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714328
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680288}

This is a follow up CL after cr/1639717. This cleans up
the previous CL and also remove the usage of SyncAccountType
everywhere. Instead, the sync service is called directly
to see whether sync is enabled. The new proto
ReusedPasswordAccountType is used to cover both SyncAccountType
and ReusedPasswordType.

https://docs.google.com/document/d/1u6hZGajdhPPlvDQUaMu72UeRAEuM8TVZ4zYcRvmVnew/edit?usp=sharing

Bug: 914410
Change-Id: Ia2dc704d85205396bb2c1d501cbf9d7e69aed535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673863
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680287}

This expands upon the vulkan_pixel_skia_gold_test currently running
on Android GPU FYI, and adds Linux configurations.

This is targetting:
  "Linux FYI Experimental Release (Intel HD 630)"
  "Linux FYI Experimental Release (NVIDIA)"
as both are currently on 19.04. Once the rest of the fleet is
updated we will shift these to "Linux FYI SkiaRenderer Vulkan (NVIDIA)"

pixel_expectations has been updated to reflect the triaged failures

TEST=vulkan_pixel_skia_gold_test

Bug: 956139
Change-Id: I382fab84dcfa73ad073b569a26940587cc29123e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688373Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680286}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf1a7ab86cc3..0cc6f67d9766


Created with:
  gclient setdep -r src-internal@0cc6f67d9766

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: I2e71e586c3a92f6a433c9b37c31fd5a1302b9dfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716293Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#680285}

BUG=762641
TBR=malaykeshav@google.com

Change-Id: I8bfef7ac941175ab4211ab692f540e8952867c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716225Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680284}

This cl migrates kAssistantHotwordAlwaysOn, kAssistantLaunchWithMicOpen
and kAssistantNotificationEnabled preferences from arc_prefs to
assistant_prefs.

Also updated usages in Assistant Service and ash, removed obsolete
methods.

Detailed design doc: https://goto.google.com/assistant-prefs

Bug: b/110211045
Test: Run existing tests
Change-Id: I23387684b78327b8b7f7174302582dd97735eb24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713601
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680283}

This fixes `sync_integration_tests --enable-features=AppServiceAsh
--gtest_filter="TwoClientAppListSyncTest.Install"`. It fails before and
passes after this commit.

Note that `sync_integration_tests
--gtest_filter="TwoClientAppListSyncTest.Install"`, without
AppServiceAsh enabled, passes both before and after this commit.

BUG=826982

Change-Id: Ieea9177e60e198307dca9fd13b0a8e73681d33d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708692
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680282}

Originally we didn't keep the ownership of |gpu_task_runner_| when
creating VideoDecoder. When we create the second VideoDecoder, this
variable will become nullptr. This CL fixes this bug.

BUG=chromium:986752
TEST=reload crosvideo.appspot.com and no crash

Change-Id: I8abebd44b7423dff0bcb663ae74fdfe7e958e7fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714625Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680281}

Bots are added by
https://chrome-internal-review.googlesource.com/c/infradata/config/+/1506829

Bug: 954450, 977061, 956776
Change-Id: Ibffe21b019a0bb90f3f28869a7592f630792e3d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714305Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680280}

This CL is part of the work on file-handling:
https://github.com/WICG/file-handling/blob/master/explainer.md

After this CL, websites will be able to access files (if any) that
they were launched with.

This feature is hidden behind two experimental flags:
NativeFileSystemAPI and FileHandlingAPI.

Bug: 829689
Change-Id: I503afebb7d5ee00eff3bc032245c57966ca34872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672608
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680279}

Currently if an authenticator is being added to the BLE device chooser
dialog but it is not yet in pairing mode, it will use a generic display
name. This CL causes the display name to be updated to the correct
device name when the device enters pairing mode.

Bug: 906750
Change-Id: Ic86abf9a055746634b64b5e9043fa37640076d14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708917Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680278}

This fixes a regression that caused cancelling out of the native Windows
WebAuthn UI would show an error dialog, when the request should have
just been ended right away.

The error dialog in question contained a "retry" button, which was non-
functional because it just returned the UI to an empty transport
selection UI. Conceptually, we don't want to offer the "retry" button on
Windows, because the Windows UI brings its own retry behavior for
certain cases (e.g. user touched the wrong security key). Hence, this
change also extends the retry logic on
ChromeAuthenticatorRequestDelegate to hide retry buttons after
dispatching a request to the Windows API.

Bug: 985597
Change-Id: Ie02721068c847156222e81f193fd446929ca996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710741
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680277}

This reverts commit d332af51.

Fixed crash due to missing member var initialization.

TEST=ran failing gl_unittests locally

Original change's description:
> Revert "gpu: Sync to primary monitor's vblank (windows)"
>
> This reverts commit bd0cae50.
>
> Reason for revert: Cause failures in DirectCompositionSurfaceTest.*
> Builder: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29?limit=200
> First build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/22377?blamelist=1#overview-tab
>
> Crash example:
> ...snip...
>
> Original change's description:
> > gpu: Sync to primary monitor's vblank (windows)
> >
> > DWM composition is limited to primary monitor's refresh rate.  Prior to
> > GPU vsync we would use DWM composition rate to drive begin frames.
> >
> > With GPU vsync we started using per monitor vblank to limit begin frames
> > in case primary monitor had higher refresh rate, but this might be
> > causing draw duration and omnibar latency regressions.  MS platform team
> > also suggested syncing to primary monitor only.  In any case the correct
> > approach would be to further limit begin frames based on event queries
> > from 2 frames back.
> >
> > This CL makes the GPU vsync begin frames sync to primary monitor, and
> > also makes the vsync thread a singleton since it doesn't have per-window
> > state any more.
> >
> > Bug: 953970
> > Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#679832}
>
> TBR=zmo@chromium.org,sunnyps@chromium.org
>
> Change-Id: If4a762325952dd33283bf41a13321e759de51025
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 953970
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713510
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679915}

TBR=zmo@chromium.org,sunnyps@chromium.org,kolos@chromium.org

Change-Id: I743026c218932916aba9d9c7722d8343e9fdbdd9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716211
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680276}

Bug: 987108
Change-Id: I7a1c2b89a0ed6cfce4d2b9761b0928a1808ebf39
Notry: true
Tbr: nhiroki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715888Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680275}

Converting command-line switch that turns on default SiteInstances into
a feature flag so that we can turn it on via a Finch experiment.

Bug: 958060
Change-Id: I749c9622978a12344a18aca843188a207651754b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710025Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680274}

The Closure Compiler issue about typedefs in local scopes [1], which
forced us to use cr.exportPath() seems to have been fixed.

Removing two TODOs in the code referring to this bug, and also updating
a few print_preview files as a proof-of-concept. Remaining cr.exportPath()
calls will be removed in follow up CLs.

[1] https://github.com/google/closure-compiler/issues/544

Bug: 986481
Change-Id: I1799214184b61a507d864e862d955b90d9a0f245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713339
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680273}

Test from this builder consumes less than 1.27(CQ) + 0.27(CI) machine hour in
chrome pool from p99 in recent 30 days.
I took the stats from
http://shortn/_vS3Df0uFD0

Bug: 954450
Change-Id: I626d6448788c6f449dce98c4ed735aa9915c6850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712603Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680272}

Currently PDFiumEngine::GetPageScreenRect() calculates the area
of the |page_index| page, including the area around it such as
shadows and separators. In two-up view, when two pages are
side-by-side and one page is shorter than the other, the space
below the shorter page must be drawn as empty space to match
the height of the taller page.

This CL refactors PDFiumEngine::GetPageScreenRect() so that when
|two_up_view_| is true, it calls draw_utils::GetSurroundingRect()
with a copy of the rect for |page_index| page with its height set
to the max height of the two pages. It also adds
PDFiumEngine::GetAdjacentPageIndexForTwoUpView() which retrieves
the index of the page adjacent to the current page.

Bug: 51472
Change-Id: I869903f869e926117cd60beb92db0ce96606579a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715116
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680271}

Lottie player needs to set a size on the canvas it draws on. To do this
the size needs to be provided by the client and set by the worker.

Bug: 986954
Change-Id: I3c30885ed0e1e038def113bba427cff6b0b452a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716025
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680270}

When the Plugin VM has shut down (either via the shelf context menu or
from within the VM itself), we should close the window.

Also update the tests to always create a ChromeLauncherController so we
don't have to handle the null case, which doesn't happen otherwise.

Bug: b:134714407
Change-Id: I00dd36c8f61ca6187e118cdbd63ba89d6e357fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688465Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680269}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Please review and LGTM before July 16th or the CL will be
submitted as-is.

NOTRY=true

Bug: 977050
Change-Id: I3fef367cfa4a2abb2e5b2f4766ea592ccb8abfd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700845Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680268}