GitLab

Fixes required for SequenceManager/ThreadControllerWithMessagePump to
work properly on all platforms:

Always call MessagePump::ScheduleWork from EnsureWorkScheduled to avoid
deadlocks on some platforms.

Switch from implicit quit_do_work to quit_pending, which is set to false
when the current run loop (and ThreadController::Run) call ends.

Improve test coverage.

R=alexclarke@chromium.org
СС=gab@chromium.org
BUG=891670

Change-Id: I9fb554ed91cdca6982e773f4b29055b4ae99dc95
Reviewed-on: https://chromium-review.googlesource.com/c/1337501
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608521}

If there's a paint fragment, we're using it to paint, so we need
to get the ID from that, not from the LayoutObject.

Fixes 3 unit tests in paint_layer_painter_test.

R=chrishtr@chromium.org, kojii@chromium.org

Change-Id: Ieb3066e5a52c8b4ecdda20aa2226f5df6f32e7b4
Reviewed-on: https://chromium-review.googlesource.com/c/1338380
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608520}

This will allow native code to be stripped out of the main library
when it moves to a Dynamic Feature Module.  For now, the libraries will
be identical.

BUG=874584

Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913
Reviewed-on: https://chromium-review.googlesource.com/c/1332248Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608519}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/91de11099dcd..59127a5d3941


git log 91de11099dcd..59127a5d3941 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 ehmaldonado@chromium.org metrics: Spell out PII.


Created with:
  gclient setdep -r src/third_party/depot_tools@59127a5d3941

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=agable@chromium.org

Change-Id: I71ccced8500b4fc304c184c41ed3c239804944ef
Reviewed-on: https://chromium-review.googlesource.com/c/1338147Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608518}

The crash was caused by attempting to cancel and/or update the priority
of a connection attempt which had not yet started. Starting a
connection is posted in an asynchronous task, so it is possible that
the connection attempt is canceled before it has been attempted. In
this case, we were erroneously assuming that the connection attempt
metadata had already been set when it actually had not.

This CL fixes this race condition by explicitly checking if the
connection has been attempted before performing any operation which
touches connection metadata.

Bug: 888073
Change-Id: I183202863f8e018b5dfdf77e1b208843217689e7
Reviewed-on: https://chromium-review.googlesource.com/c/1338322Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608517}

The issue is related to the crashes http://crbug/829367 on Samsung (also, Lenovo
and Yulong) Marshmallow devices. Because of those crashes we prohibit setting
small notification icons as Bitmaps.

The icon coming from a web page shown in a TWA comes in a form of a Bitmap, so
we can't use that. A reasonable fallback would be to use the icon specified by
its resource id in meta-data for TWAService or by extending TWAService.

Unfortunately, there is a problem with that fallback as well. For M+ the small
icon has to be from the resources of the app whose context is passed to the
Notification.Builder constructor. Normally we would use the bitmap decoded (on
the client's side) from resource id. But then again, on Samsung M we can't set
that bitmap due to the crashes.

In this CL we create the context of client's app using Context#createForPackage,
pass that into NotificationBuilder, and that way we can use the icon id.

Since this approach is quite unusual and seems risky, it is used only in the
cases we're fixing, and protected by a feature flag.

Bug: 864786
Change-Id: Ia401f56b446e7dcc684697faea77ae2a3a402e67
Reviewed-on: https://chromium-review.googlesource.com/c/1228075
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608516}

Adds a channel for sending messages to web content. Messages can include
MessagePorts to allow for bidirectional message exchange between the
FIDL client and web content.

Promotes Blink CloneableMessage and TransferableMessage struct traits
to "public" so that the messages can be serialized and deserialized
by code outside Blink.

Bug: 893236
Change-Id: If4e23a65e9d35e1ed2ce80de95e9f2212c55aecf
Reviewed-on: https://chromium-review.googlesource.com/c/1318839Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608515}

This change updates the WebUsbAllowDevicesForUrls policy to use GURL
instead of ContentSettingsPattern for allowing devices to origins.

Design doc:
https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w

Bug: 854329
Change-Id: Idaf4fb27b96fb63d6c182e164fef64b5df2dcf4d
Reviewed-on: https://chromium-review.googlesource.com/c/1327805
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608514}

Specifically PasswordManagerInteractiveTest.PromptForXHRWithoutOnSubmit.

BUG=905789
TEST=test only change
TBR=mukai@chromium.org

Change-Id: Ia34a1d2b648964943efd137ab82a7c1082ae940a
Reviewed-on: https://chromium-review.googlesource.com/c/1338203Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608513}

menu_model_ refers to the root model, so it was previously checking the
enabled state of the wrong menu model.

Change-Id: Ia1a3662ea68779cbb86663973ba4599d9fabb054
Reviewed-on: https://chromium-review.googlesource.com/c/1336443Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jeremy Apthorp <jeremya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608512}

This is a follow-up to https://chromium-review.googlesource.com/c/1305891

Missed that Mac had its own impl.
Example problematic trace because of this http://crash/18c6999290e01f89

Made all impls match waitable_event_win.cc
(also ignoring the ScopedEventWaitActivity when idle)

R=fdoray@chromium.org

Bug: 899897
Change-Id: Ib5aa1cec487f80a6f1d603658279666ee0d1de60
Reviewed-on: https://chromium-review.googlesource.com/c/1336073Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608511}

This fixes a GC crash.

Change-Id: Ie5fcfdee033e8f2b45282bfc88d1210bf3a8d861
Reviewed-on: https://chromium-review.googlesource.com/c/1338335Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608510}

Actually puts top level hint processing and evaluation behind a new
Feature that is disabled by default (in case we need to revert hints
due to memory footprint or such).

Bug: 902802
Change-Id: I03735e1b724bbcdf32f7cf2eb5025978bc657ca9
Reviewed-on: https://chromium-review.googlesource.com/c/1338301Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608509}

This patch is a followup to https://crrev.com/605470 and removes more
cc::Layer hierarchy modifications from GraphicsLayers. We rely on
cc::Layers being updated in PaintArtifactCompositor (PAC).

Bug: 898668
Change-Id: I021119d3ddd3314bba03614f2fb4ce9f07ea62eb
Reviewed-on: https://chromium-review.googlesource.com/c/1337288Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608508}

Followup to crrev.com/c/1335207, which missed some @available calls.

Bug: 894099, 826369, 826011
Change-Id: I901cf055264b73ac6c2cebddabb0c050e53d8f0f
Reviewed-on: https://chromium-review.googlesource.com/c/1335960
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608507}

syncer::TestSyncService already supports most of the state that's
required here, so this lets us remove a bunch of boilerplate.

Bug: 859874
Change-Id: I3c45e341f31c199176dd8173b6a858a8c704c15f
Reviewed-on: https://chromium-review.googlesource.com/c/1335582
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608506}

This works around a hard to fix bug in pre-BGPT Blink compositing
code that involves mismatches between clips in the property trees
and clips in the graphics layers.

After BGPT launches, this patch can be reverted, and videos
changed to report ShouldClipOverflow() as true on their LayoutBox.

Bug: 900602

Change-Id: I76f5d18f2ecd9a10120d96c4a7898b641b5f557a
Reviewed-on: https://chromium-review.googlesource.com/c/1337289
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608505}

https://skia.googlesource.com/skia.git/+log/005fdd4ec834..ce7a16b318c9


git log 005fdd4ec834..ce7a16b318c9 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 benjaminwagner@google.com Upgrade NVIDIA driver on Win10 QuadroP400 bots.
2018-11-15 reed@google.com create shared helper for strikecache and SkFont
2018-11-15 mtklein@google.com commit to alpha bitmap procs


Created with:
  gclient setdep -r src/third_party/skia@ce7a16b318c9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:905062
TBR=rmistry@chromium.org

Change-Id: I80c6998cce041dcb084eb7e329cf014fdc65b73c
Reviewed-on: https://chromium-review.googlesource.com/c/1337645Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608504}

Currently when you try using Mojo without first initializing it
properly, you get an error message about the function not being
supported in "this version" of Mojo Core. This is marginally better
than a cryptic crash stack, but still misleading.

This CL detects when a missing function is due to a lack of Mojo
initialization and reports it as such.

Bug: 682732
Change-Id: Ia3f057171f2387a0387a7547a1a55fcc413cf7c0
Reviewed-on: https://chromium-review.googlesource.com/c/1337813Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#608503}

Will delete console references to chromium.lkgr once this lands safely.

Bug: 903591
Change-Id: I9263ff0fdbed95cc0430a4190338e92a871ccc09
Reviewed-on: https://chromium-review.googlesource.com/c/1338183Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608502}

This reverts commit 1dfd4418.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix video quad rect and surface output rect
> 
> Video surface output rect didn't take rotation into account so when
> SurfaceAggregator would stretch content to fill bounds, it would end up
> with the wrong scaling factors (squash in one dimension and expand in
> another) since the surface quad's bounds (in the embedder) were rotated.
> 
> To work around this (or by accident), VideoFrameResourceProvider was
> passing the rotated size as the quad's rect which doesn't make sense
> intuitively.  This also worked by accident with DirectComposition
> overlays because of applying another scaling which would fix the aspect
> ratio again.
> 
> This change makes it possible to use the |quad_to_target_transform| as
> is, without having to apply an aspect ratio correcting scaling, and to
> assume that the quad's rect is in the pre-transform space.
> 
> Bug: 904035
> Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234
> Reviewed-on: https://chromium-review.googlesource.com/c/1334971
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608495}

TBR=kbr@chromium.org,enne@chromium.org,sunnyps@chromium.org,liberato@chromium.org

Change-Id: I99727abc125468581caa0cf9e2ddea74351dd1f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 904035
Reviewed-on: https://chromium-review.googlesource.com/c/1338206Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608501}

Move keyboard configuration out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ia40aa6614ff1d386bdb3241c0fee9499d73d18a7
Reviewed-on: https://chromium-review.googlesource.com/c/1320655Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#608500}

Assets are confirmed to be the same.

Bug: None
Change-Id: I5dc86eb5462dc4f43a839061c1da4c7c67f3eb87
Reviewed-on: https://chromium-review.googlesource.com/c/1336221Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608499}

There was some incorrect logic in InProcessCommandBuffer. Presentation
feedback was getting sent to the GpuControlClient even if it didn't
request it. Worse yet, vsync timing parameters were getting updated if
presentation feedback was requested, even if the presentation feedback
didn't contain accurate vsync information.

On mac with OOP-D this was causing the real vsync timebase provided by
the browser to get overridden with junk. Mac doesn't have accurate
presentation feedback, instead it's just base::TimeTicks::Now() for when
swap buffers completed.

Share the existing logic found in GLES2CommandBufferStub and
CommandBufferProxyImpl with InProcessCommandBuffer to avoid future
problems.

Bug: 900564
Change-Id: Ib1bdb822b2357a905a923a537d4da7bf01ad0a25
Reviewed-on: https://chromium-review.googlesource.com/c/1337638
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608498}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a29a9947ac96..ab76e332de7a


git log a29a9947ac96..ab76e332de7a --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fjhenigman@users.noreply.github.com Validate uniform variable type in Vulkan (#1949) (#2055)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ab76e332de7a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I02a75ed134e8af75a34bc2793b5757226ee4b2de
Reviewed-on: https://chromium-review.googlesource.com/c/1338148Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608497}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30746749adb0..5ccf40a90be8


Created with:
  gclient setdep -r src-internal@5ccf40a90be8

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1190a2165c8e4bb31be6080a7c782ef9942aa66c
Reviewed-on: https://chromium-review.googlesource.com/c/1337642Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608496}

Video surface output rect didn't take rotation into account so when
SurfaceAggregator would stretch content to fill bounds, it would end up
with the wrong scaling factors (squash in one dimension and expand in
another) since the surface quad's bounds (in the embedder) were rotated.

To work around this (or by accident), VideoFrameResourceProvider was
passing the rotated size as the quad's rect which doesn't make sense
intuitively.  This also worked by accident with DirectComposition
overlays because of applying another scaling which would fix the aspect
ratio again.

This change makes it possible to use the |quad_to_target_transform| as
is, without having to apply an aspect ratio correcting scaling, and to
assume that the quad's rect is in the pre-transform space.

Bug: 904035
Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234
Reviewed-on: https://chromium-review.googlesource.com/c/1334971Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608495}

https://pdfium.googlesource.com/pdfium.git/+log/2585eafdcba3..2aa7e8cbc413


git log 2585eafdcba3..2aa7e8cbc413 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 tsepez@chromium.org Revert "Track indirect object holder in more CPDF_ objects."
2018-11-15 thestig@chromium.org Revert "Slightly simplify CPDF_FontEncoding::Realize()."
2018-11-15 tsepez@chromium.org Revert "Make orphaning old objects automatic during dictionary set/removal."
2018-11-15 tsepez@chromium.org Speculative fix for unit test failure under code coverage
2018-11-15 thestig@chromium.org Remove some inactive OWNERS.
2018-11-15 tsepez@chromium.org Better tests for AFSpecial_Format().
2018-11-14 tsepez@chromium.org Process XFA preamble by inclusion rather than hard-coded strings
2018-11-14 thestig@chromium.org Avoid writing out empty streams in CPDF_Stream::WriteTo().
2018-11-14 thestig@chromium.org Slightly simplify CPDF_FontEncoding::Realize().
2018-11-14 tsepez@chromium.org Make orphaning old objects automatic during dictionary set/removal.
2018-11-14 tsepez@chromium.org Process XFA config by inclusion in place of hard coded strings
2018-11-14 tsepez@chromium.org Process XFA locale by inclusion rather than hard-coded string.
2018-11-14 tsepez@chromium.org Track indirect object holder in more CPDF_ objects.
2018-11-14 thestig@chromium.org Add some basic CPDF_PSEngine tests.


Created with:
  gclient setdep -r src/third_party/pdfium@2aa7e8cbc413

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:901654,chromium:905142,chromium:901654
TBR=dsinclair@chromium.org

Change-Id: Id92cee32fc92da023a16e1bd5fe2e24b0752dbb3
Reviewed-on: https://chromium-review.googlesource.com/c/1337641Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608494}

Some enumerations have only a single entry of 0 (which is technically
an "underflow").  Support this by changing the maximum from 1 to 2.

Bug: 904964
Change-Id: If81522c55da292948f6a04cc51077111200537f1
Reviewed-on: https://chromium-review.googlesource.com/c/1336208Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608493}

Introduces a new Activity type to replace ChromeTabbedActivity when
running on a device with no touch input.

Bug: 904993
Change-Id: I8d9496fdb21735141b74135be3dc975a08c3e850
Reviewed-on: https://chromium-review.googlesource.com/c/1313556
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608492}

This reverts commit 21f4d499.

Reason for revert: crbug.com/905619

Original change's description:
> Reland "Get NetworkChangeNotifier working on ChromeOS with network service."
> 
> This is identical to crrev.com/c/1329897, but the underlying issue that
> caused that CL to break unit tests was fixed in crrev.com/c/1336066.
> 
> Original change's description:
> > Get NetworkChangeNotifier working on ChromeOS with network service.
> >
> > The current NetworkChangeNotifierChromeOS implementation won't work
> > with the network service enabled because it listens for network changes
> > from Shill, which only supports a single client. The browser process
> > has other dependencies on Shill, so it has to be the client for the time
> > being, meaning the network service can't directly listen for network
> > changes and has to be notified of them from the browser process.
> >
> > This CL splits the NetworkChangeNotifierChromeOS into two parts;
> > the first will live in the browser process and listen to Shill, while
> > the second is the actual NetworkChangeNotifierChromeOS implementation
> > which will have an instance in both the browser and network processes.
> > Since NetworkChangeNotifierChromeOS can't actually listen for network
> > changes itself, it just gets notified of changes from part 1 via a new
> > method in NetworkChangeManager. When the thing listening to Shill sees
> > a network change, it notifies its local NetworkChangeNotifierChromeOS
> > instance, and calls the new NetworkChangeManager method, the
> > implementation of which then notifies the network service's
> > NetworkChangeNotifierChromeOS instance.
> >
> > Bug: 882610
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274445
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#606665}
> 
> Bug: 882610
> Change-Id: I05ecbac510b479eb28520cc0b0ad5b613519fab7
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/c/1336154
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608265}

TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org

Change-Id: I0bda42c81a1e445c9d530576d8b6f75630d0c0d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882610
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1338204Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608491}

Bug: 900755
Change-Id: I07ed1f9e3bc27ff617b0f7d0f22ec5ac9ba22608
Reviewed-on: https://chromium-review.googlesource.com/c/1337069Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608490}

Bug: 893460
Change-Id: I40d49723dc53ee45178c95698f05d8cecc040097
Reviewed-on: https://chromium-review.googlesource.com/c/1318059
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608489}

Creates a new TopToolbarCoordinator to sit between ToolbarManager and
ToolbarLayout. TopToolbarCoordinator implements the Toolbar interface
and acts as the public message channel to other UI components.

The API surface in TopToolbarCoordinator is quite large currently.
Future CLs will attempt to slim the API surface.

BUG=897294

Change-Id: Ic16df5946f3373ecbea4a1f3e908c05086b2dbc1
Reviewed-on: https://chromium-review.googlesource.com/c/1336081
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608488}

TBR=alph@chromium.org

Bug: 905772
Change-Id: Ide0a5695213b14266e154dab9bbf0103f86713b8
Reviewed-on: https://chromium-review.googlesource.com/c/1338321Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608487}

This add layout tests to ensure javascript code caching is working as
expected. This also adds virtual tests with (
--enable-features=IsolatedCodeCache --site-per-process) to test that the
isolated code cache is behaving as expected. These tests test that:
1. code cache is created on the second visit to the script
2. code cache is consumed on the third visit to the script
3. code cache for the same script resource is not reused if
requested from a different origin (for the virtual tests).

This also adds a timeout expectation for the failing tests.

Bug: chromium:879494
Change-Id: I4b5b4cdce1f9dbccf31ba24f5efee2683b5a0579
Reviewed-on: https://chromium-review.googlesource.com/c/1329561Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608486}

add MSAN expectation

TBR=robertma@chromium.org

Bug: 856601
Change-Id: Idb002c64071199228cb2b5881e1e773de0325fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1338299Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608485}

Removes another stateful component of LoginBubble to make it easier to
refactor in subsequent CLs.

Bug: 905512
Change-Id: If3dca30e9bb531ca1acb829e79db07be6f86d3d8
Reviewed-on: https://chromium-review.googlesource.com/c/1336969
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608484}

If unspecified (in headers or content), resources like HTML in iframes
fall back to the parent's encoding. This should not be the case for
XML/JSON which have well-defined defaults.

Bug: 904017
Change-Id: I42f8950c5c2ef63c98bcec58a1f4b0bd0b190c33
Reviewed-on: https://chromium-review.googlesource.com/c/1331953Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608483}

Fix attribution floating above the custom link toast notification.

Bug: 851296
Change-Id: Ibcf9ae6e48f89d6a7fece3fa79455d4004bece05
Reviewed-on: https://chromium-review.googlesource.com/c/1336668
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608482}