GitLab

This reverts commit 9da458ed.

Reason for revert: Appears to have caused a buildbreak on win-archive-rel bot: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/10166

Original change's description:
> Manually roll src/third_party/perfetto 0dace75a3e64..08a30f8552a1 (8 commits)
> 
> https://android.googlesource.com/platform/external/perfetto.git/+log/0dace75a3e64..08a30f8552a1
> 
> git log 0dace75a3e64..08a30f8552a1 --date=short --first-parent --format='%ad %ae %s'
> 2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto"
> 2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling"
> 2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack."
> 2020-01-27 primiano@google.com Speculatively fix chromium roll
> 2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer
> 2020-01-27 primiano@google.com Update GN and mass reformat gn files
> 2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service"
> 2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px"
> 
> Created with:
>   gclient setdep -r src/third_party/perfetto@08a30f8552a1
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Bug: None
> Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55
> Tbr: perfetto-bugs@google.com
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Primiano Tucci <primiano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735490}

TBR=primiano@chromium.org,eseckler@chromium.org

Change-Id: I8de9e0549e3b7d6b22854e0e9da865a6145ea31c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023230Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735509}

Removes chromium.far from CIPD distribution, now the downstream
consumers have fully migrated to using "web_engine.far" instead.

TBR=sergeyu@chromium.org

Bug: 1029180
Change-Id: I2f80b641e20b7c06ec17ea7de27501d3a4eb1012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008273Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735508}

It now uses the same approach as the Settings back button per http://crrev.com/c/2006260

Bug: 1034183
Change-Id: I74661463921132db2756b916bed74d6384ca0215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020621
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735507}

Originally applied in
https://chromium-review.googlesource.com/c/chromium/src/+/1996132

Change-Id: I236a50a6a4592f280cc898bc5702b6b3d44b4f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022361Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735506}

Browser Action API tests exercise a fair amount of the "general"
behavior of the extensions menu, so it's good to have extra coverage.
Parameterize them (further) to run with and without the extensions
menu turned on.

Bug: None
Change-Id: I827a4ca4a66b4df185698a0fe68a71d80b28efac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020610Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735505}

Bug: 726475
Change-Id: Ia9068d24655c3cff62faeaf6eec7815fec4fdba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967792Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735504}

Extend SettingsActivity action bar shadow to ListFragments as well.
Currently, this is only used by the Search Engine Settings screen.

Manual test of new UI:
https://screenshot.googleplex.com/original/HLC5cp01rKb.png

Fixed: 988877
Change-Id: Iabc971dbbe19e11db83818d6c937a798ce8d494f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021333Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735503}

R=mseaborn@chromium.org
TBR=mseaborn@chromium.org

Bug: 1046033
Change-Id: Idc13f4bf1fc4417c5deba549129ff5b8c903ecfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023268Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735502}

We currently deep link to "chrome://os-settings/lanugages" which will
bring us to the languages section of top-level OS settings. The subpage
that is DCHECKed against is "chrome://os-settings/languages/details"
which will actually load the languages subpage.

We will now deep link to the actual subpage.

Bug: b:148303041
Change-Id: I4498e25d30dd890e43b8562a998d832cff4ea18e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023467Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#735501}

https://webrtc.googlesource.com/src.git/+log/8c79c6e1af35..2e4f440fdeb6

git log 8c79c6e1af35..2e4f440fdeb6 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 08a3245b..5a8e8ca5 (735303:735421)
2020-01-27 srte@webrtc.org Revert "Only include overhead if using send side bandwidth estimation."

Created with:
  gclient setdep -r src/third_party/webrtc@2e4f440fdeb6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ice9835e6440cad1f2b666668b060d8c9aa763719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023007Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735500}

Without timeout, the wait() may block infinitely if something
goes wrong during the sign in step.

Bug: 1010568
Change-Id: I244d8ea43f6ed691f0d55e55cb554b48f52e4c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017645Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735499}

TBR: pdr@chromium.org
Bug: 1046030
Change-Id: I0810c75544cec478ef2c71a7149a76a0cb99b487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023348Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735498}

https://quiche.googlesource.com/quiche.git/+log/3bbaaf584c20..2d483ad845f1

$ git log 3bbaaf584..2d483ad84 --date=short --no-merges --format='%ad %ae %s'
2020-01-24 quiche-dev Add a ProofSource to QuicCryptoClientConfig.
2020-01-24 quiche-dev Add a ServerProofVerifier and ClientCertMode to QuicCryptoServerConfig.
2020-01-24 quiche-dev Add an enumeration of client certificate modes to quic_types.h.
2020-01-24 quiche-dev Add a ServerProofVerifier interface to QUIC.
2020-01-24 fayang gfe-relnote: In QUIC, add OnOneRttPacketAcknowledged to TLS handshaker, and this is used to allow client mark handshake confirmed when handshake done frame is not supported. Not affecting prod, not protected.
2020-01-23 renjietang For IETF QUIC, Initialize bidirectional stream limit to 0, and unidirectional stream limit to the expected number of streams.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I9c904fab3011b18a35691b931f1a3dc115ca837a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022242
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735497}

Also renames translate::mojom::Page interface to
translate::mojom::TranslateAgent

No functional changes.

Bug: 1043351
Change-Id: I2994e1219ff95aadd3fd650ebb1ee79e7d7b37e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007319Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735496}

Waiting for the callback explicitly is more robust than running the
MessageLoop until idle and assuming that the callback has been made.

Change-Id: Icebbdc8ab0e0e9d59c6ea69c7c80dd21b2df965e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005449
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735495}

Create a new toggle that allows the ability to turn third-party cookie
blocking in incognito on and off.
https://screenshot.googleplex.com/LnvCaA3SB6W.png

Bug: 1040091
Change-Id: Iff32a67f6415b9fe72f9c92e4946074fdc9afc6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006548
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735494}

This is a reland of fd84ab8a

Original change's description:
> mac: roll to 10.15 SDK
>
> This change rolls the hermetic Xcode to 11.2.1 aka 11B53, with the
> 10.15 SDK.
>
> Bug: 1023913
> Change-Id: I072a57b5f9c93bc08984b05d0de3ea62886a59dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964531
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#725141}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993723
> Cr-Commit-Position: refs/heads/master@{#730238}

Bug: 1023913
Change-Id: Icb5ca715edd7972c8b3824aa58a8e2b8df25d15b
Tbr: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022257Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735493}

The new test should not be in WPT because the HasLineIfEmpty behavior is
not defined by any standards.

Bug: 1044853
Change-Id: I23e26f5ae23ccf8f283c876e8aba6f9b27f6b8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014626
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735492}

R=pkasting@chromium.org
TBR=pkasting@chromium.org

Bug: 1046028
Change-Id: I9c9ac87c461a10f572436fa58fbb8f492d7f4534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023465Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735491}

https://android.googlesource.com/platform/external/perfetto.git/+log/0dace75a3e64..08a30f8552a1

git log 0dace75a3e64..08a30f8552a1 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 eseckler@google.com Merge "build: add src/tracing/ipc/service to Chrome's libperfetto"
2020-01-27 treehugger-gerrit@google.com Merge "traced_perf: re-enable linux build + add x86 regs handling"
2020-01-27 fmayer@google.com Merge "Fix StackProfileTracker for empty callstack."
2020-01-27 primiano@google.com Speculatively fix chromium roll
2020-01-27 primiano@google.com Roll clang, libcxx and fuzzer
2020-01-27 primiano@google.com Update GN and mass reformat gn files
2020-01-27 primiano@google.com Merge "GN: clean up build files, split ipc client/service"
2020-01-27 taylori@google.com Merge "perfetto-ui: Fix canvas limit px"

Created with:
  gclient setdep -r src/third_party/perfetto@08a30f8552a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Change-Id: Ib610f52351d8b97a7a9f80f7c492e5a67b060c55
Tbr: perfetto-bugs@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022646Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735490}

TBR=robertma

Change-Id: I6608231fbf21ca05685cd44770577ddf1f37a707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019385Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735489}

The TemplateURL were not deleted when individual history
items were removed. This is deleted only via clear browsing.

The fix was to delete template urls for only those origins
which don't have any urls trace in the history. The deletion
is now made common for individual history deletion and clear
browsing data.

This CL also adds a browser test, where we add an URL to the history
and delete it and checks if the corresponding template url is
deleted too.

Bug: 87322
Change-Id: I0b51021c17b397d8ba172d0f882778436dd66c60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821611
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735488}

Device is going through enrollment flow rarely, and the logs that are
written by that flow should appear only once. Which means the additions
in this CL will not pollute the logs too much.

BUG=chromium:1021892
TEST=Manual check that logs appear as expected at enrollment.

Change-Id: Ia24c11f658ad9eb869390212bb7db8590b621135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991433Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735487}

This reverts commit 37ca67ee with
various non-trivial updates to the patch due to git conflicts as well
as logic having evolved meanwhile.

Reason for revert: users must have migrated to prefs after 9 months.
Clients that haven't migrated meanwhile will incur in additional data
downloaded from sync servers, and may worst-case run into undeletions if
they were unlikely enough to have pending local deletions.

Original change's description:
> Reintroduce sync cache GUID migration logic from directory to prefs
>
> After some back and forth, we've concluded that there's too much risk
> involved in assuming most clients have already migrated to prefs, i.e.
> cache GUID and birthday populated.
>
> As middle ground, we keep considering the values in prefs the
> authoritative ones, but if empty, we populate them from the sync
> directory. This adds some complexity, but allows us to defer the more
> aggressive turndown (disable migration), which in addition can now be
> guarded behind a feature toggle.
>
> Bug: 923285
> Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659030}

Bug: 923285
Change-Id: I35cad35fdd398db08ee3a5cea82eaee5ebd9e980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022787
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735486}

1. Snap the active window in clamshell mode
2. Switch to another user session
3. Switch to tablet mode
4. Switch back to the first user session

The snapped window should be carried over to tablet split view.

Test: manual
Change-Id: I830114212b595dc44c6513e9072141cd8282dadc
Fixed: 936610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021187
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735485}

Since all chromium clients in the renderer now use BrowserInterfaceBroker,
this change marks old methods returning InterfaceProvider* as deprecated.

Bug: 718652

Change-Id: Ie01d60d498e9118f7817ae9a44d2533a848b4b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020677Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735484}

https://skia.googlesource.com/skia.git/+log/b1e9971eb712..28a9b122f5a5

git log b1e9971eb712..28a9b122f5a5 --date=short --first-parent --format='%ad %ae %s'
2020-01-27 jvanverth@google.com Revert "Wrap page index packing in helper methods."

Created with:
  gclient setdep -r src/third_party/skia@28a9b122f5a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I3c6405c8830168605003b95d89e7b762f8092035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022974Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735483}

Tracks if ice configs could be fetched and parsed successfully, or if
we had to rely on default stun servers for creating the connection. The time
taken for response is tracked on the API dashboard.

Bug: 1031147
Change-Id: Ie79916fcbb50d6d762cdcb0f3915cebe4e7f9e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022707Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735482}

Why: scheme://eTLD+1 is the more natural delimitation between same-site
and not.


Bug: 986782

Change-Id: Ie932effc4c0bfc87375c4f70c9db2099294f54ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008027Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735481}

Programmatic smooth scrolls should also be instant if the smooth scroll
flag is explicitly disabled.

Previously landed in https://crrev.com/c/1536759 and in
https://crrev.com/c/2009842

To reland, this CL force enables the scroll animator in Blink web
tests. Without this, the usual flow for determining if the animator is
enabled is followed, which leads to inconsistencies. On Mac, the
animator is enabled in Chrome but not in content shell. This leads to
inconsistencies with other platforms (Mac tests ran without smooth
scroll while Linux/Windows ran with) and ensuring we test what we ship.

This change required some minor fixes to tests that assumed instant
scroll on Mac (and uncovered one real bug).

Second reland fixes a few more tests on Mac. See diff from original
patchset for changes.

TBR=flackr@chromium.org,nasko@chromium.org

Bug: 944583
Change-Id: Ib91c417f1fcc2b27601f2c7039b02da72b9d5420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022356Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735480}

This reverts commit 97c38202.

Reason for revert: miscompiles seen in crbug.com/1045948

Original change's description:
> Add UWP support to Windows toolchain.
> 
> Slight update to MSVC - VS version from 16.3.1 to 16.4.3 as a side effect.
> Other components kept at the old versions:
> Windows SDK 10.0.18362
> Debuggers 10.0.17763
> d3dcompiler_47.dll 10.0.17134
> 
> Packaging was done on a Windows Server 2019 VM, cleanly created for this
> purpose.
> 
> The package was created by downloading VS Professional 2019 installer
> from https://visualstudio.microsoft.com/downloads/
> and then running the installer like this:
> 
> $ PATH_TO_INSTALLER.EXE ^
>     --add Microsoft.VisualStudio.Workload.NativeDesktop ^
>     --add Microsoft.VisualStudio.Component.VC.ATLMFC ^
>     --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^
>     --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^
>     --includeRecommended --passive
> 
> The 10.0.18362.0 SDK was installed by this as well.
> Then Add or Remove Programs was used to modify the 10.0.18362.0 SDK to add
> the Debuggers package.
> 
> Then the packaging script was run like this:
> 
>   python depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.18362.0
> 
> Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping
> that the final packaging step was to unzip the package, copy over the two copies
> of that DLL from win_sdk\Redist, replace the Debuggers directory with the
> 10.0.17763 SDK, and then repackage the toolchain with:
>   > python package_from_installed.py --repackage=<full-path-to-toolchain-dir>
> 
> UWP support was previously added to package_from_installed.py
> in http://crrev.com/c/2007881 and http://crrev.com/c/2013579
> 
> Bug: 1032635
> Change-Id: I85313de0529aa7591e5066bc697c640c5dc52463
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015984
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734608}

TBR=thakis@chromium.org,ynovikov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1032635
Change-Id: Ib3caeaab51cbc4c133955585c5ab4ba69ac480de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022357Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735479}

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=treib@chromium.org

Bug: 1042208
Change-Id: I3461ae666e4338e945492df669a39f0fbeb445bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017526Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735478}

This patch removes display locking trace events that were not adding
any value. They are instead replaced with two new ones:
- A count of total locked display locks.
- An async slice for forced locks

R=chrishtr@chromium.org, flackr@chromium.org

Change-Id: Ic3e075767e53054aeb88f6860226f08162948021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022619Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735477}

This CL fixes VizProcessContextProvider to ensure that context_result_
is initialized on construction.

The GLOutputSurfaceBufferQueue tests are re-enabled: they surfaced this
issue and MSAN was failing on Linux.

Bug: 1045602
Test: Run GLOutputSurfaceBufferQueue tests locally with MSAN.
Change-Id: I0e8c3c210d099d4cabe1d583296ec1280ad79cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021543
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735476}

TBR: pfeldman@chromium.org
Bug: 1045980
Change-Id: Ibf77f8c7fcd6dad68e9e4d53869fadaf87908f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023145Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735475}

Fixed: 1040289
Change-Id: I759f6bee1bf641f6ca68ddfd8f59926c7e465441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017642Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735474}

When we detach a portal contents, we destroy its main frame's child RWHV.
If there is an ongoing cross site navigation in the portal's main frame
which has created a speculative RenderFrameHost, then the speculative
RFH's child RWHV is not destroyed. When the navigation commits, the
speculative RFH is set. Now the top level RFH has a child RWHV, which
leads to bad casts and a crash.

We now destroy any speculative RFH's RWHV.

Bug: 942194
Change-Id: Icbb2fa2e691c16f28aa37d305f495ce52a0f8880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018183
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735473}

This function has a truly weird contract that I didn't completely
understand initially, so I caused a regression.

Regression here:
https://chromium-review.googlesource.com/c/chromium/src/+/1955787

The weird contract is - it recalculates the match's classifications,
except in the case where we pass in a flag to forbid bold-all, and the
reclassification would otherwise bold-all. Then the function is
supposed to leave the existing classifications alone.

It's weird, but it's necessary for flicker-free search queries as the
user types with punctuation.

This CL fixes it.

It also adds some tests to prevent future regressions, as well as to
explicitly document the edge case.

I'll make a followup CL to do the same fix and test for NavigationResult
separately.

Bug: 1043440
Change-Id: Ieb4a9b6fd901eff9df553ce846c53e4ae11c0455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021316Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735472}

Bug: 951969, 936273
Change-Id: I87faaf33217d1d6bccc77710deceb71384babe58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987083
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735471}

This is a reland of c0e15aa2

Original change's description:
> assistant: add shelf layout unit tests
> 
> * Add a couple shelf layout tests to make sure when Assistant
>   is invoked in tablet mode with/without apps, the hotseat state
>   won't change.
> 
> Bug: None
> Test: unit tests
> Change-Id: I7103fe9489f780cd441942801aa4d03b71825dbe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013752
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734728}

Bug: None
Change-Id: I6b45dfe52c810805426bef07ed182354298958e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020526Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735470}