GitLab

This CL adds a "tab presentation delegate" to the tab grid view
controller, and has the coordinator implement that delegate protocol.

For now, the path to actually trigger the presentation of the active
tab goes through the tab switcher delegate (that is, MainController).
Once there are fewer tab switchers to support, that can be cleaned up.

Bug: 804534
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6d32e6c8145fe361ed4d6de51ced3d1178737a3d
Reviewed-on: https://chromium-review.googlesource.com/942344
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540286}

`clang-cl /Brepro -flto=thin` causes:

    warning: argument unused during compilation: '-mno-incremental-linker-compatible'

because /Brepro is a built-in assembler flag, which isn't used in LTO builds.

(We have an open bug on clang-cl somewhere to print the original spelling of
aliased flags.)

Bug: 330260
Change-Id: I72c6fb496107a7c937019293e6ad6f749a680a20
Reviewed-on: https://chromium-review.googlesource.com/944003Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540285}

Currently Aura Overlay Scrollbar paints in PaintedOverlayScrollbarLayer which
only paint the thumb part. In this patch, we paint the tickmarks when
we have tickmarks in scrollbar when PaintedOverlayScrollbarLayer update.

Bug: 759152
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9e351b475cd9afa14cdae9264a2b78ab36a18258
Reviewed-on: https://chromium-review.googlesource.com/641611
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540284}

A lot of surface synchronization and RenderFrameMetadata CLs coming up
in this area lately. Adding myself to OWNERS to allow us to iterate on
CLs locally.

Bug: none
Change-Id: I0ceb4b3bb5618bd96c1b396a765a730e9be779b5
Reviewed-on: https://chromium-review.googlesource.com/943595Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540283}

This reverts commit 89b772d7.

Reason for revert: Test CL for https://chromium-review.googlesource.com/c/chromiumos/chromite/+/940628

Original change's description:
> Automated Commit: New LKGM version 10451.0.0 for chromeos.
> 
> BUG=762641
> TBR=oshima@google.com
> 
> Change-Id: I84344160de382a6af51c5d97bcee16f3d8e2fd12
> Reviewed-on: https://chromium-review.googlesource.com/944007
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540280}

TBR=achuith@chromium.org,oshima@chromium.org

Change-Id: I54a2c2fa18bb9ca15c27053f029bfdfe26589cc2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762641
Reviewed-on: https://chromium-review.googlesource.com/944203Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540282}

rr defaults to writing the trace to $HOME/.local/share/rr but run-webkit-tests
creates a dummy home directory that is deleted after tests run. In order to
make this "just work" we can symlink .local/share/rr to the real directory if
it exists.

Bug: 817861
Change-Id: I845c023c3be98835bddb757dad9a18231c7e69ce
Reviewed-on: https://chromium-review.googlesource.com/943826Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540281}

BUG=762641
TBR=oshima@google.com

Change-Id: I84344160de382a6af51c5d97bcee16f3d8e2fd12
Reviewed-on: https://chromium-review.googlesource.com/944007Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540280}

Adding a method to the NetworkContext to clear the HTTP cache. The
implementation in the network service duplicates some of the code from
content::StoragePartitionHttpCacheDataRemover.

Changed the BrowsingDataRemoverBrowserTest.Cache test to work with the
network service. Since we do not want to expose more cache states
(such as cache size) for tests, we rely on reloading pages after
stopping the embedded server to test the page is available in the
cache.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5c7687f931d57cf09119e6e26ae5d1d61eb247f3
Reviewed-on: https://chromium-review.googlesource.com/909949Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540279}

Bug: 814935
Change-Id: I190604ed932cf23e8b9d38f9dbae3339ef1f76da
Reviewed-on: https://chromium-review.googlesource.com/944002Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540278}

Following bot results are included.
4003 4014 4011 4009 4004

0 lines were removed and 7 lines were deflaked by consecutive results
since 3971.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie2468e2f9c8c4dde18557d7d706f5087448c7b84
Reviewed-on: https://chromium-review.googlesource.com/942130
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540277}

This removes an unnecessary section from
WebrtcFrameSchedulerSimple::ScheduleNextFrame()
to address review comments on
https://chromium-review.googlesource.com/940449
and potentially improves performance and b/w utilization.

Bug: 816727
Change-Id: I76aaf326a48f985880ea7ff4ba4e16cc246862b3
Reviewed-on: https://chromium-review.googlesource.com/942484Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540276}

when packets go out of order.

Bug: 817496
Change-Id: Id0d0a987bd46664ab68ba04fe7134b4d19fee8e8
Reviewed-on: https://chromium-review.googlesource.com/941388
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540275}

changes:
Base CL is: crrev.com/c/738826.
UI review prefer one shortcut for this feature. So we are using
"Search+Alt+m". Instead of allowing user specify moving direction, we
just move window incrementally in sorted display id list and in a cycle
manner.

Bug: 778438
Test: tested on device and test coverage
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I35f946fd26885c0b435c437ef4dc766169989f8f
Reviewed-on: https://chromium-review.googlesource.com/942001Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#540274}

This results in significant overlap with the existing
SafeBrowsingExtendedReportingOptInAllowed policy, which is being deprecated here.

We continue to support SBEROptInAllowed as a legacy preference until it the
associated policy is deprecated, but we also need the pref for WebView.

Bug: 798808
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d0f32dff4575196a0d6b3e7120c3a76ff165751
Reviewed-on: https://chromium-review.googlesource.com/888859
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540273}

Adding a UKM metric to track whether a page was specifically requested
via voice search.

Bug: 808584
Change-Id: Id20c93ccf3c193e9559a2fbf5bcb87987e08fc1e
Reviewed-on: https://chromium-review.googlesource.com/940605Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540272}

The mesa packages were originally added because of an issue with installing
libgbm-dev on Saucy.  The CL description is inlined below:

------------------------------------------------------------------------
commit: 419a9a64
Author: primiano@chromium.org <primiano@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 19 18:26:18 2014 +0000

Fix installation of libgbm-dev package in install-build-deps.sh

crrev.com/106633002 has recently introduced a dependency on libgbm-dev.
Unfortunatelly, this package is a bit more trickier to install, for the
following reason: it depends on mesa-glx and, conversely to most of the
other packages, only one version of mesa (w.r.t backports) can exist in
the system. Google's workstations are configured to use the -lts-saucy
version of mesa. The right package in this case is libgbm-dev-lts-saucy
and attempting to install just libgbm-dev ends up in a failure.
This change fixes install-build-deps.sh, installing the matching version
of libgbm-dev (w.r.t libgl1-mesa-glx), falling back to libgbm-dev.
------------------------------------------------------------------------

Currently, this is causing issues on Googler's machines (see chrome-linux
mailing list).  Since the Saucy days are over, just depend on libgbm-dev
directly.  Tested on Ubuntu Trusty, Ubuntu Xenial, Debian Stretch, and Debian
Testing.

R=dpranke

Change-Id: I43568ab8b8c66c2aa6cd394c67f2cf90d6d1762c
Reviewed-on: https://chromium-review.googlesource.com/944047Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540271}

Collect Event.VizHitTest.AggregateTime, Event.VizHitTest.HitTestRegions,
Event.VizHitTest.TargetTime and Event.VizHitTest.TransformTime.

Bug: 817673
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaae1009aa74f679a2e40c56f62e24a6fb3422be4
Reviewed-on: https://chromium-review.googlesource.com/942604
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540270}

The new lint rule checks for non-existence and duplicate items.

Updated LayoutTests/SmokeTests for tests that have been moved or
deleted.

Change-Id: I3de74e519d36c08871af872d3a439ba28fe1bdc2
Reviewed-on: https://chromium-review.googlesource.com/942606
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540269}

ClipRect has a ToString function but did not have a stream operator
defined. This patch adds operator<<(..., ClipRect) which enables:
ClipRect clip_rect;
LOG(INFO) << "Clip rect: " << clip_rect;

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f34867fb50dd71c76779223ac7871e5e77dc568
Reviewed-on: https://chromium-review.googlesource.com/943679
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540268}

Bug: 817873
Change-Id: Ib22851d80508d65e5f9fa651af8dc629da17ddd4
Reviewed-on: https://chromium-review.googlesource.com/943830Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540267}

TabManager discards tabs, but also ARC processes.
LifecycleUnit is an abstraction to help us having one
code path for all discards.

Bug: 775644
Change-Id: I4d2e89a710afe097cc2d6222a6c156f57c774144
Reviewed-on: https://chromium-review.googlesource.com/842306
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540266}

These will be turned into deprecation warnings when we
start deprecating SDES crypto and the constraint.

Bug: 804275
Change-Id: I0c5763406b9f4bd32890708e34a132ad6553a929
Reviewed-on: https://chromium-review.googlesource.com/941955Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540265}

Fix browser tests that use host_resolver() and navigate in SetUpOnMainThread with the network service.

These currently silently fail, as we only sync the host_resolver() rules after SetUpOnMainThread returns. Improve this by watching the main window's WebContents for navigations and syncing the rules immediately.

This won't cover all corner cases, i.e. if a test navigates a new tab or window. However it should cover the majority of cases.

Bug: 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie14daf47582d187f6d4aa6bf0a36885997fee6c8
Reviewed-on: https://chromium-review.googlesource.com/940165Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540264}

This CL removes net/tools/get_server_time now that
//components/network_time_tracker is using a different mechanism
(x-cup-server-proof). This utility is no longer
relevant.

Bug: 801668
Change-Id: I0bc75a9d21244a0c3bbe0ed50da2783e7169c61c
Reviewed-on: https://chromium-review.googlesource.com/943343Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540263}

Regular upgrade to the newest public release of the VR APKs.

Change-Id: I3f6aa68192fc35d52cdfb946c8c1e197c06ecfdd
Reviewed-on: https://chromium-review.googlesource.com/942227
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540262}

Currently turning on the P2P sharing flag can lead to a crash in two
ways while trying to set up the file for sharing.  This patch checks
for a null file path, and returns instead of crashing if we do not
have a file path.

The two cases leading to this will be addressed separately.

In the first case, we might end up with a null file path.  This can
happen if we are sharing a content URI, which does not have an
associated file.  The proper fix is to re-share the content URI.
https://crbug.com/817608 is tracking the proper fix.

In the second case, (https://crbug.com/817611), we are trying to share
from a private directory.  We need to detect the attempt to share from
a private directory and prevent it. This will largely be mitigated
when we implement the planned upgrade task to move all offline pages
out of the private directory and into a public location, but we still
need to fix the bug in case a file fails the upgrade.

Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf

Bug: 758690
Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf
Reviewed-on: https://chromium-review.googlesource.com/937842
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540261}

This reverts commit 58866fc9.

Reason for revert: broke the build -- https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63495

Original change's description:
> Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
>              on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
>              HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30
> Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
> Reviewed-on: https://chromium-review.googlesource.com/941512
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540253}

TBR=jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: I0f0866b62d41f53b702d17681b6540c766db98b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/944122Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540260}

Currently, if you're in the Android tab picker and you're dragging to close a
tab, but your finger hits the other stack, we treat this as if you immediately
lifted your finger once it hit the other stack. This feels kind of weird and
jarring.

This CL fixes the behavior so the tab keeps getting dragged until you actually
lift your finger.

Bug: 817885
Change-Id: I5ea113d28dccfa33b29c33575f0b6e29f9dfb9ef
Reviewed-on: https://chromium-review.googlesource.com/935667
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540259}

Previously we did not handle the case of computing the value of an
interpolated transform, which occurs when we interpolate between
two different transform types containing percentages.

The correct result is currently not spec'd [1], so this patch fixes this
by just returning "none" in this case.

[1] https://github.com/w3c/css-houdini-drafts/issues/425

Bug: 816803
Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6
Reviewed-on: https://chromium-review.googlesource.com/942595Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540258}

We now use the BACKGROUND_SYNC permission to decide whether or not to
upload reports for a particular origin.  Note that as currently written,
we don't use this permission to decide whether to *collect* the reports,
only whether to *send* them.  Whether or not to collect is controlled
by the site's cookie settings.

Bug: 704259
Change-Id: I059019ab85106c26f4d156e9f5d61e2f8b8fa757
Reviewed-on: https://chromium-review.googlesource.com/937572Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#540257}

While presenting to a local display, if we remove the display with a
fullscreen presentation, the presentation can move to the display with
the controlling window while still being fullscreen and cover the
controlling window. This CL makes the presentation window exit
fullscreen in such cases.

Bug: 805139
Change-Id: I02c4234d95ee9477683550fdad454e1aee6b460b
Reviewed-on: https://chromium-review.googlesource.com/902889Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540256}

These tests originally passed the CQ mac bots because they are allowed
to crash due to http://crbug.com/816534 , and the CQ mac bot runs with
DCHECK enabled. Unfortunately however that hide the fact that on
non-DCHECK macs, the test has different output.

Bug: 772014
Change-Id: I4bbaeb853426ad48488111a667a6caf4ba7284f6
Reviewed-on: https://chromium-review.googlesource.com/939670Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540255}

The following CT Logs have passed their monitoring period and
are being added as trusted Logs in Chrome:

Google Argon2018, Argon2019, Argon2020, Argon2021
Cloudflare Nimbus2018, Nimbus2019, Nimbus2020, Nimbus2021

Bug: 756814, 756817, 756818, 756819, 780654, 780655, 780656, 780657
Change-Id: I6b8671db0dc7ba34b666345049934ed3e2b5705a
Reviewed-on: https://chromium-review.googlesource.com/942688Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540254}

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
             on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
             HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ

Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.

Bug: crashpad:30
Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
Reviewed-on: https://chromium-review.googlesource.com/941512Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540253}

Turned out the rounding made to calculate count could add significant
errors to the samples on regular allocation patterns. The patch
replaces count with the total value attributed to the sample.

BUG=803276

Change-Id: I2f40ad403275817696330d502dadfd76657a552a
Reviewed-on: https://chromium-review.googlesource.com/941734
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540252}

Bug: 807015
Test: None
Change-Id: I6b9ae265f6105dc7160f041b7e752785180889f3
Reviewed-on: https://chromium-review.googlesource.com/941389Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540251}

Before this CL, high contrast was applied to the contents of
the viewport twice (once on the copied contents, and another
since the viewport is a child of the root layer), resulting
in undoing its effect.
This CL updates the "inverted" status of the viewport layer.

BUG=817431
TEST=Added test coverage.

Change-Id: I4d946e5ae22f1232db74fecf7b32311073124055
Reviewed-on: https://chromium-review.googlesource.com/942602
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540250}

These are tests failing because of image (and image+text) diff.

Steps:
1. Tried on mac10.13_blink_rel.
2. Filtered out image & image+text failures.
3. Rebaselined these tests on Mac ports *only* (otherwise, many Win &
Linux expectations would be modified unwarrantedly).
4. Added back all the flaky expectations (these tests were not flaky in
this single job, which doesn't mean they are not flaky).

Lastly, a bunch of failure expectations associated with issue 701047 were
automatically removed by rebaseline-cl. After examination of the new
baselines, it seems the issue is indeed gone ("m" and "w" display correctly
on Mac 10.12 now).

Bug: 774301, 701047
Change-Id: I649a7973ca24752ae23f5f10bd82f0cf1c6901e9
Reviewed-on: https://chromium-review.googlesource.com/899783
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540249}

This test is failing on the Nougat bot. Since the feature is unshipped
and currently unowned, it's best to just disable for now. We'll block
the feature bug on reenabling it.

Bug: 773076
Change-Id: I30d019267116fcae937e86f5f514f2a260829dc4
Reviewed-on: https://chromium-review.googlesource.com/943246Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540248}

https://pdfium.googlesource.com/pdfium.git/+log/198792b7e860..71cdd20e9d74

$ git log 198792b7e..71cdd20e9 --date=short --no-merges --format='%ad %ae %s'
2018-03-01 rharrison Disable XFA tests without embedded fonts
2018-03-01 thestig Add a test for FPDFImageObj_GetBitmap() with a JBIG image.
2018-03-01 thestig Break up CFX_DIBSource::ConvertBuffer().

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iba02fd7b624598f40cf91a2f9b8a71f9750fbd6d
Reviewed-on: https://chromium-review.googlesource.com/943604
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540247}