- 23 Sep, 2019 40 commits
-
-
Anatoliy Potapchuk authored
This reverts commit 7f37ccd8. Reason for revert: I have menually tested the previously failing tests on linux-chromeos-os builders. Tests no longer fail, enabling them back. Original change's description: > [Sheriff] Disable many PolicyDeviceDisplayResolution tests. > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ConnectExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.SetAndUnsetPolicy/0 > PolicyDeviceDisplayResolution/DisplayResolutionBootTest.Reboot/0 > > TBR=antrim@chromium.org > > Bug: 1000694 > Change-Id: I58373a317fc917f79ff440ec14c62dc9d84cda6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800409 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696000} TBR=antrim@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000694 Change-Id: I179ddcf31fe0ac425ce6f5d8c99d2ed35420d962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813345Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#698854}
-
Chinglin Yu authored
This adds a new target, profile_provider_unittest, as part of chromiumos_preflight to make it build for cros_vm. The test will then be added as part of the tests that run on cros_vm per build for the chromium repo. The test exercises the perf collector end-to-end, from the chrome browser to debugd to make real perf collections. The test adds coverage to paths that are mocked by current unit tests. Bug: 1002751 Test: Reverse apply crrev.com/c/1764319 and check that the test crashes. Then apply crrev.com/c/1773881 and check that the test passes Change-Id: I6d11a26dcd726f5bc4b8dabc9810e31f1370e5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797948 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:Gabriel Marin <gmx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698853}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7cb60e812f16..b5578f4f0b22 git log 7cb60e812f16..b5578f4f0b22 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b5578f4f0b22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ia72def3dcfd3ea2e41245b8a407e635285a60027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698852}
-
Jan Scheffler authored
This patch adds decodes urls before trying to associate them with files from the local filesystem in workspaces. Bug: chromium:992717 Change-Id: I57678ee5db7fab7c43a254f9440b25744356c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807503Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#698851}
-
Ross McIlroy authored
Disables v8.browsing_mobile-future to free up capacity and enable us to update the mobile system_health stories to 2019. Once the 2016 versions are removed, we can re-enable this benchmark. BUG=chromium:878390 Change-Id: I32071bec5f1ce4fc75dfe4fe42ddf6c04397c4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813327 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#698850}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I63c119deea4ef10ae933bac434658d59f8e991fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818517 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#698849}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa002e6324b8..79a8474b8c1c git log fa002e6324b8..79a8474b8c1c --date=short --no-merges --format='%ad %ae %s' 2019-09-23 dberris@chromium.org Pinpoint: Pull out benchmark args to top-level Created with: gclient setdep -r src/third_party/catapult@79a8474b8c1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006658 Change-Id: I762342c494697d1a558cbb06e627b4fcdc9697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819120Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1006655 Test: Welcome banner won't popup. All other camera feature function normally. Change-Id: I7157845a9b9158e7a884a1589e51e8db3fc589ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818001 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#698847}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66e6e12e7e7a..db3a63384629 Created with: gclient setdep -r src-internal@db3a63384629 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I66381f0d9ccda04d60ed5a215076daed5aa31868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698846}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/170b5dd856b1..c1a585fab0c1 Add HB_NO_WIN1256 to avoid building support for .fon font files. This code also triggers a Clang warning for incorrect array size computation. See https://crbug.com/1002945 $ git log 170b5dd85..c1a585fab --date=short --no-merges --format='%ad %ae %s' 2019-09-21 ebrahim [gpos] minor 2019-09-21 ebrahim Fix clang -Wrange-loop-analysis complains 2019-09-21 ebrahim Minor, turn more of hb_apply to for each 2019-09-21 ebrahim [fuzzer] Don't process output in debug mode as it causes timeout 2019-09-14 ebrahim [ci] Re-enable debug builds on fedora bot 2019-09-21 ebrahim [ci] Enable HB_WITH_WIN1256 on -Weverything bot 2019-09-21 ebrahim [cmap] Turn hb_apply into foreach where possible 2019-09-21 ebrahim [cmap] minor 2019-09-21 ebrahim minor, use internal API instead public hb_set_has 2019-09-21 ebrahim [cmap] minor, turn 8 spaces to tab 2019-08-29 qxliu [subset] updates according to review comments 2019-08-21 qxliu [subset] Add integration tests for cmap14 2019-08-16 qxliu [subset] subsetting cmap14 2019-08-07 qxliu [subset] glyph closure for CMAP14 2019-09-18 ebrahim Avoid bitwise negate of enum value 2019-09-18 ebrahim minor 2019-09-18 ebrahim Don't rely on undefined left shift of negative value behavior 2019-09-18 ebrahim Don't seek of out-of-bound value even if the result is not used 2019-09-18 ebrahim Don't rely on nullptr deref recovery 2019-09-18 ebrahim Don't call memset when length is zero 2019-09-18 ebrahim [ci] Run -fno-sanitize-recover=undefined checks 2019-09-16 ebrahim Avoid stdint.h in Kernel module compiles 2019-09-16 ebrahim Extract an avoid errno compile flag 2019-09-15 ebrahim [doc] fix minor typo 2019-09-14 ebrahim [ci] Install cmake on macOS cmake/amalgam tester 2019-09-14 ebrahim [coretext] Fix double promotion warnings by making casts explicit 2019-09-14 ebrahim [ci] Don't build cmake tests in macOS bot 2019-09-14 ebrahim [name] Undef entry_{index,score} to avoid collision in amalgam builds 2019-09-14 ebrahim Rename GlyphID to HBGlyphID 2019-09-14 ebrahim [ci] Update and compile cmake/amalgam on macOS bot 2019-09-10 behdad Rename Fixed to HBFixed Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1002945 Change-Id: I6437e60a606cb7d7bcbb4813a215b104f40d7d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819176Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#698845}
-
Yi Su authored
Currently in WebStateImpl::ClearTransientContent we store a pointer to the SSLStatus of old visible nav-item, and compare it with the new nav-item after interstitial is dismissed. This will lead to a crash if old nav-item is released in the middle. Copying SSLStatus to a local variable will avoid this crash. Bug: 1001622 Change-Id: I0f0e78c5c8297516f79eb56c56b97b8a5c4d92e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816473Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698844}
-
Maksim Sisov authored
This functionality seems to be platform independent, so the PlatformWindow interface got new method: ShouldWindowContentsBeTransparent. It is now implemented for both X11 and Windows platforms (the last one was taken from DWTHWin). Now, the DesktopNativeWidgetAura::UpdateWindowTransparency sets the transparency based on the value returned from ShouldWindowContentsBeTransparent. In addition to it, the interface has default implementation and returns false as DWTHPlatform used to be doing before. The platforms that are interested in providing different values must override and implement that method. Also, setting native frame has been moved as long as OnNativeWidgetCreate call is passed all the way down from DWTHX11 to DWTHLinux to DWTHPlatform. Bug: 990756 Change-Id: I7069609a2abe068b3553039d2e03ab98c3babd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789222 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698843}
-
Sigurd Schneider authored
The title is not showing anyway, because <option> elements are not supposed to have a title property as per spec, and the browser discards the property. Bug: chromium:1005142 Change-Id: I89f24cd159a5cdbdbeadf71bc31a88abc00076ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815876Reviewed-by:
-
Andreea Costinas authored
This CL fixes WPAD with DHCP by creating a DHCP PAC file fetcher in //net that delegates fetching the URL to an interface. This interface is set at the service level to an object that does a mojo call to the browser process to retrieve the URL. The browser process then gets the web proxy auto-discovery URL from the NetworkHandler::DefaultNetwork which mirrors the network state of the Shill default network. Bug:991867 Test: manually tested on ChromeOS content_unittests --gtest_filter=ProxyServiceMojoWithDhcpPacFileFetcherMojoTest.ResolveProxySuccess browser_tests -gtest_filter=WPADHttpProxyScriptBrowserTest.Verify Change-Id: Ibf1ec1a6d8e69dcaf4a113b68b17151329d26308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790886Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#698841}
-
danakj authored
The EmulationHandler only enables touch or device emulation on the main frame. Currently the touch handler is explicit about this, which was added a few months after the check for being a local root. That change should obsolete the local root check (main frame is a subset of local root frames), though both remain in the code. Remove the local root comparison. The device emulation path still only checks for local root, but could be changed to main frame also for more clarity. The GetWebContents() method returns null only if the host_ is null, so instead of checking both of these for null, only call GetWebContents() when |host_| is not null, and change methods to check for |host_| in places that they checked for GetWebContents(). The GetRenderWidgetHost() on RenderFrameHostImpl never returns null, as per its comment: // Returns the RenderWidgetHostImpl attached to this frame or the nearest // ancestor frame, which could potentially be the root. For most input // and rendering related purposes, GetView() should be preferred and // RenderWidgetHostViewBase methods used. GetRenderWidgetHost() will not // return a nullptr, whereas GetView() potentially will (for instance, // after a renderer crash). // // This method crashes if this RenderFrameHostImpl does not own a // a RenderWidgetHost and nor does any of its ancestors. That would // typically mean that the frame has been detached from the frame tree. virtual RenderWidgetHostImpl* GetRenderWidgetHost(); R=yangguo@chromium.org Bug: 1006052 Change-Id: Ia43c2fb04de343f7c6e2c7cd1600a9bdc1a14908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815735 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Lowell Manners authored
This prevents tests that expect frames to be evicted from the cache from incorrectly passing (due to timed expiration). Change-Id: I41507b8fa808b1d5019bd1777706919a53c38407 Bug: 987187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813335 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698839}
-
Olivia Flynn authored
Addresses a bug where CodeMirror's update view process, which deletes non-visible nodes, causes Widget.js to throw many errors and crash the source code frame because Widgets have been inserted into CodeMirror lines, but cannot be removed by regular DOM operations. This occurs when scrolling with an edit breakpoint dialog open. This solution introduces a function to mark a widget as externally managed, which excludes it from its ancestor's __widgetCounter. Before and after gifs: https://imgur.com/a/CIFNO8Y Bug: 984762 Change-Id: Id569d201569461c863e53fe07b22f81683b4862e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705174Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Ib001f3b8064dbcd99a7149623a62397109be9305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818298 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Jason Lin authored
Enums |InstallationState| and |Error| in class |CrostiniInstallerUIDelegate| are moved to file crostini_installer_types.mojom and renamed to `InstallerState` and `InstallerError`. All other changes to .h and .cc files are just simple replacement to migrate to the new types. The purpose of this CL is to allow the js code of the new Crostini WebUI installer to use the same enums. Bug: 929571 Change-Id: I185bb94b79187db98850dba4d23a7ba221e1d1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815797Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#698836}
-
Yao Xiao authored
Use originating_contents when initiator origin is opaque Bug: 1005218 Change-Id: I4ea659b5ea1a233ee122c6fe5d48d00d6bbe9dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814624Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#698835}
-
Tomasz Moniuszko authored
Includes are redundant as safe browsing calls has been removed in https://chromium-review.googlesource.com/1233115 Change-Id: Icb8fd04ddd445f96218d674c7055967a9451e2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796351Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#698834}
-
Alex Danilo authored
Panel items can be created and attached to a a display panel by calling createPanelItem() followed by attachPanelItem() and they can be removed by calling removePanelItem(). Change the API surface for attaching panel items to ignore panel items that have already been removed using removePanelItem(). Bug: 1006124 Tests: Updated browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Change-Id: Id7dce8496f4a5cf2090b9071404bd45b5033ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819078Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698833}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b4c0ee19b74..776d81525e7c git log 5b4c0ee19b74..776d81525e7c --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3243c3b1..82de2e61 (463 commits) Created with: gclient setdep -r src/third_party/skia@776d81525e7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I5f91e282075740a46c8d167a5315c5242036dcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818293Reviewed-by:
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. - WebLocalizedString::kFileButtonChooseFileLabel - WebLocalizedString::kFileButtonChooseMultipleFilesLabel This CL keeps ToMessageID() and makes ToMessageID() returns |resource_id| as is if it doesn't match to any of WebLocalizedString::kFoo to replace WebLocalizedString::kFoo gradually. Bug: 995644 Change-Id: Ia56045df0b854f2da4cdfef167644ced277d8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768500Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#698831}
-
Pavol Marko authored
Now that the underlying flakes in https://crbug.com/1005082 and https://crbug.com/1005723 have been fixed, re-enable the auto enrollment test suite. Bug: 992022 Change-Id: I7e4adb637a7a56d9b161d9d89aa31ffcdceaad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817597 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698830}
-
Bao-Duy Tran authored
test data for Chrome OS. These test data are tightly coupled with the actual manifest of the IME extension in use. There are separate and independent manifests defined for Chromium OS and Chrome OS. Chromium OS: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/input_method/xkb_manifest.json Chrome OS: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json Current test data are based on the Chromium OS manifest and thus some tests are failing on Chrome OS build in cases where the two manifests differ. We should completely isolate test data for the two OSes and fix them for Chrome OS. Bug: 977170 Change-Id: Ibf47068264e20aa6028b32b60b5d98791c7f49eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808980Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#698829}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/510fd3c3..5f6491d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea21b33e5723afba9a1d17fb48e5c2b9846f25ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698828}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I5db070b8ce14beaf140c20b8ca3dc3c99714755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815989 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#698827}
-
Pavol Marko authored
Now that the underlying flakes in https://crbug.com/1005082 and https://crbug.com/1005723 have been fixed, re-enable the test suite. Bug: 1005697, 1005450, 1005451, 1005452, 1005453, 1005454, 1005455 Change-Id: I12935cd3e80d569168769709b273d748b04b0573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814920 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11e2cbc5cca3..66e6e12e7e7a Created with: gclient setdep -r src-internal@66e6e12e7e7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I97676e08c2a27278a3c90c6478cf298ebd62fd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819001Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4854b9f8047e..3c5f91b74871 git log 4854b9f8047e..3c5f91b74871 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e74d6b59..82de2e61 (698711:698813) 2019-09-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5cbf4ebd..e74d6b59 (698593:698711) Created with: gclient setdep -r src/third_party/webrtc@3c5f91b74871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Id8a59b70eca32bb37fbcecb8b72666e9bd2475b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819003Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4d60b5eda31..5b4c0ee19b74 git log b4d60b5eda31..5b4c0ee19b74 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b6fa949c4539..1f89f58faeb8 (5 commits) Created with: gclient setdep -r src/third_party/skia@5b4c0ee19b74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I73c6ae54ec1c248059f721f1ccca7febb16732d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819000Reviewed-by:
-
Alan Cutter authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media%2Fvideo-played-reset.html TBR=steimel@chromium.org Bug: 1006659 Change-Id: I23cba878f2ad2f993f946c6f11d8af49703580e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817869Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698822}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If8ebf2941057e20541961a6b5099f07c93a484dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818999Reviewed-by:
-
Alan Cutter authored
Mark external/wpt/html/cross-origin-embedder-policy/require-corp.https.html as flaky on debug builds https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fcross-origin-embedder-policy%2Frequire-corp.https.html TBR=pbos@chromium.org Bug: 626703 Change-Id: I48c678b89e40109b65967691143872e21b86bb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816062Reviewed-by:
-
Wei Lee authored
This CL supports the data chunk mechanism so that we could record long-length video via camera intents. Bug: 980812, 967611, b/131809655, b/134635999 Test: am start -a android.media.action.VIDEO_CAPTURE Change-Id: Ieb18c614d942fb1f59743a37eb5cfa9cbab40128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722167 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Darren Shen authored
We'll be doing some work on IMF so let's clean up the code a bit. I ran clang-tidy with: modernize-use-auto,modernize-use-equals-default,modernize-loop-convert, modernize-raw-string-literal,llvm-namespace-comment, modernize-use-emplace,modernize-use-using,modernize-raw-string-literal on //chrome/browser/chromeos/input_method/* //chrome/browser/extensions/api/input_ime/* Bug: 1005619 Change-Id: I1634591833f82e352d268bedb08516d0528b66c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815805 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698818}
-
Peter Kasting authored
Testing to see if this route avoids breaking the Linux Deterministic bot. TBR=bbudge Bug: 82078 Change-Id: I1512141cc886dafa6683f5ff38c6a50f35be067a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818998Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698817}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I8e681b7ef8cc78b94c14b0c97101a3a0a32459bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816414 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698816}
-
Alan Cutter authored
fast/canvas/OffscreenCanvas-copyImage.html and virtual/gpu/fast/canvas/OffscreenCanvas-copyImage.html are flaking on all debug bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=OffscreenCanvas-copyImage.html TBR=mstensho@chromium.org Bug: 974652 Change-Id: I841ef1902b831dbb5302efaec60d353ee1b5edb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817868Reviewed-by:
-
