- 26 Jun, 2020 40 commits
-
-
Aaron Colwell authored
Several pieces of code related to web view guests generate site URLs solely for the purpose of getting the appropriate StoragePartition. Now that there is a way to get a StoragePartition using a StoragePartitionConfig, all of these pieces of code can be migrated away from using site URLs and just use StoragePartitionConfigs directly. Bug: 1085275 Change-Id: Id7b4b6e0be52f762236e7b2281644f270a92193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254347 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#783076}
-
Nico Weber authored
Bug: 1098899 Change-Id: I7f03ab3d7305beec8057351f6c0aa50ccb9e4503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270700 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#783075}
-
Tom Anderson authored
Most of SendRequest doesn't depend on the template parameter |Reply|, so move the common code into a non-template function defined in the source file. This should hopefully reduce binary size since SendRequest() gets instantiated for every Request type (654 in total). BUG=1066670 R=sky Change-Id: Iee5934f42b1c4ceb02b3279452e4cadbb7a620fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268841Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783074}
-
Scott Little authored
The histograms OfflinePages.PageLifetime.* and OfflinePages.PageSize.* are still in use, so this CL extends their expiration. Fixed: 1089761, 1089762, 1089763, 1089764 Change-Id: I1781c89bb8b505918da20cecc486a69f68038951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268593 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783073}
-
ckitagawa authored
This CL modularizes PaintPreview to be a separate java target. See bug for design doc. Bug: 1097799 Change-Id: Ie7045db6bd913bb65c6d94862fef56fcd660a60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257560Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#783072}
-
Scott Little authored
This CL extends the expiration of two histograms that are still in use: OfflinePages.DownloadRequestTimeSinceDuplicateRequested and OfflinePages.DownloadRequestTimeSinceDuplicateSaved. Fixed: 975541 Change-Id: Ib164dbad14b981cbf92dadc78733235b9207cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268232 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783071}
-
Byungchul Kim authored
Bug: 1031540 Change-Id: I7a64d749c2c1f7484aedb8f7a7f74088972400f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270661Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Byungchul Kim <byungchul@chromium.org> Cr-Commit-Position: refs/heads/master@{#783070}
-
Mike Wasserman authored
Just check that the screen getter is invoked on fullscreenOptions. Tentative per the experimental web platform Window Placement feature. Bug: 1022988 Test: Automated Change-Id: I4d4064a8a912d679fd27f66cdf53e7f64e1cfe90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268310Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#783069}
-
Scott Little authored
The histogram OfflinePages.SQLStorage.StoreEvent is still in use, so this CL extends the expiration of this histogram. Fixed: 1089161 Change-Id: Ib70f47b6b3cb9fd6904908665cf39de07773eeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269758 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783068}
-
Scott Little authored
The histogram OfflinePages.Model.ConstructionToLoadedEventTime was removed from the code quite a while ago, and the latest milestone that I can find data for is M65. This CL marks the histogram as obsolete. Fixed: 1089145 Change-Id: I2fccc432fd993e73d6b08e55d294875103a279f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268591 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783067}
-
Scott Little authored
This histogram seems to have been removed quite a while ago, and the latest milestone I've found data for is M65, so this CL marks the OfflinePages.BatchDelete.TotalPageSize histogram as obsolete. Fixed: 1089137 Change-Id: Ib41a51928451b311018a644d29a9545404d3cb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268777 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783066}
-
Dominic Farolino authored
This CL makes ImageLoader::ShouldLoadImmediately perform a stricter check, such that we skip queueing the image loading microtask less often. The stricter check we perform is equivalent to the HTML Standard's list of available images tuple-matching logic [1]. This changes the image loading behavior for cases where an image request is made for a resource that is in the MemoryCache, but has a different CORS settings attribute / credentials mode. Consider the following, which are all requesting the same image: - An image resource was fetched with CORS settings attr B, and is in the MemoryCache / list of available images - An image request (1) for the same resource is made, with CORS settings attribute A - An image request (2) for the same resource is made, with CORS settings attribute B Prior to this CL, request (1) would skip queueing a microtask, because ImageLoader::ShouldLoadImmediately would naively consider the cached resource a match. The request would go the ResourceFetcher, and ResourceFetcher::DetermineRevalidationPolicyInternal would realize a cache miss, because the CORS settings attributes did not match. The ResourceFetcher would add the resource that was fetched with CORS settings attribute A to the MemoryCache. Then request (2) would be made, and the server would see both requests (1) and (2). After this CL, ImageLoader::ShouldLoadImmediately is more strict, implementing the same CORS settings attribute check that ResourceFetcher::DetermineRevalidationPolicyInternal does. ImageLoader queues a microtask for request (1). Then, request (2) is kicked off before the microtask is run, and requests (1) and (2) are coalesced. The server only see one (correct) request. [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:list-of-available-images R=yoavweiss@chromium.org Bug: 1093977 Change-Id: I3ca9a3cf63177572a8f45fa6be8a3b0c25f9c539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244191 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#783065}
-
Katie Dektar authored
This reverts commit 1312dd58. Reason for revert: During review of crrev.com/c/2243761, it was determined that this approach may sometimes remove the wrong entries from the navigation stack. Reverting, will try a new method after offline discussion. Original change's description: > Remove reader mode page from navigation stack on desktop. > > This means users will not be able to navigate to Reader Mode pages > using "back" or "forward" buttons, matching behavior in Android. > > Also improves the ReaderModeIconViewBrowserTest by resolving a TODO. > > AX-Relnotes: n/a. Reader mode is still behind a flag. > Bug: 1090588, 1087949 > Change-Id: I016a02b95b1a3acbff9299c518e8bf2780379d32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235988 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777001} TBR=ellyjones@chromium.org,wychen@chromium.org,katie@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090588, 1087949 Change-Id: Ibbdbf4d09ef0734848a9f12a3acf159720de967e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270697Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#783064}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Iaa71445dca0f193a1dfd1ea899c0b9756e964892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268460Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d43c3788d782..efc55b0134fa 2020-06-26 philipp.hancke@vonage.com sdp: test media type mismatch behaviour If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I114fa751e01d7abfaa5e85c5038abc20339ddb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783062}
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: 869492 Change-Id: I1dfe10e8444a7e36e50cf128a33667c68ca86639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270344 Commit-Queue: Scott Little <sclittle@chromium.org> Auto-Submit: Dominic Farolino <dom@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#783061}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/711a56c023b5..9eb483838965 2020-06-26 treehugger-gerrit@google.com Merge "Edit inline comments in .proto files" 2020-06-26 fmayer@google.com Merge "Add doc to client_ext.h." 2020-06-26 treehugger-gerrit@google.com Merge "Support partial heap graphs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied853007c9c2907cd64e9f4196651107c2d3d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783060}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia4ac6eb542d7376561fa2e104f0c9b6e10ef6c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783059}
-
Collin Baker authored
This reverts commit 89c9ea26. Reason for revert: two builds after this flaked in ../month-suggestion-picker-mouse-operations.html and ../datetimelocal-suggestion-picker-mouse-operations.html: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Original change's description: > Reland "Use wheelTick in forms/resources/common-wheel-event.js" > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. This CL we should replace > eventSender.mouseScrollBy with wheelTick which uses > gpuBenchmarking.smoothScrollByXY in > forms/resources/common-wheel-event.js. > > TBR=ellyjones@chromium.org,avi@chromium.org,sky@chromium.org,bokan@chromium.org,lanwei@chromium.org > > Bug: 1047176 > Change-Id: Ib45dce450fe395d53a443612033305bccef6b19d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268227 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783007} TBR=ellyjones@chromium.org,avi@chromium.org,sky@chromium.org,bokan@chromium.org,lanwei@chromium.org Change-Id: Ia0617e5e297d571c6812af0a31e69b26688d37ba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269750Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#783058}
-
Dominique Fauteux-Chapleau authored
TBR=cammie@chromium.org Bug: 1099758 Change-Id: I581ff1493f52d23f4d8018442de11a3b57b86f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270346Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783057}
-
zhaoyangli authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/8fbc948c8479..af46d99e3add $ git log 8fbc948c8..af46d99e3 --date=short --no-merges --format='%ad %ae %s' 2020-06-23 chanheepark Add GREYFailureHandlerHelpers.h to Xcode project. 2020-06-23 tirodkar GREYErroFormatter link up. 2020-06-23 tirodkar Move GREYErrorFormatter to CommonLib 2020-06-22 chanheepark Implement GREYErrorFormatter. 2020-06-22 tirodkar Fix project 2020-06-22 tirodkar rm unused statusBarOrientation / pre iOS8 calls. 2020-06-19 tirodkar Change GREYError keys. 2020-06-18 tirodkar RM new line after Search action info that's printed. 2020-06-17 tirodkar Unused property 2020-06-17 tirodkar Error Formatter Change 0. 2020-06-17 tirodkar Enable the ScrollView Indicator Test to work on any device config. 2020-06-16 tirodkar Failure Formatter update 2020-06-16 tirodkar Scroll Bar Synchronization 2020-06-10 tirodkar Remove Duplicated stack trace 2020-06-10 tirodkar Add animation information for sublayers of a UIView in the UIHierarchy. 2020-06-09 tirodkar https://github.com/google/EarlGrey/pull/1335 2020-06-05 tirodkar Fix doxygen comments for @return in the HostDOCategory. 2020-06-02 tirodkar Remove redundant message from the Keyboard dismissal error. 2020-06-02 chanheepark Remove description glossary from EarlGrey error message: 2020-06-02 tirodkar Revert "keyboard-dismissal-redundancy (#1322)" 2020-06-02 64929355+willsaid-google keyboard-dismissal-redundancy (#1322) 2020-06-02 albertbow Rewrite eDO app port test. 2020-06-01 tirodkar Error printing cleanup for search action & details. 2020-06-01 chanheepark Reformat error message when the app under test crashes. 2020-05-29 64929355+willsaid-google fixed 4 error typos (#1320) 2020-05-29 albertbow Add specific reasons to app-side eDO failure. 2020-05-28 tirodkar Comment update in GREYHostApplicationDistantObject 2020-05-28 mobile-devx-github-bot Add openDeepLinkURL to the Swift EarlGrey wrapper. 2020-05-27 chanheepark Remove tap constraint for checking if the button is enabled or not. 2020-05-27 chanheepark Fix broken error handling test. 2020-05-26 tirodkar Remove attribute constructor from GreyHostAppDO 2020-05-26 chanheepark Removed bundle ID from console output for error handling #1308 2020-05-21 tirodkar Internal GREYAppConfiguration refactor. 2020-05-20 tirodkar https://github.com/google/EarlGrey/pull/1307/files 2020-05-20 64929355+willsaid-google System version error (#1307) 2020-05-12 mobile-devx-github-bot Comments formatting updates 2020-05-11 chanheepark Fix failing functional test due to some eDO bug. 2020-05-11 mobile-devx-github-bot Update comments to match structure, required by doxygen 2020-05-11 tirodkar Patch https://github.com/google/EarlGrey/commit/86065a68f15a1674659b892cba007c76eb7f24d9 2020-05-08 chanheepark Remove test flag. 2020-05-08 mobile-devx-github-bot Replace `import` with `include` for c headers in EarlGrey2 2020-05-07 64929355+willsaid-google cleaned up xc schemes, and updated swift version to 5.0 for build errors (#1294) 2020-05-07 sskhandp Move static into method to scope it more tightly. 2020-05-07 sskhandp import to include for c headers 2020-05-07 tirodkar Fix the DistantObjectBackgroundExecutionTest 2020-05-06 tirodkar Remove did Happen interaction notifications. 2020-05-06 chanheepark Fix operand to AND so it sleeps only for iOS 12 and below with non delete key. 2020-05-06 tirodkar Remove did Happen interaction notifications. 2020-05-05 tirodkar Fix deep link API for iOS 13+ 2020-05-05 chanheepark Revert workaround for the automatic keyplane change when backspace is tapped. (...) 2019-12-04 mobile-devx-github-bot Pass in GREYTraversalObject directly to GREYVisibilityCheckerTarget. 2019-12-02 albertbow Translates eDO connection failure to application crash when the situation is met. 2019-12-02 mobile-devx-github-bot Change orders of the condition check. 2019-12-02 mobile-devx-github-bot Add initializers to GREYTraversalObject and make the properties readonly. 2019-11-30 tirodkar Fix xcode proj. 2019-11-29 sskhandp Rename last vestiges of GREYHierarchyObject. 2019-11-28 szymonkaz fix for GREYTraversalProperties 2019-11-27 sskhandp Remove unused method in default failure handler. 2019-11-27 mobile-devx-github-bot Integrate traversal properties to quick visibility checker. 2019-11-27 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-26 sskhandp Format GREYKeyboard.m. 2019-11-26 tirodkar Formatting fix. 2019-11-25 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-25 mobile-devx-github-bot Have accessibility elements to use traversal properties as well. 2019-11-25 mobile-devx-github-bot Support retrieving the interactionPoint of the target in quick visibility checker. 2019-11-25 tirodkar Fix podspec 2019-11-24 konrad.zdunczyk Fix EarlGreyTest.podspec 2019-11-22 mobile-devx-github-bot Change core actions' diagnosticsID. 2019-11-22 mobile-devx-github-bot Create a metadata class that stores useful information about the traversal element. 2019-11-18 tirodkar Expand interaction error legend. 2019-11-15 mobile-devx-github-bot In progress of implementing quick GREYVisibilityChecker::visibleInteractionPointForElement 2019-11-15 mobile-devx-github-bot Mark unused variable in failure handler 2019-11-14 mobile-devx-github-bot Move out some method to visibility utility file. 2019-11-13 tirodkar Fix project 2019-11-12 mobile-devx-github-bot Removing glossary and replacing [K] with the actual character string. 2019-11-11 tirodkar Remove @synthesize calls form v2 code where not needed. 2019-11-11 mobile-devx-github-bot Checking for zPosition is done on the higher level during traversal. 2019-11-11 mobile-devx-github-bot Add back-to-front traversal that sorts its sibling views by their zPositions. 2019-11-08 sskhandp Move block into variable for nicer formatting. 2019-11-08 mobile-devx-github-bot Initializing performFallback to NO as a default value. 2019-11-08 mobile-devx-github-bot Rename directory for VisibilityChecker. 2019-11-08 mobile-devx-github-bot Add corner case for updating boundingRect. 2019-11-06 tirodkar Fix warnings. 2019-11-06 tirodkar Update Podspecs for EG 2.1.0 release. 2019-11-06 mobile-devx-github-bot Changing the order of the view hierarchy back to front. 2019-11-06 tirodkar Clean up EDO imports. 2019-11-05 tirodkar Add EG 2 Changelog. 2019-11-05 tirodkar Experiment for draining before shifted view after-screenshot 2019-11-05 mobile-devx-github-bot Restructure visibility checker files to accommodate GREYQuickVisibilityChecker. 2019-11-05 mobile-devx-github-bot Changing the order of the view hierarchy back to front. 2019-11-05 mobile-devx-github-bot Internal change 2019-11-04 mobile-devx-github-bot Check q/Q instead of e/E to determine if keyboard is showing alphabetical keyplane. 2019-11-04 sskhandp Fix broken link in README and minor grammar changes. 2019-10-31 tirodkar Fix project break. 2019-10-31 mobile-devx-github-bot Added fast visibility checker files to VisibilityChecker. 2019-10-30 albertbow Remove invocation on keyWindow in iOS 13 and use alternative. 2019-10-30 tirodkar Remove grey_md5. 2019-10-29 tirodkar Initializer cleanup. 2019-10-29 tirodkar Remove unused key. 2019-10-29 tirodkar Duplicate Matcher for UITextField iOS 13 fix. Created with: roll-dep src/ios/third_party/earl_grey2/src Besides the roll: - Changed BUILD.gn file to build with file/directory changes. - Fixed the OWNERS file in ios/third_party/earl_grey2. - Disabled failing tests from this roll. Bug: 1097387, 1030701, 1099361, 1099358, 1099425, 1099429, 1099430, 1099432, 1099435, 1099436 Change-Id: I048899b3fe758d7e08124c4a3f5ac8cfe5449a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264942Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#783056}
-
Michael Chang authored
Currently the macOS updater code for //chrome/updater lacks self registration. Adding self registration for Install and Promote functionalities. Bug: 1097373 Change-Id: I2a435b49cbcf76a32d6a4c38185b6b55e5c786b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255124 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#783055}
-
Chris Davis authored
This change adds stack overflow protection for the recursive call to build the bookmarks tree. The depth of the tree is limited to 200 as we do for importing bookmarks. Anything deeper than this is silently ignored in the sync operation. Bug: 1093190 Change-Id: Id0cab5097aadc9068a77578ec4c39de536d3818a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246791 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#783054}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eb0a25a189b7..5c7b568c6d20 2020-06-26 thakis@chromium.org mac: Add ARM64 support to swiftshader. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1098899 Tbr: swiftshader-team+autoroll@google.com Change-Id: I8c814d9960804d266ce8bb0449c4436a92473390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783053}
-
Torne (Richard Coles) authored
Mention fieldtrial_testing_like_official_build to ensure builds don't get the test field trial config. Change-Id: I3f664bcf0c81d6d6dde33a4830e13f0dc11e15b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269747 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783052}
-
Tomasz Wiszkowski authored
This change replaces existing implementation of Accessibility with ViewCompat variant for compatibility with early Lollipop devices and adds more verbose announcement for executed action when user interacts with the Header view. Bug: 1099441 Change-Id: Ia3a63643dd3bfa19f46b10ae5b895b482ec3f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268229 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#783051}
-
Javier Ernesto Flores Robles authored
Log `localizedDescription` instead of `description`. Log the code of the error. Bug: 1091927 Change-Id: Iea21882a5847741fbe19196549c2deeda4f24234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270440 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#783050}
-
Mario Sanchez Prada authored
Following up on the steps of crrev.com/c/2254025, we can also remove the code in BlinkAXTreeSource that sets the |routing_id| field of the AXContentTreeData that will be sent to the browser process as part of an AXContentTreeUpdate structure, since we can easily get the same information in RFHI when the message arrives in the other side. Since this |routing_id| field was the only part of AXContentTreeData that was not included in ui::AXTreeData already, this change allows us to completely drop AXContentTreeData from the codebase along with all the related .mojom and *_traits.{h,cc} files, which gets us one step closer to the objective of crbug.com/1094150. Bug: 1094150 Change-Id: Icc3161ed9e13a8215d99d29cf6d05c66f33418e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260776Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#783049}
-
Xiaohui Chen authored
Bug: None Change-Id: I906c85c64f30e3bce4782225cf52c5a25cf470eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268458Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#783048}
-
Alan Screen authored
Out of process handling of metafile composition can have artifacts due to mismatch selection of font typeface of default system fonts. Avoid this by serializing typefaces with the other picture display lists of the metafiles so that the exact same font is used in composition. Bug: 1044996 Change-Id: I0dc9e8e03bc7d39c36381d125a3b2b612b191f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123108 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783047}
-
Hirokazu Honda authored
This fixes a wrong DCHECK condition due to the typo. Bug: None Test: video_decode_accelerator_tests for vp9 k-SVC built with --dcheck_always_on=true Change-Id: I00a682f4d3e642064ca8f00bff69dc799c062722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269602 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783046}
-
Nate Chapin authored
While in the neigbhorhood, simplify DOMWindow::DoPostMessage and don't use Document where the window suffices. Bug: 1029822 Change-Id: I31ad50e6f758b3f706d90da60d3df53ccd3c3838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268258Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783045}
-
Alan Screen authored
When adding typeface serialization for out of process metafile composition the renderer processes will try to cache the typefaces so that they are transmitted only once instead of on every page they are used. This will create a new dependency for internal processing within the print compositor service. If a page to be composited requires subframes and is delayed until they complete, then subsequent pages will also need to wait since they could be dependent upon typefaces included in this earlier page's metafile stream. This change is part of the needed support to eliminate imaging artifacts from mismatched fonts which can happen when typefaces do not get serialized with the pictures. Bug: 1044996 Change-Id: I2730b6130be7fe74da7c2b93f0f52f3995f97dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266030Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#783044}
-
Nico Weber authored
This reverts commit aae3a263. Reason for revert: breaks fuchsia_x64 on cq, crbug.com/1099786 Original change's description: > Sync: Delete ModelTypeHelper.java > > It was part of the old invalidations implementation, and not used > anymore. > This was the last reference from sync to third_party/cacheinvalidation, > so all references to that are also removed from BUILD.gn and DEPS > files. > > Bug: 1099672 > Change-Id: I3491fa1cea04d0deebe68988cd3af5a5a4da1afb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270182 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783025} TBR=treib@chromium.org,mastiz@chromium.org Change-Id: I463dd6d98c8b2c93734628557c01c376b231b62f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269746Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783043}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6c33eabe079..e922953cabe4 2020-06-26 robertphillips@google.com Adjust how GM::gpuSetup is handled in the tools 2020-06-26 bsalomon@google.com Add async rescale and read APIs to SkImage. 2020-06-26 michaelludwig@google.com Use GrMatrixEffect in gradients instead of GrCoordTransform 2020-06-26 fmalita@chromium.org [skrive] Rectangle support 2020-06-26 reed@google.com Revert "Revert "clean up after big refactor of SkColorFilter --> ...Base"" 2020-06-26 adlai@google.com Reland "Consolidate GrDrawingManager <-> GrRenderTask lifecycle" 2020-06-26 robertphillips@google.com More *ooprddl GM changes 2020-06-26 robertphillips@google.com Make gpuSetup draw a error message on failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I198ab6564c03e44ed881a9ddf02edaf136a55f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783042}
-
Charlie Reis authored
This CL updates the description of SiteInstance and the various process models now that Site Isolation has launched. It also separates the notions of the ideal abstraction (agent cluster represented by principal and browsing context group) from the practical implementation (where the definition of "site" varies by process model). BUG=1015882 Change-Id: I93a8d495ea3ab8dc69a5446d83dd841ee9fae64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256605 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#783041}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cba0d2713ec8..397cece951f6 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-26 kimjae@chromium.org OWNER: Add AU Owners for build_dlc* 2020-06-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-25 mmortensen@google.com query_build_logs: support case-insensitive queries. 2020-06-25 bpastene@chromium.org chrome_chromeos_lkgm: Run LKGM updates on normal CrOS bots. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I6829d0778e22c84421caa986e4cdb6c5f840c3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783040}
-
chrome://nearby-internalsJuliet Levesque authored
Add a tab that will eventually display Nearby-related logging. See the following screenshot for display: https://screenshot.googleplex.com/rWNCYHoapn3. Bug: 1093634 Change-Id: I61b291c20e3563c88a64e398b4320403496f7e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246557 Commit-Queue: Juliet Levesque <julietlevesque@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#783039}
-
Ryo Hashimoto authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/bd15beb76e99..1609e471b69a $ git log bd15beb76..1609e471b --date=short --no-merges --format='%ad %ae %s' 2020-06-22 hashimoto arc: Add a new D-Bus service arc-sensor-service Created with: roll-dep src/third_party/cros_system_api Bug: b:148764483 Test: build Change-Id: I4a18e48884418289d3dc13f31dcb3860834f7198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266193 Auto-Submit: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#783038}
-
Hitoshi Yoshida authored
CookieListItem is an IDL dictionary which is used as an output parameter. It has two nullable members, but their values were not set if they were null. This CL explicitly sets null values if it is expected. Bug: 839389 Change-Id: I29b4bf81a3db72835617c16f7b3120c1d2be9409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269381 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#783037}
-