GitLab

Bug: 757967
Change-Id: I863cb3dc5cc9d3e08dadaeef6ec064c16085b8b8
Reviewed-on: https://chromium-review.googlesource.com/627061Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496516}

This reverts commit ab6ca8e1.

Reason for revert:
NOTIMPLEMENTED() that caused the error has been removed from the path with the CL below. I will re-enable the test. 
https://chromium-review.googlesource.com/c/chromium/src/+/570740

Original change's description:
> Disable WebRTC VerifyCanvasCaptureWebGLFrames (timeout-flaky).
> 
> TBR=emircan@chromium.org
> 
> Bug: 740762
> Change-Id: Ib1714450f52d2fb9634c68c9bc455f09484cca39
> Reviewed-on: https://chromium-review.googlesource.com/566081
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485467}

TBR=emircan@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 740762
Change-Id: I5d312ffc8e024d303ea175809457bd3de8807cbb
Reviewed-on: https://chromium-review.googlesource.com/627038Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496515}

Ensure that long press allows text selection with the stylus on
Windows.

Rename the supression setting for touch and reuse it for pen as well.

BUG=756951

Change-Id: Ie5c0e75c5ac1d67409c8b4e915db44084fe8348d
Reviewed-on: https://chromium-review.googlesource.com/627136
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496514}

This is a reland of d2506f13
Original change's description:
> Improve suspending logic.
> 
> When loading takes too long, we can suspend the codec before
> we have a chance to load the first frame. This is all normal,
> but should only happen when we are waiting on the network.
> This CL makes sure that we have additional progress callbacks
> expected before suspending.
> 
> Bug: 728468
> Change-Id: I815520e0ba832617b04948f7fbefb88498cf79b7
> Reviewed-on: https://chromium-review.googlesource.com/614360
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494212}

Bug: 728468
Change-Id: Ide175e6e5c8d2ecaeeb81b0055352f66c917d099
Reviewed-on: https://chromium-review.googlesource.com/627616Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496513}

Currently rating and price labels seem to belong to neighbor items.
This commit changes the alignment as the new spec shows to fix this issue.

Bug: 757603
Change-Id: Id05320ee6bf6a9856c9540b0b9e39915cfc0b790
Reviewed-on: https://chromium-review.googlesource.com/627122Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#496512}

Previously it was not invoking EventTargetWithInlineData's wrapper-tracing
method, so this was getting lost in the override. This bug was previously
hidden by the redundant tracing of event listeners which was removed in
r491479: https://chromium.googlesource.com/chromium/src/+/d68025ec

A layout test for this case has been added.

Bug: 756611
Change-Id: I98c8dc49eef3b49c20788a55ca2843521051cd5e
Reviewed-on: https://chromium-review.googlesource.com/627421
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496511}

Otherwise, compositor scrolls might result in the callback being called
on the cc::Layer, which then dereferences the disposed PaintLayerScrollableArea,
before the Blink lifecycle has a chance to update and delete the cc::Layer.

Bug: 747719
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I72656d6ed49e1707d9e9554a72f39b61ed7ecec9
Reviewed-on: https://chromium-review.googlesource.com/627022
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496510}

TBR=mmoss@chromium.org

Change-Id: I226869f66f1b4bc45dea6a6f0bcabd4dd04f5f6b
Reviewed-on: https://chromium-review.googlesource.com/627393Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496509}

The conversion from an uninitialized void* to a T* triggers CFI, but this
is as-designed (the caller of VectorBuffer, in this case circular_deque,
is responsible for calling placement new and delete on this buffer).

Change-Id: I375800df238f2a077720e7d73c35a2e9140f91de
Reviewed-on: https://chromium-review.googlesource.com/627017Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496508}

This is temporary instrumentation to track down root cause of issue
756790.  It will be removed after collecting a few crash dumps with
this data.

Bug: 756790
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ifed68777902ec71ab5366f692337f2148949d677
Reviewed-on: https://chromium-review.googlesource.com/624634Reviewed-by: Charlie Reis (OOO Aug 17-24) <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496507}

Was using == instead of String equals to compare app ID with the
holdback string.

Bug: 758017
Change-Id: I42531ea7bd3895d012f326805f3ca77b182dd1c6
Reviewed-on: https://chromium-review.googlesource.com/627641
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496506}

Currently cc::ResourceProvider includes output_surface.h but it doesn't
use cc::OutputSurface. This CL removes that include and adds additional
includes directly that were included implicitly by output_surface.h.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I11da4873ecb5fbee20f52191aaa9064601aff02d
Reviewed-on: https://chromium-review.googlesource.com/627416
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496505}

- allow nodes to be clicked one beyond their text content regardless of where the node falls in the overall line
- the action node should always be the one that best fits the position as we pick the last actionable node span
- selection uses this node so selections can be made at the end of a node's text content as well

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9062ec48dddeda5f85165bac4971bf858cb1ded5
Reviewed-on: https://chromium-review.googlesource.com/618291Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496504}

Skip nans because they cause Skia asserts.

Bug: 752757
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8ac1ac10c785dad5eb74dd33107f1febb7e361c4
Reviewed-on: https://chromium-review.googlesource.com/627394
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496503}

Always use AppListDelegateImpl for Shell AppList notifications.
(avoid AppListPresenterDelegate[Mus] duplication/disparity)

Remove the delegate removal TODO, may relate to crbug.com/733662
(the delegate may be necessary until ui/app_list moves into ash)

Fix root window checks (they're null for invalid/old display ids).

Rename TestAppListPresenterImpl, connect with the ash app list.
Add helpers to spin a run loop on app list show/dismiss (via mojo).

Enable numerous tests on Mash that rely on the presenter, etc.
Avoid mock app list notifications when possible in tests.

Bug: 730887, 696028, 695751
Change-Id: I19a3f8adc7ca66a7ad81fb254198c96fb4428ae3
Reviewed-on: https://chromium-review.googlesource.com/624515Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496502}

Bug: 
Change-Id: I4b7ffbe40e81c2e2f13feda4dae3437dbf07977b
Reviewed-on: https://chromium-review.googlesource.com/627390Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496501}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0fab1ee4..20961d26

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I36fecd9b64be80274577865e72dcf09497c031f7
Reviewed-on: https://chromium-review.googlesource.com/627301Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496500}

Bug: 667560
Change-Id: I69b68f6b19ca39ec86daa5a5c5a71c4f6c8b571c
Reviewed-on: https://chromium-review.googlesource.com/626619
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496499}

* Disable POSIX signalling from BrowserTestBase for Fuchsia
  (not compatible).
* Switch EXPECT_DEATH tests to EXPECT_DEATH_IF_SUPPORTED for
  TestBrowserThreadBundleTest.
* Add fuchsia to the list of supported platforms in
  fieldtrial_to_struct.py.
* Move webrtc deps into "enable_webrtc" conditional block.


Bug: 754861, 756269
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2cce36ca3cebfeb0acf86ad0c2cf0cd0f8645f51
Reviewed-on: https://chromium-review.googlesource.com/619727
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496498}

The google logo on the NTP should be accessible using VoiceOver.

Bug: 755754
Change-Id: Ib1ae5cb7895aa0d24532c42e9a0659435427ac49
Reviewed-on: https://chromium-review.googlesource.com/623747
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496497}

Previously the stack trace inside logcat is not symbolized, making it
difficult to debug.

This cl creates a logcat_symbolizer that symbolizes the stack trace in a logcat with
the new stack_symbolizer and replaces the unsymbolized stack trace in logcat
with the symbolized stace trace. The logcat_symbolizer will be called when we record
logcat during test runs.

Bug: 657040
Change-Id: Ie6c762a088a8e32dbb7095eb661d3a8a25918baf
Reviewed-on: https://chromium-review.googlesource.com/592492
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496496}

Ash doesn't need to maintain its own enum of user metrics. Eliminate the
ones for keyboard accelerators and inline calls to base::RecordAction().

Remove unused user actions discovered during cleanup.

Bug: 616581
Test: ash_unittests
Change-Id: I3306b3e954d52439b79bb43ec5944ecf1bb9faad
Reviewed-on: https://chromium-review.googlesource.com/627057
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496495}

The media download button is now integrated into the media controller.
There is no need for a standalone button

BUG=672539

Change-Id: I562002197f01d9c75869824f1d1bf1c4c2d0227b
Reviewed-on: https://chromium-review.googlesource.com/611325
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496494}

When an HttpStreamRequest is done, cancel any orphaned
HttpStreamFactoryImpl::Job. We do not gain much by leaving the
orphaned Jobs around to do connection establishment. In both
TCP's and QUIC's cases, canceling Impl::Job does not terminate
the underlying connection attempt.

This will allow us to simplify the JobController code further --
now that it doesn't live longer than a HttpStreamRequest. I will do
follow-ups to clean up unneeded code.

Bug: 757548
Change-Id: I7d4c09f5625b27c778a74ed0b44fa83a2b0db695
Reviewed-on: https://chromium-review.googlesource.com/624420
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496493}

Please see the demo:
https://bugs.chromium.org/p/chromium/issues/detail?id=753067#c9

BUG=753067
R=erg@chromium.org,sky@chromium.org

Change-Id: Idfc5d9a37f73b22c35339140ad858f4615849556
Reviewed-on: https://chromium-review.googlesource.com/626856Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496492}

This patch adds UKM reports for background tabs audibility. Currently we
collect audible signal at frame-level, both main frame and child frames
are using the same source id to report UKM.

BUG=731270, 753486

Change-Id: I461ea2d8a6ef742fcb2850250ad68a5b71c89600
Reviewed-on: https://chromium-review.googlesource.com/604515
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496491}

Bug: 667560
Change-Id: I02c0fef9c64c8d0846f97a12f28caa308b9d3eaa
Reviewed-on: https://chromium-review.googlesource.com/622102Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496490}

There is minimal ambiguity for tree related classes to reference the
LayerTreeHostImpl as host_impl rather than layer_tree_host_impl, and
reasonably high value from shorter code.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifb4e1c098ba8aa840aaa5c2ccf91e5b525a4be8b
Reviewed-on: https://chromium-review.googlesource.com/627389Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496489}

This patch introduces //components/viz/common:resource_format which only
contains the resource format and associated utils. The top level common
component publicly depends on this.

This means that other components can still simply pull in common and get
the resource format as well, but it also allows components to only
depend on resource_format, thus avoiding pulling in other common deps.

The patch also cleans up some comments and includes in the resource
format area

R=fsamuel@chromium.org, piman@chromium.org

Change-Id: Ia1cab35bce015e02290d8a71ef70cbe26a1a6c43
Reviewed-on: https://chromium-review.googlesource.com/626676Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496488}

R: pwnall
Bug: 757142, 756754
Change-Id: Id055826191299965eddf8640eb09c640ad3f58c3
Reviewed-on: https://chromium-review.googlesource.com/627019
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496487}

These metrics will give us a sense of how expensive the GetProgramsData
operation is on our user's machine.

Bug: 754488
Change-Id: I85d12045fa0de33284f902c844766ece6205071e
Reviewed-on: https://chromium-review.googlesource.com/612504
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496486}

Already disabled in non-threaded format.

TBR=pdr@chromium.org

Change-Id: I1b25a923836337a1f262d163d7d53c4ad47db165
Reviewed-on: https://chromium-review.googlesource.com/627395Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496485}

This CL removes the pending requests map and associate a
QuicStreamRequest* with an active Job. This to avoid having
to maintain two containers that can go out of sync. The linked
bug suggested that they can be out of sync.

Bug: 750271
Change-Id: Idaa41ece587f1a63130b0b93fad4ed74f69f3468
Reviewed-on: https://chromium-review.googlesource.com/627116Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496484}

Currently, we decide whether to propagate a scroll by looking at the dominant
axis of the scroll, and see if scroll-boundary-behavior prevents the
propagation in that direction. This brings complexity to the code, and
confusions to the user, but was a compromise because railing wasn't present in
GestureScrollBegin.

Now we have railing in GestureScrollBegin(r492983), so any scroll_delta passed
to the renderer is a non-trival scroll and should be taken into account. This
patch prevents the scroll being propagated if the scroll has any delta on the
direction prevented by scroll-boundary-behavior.

Bug: 754397
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie0a0681a0d6e515adc6f2e28ccf482cf13b70771
Reviewed-on: https://chromium-review.googlesource.com/611092Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496483}

This change adds a null check to the function that updates the
omnibox results container visibility. If there is no container,
do nothing.

BUG=753455

Change-Id: I12f714effe178a8e2408f0f1e9daa210d87216de
Reviewed-on: https://chromium-review.googlesource.com/625075Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496482}

If enabled, SafeBrowsing URL checks will behave in the same way as when Network
Service is enabled. In other words, they don't defer starting requests or
following redirects, no matter on desktop or mobile. Instead they only defer
response processing.

Currently the feature is disabled by default. Follow-up work:
- Make the corresponding change on Android WebView.
- Following the finch experiment process, send out a doc/email to request a
  finch experiment.
- Remove the old behavior eventually.

Bug: 715673
Change-Id: I9b23efc58965a82dcb3ba0ccaa91a77bdccbca92
Reviewed-on: https://chromium-review.googlesource.com/625034
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Varun Khaneja (slow) <vakh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496481}

BUG=757977,738613,757938,648274
TBR=pdr@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I163c04bddfd2922adf78b87cb18749b5f02e9b4a
Reviewed-on: https://chromium-review.googlesource.com/627024Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496480}

Previously the mojo::edk::ChannelFuchsia was hard-wired to cope only
with file-descriptors for simple files, which wrap a single underlying
platform handle, e.g. a virtual memory object containing the file data.

This CL extends the implementation to cope with MXIO file-descriptors
which build on multiple platform resources, notably device files such as
"/dev/zero". We make some assumptions about the contents of the |info|
returned with the unwrapped handles, so this may need revisiting in
future.

Bug: 734791, 740791
Change-Id: I6aac82bb5b34995381d08bd5b0f8df44a156bc37
Reviewed-on: https://chromium-review.googlesource.com/624815Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496479}

This reverts commit 9de3fd9b.

Reason for revert: 

Given https://chromium-review.googlesource.com/c/chromium/src/+/627259, it is safe to revert this revert of 616100. For details see revert reason in CL 627259.

Original change's description:
> Revert "Fix UI bugs when hiding context menu submenus and their children"
> 
> This reverts commit 3f8c6daa.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Note from Catherine Mullings:
> 
> Btw, this other CL (https://chromium-review.googlesource.com/c/chromium/src/+/616100/) depends on 553578. If you revert 553578, you'll need to revert 616100 too
> 
> (and I've reverted 553578).
> 
> 
> Original change's description:
> > Fix UI bugs when hiding context menu submenus and their children
> > 
> > This CL fixes a bug on Mac so that when a context menu submenu is
> > hidden, it does not appear in the context menu. Related on Mac, this CL
> > fixes the case when a context menu submenu's children are hidden, so
> > that the context menu submenu contains the empty menu item, "(empty)".
> > 
> > The second bug indicated above is fixed on Linux as well in this bug.
> > 
> > Note that this patch depends on the on-going implementation being
> > reviewed here: https://chromium-review.googlesource.com/c/553578
> > 
> > Bug: 750802
> > Change-Id: Ic8c7c0a1c8da11adb3fc5dfb271f26b28c35a41c
> > Reviewed-on: https://chromium-review.googlesource.com/616100
> > Commit-Queue: catmullings <catmullings@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#496370}
> 
> TBR=sky@chromium.org,tapted@chromium.org,rdevlin.cronin@chromium.org,catmullings@chromium.org
> 
> Change-Id: Id431bc9898a3a1cdabb829ad7168d81c211383b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 750802
> Reviewed-on: https://chromium-review.googlesource.com/627016
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496387}

TBR=sky@chromium.org,tapted@chromium.org,rdevlin.cronin@chromium.org,dschuyler@chromium.org,catmullings@chromium.org

Change-Id: I24310cb1211e12c92f5207e5d8f895e31581a3d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750802
Reviewed-on: https://chromium-review.googlesource.com/627186Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496478}

In this CL, SchedulerWorkerPoolImpl::SchedulerWorker::Delegate now
implements the BlockingObserver interface. Note: In this CL, only
BlockingType::WILL_BLOCK will supported.

When ScopedBlockingCall is instantiated with WILL_BLOCK, 
SchedulerWorker::Delegate::BlockingScopeEntered will
increment |worker_capacity_| and create a new worker if needed. When
the ScopedBlockingCall object is destroyed, |worker_capacity_| is 
decremented back.

Bug: 738104
Change-Id: I19e1a2ba6cc11cf77cd8cc3de487b2f4a2bbc351
Reviewed-on: https://chromium-review.googlesource.com/612502
Commit-Queue: Jeffrey He <jeffreyhe@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496477}