- 04 Feb, 2020 40 commits
-
-
Becca Hughes authored
Since we have the aggregate watchtime in seconds it will be easier if we store the watchtime in seconds, especially since we don't need millisecond level accuracy. BUG=1024351 Change-Id: I985d6f9d42c1d7ccf3eb9ba88c0dba1bc14e93e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037633 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738332}
-
Rouslan Solomakhin authored
Before this patch, a null payment method section or unselected payment instrument could result in a NullPointerException inside of the isMicrotransactionUiApplicable() method in PaymentRequestImpl. This patch null-checks the payment method section and the selected payment instrument before accessing them. After this patch, isMicrotransactionUiApplicable() will not throw NullPointerException. Bug: 1046938 Change-Id: I14335effa84c5ca44a2de960f63e25fe3eb5ee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033676 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738331}
-
Amy Huang authored
Currently on windows some binary sizes are too large, and compressing debug info sections solves the issue. Linux has zlib while windows does not, so this change downloads and builds zlib and uses it to build llvm. BUG=1004965 TEST=None Change-Id: I74f2700e14855e3e74c73753c16df7195b3944f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846781 Auto-Submit: Amy Huang <akhuang@google.com> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Amy Huang <akhuang@google.com> Cr-Commit-Position: refs/heads/master@{#738330}
-
Danyao Wang authored
Bug: 996468 Change-Id: I6027b0693d1ab516a7c3a9b94df82d8ca3c4ef49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035303 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738329}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. The supervised user feature isn't coupled to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. On Android, it is always equivalent to the primary account. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400 Test: updated existing unit tests Test: add user and signin works with both parent and child accounts webui for parent controls works, webui for child account setup works Change-Id: Ic45dd82bb3d5e3cbd53d32bc5b68abec677ba636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026176 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738328}
-
Mihai Sardarescu authored
This CL is a follow-up to CL http://crrev/c/2033252 and it extracts the sign-in EarlGrey2 tests to a separate test module. It also re-enables the tests. Bug: 1045478 Change-Id: Ifff26f5a4821a086d5722c168152a80aafc61cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035992Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738327}
-
Vikas Soni authored
Remove the flags to disable AImageReader on android media path. This is because AImageReader has been enabled by default on chrome starting M76. Change-Id: Iddb8d112095d59479d337feae4abee59289690f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036354Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738326}
-
Saman Sami authored
Relands https://crrev.com/c/2016327 but avoids calling BufferQueue::GetCurrentBuffer() in GLOutputSurfaceBufferQueue due to issues with empty swaps. Plumb mailbox for the primary plane to OverlayProcessorOzone and use SharedImageInterface to obtain the corresponding NativePixmap. Bug: 756454,1047030 Change-Id: I78466b2225b2d4402b853f9f7cbade485144b18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036430 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#738325}
-
Bo Liu authored
The effective process importance is computed from many inputs that can change independently. An undesired case happens when one change causes a binding to be dropped, but a closely-followed subsequent change adds the binding back. This causes the process to temporarily drop the binding which then can cause the OS to kill the process. Use a herustic to delay calls to drop bindings to avoid situations like this. To be conservative, only use apply this delay on the initial one second of the process to avoid wider impact. Bug: 1045059 Change-Id: I73462cf3c43140416871ef7abef3d77a419ca5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031305Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738324}
-
Patrick Monette authored
This CL adds WorkerNodeImpl::OnFinalResponseURLDetermined() so that the |url_| field can be set when it's value is available. Bug: 1048332 Change-Id: Ida299a8b587aa7753d30023e0d36d11907037d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036366 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738323}
-
Peng Huang authored
The CL fixes two problems which cause the test failure. 1. Vulkan surface is destroyed asynchronousl. When chrome re-creates vulkan surface with the same AWindow, the old vulkan surface may still exist. And then the new vulkan surface creation will fail. 2. GrContext is abandoned when chrome goes into background, and then the same GrContext will be reused when chrome goes back to foreground again. Bug: 1033170,1012282,1048692 Change-Id: Iedcb524d1215329c89c32fb633414e167e77bd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036442 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738322}
-
Natalie Chouinard authored
Move datareduction settings alongside other datareduction code. Bug: 1047357 Change-Id: I2946c09be6dc5b7d3b390eac70fffe49af534cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031543Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0e3f952babd58e1b019c4e42d6c5099a1faaa145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037501Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738320}
-
Kevin Schoedel authored
This covers the case of a RenderWidgetHost for a subframe, for which we do not receive View notifications. Bug: b/148303679 Change-Id: Iaaf6748b0a40e37e83d8b54925666f254a8b392d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037635Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738319}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/00a610e6768c..047cb6914ae5 git log 00a610e6768c..047cb6914ae5 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 khamu@microsoft.com Fixed high contrast in Elements panels. 2020-02-04 tvanderlippe@chromium.org Migrate network/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@047cb6914ae5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80a71a2cb4de0b6eaa7b524d9be971740227e995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738318}
-
chrome://settings/settings_v3.htmlDemetrios Papadopoulos authored
Previously this was happening for optimize_webui=false only. Changed it to happen also for optimize_webui=true case. Bug: 1026426 Change-Id: Icb8610e5aafc69e03510b575ec4700a9f9228d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037074 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738317}
-
Brian White authored
Change-Id: Id9fa420ba24a5ef1c5bc6b3be15a82c0b189ec8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036376 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
rbpotter authored
This is imported by settings_animated_pages, which will be migrated to Polymer 3 in a followup. Bug: 1026426 Change-Id: If0808e2b900f869a6bc317b509be502bf5b836bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036928Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738315}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.4-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I52fd13039c5c0cc3a8eeb019fbe0be26cc2d8c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037623Reviewed-by:
-
Olle Liljenzin authored
The make_dafsa script is extended with a switch that when applied will reverse the order of all input strings, so that end characters appears first in the generated graphs. Together with a new lookup function host names can be looked up from right to left to find the longest suffix matching entire components separated by dots. GetRegistryLengthImpl() is modified to use the new lookup function, replacing the loop with repeated lookups by a single lookup. Tests on a larger set of host names from an external source showed a reduction in the total number of lookups by 50% and total time spent in GetRegistryLengthImpl() was down by 40% in average. All hosts used in the tests were valid and resulted in positive registry lengths. Similar performance gain was obtained also after the set of host names was modified to produce negative lookup results. BUG=678334 Change-Id: Ie6da70ef6ee33194da2988078e78c5eca6495453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033512Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Olle Liljenzin <ollel@opera.com> Cr-Commit-Position: refs/heads/master@{#738313}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ieb8ee52df9f877fcba18ff50f358cf37672dccbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037622Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4028.0-1580732019-benchmark-81.0.4044.4-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie1654231ebf8a84b9f1f00fee0f00982788a7d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037620Reviewed-by:
-
Peter Kasting authored
Having the various WithXXX() methods depending on this was fragile against future changes that add members to the class, unless the constructor takes them as args. This bit me while fixing bug 1012136. They now do a copy-and-set (preserving all existing state). Having the ForXXX() methods depend on this failed to take advantage of member default values, and delegating constructors, which is also a bit of a maintenance hazard. These are now constructors directly. Finally, having factory functions is unusual when construction cannot fail, needs no extra initialization, and doesn't return a pointer to a polymorphic base; plus, the factory methods are more verbose, but (IMO) do not really add significant/necessary clarity. Bug: none Change-Id: I3b89bb893e1ff20bcae68e7df5c55d2176f5bd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036527Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#738310}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dc397e0a03e0..e06acb7de1b8 git log dc397e0a03e0..e06acb7de1b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 tsepez@chromium.org Ensure label item lists are not excessively sized in CXFA_FFListBox. 2020-02-04 tsepez@chromium.org Remove stray comma from elements.inc table. 2020-02-03 tsepez@chromium.org Tidy cpdfsdk_widget.h Created with: gclient setdep -r src/third_party/pdfium@e06acb7de1b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1047914 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I75df28f8d6862d161678e40400d410b825624052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037555Reviewed-by:
-
Charlene Yan authored
Bug: 1046554 Change-Id: I79f37516e26aeb0fea7261b20082c7f882485918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036483Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738308}
-
Tibor Goldschwendt authored
Bug: 1042534 Change-Id: Icfeac3fd1d4361227a56119ffeb71c5797a6be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032431 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#738307}
-
Anand K. Mistry authored
RunOnceCallback now works as expected with move-only callbacks, so using a non-const reference in the mock is no longer necessary. Bug: None Change-Id: Idaf90afbd11c3c647b52f5552ffbba7517024f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037277Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738306}
-
Chris Lu authored
This creates an EG2 test suite for Translate for the new Messages UI. Many tests are either direct copies or similar to those found in TranslateTestCase. Some of them were also not moved over, because they do not apply to the new Messages design. Bug: 1014959 Change-Id: I4df264e6dcfabcdc7ad3933aeb43f2bb255c3d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036371 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738305}
-
Kyle Horimoto authored
This fixes an issue where the app name can be truncated if it is a very long string. Bug: b/146928018 Change-Id: Ic9831ef42342890d290c9a2b2f09a8d8ecad3cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033920 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#738304}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/755ff85d1885..9a3ade44d9f4 Created with: gclient setdep -r src-internal@9a3ade44d9f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9e7623bc82d688e545e40a39f0c7efeb958e1275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037567Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738303}
-
Wan-Teh Chang authored
Bug: 1026522 Change-Id: I91536620b13ba571a701cb0c1931f1f49a2bc625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037730Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: James Zern <jzern@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#738302}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/36c6ca3e8f7f..11701ad0ea8f git log 36c6ca3e8f7f..11701ad0ea8f --date=short --first-parent --format='%ad %ae %s' 2020-02-04 jophba@chromium.org Fix GCC + libsdl/libavcodec build Created with: gclient setdep -r src/third_party/openscreen/src@11701ad0ea8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I93f8026ff5ae9b7e9acf22da13e5c7c3f540778d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037615Reviewed-by:
-
dalyk authored
This param will be applied to any WebContents that are newly created during the navigation so that the WebContents can be properly classified before any DNS requests are made. (For WebContents that are created for captive portal resolution in secure mode, we need to disable secure DNS.) Bug: 10161646 Change-Id: Ia38cd9b0d6013cae7f272cc42302bba875152e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026349 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738300}
-
Charlie Hu authored
- Use base::make_optional instead of base::Optional constructor. - Add const qualifier on field line_number and column_number. Change-Id: I99145d52b98d609aaa0591722626b43093f00900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037323 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738299}
-
Emily Stark authored
Previously, with HTTP auth committed interstitials, LoginTabHelper cancels navigations that receive 401 responses and commits a blank page. The auth prompt is shown on top of the blank page normally. However, in the case that the browser supplied credentials and the server still sent a 401 response (i.e., credentials were incorrect), LoginTabHelper would cancel the navigation but not show the auth prompt (due to lack of auth challenge -- the challenge is only populated when credentials aren't supplied in the request). This led to a weird situation where neither the auth prompt nor the 401 response body from the server would be displayed to the user. To rectify this, LoginTabHelper should not cancel a request with a 401 response unless there is an auth challenge present for which to show a prompt. This maintains the same UX as we had before committed interstitials. Bug: 1047742 Change-Id: I83eba22e52676946d7f3a6cffc14f699265f75d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036970Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#738298}
-
Avery Musbach authored
Bug: None Change-Id: Ib901eeae6a357baaa9d25605aed71c58664b8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033889Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#738297}
-
Connie Wan authored
See bug for details on the issues. Issue #1: When dragging multiple tabs to the left, reverting doesn't return them to the correct position. Was happening even without groups. - Fixed by adjusting the target index of revert to account for unreverted tabs. Issue #2: Intermittent crashes. - Seems to be fixed by crrev.com/c/2020908 Issue #3: Header is not returned to the initial view position. - Fixed by adding a call to MoveTabGroup(), which is only needed when dragging within the same tabstrip (otherwise, a new group is being created and positioned correctly). Issue #4: Selection is not restored correctly. - Fixed by actively setting the index of group headers to kNoTab, so that checks in RestoreInitialSelection() correctly ignore group headers. Note: The change at line 657 is to work with line 1656, which is assuming that source_model_index is explicitly set to kNoTab. Bug: 1047761 Change-Id: I18af6a66d4e7788ed90c9be1f27556fc0018c6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036362 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738296}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/094c157fc3f0..555a304caa85 git log 094c157fc3f0..555a304caa85 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 lamontjones@chromium.org api: compile protos 2020-02-04 honglinyu@chromium.org Make deployment of "icudtl.dat" optional 2020-02-04 ahassani@chromium.org cros_flash: Execute scripts out of /usr/local/tmp/cros-flash 2020-02-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 seanabraham@chromium.org chromeos_config_boards: add eve-lacros 2020-02-03 vapier@chromium.org cros_setup_toolchains: handle duplicate source libs better 2020-02-03 seanabraham@chromium.org chromeos_config: lab board nami, not nami-kvm 2020-02-03 achuith@chromium.org Revert "cros_chrome_sdk: Update SDK_VERSION on fallback." 2020-02-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-03 saklein@chromium.org cros deploy: ignore built slot operator. 2020-02-03 vapier@chromium.org stripped-packages.tar: clean up internal paths 2020-02-03 geohsu@google.com Update builders for M81 ChromeOS attempt 2 2020-02-03 lamontjones@chromium.org api: compile protos Created with: gclient setdep -r src/third_party/chromite@555a304caa85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I3699241c13a54eb766a2b41a5ace1a62bf121ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037420Reviewed-by:
-
Yann Dago authored
Bug: 958893 Change-Id: I46c74b4732f5a76b10c27f0603fa3aa6c0bbd803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018128 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Eric Seckler authored
Some of our startup tracing tests timeout flakily, and it seems that the flakiness stems from the file not being written quickly enough on the background task runner. This patch overrides the task priority for the task runner for these tests to USER_BLOCKING, which should make file writing more likely to finish in time. Also reenables one of the tests on windows, where it was previously timing out flakily. Bug: 1046447 Change-Id: Ibbe2ef61f81567a364f4d3396162e72be22b4457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032109Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738293}
-
