GitLab

This is intentionally tiny and intended to be merged into M41.
views::Label already knows the size of the text (GetTextSize()
returns the cached size), therefore it knows the current text
does not fade at all.

Since this will avoid the check if the text may fade or not in
gfx::Canvas::DrawFadedString(), this can potentially make
the drawing 2x faster if the text doesn't fade at all.

BUG=451297
R=sky@chromium.org
TEST=on link_freon, with the bookmark sample in crbug.com/440551
  (contains ~15 bookmarks), repaint of bookmark bar is improved
  as: ~100msec -> ~55msec

Review URL: https://codereview.chromium.org/870903002

Cr-Commit-Position: refs/heads/master@{#312942}

Review URL: https://codereview.chromium.org/870913003

Cr-Commit-Position: refs/heads/master@{#312941}

BUG=chromedriver:998
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/870123002

Cr-Commit-Position: refs/heads/master@{#312940}

BUG=450854,429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/867333002

Cr-Commit-Position: refs/heads/master@{#312939}

<webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys
and so on but for keys it doesn't know how to handle, it should pass them along as other
GuestViews do.

This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected.

BUG=none

Review URL: https://codereview.chromium.org/869193004

Cr-Commit-Position: refs/heads/master@{#312938}

This also updates the logging in shiil_property_util to use
device_event_log.h.

TBR=isherman@chromium.org for trivial change
BUG=none

Review URL: https://codereview.chromium.org/819583004

Cr-Commit-Position: refs/heads/master@{#312937}

This change eliminates the need to have a transparent button on top of
overview mode windows by installing a static event targeter on each of
the item windows. The targeter checks for events on the item bounds and
redirects events to a label button located under each item. This way, we
greatly simplify event handling while preventing events to reach the
actual windows.

The reason why we use a label button now is that it already handles clicks
and taps, as well as accessibility stuff (touch exploration, chromevox
feedback) that were being handled in the transparent window before.

The CL only involves refactoring - no features have been added or
removed.

BUG=446548
TEST=WindowSelectorTest.*

Review URL: https://codereview.chromium.org/810033010

Cr-Commit-Position: refs/heads/master@{#312936}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b18308..9994197

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/873543003

Cr-Commit-Position: refs/heads/master@{#312935}

BUG=450428

Review URL: https://codereview.chromium.org/861953002

Cr-Commit-Position: refs/heads/master@{#312934}

Review URL: https://codereview.chromium.org/870093002

Cr-Commit-Position: refs/heads/master@{#312933}

NativeDisplayDelegateProxy needs to read a file which is necessary to start chrome on UI thread. The file is on tmpfs, so it should be fast.

I've got jam@'s agreement, who is the owner of base/threading/thread_restriction*, in https://codereview.chromium.org/854203002/

BUG=None
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/866103002

Cr-Commit-Position: refs/heads/master@{#312932}

This pulls in a single change—a build fix for ARMv6 builds.

c5cc15b Don't expect bsaes functions on ARMv6.

BUG=none

Review URL: https://codereview.chromium.org/874543004

Cr-Commit-Position: refs/heads/master@{#312931}

Once again, issue remains in Android version 5.0.2.

BUG=438657

Review URL: https://codereview.chromium.org/867893002

Cr-Commit-Position: refs/heads/master@{#312930}

Move expire_history_backend.{cc,h} into //components/history/core/browser
and update .gyp and .gn files.

Remove some obsolete code in expire_history_backend_unittest.cc file.

BUG=370850
R=droger@google.com

Review URL: https://codereview.chromium.org/870593003

Cr-Commit-Position: refs/heads/master@{#312929}

Rename webview_ to web_view to be more consistent with naming elsewhere.

Use auto when useful.

BUG=none

Review URL: https://codereview.chromium.org/873533002

Cr-Commit-Position: refs/heads/master@{#312928}

Remove gray background color for non-focused selected list items on chrome://settings/autofillEditAddress page.

BUG=444770

Review URL: https://codereview.chromium.org/840503002

Cr-Commit-Position: refs/heads/master@{#312927}

When DelegatedFrameHost was split off from RenderWidgetHostViewAura,
I had DelegatedFrameHost access the ui::Compositor via a call into the
client. This is harder to reason about than it should be, and leaves open
the possibility of keeping the DelegatedFrameHost as an observer of a
dead ui::Compositor.

Explicitly detach the DelegatedFrameHost from the ui::Compositor
when the ui::Compositor is being destroyed. Add a check to the
observer list, to ensure that it is empty at destruction.

BUG=(paying down technical debt)

Review URL: https://codereview.chromium.org/859423002

Cr-Commit-Position: refs/heads/master@{#312926}

This patch changes the way eviction queue is built to be more like the
raster queue. That is, instead of taking a pointer to the queue to be
built, the function returns a scoped_ptr to the queue that it built.

R=reveman, danakj

Review URL: https://codereview.chromium.org/862263004

Cr-Commit-Position: refs/heads/master@{#312925}

This is never null anymore, no need to check for null-ness.

R=vmpstr

Review URL: https://codereview.chromium.org/865973007

Cr-Commit-Position: refs/heads/master@{#312924}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/868153002

Cr-Commit-Position: refs/heads/master@{#312923}

For future CL: queueing messages, sending messages from Java to JS through message channel, transferring ports in message channels, closing channels.

BUG=393291

Review URL: https://codereview.chromium.org/831523004

Cr-Commit-Position: refs/heads/master@{#312922}

The idea here is that for reasons not fully understood at the moment, the
files in this CL failed the checkperms script, so 808773005 can't land.

This CL attempt to land the offending files, with two goals in mind. First,
unblock 80877300. Second, provide a clear repro for the chrome-infra team to
look at, in case something fails.

There is something going on uploading binary patches and permissions using
git cl upload.

BUG=450337
R=blundell@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/866143002

Cr-Commit-Position: refs/heads/master@{#312921}

BUG=444242

Review URL: https://codereview.chromium.org/813873005

Cr-Commit-Position: refs/heads/master@{#312920}

This removes another source of raw process handles.

BUG=417532

Review URL: https://codereview.chromium.org/860453002

Cr-Commit-Position: refs/heads/master@{#312919}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f803da1..1c40292

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/867123004

Cr-Commit-Position: refs/heads/master@{#312918}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f492958..5b18308

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/872853002

Cr-Commit-Position: refs/heads/master@{#312917}

This CL adds a column in the bookmarks images database.
It contains the dominant color extracted from the image.
Since this computation can be lengthy, it is done in the background, when the
image is stored in the database.
For old databases, a migration path is provided and the dominant color is
computed and stored upon querying the image for the first time.

BUG=448443

Review URL: https://codereview.chromium.org/875463003

Cr-Commit-Position: refs/heads/master@{#312916}

Also renamed a bunch of the public methods for clarity.

The old SyncStatusHelper class will be removed once downstream is
updated.

Review URL: https://codereview.chromium.org/845543005

Cr-Commit-Position: refs/heads/master@{#312915}

* Keep lines within 80 chars, taking care around backslashes.
* Surround key names with '"'.
* Put a ',' between phones and tablets when concatenating.

Review URL: https://codereview.chromium.org/749353003

Cr-Commit-Position: refs/heads/master@{#312914}

<webview>, <appview> and <extensionoptions> can now navigate on creation.

This means that an initial navigation of these elements can begin even if the container is set to display:none. This sets the underpinnings for teleporting content across containers.

TODO: contentWindow should become available prior to attachment.

BUG=434226
TBR=lazyboy@chromium.org for guest_view OWNER (lazyboy@ is OOO)

Review URL: https://codereview.chromium.org/845363004

Cr-Commit-Position: refs/heads/master@{#312913}

2027: win: 'EnableEnhancedInstructionSet': '5' now enables /arch:AVX2.

BUG=451290
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/873793002

Cr-Commit-Position: refs/heads/master@{#312912}

BUG=442526

Review URL: https://codereview.chromium.org/868163002

Cr-Commit-Position: refs/heads/master@{#312911}

BUG=450790

Review URL: https://codereview.chromium.org/867973002

Cr-Commit-Position: refs/heads/master@{#312910}

Taking over some TODOs for noelallen and adding myself
to OWNERS files in a few places.

BUG=None
TEST=None
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/875543002

Cr-Commit-Position: refs/heads/master@{#312909}

CaptivePortal and SafeBrowsingBlockingPage tests wait for the interstitial to get ready in different ways. This CL unifies them.

BUG=448486

Review URL: https://codereview.chromium.org/829263004

Cr-Commit-Position: refs/heads/master@{#312908}

https://bit.ly/AutoBlobToDisk

R=michaeln, piman
BUG=375297

Committed: https://crrev.com/4e45f41babddb10985c8c0afb9b0b6b9e8356094
Cr-Commit-Position: refs/heads/master@{#312770}

Review URL: https://codereview.chromium.org/821913004

Cr-Commit-Position: refs/heads/master@{#312907}

There are issue with the Guest Profile's cookies not being cleared as they should be when Guest Mode is closed. To ensure the Guest Profile isn't being used when there are no Guest browsers open, move the User Manager onto a new profile.

This is a modern version of this older CL: https://codereview.chromium.org/239543012/

BUG=445036

Review URL: https://codereview.chromium.org/847733005

Cr-Commit-Position: refs/heads/master@{#312906}

We set this variable in a few places but never read it.

R=vmpstr

Review URL: https://codereview.chromium.org/872863002

Cr-Commit-Position: refs/heads/master@{#312905}

Changed the code not to load server config if there is no alternative
protocol entry for QUIC. During our experiments, we found that
disable_loading_server_info_for_new_servers being set to true has
reduced the latency until crypto handshake completion.

This is a revert of https://codereview.chromium.org/811073004/

We check for alternative protocols only if there is a http_server_properties_ object.

R=rch@chromium.org

Committed: https://crrev.com/6a454624b8f2827af3ec154bb96e61e7fdcf9e3a
Cr-Commit-Position: refs/heads/master@{#312741}

Review URL: https://codereview.chromium.org/858323002

Cr-Commit-Position: refs/heads/master@{#312904}

I recently introduced a change which caused SQLitePersistentCookieStore to load
the cookies for one eTLD every 200ms, instead of every 0ms. That change
appeared to cause a hang during shutdown.

This CL changes the delay from 200ms back to 0ms while I investigate the hang.

BUG=436152, 448910

Review URL: https://codereview.chromium.org/844533005

Cr-Commit-Position: refs/heads/master@{#312903}