- 23 Aug, 2018 28 commits
-
-
Asami Doi authored
This CL allows a user to use 'name' property on DedicatedWorker and access from worker thread by 'self.name'. i.e // index.html const worker = new Worker("dedicated_worker.js", { name: "worker_name" }); // dedicated_worker.js console.log(self.name); // worker_name Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/aZ804HggENE/WwWgDrz4DgAJ Spec: https://html.spec.whatwg.org/multipage/workers.html#workeroptions Spec: https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-dedicatedworkerglobalscope-interface Bug: 721219 Change-Id: I36127df5ee249ecf6c13ae30aaac42621b3720b5 Reviewed-on: https://chromium-review.googlesource.com/1176887Reviewed-by:Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Asami Doi <asamidoi@google.com> Cr-Commit-Position: refs/heads/master@{#585348}
-
https://bugs.chromium.org/p/chromium/issues/detail?id=872922Quentin Fiard authored
I'll request a merge into M69 when this is in so we can restart experiments quickly. Bug: 872922 Change-Id: Icb269a5f6499a5a58a2a51f3348b23e15f20c035 Reviewed-on: https://chromium-review.googlesource.com/1183912 Commit-Queue: Quentin Fiard <qfiard@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585347}
-
Yoichi Osato authored
At ObjectPaintInvalidatorWithContext::InvalidateSelection we update PartialInvalidationVisualRect even if the union rect of old and new selection rect is empty. This patch skips the update if the union rect is empty. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I11dd813381b4fd5be69d4357e816d9c64cdb17ba Reviewed-on: https://chromium-review.googlesource.com/1183011Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#585346}
-
Bailey Berro authored
This change adds an enterprise policy that disables NetBios share discovery by default for enterprises and allows enterprises to manually turn it on. NetBios discovery will be on for non-enterprise users. This change does include any code to enforce the policy. Bug: chromium:757625 Change-Id: I30288a13ef89378f021364b6f1fe4cead4e44afe Reviewed-on: https://chromium-review.googlesource.com/1184240 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#585345}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4238afbd1d0..46ef92275f43 git log a4238afbd1d0..46ef92275f43 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 fmayer@google.com Do not specify API level twice. Created with: gclient setdep -r src/third_party/perfetto@46ef92275f43 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibf7351dec8fd0b898e9c450022d5ad03be705e4f Reviewed-on: https://chromium-review.googlesource.com/1185688Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585344}
-
Matt Falkenhagen authored
ServiceWorkerNavigationPreloadTest.NetworkFallback is flaky when NetworkService is on, after r585201. Temporarily disabling to soothe the CQ while I investigate. Bug: 876911, 873575 Change-Id: I8b5cdd9ae8ac173a2a6debba05219bad7fa0d606 TBR: kinuko NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1186003Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585343}
-
Anna Offenwanger authored
This is a reland of f4c510e1 Original change's description: > Move XR LayoutTests over to be WPTs > > Moving as many of the WebXR LayoutTests as possible over to be > WebPlatformTests. All the tests that have been moved test some > aspect of the spec (https://immersive-web.github.io/webxr/) in > a platform agnostic way. > > Bug: 863557, 844772 > Change-Id: I203b4c59be0daa0ca624fb0281fc33035f1be8a1 > Reviewed-on: https://chromium-review.googlesource.com/1171857 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585064} Bug: 863557, 844772 Change-Id: I2a85e45018fc0a17fe91c3d7bddd89587a2617e0 Reviewed-on: https://chromium-review.googlesource.com/1185384Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585342}
-
Min Qin authored
All codes in ProcessInitializationHandler.initializePostNative() requires full browser to run. And some of the class uses profile during initialization, which will crash when only service manager is running. As a result, there is no need to run this method if full browser is not launched. For services, they should add their own required tasks in ChromeBrowserInitializer.handlePostNativeStartup. BUG=695115 Change-Id: I66f314cfcb56df00553f017d3e5b6989e3a9ef60 Reviewed-on: https://chromium-review.googlesource.com/1182008Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585341}
-
Manu Cornet authored
* Add a simple mechanism to keep track of the active shelf item in the model * Use the existing shelf window watcher to update the active shelf item * When rendering shelf items in ShelfView, query the active shelf item to show the proper indicator * Remove the STATUS_ACTIVE value since this is now all managed within ash Bug: 874181 Bug: 805612 Change-Id: I089587646208ee03776f95a4f479c5b6d35d82f8 Reviewed-on: https://chromium-review.googlesource.com/1180274Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#585340}
-
Anna Offenwanger authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I911ec971475379b5627e5bfc91bdf612127f21f9 Reviewed-on: https://chromium-review.googlesource.com/1182678 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585339}
-
George Burgess IV authored
ThinLTO emits warnings when linking modules with different target triples. Android uses armv7-a as its default triple, so the mixing with armv8-a here is problematic. Bug: 807147 Test: md5sum <(objdump -d crc32_simd.o) is the same for Android. Change-Id: If2bffc4090d3d94f158eea80d19ee9eb827fc837 Reviewed-on: https://chromium-review.googlesource.com/1147867 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#585338}
-
Wez authored
Temporarily add some values to minidumps, to help diagnose BlobReader crash reports. Bug: 864351 Change-Id: I70a8b36e83fdb1c43f698d83aaf6b712da6a9264 Reviewed-on: https://chromium-review.googlesource.com/1185906Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585337}
-
Christian Fremerey authored
Adds an enum for distinguishing which call sites trigger video capture errors. The goal of this work is to improve the UMA logging by differentiating various possible sources of error events. Doing so will help us better understand what error events contribute most to the high error counts and will help us better pinpoint causes for future changes in error counts. Design Doc: https://docs.google.com/document/d/1chso0ntOMecY7SfcrQzkHLuBAxO_oUwSpOhy1MrXAhc/edit?usp=sharing Bug: 849636, 876002 Change-Id: I02fcc8930ff7e66a15c91c4393bf9a280383902b Reviewed-on: https://chromium-review.googlesource.com/1180412 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585336}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92b161fab40f..33d5394d08f6 git log 92b161fab40f..33d5394d08f6 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 scroggo@google.com Revert "Switch SkCodec to use skcms" and follow on change 2018-08-22 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms b2fffd2ecf2e..e8e06f9724b0 (1 commits) 2018-08-22 robertphillips@google.com Address perf regression due adding GrRenderTargetContext::drawShape method 2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 44ae899ae9ce..9259fd0d4f4c (6 commits) 2018-08-22 brianosman@google.com Fix CMYK handling in JPEG codec 2018-08-22 brianosman@google.com Stop conflating F16 with linear gamma 2018-08-22 csmartdalton@google.com Reland "Disable GPU clip masks" 2018-08-22 brianosman@google.com Add support for unpremul image sources in the GPU backend 2018-08-22 michaelludwig@google.com Add reset and findLastOf to SkSLString. 2018-08-22 benjaminwagner@google.com [infra] Remove Braswell Perf Debug jobs. 2018-08-22 herb@google.com Pull SkSpan into its own header file 2018-08-22 benjaminwagner@google.com Remove extra Mac CPU jobs. Created with: gclient setdep -r src/third_party/skia@33d5394d08f6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Iad8298e24e90590bfa96a2b11b14a60dd7aa3a25 Reviewed-on: https://chromium-review.googlesource.com/1185687Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585335}
-
Dale Curtis authored
The media pipeline does not expect to be called about track changes prior to HaveCurrentData. There's also no reason for the element to create disabled video+audio tracks and then tell the renderer to enable those very same non-existant tracks. Just create them as enabled instead. It's possible we can remove even the creation of placeholder tracks, but that's a bigger web facing change, so I don't want to hold up this bug fix on that analysis. BUG=873837 TEST=new unittest, twitter videos no longer hang. Change-Id: I9863ae4feca29a58140e6dad1532bc8b7a380c3b Reviewed-on: https://chromium-review.googlesource.com/1180347 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#585334}
-
Alexey Baskakov authored
Fix all GN issues and add the following to GN check_targets: //apps/* //chrome/browser/apps/* //chrome/browser/web_applications/* to make `gn check` working again. Drive by: Extract web_applications:browser_tests source set in GN. TBR=dpranke@chromium.org Bug: 367595 Change-Id: I8704d4893554fc4028c09d681871a05bc56ddbcf Reviewed-on: https://chromium-review.googlesource.com/1182902 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585333}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7e7e0b8379c4..81e0830e6734 git log 7e7e0b8379c4..81e0830e6734 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 hnakashima@chromium.org Simplify internal state of CBC_BarcodeMatrix. 2018-08-22 hnakashima@chromium.org Remove unused barcode matrix scaling code. 2018-08-22 rharrison@chromium.org Properly handle language markers in decoded text Created with: gclient setdep -r src/third_party/pdfium@81e0830e6734 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I29439ab1c305a115569bccb0a3bd6e46f0a482bf Reviewed-on: https://chromium-review.googlesource.com/1185686Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585332}
-
Will Harris authored
../../chrome_elf/pe_image_safe/pe_image_safe.cc(76,75): error: implicit conversion loses integer precision: 'long long' to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] DWORD optional_header_offset = reinterpret_cast<char*>(optional_header) - ~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ ../../chrome_elf/third_party_dlls/main.cc(77,54): error: implicit conversion loses integer precision: 'std::vector<unsigned char, std::allocator<unsigned char> >::size_type' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] value_bytes.data(), value_bytes.size()); ~~~~~~~~~~~~^~~~~~ ../../chrome_elf/third_party_dlls/logs.cc(127,46): error: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32] : kMaxLogEntries - entries_.size(); ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ../../chrome_elf/third_party_dlls/hook.cc(283,32): error: implicit conversion loses integer precision: 'ULONG_PTR' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32] if (!GetDataFromImage(*base, *view_size, &time_date_stamp, &image_size, ~~~~~~~~~~~~~~~~ ^~~~~~~~~~ BUG=588506 Change-Id: I82abea7b741de1c56e9bcd1ce8c5bd59357ed20b Reviewed-on: https://chromium-review.googlesource.com/1184318 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#585331}
-
Erik Chen authored
The option --use-isolate-files causes compare_build_artifacts.py to compare the files referenced by .isolate. It should also compare the contents of .isolated files. Bug: 876915 Change-Id: I06eb0d3373493db90b75befe9e0b47c9de58cbe0 Reviewed-on: https://chromium-review.googlesource.com/1185991Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585330}
-
Reilly Grant authored
This change makes Web Bluetooth available by default thanks to the new WinRT-based Bluetooth Low Energy backend. Bug: 419413 Change-Id: I112349b9ede67c1217cbde6ac6a04a8bea9201b7 Reviewed-on: https://chromium-review.googlesource.com/1184970 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585329}
-
Hiroshi Ichikawa authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1a0354accc09e93c0c931e7528dce70aadfd3411 Reviewed-on: https://chromium-review.googlesource.com/1159930Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#585328}
-
Trent Apted authored
Follow-ups to review comments in https://crrev.com/c/1053338 Bug: 842987 Change-Id: I1cf78667887bb86555d3f9043e2afe5d8eacf2bb Reviewed-on: https://chromium-review.googlesource.com/1184590Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#585327}
-
Hector Carmona authored
This is technical debt that will be more expensive if we build out the email NUX before resolving. Bug: None Change-Id: Ibb92872a55bc6089a7fcda6dc52064f4ef87150a Reviewed-on: https://chromium-review.googlesource.com/1183844Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#585326}
-
Kevin Marshall authored
The test is disabled because it is causing false negatives on the bots. It will be reenabled once the root cause is diagnosed and addressed. TBR=skym@chromium.org Bug: 876894 Change-Id: I5ab50f94768bdcd27e06d9f435eddadbf1e1ec5f Reviewed-on: https://chromium-review.googlesource.com/1186029Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585325}
-
James Cook authored
This simplifies teardown, especially in ash on Chrome OS. Also add tests for the code in crrev.com/c/1180070 which generally skips event dispatch during shutdown. Bug: 874156 Test: added to aura_unittests Change-Id: I1356c3a1ab09f07d23dca1545d3159fcc4016e2d Reviewed-on: https://chromium-review.googlesource.com/1181537Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585324}
-
Wez authored
Bug: 875486 Change-Id: I448361ccdb91b83ab71c6eda34066e6e76c278de Reviewed-on: https://chromium-review.googlesource.com/1185490Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585323}
-
Kai Ninomiya authored
For camera-to-WebGL on Nexus 6P at 720p, this improves blocking texImage2D time from ~12ms to ~4ms (200% speedup). On some other devices and resolutions, I think there can be up to a ~10x speedup. * Adds an optimized upload path for CPU-side YUV video frames (e.g. those coming from a video camera on Android). This path uploads the individual Y/U/V textures to the GPU, performs a GPU YUV-RGB decode, and copies the result into the WebGL texture. This code path could potentially be further optimized in 2 ways: * Avoid the extra copy of the CPU-side YUV data from browser-renderer shared memory (VideoFrame::STORAGE_SHMEM) to renderer-gpu shared memory (transfer buffer, probably). * Avoid the extra copy from the decoded image (SkImage) into the WebGL texture, and instead decode directly into the WebGL texture. * Removes an old GPU-GPU path that was obsoleted by CopyVideoTextureToPlatformTexture. This obsolete path was only handling CPU-GPU uploads instead of GPU-GPU uploads, and it was doing so by performing an expensive YUV-RGB conversion on the CPU. This also allowed some cleanup in TexImageHelperHTMLVideoElement. Bug: 867368 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id25d5dbfc76ec8f9dc606890588a20978f6943f6 Reviewed-on: https://chromium-review.googlesource.com/1161606 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#585322}
-
bsheedy authored
Modifies an existing test that brings up a keyboard so that it also inputs text via the keyboard. This is to catch future occurances of https://crbug.com/874671 where inputting text into the VR Browser's omnibox would cause a browser crash. Also installs the latest VR Keyboard APK as part of pre-test setup in test suites that could potentially use the keyboard. Bug: 874671, 874696 Change-Id: Ic04d678e14de918fbf159078422c9d5459e8d98d Reviewed-on: https://chromium-review.googlesource.com/1176876Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585321}
-
- 22 Aug, 2018 12 commits
-
-
Kevin Marshall authored
This method calls directly into WebContents::Stop(). Added a test case for end-to-end verification of browser behavior. Bug: 852145 Change-Id: Ia1301976542e3b4996579422b98e4d2ae41ea646 Reviewed-on: https://chromium-review.googlesource.com/1185737 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585320}
-
Lei Zhang authored
Most PrintPreviewHandler methods have the request ID last. Change-Id: Ie5d21e108df05859fb5b11229a2f97bd0ae93ff1 Reviewed-on: https://chromium-review.googlesource.com/1184384Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585319}
-
Hans Wennborg authored
This is a reland of 1501aabf The goma failures which caused the previous revert are believe to be flaky. Original change's description: > Clang: stop building with GCC/libstdc++ from Ubuntu Precise (roll 338452-1:338452-2) > > Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang > that would work on Precise or later. These days, all bots and developers are on > Trusty or later, so this should no longer be necessary. > > Bug: none > Change-Id: I518ee55d07c04dc89163fe262c81d935e05fed78 > Reviewed-on: https://chromium-review.googlesource.com/1183915 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585067} TBR=thakis Bug: none Change-Id: Ibd2be5064bbdf0ed36aa09c0525825c530465813 Reviewed-on: https://chromium-review.googlesource.com/1185684Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585318}
-
Kevin Marshall authored
Replaces the FIDL event based handler for navigation events with a NavigationEventObserver class, which can be set or removed at any point over the lifetime of a Frame. The Observer uses acknowledgement closures for flow control. The client signals that it is ready to receive an additional navigation event by invoking the closure. Bug: 852145 Change-Id: I0a53d6d003a44d895b6616b8d19a85e524b22053 Reviewed-on: https://chromium-review.googlesource.com/1183593 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585317}
-
Dominic Mazzoni authored
ChromeVox was ignoring the checkedStateChanged event because it didn't think that event should apply to a 'switch' role. It was correctly announcing the state, just not correctly announcing when it changed. Bug: b/111353265 Change-Id: I77c420c00e90d31c78f86610df7a3713eede360f Reviewed-on: https://chromium-review.googlesource.com/1185866Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585316}
-
Yiming Zhou authored
Chrome extension API methods are asynchronous and use callbacks. Much of the Action Recorder Extension background script wrap Chrome Extension API methods inside functions that return promises. Prior to this change, the background script handles sequential asynchronous calls using promise chains. Promise chains are cumbersome to write and difficult to debug. This change replaces promise chains with async functions and sequential await calls. Bug: 855284 Change-Id: Ic73608d9e6a207505f2d21a8a6005ce7418344a4 Reviewed-on: https://chromium-review.googlesource.com/1179312 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#585315}
-
Moe Ahmadi authored
- Updates existing strings and adds new ones related to the new Autofill addresses and payment methods settings in components/autofill_strings to share on all platforms. - Makes visual changes to the addresses and payment methods settings pages on iOS by adding a message under toggle that controls Autofill for that type. TBR=sebsg@ Bug: 873215 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8fe68a0f1776151f062006e95219a4ad41d8bb63 Reviewed-on: https://chromium-review.googlesource.com/1180556 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585314}
-
Sophie Chang authored
Bug: 867129 Change-Id: I4eb4fe573b0a0e9adb6a23859d2263adce9c6fe7 Reviewed-on: https://chromium-review.googlesource.com/1182606 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585313}
-
Wez authored
Extend the base::AsyncDispatcher implementation of the |async_ops_t| to support the new exception port bind/unbind APIs. Bug: 873489 Change-Id: I24cbc4aa687296fcefb09b5261486f1f8849b4ed Reviewed-on: https://chromium-review.googlesource.com/1172149 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585312}
-
Kunihiko Sakamoto authored
This patch updates the followings: - Use the Digest header instead of the MI header - Update the identifier from mi-sha256-draft2 to mi-sha256-03 - The top-proof is now encoded in standard base64, not base64url Http-mice-03 also changes the behavior on 0-length payloads. That will be addressed in a followup CL. Bug: 875721 Change-Id: I4c53a5ed6c25a62685d523c7a9d4583875a940c2 Reviewed-on: https://chromium-review.googlesource.com/1180955 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585311}
-
Annie Sullivan authored
This is part of a larger project to extend page load timings to include the time from user input to navigation. This CL makes it possible to see different input types separately. See the last section of the design doc: https://docs.google.com/document/d/1dkjlbAQXdeXlnAwYFP7ueAIfO84DnQJ9U01krXv4x3s/edit# Bug: 750639 Change-Id: Ia37e5fe0bad25d5428f4c34d41292e660bd6d281 Reviewed-on: https://chromium-review.googlesource.com/1183587 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585310}
-
Scott Violet authored
It only contains the files included else where. BUG=none TEST=none Change-Id: I1df5f3280515c101818bd837d4ea7b4486a7a19a Reviewed-on: https://chromium-review.googlesource.com/1185916 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585309}
-