- 28 May, 2020 31 commits
-
-
Becca Hughes authored
This is a reland of b7d9656d TBR=dalecurtis@chromium.org Original change's description: > [Media History] Do not record background or muted watchtime > > Adds a fix so that Media History does not record > background or muted watchtime since they are not > useful to us (we only want foreground unmuted). > > BUG=1086511 > > Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771995} Bug: 1086511 Change-Id: I8bc4c8a4d73df513e8a1c48f772c7af9de256faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219109 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772500}
-
Mustafa Emre Acer authored
SafeBrowsing Delayed Warnings experiment can block a download if the current page has a delayed warning. In that case, this CL prints a message to the console. Bug: 1081317 Change-Id: Ib11dd687ef66eba1dc42e02f1929067f714bb4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215450Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772499}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom interface definition. Bug: 1070663 Change-Id: I832d7ecaf6d8b2c778eb9f1378f183c027585d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216910Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772498}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cdaf0be1f4ce..6e7ddb698ba0 2020-05-27 agable@chromium.org Remove agable from depot_tools OWNERS and TODOs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3e2023130e6d295798d20e14df6a4e153e569b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772497}
-
Moe Ahmadi authored
The crash in crbug/1086848 is likely due to the page method calls being handled before |autocomplete_controller_| is initialized. The page calls StopAutocomplete when the realbox loses focus. |autocomplete_controller_| *should* have been created when the realbox got focus in the first place. However, there may be edge cases around autofocus that could cause the realbox to get focus without QueryAutocomplete being called. Bug: 1086848 Change-Id: I4cc2f429a7420c6ba7f8dc66062e17fba8d40664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219105Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772496}
-
Brian Sheedy authored
Adds "os", "os_version", and "os_version_detail_string" to the the JSON data that is uploaded to Gold when an image is compared. This will make it easier to tell what bot produced an image. Also adds "driver_version". Example output is "win", "win10", "10.0.18362", and "26.21.14.3102" respectively. Bug: 1086751 Change-Id: I8a722db102808502a8100d700942a8348d2b5c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218479 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772495}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. This CL is thus a no-op. These changes are required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 1026641, 968047 Change-Id: I0009714cea5659d154e7f278b18499e41ff745fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219169 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772494}
-
Vasiliy Telezhnikov authored
This CL handles adds handling of few more cases: * Small videos have bad matrix. We get small sizes likely because decoding errors * Shrink amount other than 1.0. This is best guess approach as there is no way knowing what shrink amount was used. * Empty matrix case (when either of scales is zero). Shouldn't happen outside of small size case. This CL also add fallback to visible_size if coded_size/visible_rect seem wrong or matrix was broken and adds DumpWithoutCrashing for that case. Bug: 1081695, 1086624, 1076564 Change-Id: Ife0b70bc85b9249fa2805df1db59733ac8cdbd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216731 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772493}
-
Trent Begin authored
Bug: chromium:1084295 Change-Id: Ia6f53b3f49a2472180e20f80fc189187fdda2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218575Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772492}
-
Yuichiro Hanada authored
This CL will prevent normal apps and web pages from intercepting the key. Bug: b:156526777 Change-Id: Id51309805f6478f9e8e3647241c2b4649bd0011c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212102Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#772491}
-
Giovanni Ortuño Urquidi authored
Adds some simple tests to ensure imported constants and constants specified in terms of other constants have the correct values. The CL used to do more, but https://crrev.com/c/2204846 made it all redundant. Bug: 1002798,1008761 Change-Id: I2de4b945848c8b4ad358fbcd296189c8d989cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839752Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#772490}
-
My Nguyen authored
Add the function based on design doc at http://go/e14s-autocorrect-window. Bug: 1068807 Test: Will add later in browsertest for the api Change-Id: I7e9c65af3598cbb6e0e3077d193f5a1f6555816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166228 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772489}
-
Filip Gorski authored
Bug: 1075602 Change-Id: I37e8037ab6c362bd388c595fe278bdee34ebdf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198546 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#772488}
-
Yury Semikhatsky authored
Bug: 1085150 Change-Id: I4c69b33a89708ac2c7e3d9edf5d1ad3066facc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218485 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772487}
-
Nazih Almalki authored
Ack a pending surface early the client's scheduler to schedule frames for future surface changes This case happens when screen rotation takes place while there is an active frame when this takes place it has a unique signature of 2 consecutive submit frame requests with clients_needs_begin_frame_ is set (high) and 1st frame is not a new surface and 2nd frame is a new surface. Bug: 1060058 Change-Id: I7020d10aade334e7fda20749217747cea2a2c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190049 Commit-Queue: Nazih Almalki <nalmalki@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#772486}
-
Rouslan Solomakhin authored
Before this patch, the C++ payment app interface omitted app identifiers, minimal UI fields, and deduplication fields that are used on Android. It also required each individual app implementation to convert from PaymentDetails to PaymentRequestDetailsUpdate mojo struct, although Android performed the conversion in a central place and passed the Update struct to the payment app. These discrepancies prevented using a C++ payment app in Java (through a JNI wrapper). This patch adds the ID, minimal UI, and deduplication fields to the C++ payment app interface, implements the minimal UI and deduplication fields in the C++ service worker payment app, as well as changes the UpdateWith() method to accept a PaymentRequestDetailsUpdate mojo struct. After this patch, using a C++ payment app in Java (through a JNI wrapper) is easier. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I39146a08fcd74fe9a883c67107c8fc8cbc17a400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217847Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772485}
-
Rahul Arakeri authored
This CL allows the root scroller to be overscrolled beyond the scroll bounds. The OverscrollBounceController drives this. The basic principle here is: the scroll deltas on GSU are fed into a hyperbolic tangent function (ranging [0, 2]). This tells how far the scroller bounds can be "stretched" when the user overscrolls. See OverscrollBounceDistance for details. Animating the bounce back is not in the scope of this CL. Bug: 1058071 Change-Id: I3023c69078ffc6dff0ecfe3554d699ea3b9d1553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198596 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772484}
-
David Black authored
Currently AssistantZeroStateView's only child is the pre-existing greeting label. Moving forward, AssistantZeroStateView will conditionally show a richer view in lieu of greeting label. The changes in this CL should not be perceivable to the end user. Bug: b:157510546 Change-Id: I9e813a3d04a9ee9c734c9f5e2ff6913fd18b0ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213925 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#772483}
-
Andrey Kosyakov authored
Upstream fix: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2216940 Bug: 1085228 Change-Id: I641542cd65f18a573a291a7e3f0feebce7b69ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216708 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772482}
-
Rachel Wong authored
Currently, privacy_info_view is a launcher notice about Assistant privacy. This CL separates privacy_info_view into two classes: 1) privacy_info_view.*, a parent class for privacy notices in the launcher; 2) assistant/assistant_privacy_info_view.*, which contains all the Assistant-specific methods and strings. This allows us to create a new privacy notice for Suggested Content, which uses the same parent view but has its own methods and strings. This CL should not make any functionality changes. Bug: 1079169 Change-Id: I28324a9196ef2643e5fdcef122c13a8113ee2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198848Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#772481}
-
Tomasz Wiszkowski authored
This change allows most tests to operate without having the QueryTile Processor initialized if these don't care about its presence. Bug: 982818 Change-Id: I6fe6c0bba9fb83d99bcad9e93c84a831df2da8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219149 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772480}
-
David Black authored
Copy and paste error caused Assistant MicView to never register to observe AssistantInteractionModel events in recent refactoring. Bug: b:157579976 Change-Id: I992387d69ccfafccd8842070563269b65f974aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218673Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If0eb3cf6c9a7c659b00269b77edf93116aa29990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219230Reviewed-by:
-
Kurt Catti-Schmidt authored
Per https://chromium-review.googlesource.com/c/chromium/src/+/2163429, this change moves GridNG files to their own directory. This will help organize subsequent changes where we will be introducing classes specific to GridNG. There should be no behavioral changes associated with this PR. Bug: 1045599 Change-Id: I50c2c98a7903904bf80663801a80ed1874bb0f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218616 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#772477}
-
Zach Trudo authored
Bug: b/157188195 Change-Id: I70b45ca1dc44f48d08638b9f23a4eaaae73052b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212796 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772476}
-
Xianzhu Wang authored
I changed the filter in crrev.com/c/2202974 to treat results like [ Failure Crash ] as unexpected flaky if the expectation is like [ Failure Timeout ], but it had a bug that containsAll couldn't deal with the differences of the failure keys in actual and expected result (e.g. actual TEXT vs expected FAILURE). Change-Id: Iacd547a242277ad8b39645a2c2130c1d8670bf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218530Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772475}
-
Yuichiro Hanada authored
This CL lets InputMethodEngine choose the InputMethodKeyboardController instance. It allows us to use different InputMethodKeyboardControllers for ARC IMEs and Chrome OS IMEs. Bug: 1060272 Change-Id: I5677a58429ef2ced5343b8cb3c34dca929f276a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214733Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/517beaa4782d..05c3b7867dfb $ git log 517beaa47..05c3b7867 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 wub Update quicunorderedmap to quichashmap in quicdispatcher, transportparameters, quicspdysession and qpackblockingmanager. no behavior change. 2020-05-26 renjietang Remove ALL_UNACKED_RETRANSMISSION from TransmissionType because it's not used anymore. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic854b26c758919f06dfa9312be523686ceab724e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219090Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772473}
-
Sharon Yang authored
Change-Id: I3fd006f9e87c8bdfb8007d9c06d2778b0edce539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155183 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772472}
-
Chris Harrelson authored
The use counters removed in this CL are deprecated since issue 785212 was fixed. Bug: 785212 Change-Id: I52f41cac65e7e5edb171237c4a683fbe78920bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202788Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772471}
-
Alexey Baskakov authored
Multiple test fixtures set the TestAppRegistrar explicitly via TestWebAppProvider::SetRegistrar() and TestAppRegistrar is a type unrelated to WebAppRegistrar. Later we will get rid of TestAppRegistrar everywhere: that is a third type of registry (in addition to BookmarkApps and WebApps). Replacing it with TestWebAppRegistryController is a separate follow up task. Bug: 1082881 Change-Id: I7d59f10360f766fccbc888b8c461aefe27b0cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215078 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772470}
-
- 27 May, 2020 9 commits
-
-
Gabriel Charette authored
Same as in ScheduleWork() (reset the state on unexpected failure). R=fdoray@chromium.org Bug: 1074019 Change-Id: Ia4e04126d1cc879b369638b93f63b7397bc1e14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216033Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772469}
-
Peter Kotwicz authored
This CL: - Modifies CustomTabAppMenuPropertiesDelegateto enable adding site to homescreen when WebAPK is out of scope - Introduces EmptyVerifier and uses it for custom tabs - Deletes ExternalIntentsPolicyProviderin favour of accessing verifier directly - Moves trustedwebactivityui.controller.Verifier ot ui.controller.Verifier BUG=1083256 Change-Id: Ic0c1c98ccb3ccef2b71019b3da544c34488477b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205519 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772468}
-
Becca Hughes authored
We want to check the feed URL against Safe Search (which is in MediaFeedsService) on discovery so first we need to move discovery to MediaFeedsService. BUG=1085095 Change-Id: I12511d9cb8ce3afb095abea50a50c59a1773fdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211046 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Christian Biesinger authored
As requested in https://crrev.com/c/2212984 Bug: 1083020 Change-Id: I989fd01823a6fdb01e60f4f5d6d3ef0d85f3f693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218797Reviewed-by:
-
Kyle Horimoto authored
This class adds metadata regarding whether the section contains only a link to a subpage. Additionally, this CL moves section result generation to a public function on this class. Bug: 1082249, 1071700 Change-Id: Ib191d6a2636adf102d0cd4fde5c1fd298a220e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219154Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772465}
-
Ben Kelly authored
Bug: 1018920 Change-Id: Ia4d148502279e768756eb07a9aad2384c190f50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218671Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772464}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. c/b/net tests are updated to use the new API, and a test is expanded to cover non-primary OTRs. Bug: 1060940 Change-Id: I7962466b337c053c912a617e827af8008639fb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211345 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL restores recording SOURCE_EXTERNAL_INTENT_FROM_CHROME enum value in in the Launch.HomeScreenSource UMA metric by propagating the android.provider.Browser intent extra from WebappLauncherActivity to WebappActivity. This fixes a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/2180856 BUG=1086846 Change-Id: I0e2817536565442d910626a8f032c4a4caf2c66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217378Reviewed-by:
-
James Cook authored
UserImageManagerTest.SaveUserImageFromProfileImage was using signin::SetRefreshTokenForPrimaryAccount(), which assumes there is a "sync consented" primary account. SplitSettingsSync does not set a sync-consented account until the user goes through the sync consent screen. This test doesn't care about sync consent, so change it to use SetRefreshTokenForAccount(). This avoids a DCHECK failure when SplitSettingsSync is enabled. Bug: 1060289 Change-Id: I7c2b262707ea04c7a23f374680bcffa1eb876104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218804 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772461}
-
