- 14 Aug, 2019 40 commits
-
-
Andrew Luo authored
Bug: 970083 Change-Id: I8ac599755f0900c5aae862e554dcafc91d7c7fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682988 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686833}
-
Steven Bennetts authored
Multiple refactorings made this class and its inheritors a bit tricky to follow. This CL removes some duplication and moves observers closer to where they are used. Bug: 862420 Change-Id: Ibfe1424b621a478f3ec5020b9f3d453cff79b94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752773 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686832}
-
yilkal authored
Moved supervised_user_error_page_strings.grdp, supervised_user_error_page_strings_grdp/ to chrome/app/. This is to resolve translation extraction failure for chrome client project. Updated references in chrome/app/generated_resources.grd Bug: 993353 Change-Id: I9cdf74fdb093b7091f3c6df1fc0e3b038f67ba65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752172 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#686831}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/99cffe5db419..2971fd34dc63 git log 99cffe5db419..2971fd34dc63 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 jmadill@chromium.org Roll glmark2. Created with: gclient setdep -r src/third_party/angle@2971fd34dc63 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I931dec093303fc2b82fcb39f4a4756a2d8a5db03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686830}
-
Michael Giuffrida authored
These were mostly used for legacy supervised users. Bug: 971311 Change-Id: Ibce0f760a8043bf3795070be74f81b86949f4f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746764 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#686829}
-
Saman Sami authored
Library name needs to be updated. TBR=penghuang@chromium.org Change-Id: I8e797d6bf7d31416b195846c05f598f72eed9fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753547Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#686828}
-
Alex Khouderchah authored
Bug: None Change-Id: I6d3d9ff9a6b964da77970871c09bc8367579c2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753068 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#686827}
-
Jacob DeWitt authored
Add a browser test that connects 2 gamepads and then simulates the following inputs, making sure that the button state of both gamepads are correct after each step. 1) press gamepad #1 primary button 2) press gamepad #2 primary button 3) release gamepad #2 primary button 4) release gamepad #1 primary button Also add a browser test that uses 2 input sources and sends select events, making sure they are sent to the correct controller. Bug: 961325 Change-Id: I9650c0898376e082823ae0f8078289eb5782ada3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747306 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#686826}
-
Yuke Liao authored
This reverts commit 935afaa8. Reason for revert: Per Wez's comments, this change doesn't do what we expect. Original change's description: > [coverage] Remove Clang coverage dump at fast exit. > > The coverage dump in TerminateCurrentProcessImmediately is currently > blocking us from gathering coverage for sandboxed processes, because > it corrupts the data from those processes. > > This is a temporary workaround, until we implement a proper solution > for the data corruption. > > Bug: 993537 > Change-Id: Idd4669f3d41b349247161e9611e52ca00a9e75ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752926 > Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686667} TBR=wez@chromium.org,nodir@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org Change-Id: I454f38a7a708e6b7cff36f0603d03e96332d37ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753549Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686825}
-
Sami Kyostila authored
This patch makes it a requirement for all task traits to specify their thread affinity. Previously task traits that did not name a specific thread would implicitly run on the thread pool, which could be surprising. To make this more obvious, thread pool tasks must now use the base::ThreadPool() trait. We also modify the base::HasTrait() template helper to not require passing arguments because 1) that makes it possible to use the helper in a constant (compile-time) expression and 2) the helper wasn't using the argument values for anything anyway. TBR=mackay@chromium.org Bug: 968047 Change-Id: I2950c632772b341fd0eebb85f14f31dbcb158715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635827Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686824}
-
Evan Stade authored
Bug: 268984 Change-Id: I71d4c64fdf9dfb8fa14e78e14bab2e34051c18dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753049Reviewed-by:
-
Primiano Tucci authored
Add active tracing owners to third_party/blink/renderer/platform/instrumentation/OWNERS Change-Id: I5227f3b7290fbc3c9b64520e1b91cbca063f150b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754202 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#686822}
-
Stepan Khapugin authored
Fix a bug where the history icon was used for search history. Bug: 986326 Change-Id: I2be976f67616f2431e25aa5bb62ef6d01ac39ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754029Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686821}
-
Robert Liao authored
The viz::TestGpuServiceHolder needs Mojo. base!base::debug::BreakDebugger+0x23 base!logging::LogMessage::~LogMessage+0x7d8 mojo_public_system!`anonymous namespace'::NotImplemented+0x1c6 mojo_public_system!MojoCreateMessagePipe+0x90 aura_demo_exe!mojo::CreateMessagePipe+0x1bd aura_demo_exe!mojo::MessagePipe::MessagePipe+0x78 aura_demo_exe!mojo::PendingRemote<viz::mojom::GpuHost>::InitWithNewPipeAndPassReceiver+0xf7 aura_demo_exe!viz::TestGpuServiceHolder::InitializeOnGpuThread+0x371 Change-Id: Ic3de93fb4368f7885a9db40f37f200a697d029d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752112 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#686820}
-
Fredrik Söderquist authored
Since the Blink runtime enabled feature (BlinkGenPropertyTrees) was removed in d6c4a0cf, this no longer does anything (and would trigger a warning from RuntimeEnabledFeatures::SetFeatureEnabledFromString). Bug: 989251 Change-Id: I7658c7d99c2b8bd2f43c26ce86e288b61a0546ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753933Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#686819}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id5c6e647f3ce32d704e26f8827b4ada9b1f640a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753719Reviewed-by:
-
Tamer Tas authored
This CL fixes the broken builds in https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Future/4 R=jbudorick@chromium.org CC=machenbach@chromium.org Bug: chromium:883629 Change-Id: I3d3ce07df5e17c7fdef775221cc5c8436691c00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753823 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Juanmi Huertas authored
Adding a TakeDataHandler that removes the data from the loader to be able to pass it around inside the decoder of the image_bitmap_factories to be able to safely move around the data to prevent UAF. Fixing also the calling to the function needed to decode as a static member function, and passing around the callback result to resolve the decoded frame. Bug: 989950 Change-Id: Ica57fcebab62a4a6f23a53a6de6709671ea24c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738629 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686816}
-
Tsuyoshi Horo authored
Bug: 989868,924416 Change-Id: I512cd9681adbc4a8ea3080c917baae7b82b22395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750468Reviewed-by:
-
David Bokan authored
Add a flag to chrome://flags to allow users to experiment with turning off Chrome's use of RequestUnbufferedDispatch (enabled by default) to allow input buffering and resampling by Android rather than Chrome. Change-Id: I4d28b01f5d1ffb965b9651e6cedaab3e6ca4e03d Bug: 993629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753542Reviewed-by:
-
Matt Menke authored
ResourcePrefetchPredictor was always using the origin of the initial page being navigated to in constructing the NetworkIsolationKey. With this CL, it uses the origin it expects the page to redirect to instead. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1730782, which was reverted due to a racy test. Bug: 987735 Change-Id: I6ed1b1508dc9f4c9186cdee8a6afe9ea7b16f95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746591 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686813}
-
Cathie Chen authored
In order to measure the risk of changing scroll position to match the specification, use kElementWithLeftwardOrUpwardOverflowDirection_GetScrollLeftOrTop to count documents in leftwards and upwards calling scrollLeft/Top, setScrollLeft/Top, and scrollTo. And use kElementWithLeftwardOrUpwardOverflowDirection_ScrollLeftOrTopSetPositive to count the positive values setting which should be non positive. Bug: 721759 Change-Id: Ic0a9a8b688b37e3f0c95d3e3b60caad2bb0b9be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741776 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#686812}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/603ccac0c742..e43bce26f435 Created with: gclient setdep -r src-internal@e43bce26f435 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id7b921f6b83965f579326f321b851085e2c786b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753749Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686811}
-
Francois Doray authored
Bug: 887407 Change-Id: I0196aad66794fe4856c3a8394c81b614274813dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752635Reviewed-by:
-
Mike Frysinger authored
The unicode() builtin doesn't exist in Python 3. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Ie7c1f8d259f7c926dd43669fc0d48d87dd2fae63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700508Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686809}
-
Dave Tapuska authored
In order to add another dimension to check whether one security origin can access another we will add a cluster_id representing which AgentCluster the SecurityOrigin belongs to. BUG=961448 Change-Id: I79ff0156c91bc130b2dd0ad1a89241ec39b870d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730574 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686808}
-
Hazem Ashmawy authored
This class aggregates WebView crash info from different logs using: (UploadedCrashesInfoLoader, UnuploadedFilesStateLoader, WebViewCrashLogParser), then combines them in one list and sort them by recent crashes first. This crash info can be used by WebView crash UI. Bug: 964392 Change-Id: I875917e18d9dfb1315802df1ba6dca06f801d55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693961 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#686807}
-
Nektarios Paisios authored
This patch is 1 of 6 of a larger effort. The ultimate goal is to remove ui/accessibility/ax_text_utils and replace all its functionality with AXPosition, as well as integrate AXPosition in the chrome.automation API. 1. Implement CreatePositionAtTextBoundary on AXPosition. Move TextDirection from ax_text_utils to ax_text_boundary and rename to AXTextBoundaryDirection. 2. Implement ExpandToEnclosingTextBoundary in AXRange. Create AXRangeExpandBehavior::kLeftFirst,kRightFirst. 3. Remove FindTextBoundary from AXPlatformNodeBase, AXPlatformNodeDelegate, BrowserAccessibility, etc. and re-implement its functionality using AXRange::ExpandToEnclosingTextBoundary. This will unify Win and Linux ATK text navigation in AXPosition and AXRange. 4. Update BrowserAccessibilityCocoa to use AXPosition::CreatePositionAtTextBoundary and AXRange::ExpandToEnclosingTextBoundary. Write extensive tests for all text navigation operations in BrowserAccessibilityCocoa. 5. Expose word boundaries on Views using AXPosition and remove associated functionality from ax_text_utils. 6. Use AXPosition and AXRange to calculate word boundaries in chrome.automation. R=aleventhal@chromium.org, kbabbitt@microsoft.com Bug: 992562 Change-Id: I6c6b2c2e2756126cd632840baed699777c88839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745408Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686806}
-
Joel Hockey authored
Bug: b:131589705 Change-Id: I3854000c415e9e18ee5d0625375fbcc53bf470e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752576 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686805}
-
Istiaque Ahmed authored
usbPrivate was already deleted in https://codereview.chromium.org/617933002, so mark their corresponding historgram enum as deleted. Bug: None Change-Id: I83776a8c5e1977f4262a12e7dbdc03d2f1140684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752178 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686804}
-
Ian Kilpatrick authored
From: https://chromium-review.googlesource.com/c/chromium/src/+/1752692 This removes return reference for NGConstraintSpaceBuilder methods. Change-Id: I599dbee592397b3704de21779a7085378733e4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752287Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686803}
-
Sergio Villar Senin authored
This is another step in the process of moving the animation engine to base::Time* types. We're replacing doubles by base::TimeDelta which is the perfect fit to represent durations. We are not using AnimationTimeDelta, the wrapper class we're using to ease the transition, because the animation timers require a base::TimeDelta anyway so, the conversion from double to TimeDelta needs to be done anyway. Bug: 737867 Change-Id: I028fec11be2120548f829a1090e26ee4430a8a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746253Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#686802}
-
Ioana Stefan authored
BackgroundTaskScheduler currently keeps information about both the id and the class name of the tasks it schedules. This information is redundant, since a task id can be associated with its class. This CL is the first out of several that will remove the retention of BackgroundTask class names. This CL modifies the way in which the corresponding BackgroundTask class is retrieved. The selection of the correct class will be done based on a BackgroundTask factory. The caller of BackgroundTaskScheduler is responsible for setting this factory so that it will take into consideration all the needed task ids. This work exposes an interface for the BackgroundTask factory and a concrete implementation for //chrome, the main user of this component. Specific code calls and tests are updated accordingly. Bug: 916875 Change-Id: Idf2bfa18e83316df9fbd03d84571ba5c9d1fca03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742164 Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#686801}
-
Dmitriy Kalchenko authored
Tab with external URL should be active when launches an URL externally via App or CLI. The current Chromium behavior is that it activates first pinned tab in this case. Bug: 812545 Change-Id: I1531fc65ad8b2d6dda3271d13d3fae4f84fd1cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742155 Auto-Submit: Dmitry Kalchenko <xafster@yandex-team.ru> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#686800}
-
Marc Treib authored
Before this CL, the SECURITY_EVENTS type was enabled only if the "Sync everything" toggle was on. That doesn't make much sense, and was never the intention. This CL adds SECURITY_EVENTS to the AlwaysPreferredUserTypes set, so it will always be enabled if Sync is on (unless the data type itself decides that it shouldn't be enabled). Bug: 993119 Change-Id: I54e5a444dbfaa05647aff740f20b0c8764ceb504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751986 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#686799}
-
Michael Giuffrida authored
With KioskNext mode removed, app_list_controller should always exist. Bug: 977019 Change-Id: I8699f7cedc425b86bcca668ad066417379c111e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747745 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Christopher Grant authored
Remove arguments that no longer do anything in the script, and are no longer specified by official build scripts. Change-Id: I1f451d69fd9051e060885aa420e815ec84bd110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651925Reviewed-by:
-
Evan Shrubsole authored
This is a reland of ae18b126 The problem with the first CL was that calling FakeAudioInputStream::Stop() calls Stop() on the capture thread. Thread::Stop() triggers a join, which blocks. On Mac, the AudioThread is actually the browser UI thread, and this block is not ok. The fix to mitigate this issue is to have the capture thread owned in a std::unique ptr that deletes the capture thread on the AudioManager worker thread. The capture thread will be stopped on the worker thread when it is deleted. Original change's description: > Use REALTIME_AUDIO thread for Fake Input Stream > > Delays were seen when using the Audio Thread, detailed in the attached > bug. The use of the REALTIME_AUDIO priority fixes these delays. > > Bug: 971265 > Change-Id: Ieaf280b966354e3515f038ab81841572e075f0b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655530 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Evan Shrubsole <eshr@google.com> > Cr-Commit-Position: refs/heads/master@{#670443} Bug: 971265 Change-Id: I6e794042fe040ad87ffe823789666c5a987ce9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702426 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#686796}
-
David Benjamin authored
This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load flags and replace them with the allow_credentials setting. See https://crbug.com/799935 and https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4 for the motivation for this change. Using credential_mode makes it harder to forget LOAD_DO_NOT_SEND_AUTH_DATA along with the two cookie flags. This has two implications: - The request will no longer participate in HTTP auth if the server requests it. HTTP auth credentials identify the user, so private requests should not send them. Note this only affects server auth, not proxy auth. Unless the server your feature speaks to requests HTTP auth, this is a no-op. - The request will be pooled with sockets used for uncredentialed requests, rather than credentialed requests. This is not expected to meaningfully change behavior. If your code requires HTTP authentication, let me know. You may need to allow credentials for your request. Bug: 799935 Change-Id: I1a891c8fe5939ad1a4afca4d94d847a0ee90aa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752627 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#686795}
-
arthursonzogni authored
The test: NavigationControllerBrowserTest.VerifyBlockedErrorPageURL_SessionHistory has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1742152 TBR=zetamoo@chromium.org Bug=990812 Change-Id: I82eb39b789da9bc4e5beeb7e128e19b1a30c8c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752831Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#686794}
-
