- 13 May, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 38a36217. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 4d43fa2e "[Feature Policy] Introduce 'focus-without-user-activation'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Icb4e67453f2448a50c5750e70444e6f63ddcaba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610466Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659187}
-
Patrick Monette authored
This solves a filename collision that happens when moving all the files in chrome/browser/conflicts to chrome/browser/win/conflicts because module_info_win_unittest.cc becomes module_info_unittest.cc, and this file already exists at chrome/browser/install_verification/win/module_info_unittest.cc Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659186}
-
Miyoung Shin authored
This CL moves the type alias of FieldTrialParams from field_trial_param_associator.h to field_trial_params.h and use base::FieldTrialParams in blink. Bug: 952716 Change-Id: Ia6587a4799a43591ef19cd88cc0c7292bc22c7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605282Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Miyoung Shin(OOO till May 17) <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#659185}
-
Becky Zhou authored
Bug: 944061 Change-Id: If83cb176e3623784af1477731fa586295cd9459f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610471 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#659184}
-
Rouslan Solomakhin authored
Before this patch, Chrome in dark mode (on desktop) would display light gray "chrome" text on dark gray background in the payment sheet. The text was not readable. This patch adds the white text logo and uses it when the dark mode is enabled. After this patch, Chrome in dark mode displays white "chrome" text on dark gray background. This is readable. Bug: 959880 Change-Id: I8d705cddebbb9b7bd01c433c7fbee9721520185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594348Reviewed-by:
Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659183}
-
Devlin Cronin authored
Mark Extensions.DidSuppressJavaScriptException as obsolete. It has been expired since 2018-08. We haven't been looking at it lately, and we can always add it back later if we need it again. This also lets us remove the ExtensionsClient::RecordDidSuppressFatalError() method, and get rid of a fair amount of plumbing. TBR=halliwell@chromium.org (mechanical //chromecast changes) Bug: 878101 Change-Id: Iea57b934621c5745786c529383a52262dde70a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604062 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#659182}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fa6ebdcd266e..a40840a4e11c git log fa6ebdcd266e..a40840a4e11c --date=short --no-merges --format='%ad %ae %s' 2019-05-13 saklein@chromium.org SdkService/Create: Added check to avoid creating the chroot when it already exists. Created with: gclient setdep -r src/third_party/chromite@a40840a4e11c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ieb47e6f88423d1e2cc7fc5883593e40fc67409b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659181}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a04028c2e67b..7a3d1fb7569a git log a04028c2e67b..7a3d1fb7569a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7a3d1fb7569a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic2f5f2b0b40f58f2cb0abb7fb51b17cdc36cbc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610455Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/87bafc38b0d0..3475b482fefa git log 87bafc38b0d0..3475b482fefa --date=short --no-merges --format='%ad %ae %s' 2019-05-13 thestig@chromium.org Remove deprecated fpdf_edit APIs. 2019-05-13 thestig@chromium.org Add regression test for a crash in CPDF_TextState::GetFont(). 2019-05-13 thestig@chromium.org Remove secondary_source in .gn. Created with: gclient setdep -r src/third_party/pdfium@3475b482fefa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:947060 TBR=pdfium-deps-rolls@chromium.org Change-Id: I7515ef33f14efaddec4da54e397450fc016d615c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610456Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/7eef071bd3d6..8eb45e950572 $ git log 7eef071bd..8eb45e950 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 dschinazi Allow variable length connection IDs for unsupported versions 2019-05-10 fayang gfe-relnote: In QUIC, when cwnd gets bootstrapped, set cwnd gain in STARTUP to 2 to avoid too much overshooting. This only affects cwnd bootstrapping experiment. 2019-05-09 nharper gfe-relnote: Test-only, enable tests in QuicConnectionTest when multipel packet number spaces are supported 2019-05-09 dschinazi Support IETF retry in v47+ 2019-05-09 dschinazi Add an QUIC version reserved for negotiation to help test negotiation Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Update flags. R=rch@chromium.org Change-Id: Id4c7e3cbfff0e0bf146768ba4fdbe6f14778c538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606586Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659178}
-
Maksim Ivanov authored
Remove the "isNewGaiaFlow" parameter from the cr.login.Authenticator's load() method. It seems that this parameter was always equal to |true| in the current implementation. Follow-up CLs will remove some other variables and code that becomes dead after this CL. Bug: 470893 Test: existing tests, manual test: checking that OOBE enrollment, OOBE login, adding a new user on Chrome OS and desktop platforms work Change-Id: I4ee8da7e42564c24c758c97058685f1c4610a11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605419Reviewed-by:Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#659177}
-
Sebastien Marchand authored
ps2 is the initial file move ps3 contains the actual file changes (renaming the namespace etc). Bug: 961336 Change-Id: Ifc36cdc231c72205ef0bd96f5e546371ed939959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605424Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#659176}
-
Nate Chapin authored
Change-Id: I6fb09493a43efe8a3e955b06c922c70b644712ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606922 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#659175}
-
Elly Fong-Jones authored
Bug: 961861 Change-Id: I0c7acb675944f44d63c447cac983b21a6331cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609880 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#659174}
-
John Budorick authored
Also fix checkdeps_test.py after the move into chromium/src. Bug: 962059 Change-Id: I86f041e5ce819e0fbf3fb1e4de29fdde6c8d4596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610222 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#659173}
-
Brian Sheedy authored
Adds the LUCI config and waterfall/test suite changes for the new "Win10 FYI Release XR Perf (NVIDIA)" bot on chromium.gpu.fyi. Bug: 939185 Change-Id: I5a1600564ebd2efb8d1f4ff43eacce1b59df56f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604405 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659172}
-
Ian Vollick authored
These are easier to use than strings. No-Presubmit: true Bug: 961143 Change-Id: I00d9c83c7687a5e109bcc4def5fd7002908ad751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607320 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659171}
-
Alexei Filippov authored
This reverts commit 4bace02d. Reason for revert: Broke compile step https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/2457 Original change's description: > Mash cleanup: remove kiosk related mojos, replace with interface > > This splits out the kiosk related mojos from the login controller > interface, and removes kiosk_app_info.mojom. It also removes a couple > methods from mojom::LoginScreenClient, replacing them with a single > callback passed to the KioskAppMenu. > > TBR=tsepez@chromium.org > > Bug: 958206, 958204 > Change-Id: I59d38c83fc91397d1d0890c87f5b18fe23fac7d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604333 > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659100} TBR=jamescook@chromium.org,estade@chromium.org,tsepez@chromium.org Change-Id: Ib88e0d99d4fea0f264affc56e146c3e292d7177b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958206, 958204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610475Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659170}
-
Yun Liu authored
Emma is unsupported since 2005 and Jacoco is developed to replace Emma Bug: 843307, 961793 Change-Id: I25689279972a0132dd8c41474de787f9aaa89a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600337 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#659169}
-
Tarun Bansal authored
Clean up the Data Reduction Proxy (DRP) server experiments code. 1. Compute the set of server experiments at a single place. The logic for checking the field trial and switches lives in params.cc. 2. Treat the set of server experiment finch param as an opaque string that Chrome passes to the server in the request headers. 3. Add browsertests Change-Id: I6f81310eec91f0e5a77d22454139e0090fe32564 Bug: 962530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607504Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659168}
-
Jazz Xu authored
Add context menu unit tests Bug: 942156 Change-Id: Ibb2feb1220098ba43f52b37b2e93b4b6efbc0e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600493Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
danakj authored
The Compositor::Initialize() call is made from various content test JNI_OnLoad methods, while browser tests call it from ContentTestSuiteBase. Instead, centralize the behaviour in the ShellMainDelegate::BasicStartupComplete() which is called from the beginning of the ContentMain() set up. Chrome browser tests will not want to use this method, since they do initialization via the production chrome codepaths, so we must move it out of ContentTestSuiteBase. Instead of moving it down to ContentBrowserTestSuite, we can centralize these calls into the ShellMainDelegate. R=avi@chromium.org Bug: 961849 Change-Id: I76abf8ea227788cdfd053a465f52c122f3f35b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609599 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659166}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4a4c259fa148..8ef6d1fe29cc git log 4a4c259fa148..8ef6d1fe29cc --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Fix interaction between Dref and explicit lod Created with: gclient setdep -r src/third_party/swiftshader@8ef6d1fe29cc The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I046697836107770b7de6aeb4f66258a97e01b3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610454Reviewed-by:
-
Tarun Bansal authored
Refactor the code in Network Quality Estimator (NQE) that computes the HTTP RTT. No functionality change. Change-Id: I1874a791af73669fcc13c545c4c99691c6b318dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610498Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659164}
-
Saman Sami authored
Activation of surfaces can trigger DidReceiveCompositorFrameAck. In order to be able to merge DidReceiveCompositorFrameAck into OnBeginFrame, we need to make sure the activations always happen before OnBeginFrame is sent. Therefore, instead of making SurfaceDependencyDeadline observe the BeginFrameSource directly, let it be notified by CompositorFrameSinkSupport so that the ordering can always be guaranteed. This has the added benefit that PrimaryBeginFrameSource can be removed, greatly simplifying the code. Bug: 942059,938947 Change-Id: Ia6443c9c579a653500e21619e1e92ec83c7006d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604497Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#659163}
-
Antonio Gomes authored
WebCallbacks is now solely used within by blink::ImageCaptureFrameGrabber. This CL moves its definition out of the Blink exposed API into image_capture_frame_grabber.h This is a follow up of the following CLs: - crrev.com/c/1546151 (Remove the use of blink::ScopedWebCallbacks in MediaRecorderHandler::EncodingInfo) - crrev.com/c/1546155 (Remove the use of blink::ScopedWebCallbacks in TransmissionEncodingInfoHandler::EncodingInfo) - crrev.com/c/1576468 (Onion soup content/renderer/image_capture/) In a final step, its complete removal will be pursued. BUG=919392,945851 R=haraken@chromium.org Change-Id: I35ee4c0cfb6a317f3e661859d3fed2447cc968ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610117 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Alex Oldemeier authored
If no hash is returned from DownloadService, no image verification can take place, so the image_manager should always indicate a failure in this case. Also adapt unit tests and add the possibility to set a hash in test_download_service. Bug: 938253 Test: browser_tests --gtest_filter="PluginVm*" && unit_tests --gtest_filter="PluginVm*" Change-Id: I8bf9f3151d44910cdc44b51179a5ac16cf67a298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596673Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#659161}
-
John Abd-El-Malek authored
Change-Id: I9a8a8137f5797fadf0c3f2f8ab7cbd5db7377d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596843Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Ben Goodger <ben@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#659160}
-
Caroline Rising authored
This change makes tab hover cards reappear immediately when hovering over a tab if the mouse hover has only been out of the tab strip for 0.5 seconds. This is to prevent wait time when a user unintentionally hovers out of the tab strip while searching for a tab. Bug: 910739 Change-Id: I47cae3e64fcf86eff12884a3ed63945632d7fd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603054 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#659159}
-
Nate Chapin authored
Bug: 961816 Change-Id: Ie17882325e9acb124843e8a1f70e5a570738e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601653 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Matt Reynolds authored
This modifies the WebHID IDL to address comments in a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1559344 In the prior commit, HIDReportItem held raw indices into the USB string table (|stringMinimum| and |stringMaximum|). These members are removed in favor of a new |strings| member which will return the actual device data. |designatorMinimum| and |designatorMaximum|, which held indices into the physical descriptor table, are removed. HIDReportItem held a |unit| member which described the unit factors that make up the unit definition. The member was a 32-bit value composed of 7 4-bit values and 4 reserved bits. These nibbles have been split into separate members for the unit system and unit factor exponents. In HIDCollectionInfo, the |reportIds| member is removed as its utility is duplicated by the report information. BUG=890096 Change-Id: I8403f9b7e275d97e58bb6c9ad73c2e2654f9d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583427Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#659157}
-
Gayane Petrosyan authored
Remove custom link pills for themes without image and use NTP_TEXT theme property for custom link titles color. As pills will be used only with themes that have images, which in dark mode didn't change to dark, then this change eliminates the need for dark pill for custom link titles. Default: https://screenshot.googleplex.com/iNq8NShsd9a.png Defaul, dark mode: https://screenshot.googleplex.com/ebiCRAxdqth.png GTK: https://screenshot.googleplex.com/LqMk30Zf91r.png theme, no image: https://screenshot.googleplex.com/NA8jugTz7xy.png theme, no image, dark mode: https://screenshot.googleplex.com/qFyj5R6Y40S.png theme with image https://screenshot.googleplex.com/7fHXFUjGF6q.png theme with image, dark mode: https://screenshot.googleplex.com/fHVRb9yAzcj.png theme and custom background: https://screenshot.googleplex.com/uahXOYpPdzx.png theme and custom background, dark mode: https://screenshot.googleplex.com/J5w8UaV3sTJ.png Bug: 959377 Change-Id: I4b5e10c4392f57cdb9b1471c3ea49802cfc902ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597639 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659156}
-
Paul Jensen authored
Dedicated thread wastes resources and causes races in tests where it can outlive thread pools. Bug: 938126 Change-Id: I335d719d72c6291c03ef33480a81b7cda719b877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609883 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#659155}
-
Eric Willigers authored
Rename web_app_controller() to app_controller() as return type was recently renamed from WebAppBrowserController* to AppBrowserController* Change-Id: I297ae05b5751454c07ee478dfc99d4094fc50839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601614 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#659154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9b86955c65aa..d696f8e6bca3 git log 9b86955c65aa..d696f8e6bca3 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 bsalomon@google.com Support GL_ANGLE_texture_rectangle. Created with: gclient setdep -r src/third_party/skia@d696f8e6bca3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I429a06c36acd801abe05a91c51ce2fa69ff37e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610442Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2947e88f7938..e935dac9ef8a git log 2947e88f7938..e935dac9ef8a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 stevenperron@google.com Make pointers to isomorphic type interchangeable with option. (#2570) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e935dac9ef8a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I76bee692be829c25266527d1cc8ba0e461fb5aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610449Reviewed-by:
-
Robert Sesek authored
Bug: 958163 Change-Id: I356398a77cee42c71ccc6c722523b832a0b9d649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610639Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659151}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I105d94fc7c03764215f07f6c3f298ff488724c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608970 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#659150}
-
Scott Violet authored
Ahmed asked about the difference between ScopedExclude and ScopedForceVisible, which tells me the docs aren't good enough. Attempts to better describe what happens with the two. BUG=none TEST=doc only change Change-Id: Ia3b798b77f7609ad70dd9f8bed0f50157b10a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604327 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#659149}
-
chrome://managementNicolas Ouellet-payeur authored
Instead of always getting redirected to 'chrome://settings/help', the back button now goes back in the tab's history. If the tab has no history, it falls back to the old behavior. Bug: 959258 Change-Id: I32c6700648839b23879c48dd69878fa74ef42986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606190Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#659148}
-
