Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Nov, 2017 35 commits
  3. 10 Nov, 2017 5 commits
    • Chris Harrelson's avatar
      Avoid stack allocations for PaintPropertyTreeBuilderFragmentContext. · 5bfb9b4d
      Chris Harrelson authored 
      The stack allocation is just to initialize the object and stick it
into a heap-allocated vector entry. Instead allocate the entry
and initialize it on the heap.

Bug: 781301
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I58af3fdc18d19950d7f8911910ee33d1b0d445af
Reviewed-on: https://chromium-review.googlesource.com/764405
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: default avatarTien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515751}
      5bfb9b4d
    • Joel Einbinder's avatar
      DevTools: Make links focusable · 2cd778f6
      Joel Einbinder authored 
      Bug: 771578
Change-Id: I4928067b157e6297b652761d09955910b574fc73
Reviewed-on: https://chromium-review.googlesource.com/738327Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515750}
      2cd778f6
    • Dave Schuyler's avatar
      [MD extensions] make side nav similar to MD history side nav · d12f1ff7
      Dave Schuyler authored 
      This CL mimics some of the styling of MD history side nav so that the UI
is more consistent between history and extensions.

Bug: 780949
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I75665607686daf1618752c7e13c229efde23d93f
Reviewed-on: https://chromium-review.googlesource.com/762388Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515749}
      d12f1ff7
    • Nektarios Paisios's avatar
      Changes AXPosition to include affinity when computing leaf text positions and... · a020ea5b
      Nektarios Paisios authored 
      Changes AXPosition to include affinity when computing leaf text positions and simplified line boundary calculations

1. When converting text positions, such as those in a text field, to either a tree position or a leaf text position, we should take affinity into consideration. When there are two equivalent resulting positions, one at the start of a child node and one after the previous child node, we should return the former when affinity is downstream and the latter when affinity is upstream.
2. Line breaks are not always used to separate lines in content editables. Modifies logic that detects if we are at the end of a line to ensure that if there is some white space at the end of the line, then we would detect it as a line separator in addition to a line break.
3. Simplifies logic for finding next and previous line boundaries by relying on AtStartOfline and AtEndOfLine methods, thus creating a smaller piece of code that deals with boundary detection.
R=dmazzoni@chromium.org

Bug: 731056
Tested: existing unit tests, manually with Gmail textareas and content editables
Change-Id: Ic936122ef19f66fcb4a1cc88cd001f4376e34346
Reviewed-on: https://chromium-review.googlesource.com/745724
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515748}
      a020ea5b
    • Vlad Tsyrklevich's avatar
      [CFI] Add protected memory container class · 36d1a861
      Vlad Tsyrklevich authored 
      This change introduces a ProtectedMemory container class intended to
store dynamically resolved function pointers for cross-DSO calls that
must be exempted from Control Flow Integrity indirect call checking.
These function pointers can not be checked by cfi-icall, instead we
place them in read-only memory and set them writable only when they
need to be initialized.  ProtectedMemory is only suitable for
storing data in global/static variables, a follow-up change will
introduce a container class that allows dynamically allocating
multiple instances of a given type.

ProtectedMemory currently only works on Linux and macOS, its use is
a no-op on other platforms.

This change also introduces two helper macros to easily call function
pointers stored in ProtectedMemory containers without cfi-icall checks
applied in order to avoid sprinkling no_sanitize("cfi-icall") attributes
throughout the source code and encouraging its misuse.

Bug: 771365
Change-Id: Ic9433095d9550ae8478ad9931ec5e3c37edb23ec
Reviewed-on: https://chromium-review.googlesource.com/706859
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Reviewed-by: default avatarBrett Wilson <brettw@chromium.org>
Reviewed-by: default avatarWill Harris <wfh@chromium.org>
Reviewed-by: default avatarChris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515747}
      36d1a861