- 13 Mar, 2018 40 commits
-
-
Carlos IL authored
Added mojo interface to handle interstitial commands and implemented it in SupervisedUserNavigationObserver which passes the commands to SupervisedUserInterstitial when committed interstitials are enabled. In a future CL an extra class will be added which will listen to JS commands from the interstitial and passes them via mojo to the observer. Bug: 817099 Change-Id: I5285e1fdaa16ee4e96ec7167d470b8ada9b73685 Reviewed-on: https://chromium-review.googlesource.com/950413 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542848}
-
Sarah Hu authored
Bug: 820128 Change-Id: I56c775c6da5d26b3904bce9e755c7eb22b012229 Reviewed-on: https://chromium-review.googlesource.com/956082Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#542847}
-
Kurt Horimoto authored
BVC only listens for fullscreen progress when it's visible and active. This CL updates BVC for the current fullscreen progress when being shown so that any updates that occur while the BVC is not visible are immediately reflected. Bug: 820174 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9447065a30c3c8bb627afe7213cb4a623d8c5fb Reviewed-on: https://chromium-review.googlesource.com/958484 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542846}
-
Bence Béky authored
Net.WebSocket.HandshakeResult histogram has been broken since https://crrev.com/304093003, because WebSocketStream::Delegate::OnResponseStarted() has not been called upon failure any longer. This CL restores this histogram by moving logging into WebSocketHandshakeStreamBase and its two derived classes. It also refines the histogram by protocol (whether the handshake is over HTTP/2 or not), and provides a more gradual reason for failure as well. Bug: 801564 Change-Id: Iefa977703124df2bfcf77bc48e05f3ac594c2f50 Reviewed-on: https://chromium-review.googlesource.com/951746 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#542845}
-
Scott Violet authored
This reverts commit 6c097bb5. Reason for revert: I'm reverting the revert as the dependent change has cycled through the bots https://chromium.googlesource.com/chromium/src/+/a5ea6086a54429ad2770cf28a3898413866e1bdd Original change's description: > Revert "Adds WindowService-ChromeOS fieldtrial" > > This reverts commit b4603176. > > Reason for revert: Reverting as one of the fixs for an interactive_ui_test failure got reverted. > > Original change's description: > > Adds WindowService-ChromeOS fieldtrial > > > > I'm not sure on the name here. I went with WindowService-ChromeOS as > > at some point we will launch the WindowService on other platforms, but > > that won't be anytime soon and is likely to be very different. So, I'm > > thinking later on we have the field trial WindowService-Desktop. > > > > BUG=814898 > > TEST=none > > > > Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e > > Reviewed-on: https://chromium-review.googlesource.com/932821 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542680} > > TBR=sky@chromium.org,rkaplow@chromium.org > > Change-Id: Id63c00a90c6fd05ff74f0ffaa6ed738a98bd74e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 814898 > Reviewed-on: https://chromium-review.googlesource.com/959763 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542713} TBR=sky@chromium.org,rkaplow@chromium.org Change-Id: I5a7259e6d6ce0ddafb516c22f847e6f662ad57b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814898 Reviewed-on: https://chromium-review.googlesource.com/960937Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542844}
-
Daniel Bratell authored
A completely unused object file in a static library will be ignored by the linker, but with jumbo builds unused cc files will be grouped with used cc files and the object file will no longer be ignored. If the cc file contains code that is bad it can then trigger followup linker errors which happened in this case where debug component windows builds had too many constructors and destructors for WebAssociatedURLLoader when building webkit_unit_tests.exe Change-Id: I16a0332b9e16903481c2995f2176e59a1ba8e53e Reviewed-on: https://chromium-review.googlesource.com/955850Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542843}
-
Daniel Cheng authored
Change-Id: I96f3a6a7e777066b87d9277c8a238bab40b4e94d Reviewed-on: https://chromium-review.googlesource.com/959682Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542842}
-
Robert Sesek authored
This adds a new use_crash_key_stubs GN argument that effectively disables the crash key subsystem. Bug: 811308 Change-Id: Ie0fba2c9af4c1514cc7dabc12ca012736a3d5422 Reviewed-on: https://chromium-review.googlesource.com/914708Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#542841}
-
Rintaro Kuroiwa authored
- It keeps breaking and requires updating. - So build it by default, the feature is still behind a runtime flag. - GN files are cleaned up so that "mojo_media_host" is set with clearer logic. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic78d4c949e0c8d57707f1d7f213c3b2fabd4b689 Reviewed-on: https://chromium-review.googlesource.com/959446 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#542840}
-
Yang Guo authored
Changes to v8::ScriptCompiler::CompileFunctionInContext observably affects debug stepping. R=haraken@chromium.org Bug: v8:7172 Change-Id: Iff4c43475e8e1f80a77557a5ffe6eab24b9a5471 Reviewed-on: https://chromium-review.googlesource.com/960904Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542839}
-
Patrick Monette authored
This is made possible now that the MTA is initialized on every sequenced task runner of the Task Scheduler. It also fixes the possible hangs on the UI thread when the automation thread was joined on destruction. Bug: 819789 Change-Id: I8964275d97c3302eaa7888e9c827d5e954c2b9eb Reviewed-on: https://chromium-review.googlesource.com/955673 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#542838}
-
Luna Lu authored
1. Without specifying allow attribute, frame policy inherits correctly. 2. With allow attribute, frame policy inherits from and overrides header policy correctly. Updating allowfullscreen and allowpaymentrequest correctly updates frame policy. 3. Frame policy is not affected by the frame's document policy. Bug: 732003 Change-Id: Ib41f883a779f11c564c91cfc03ff1224330108f5 Reviewed-on: https://chromium-review.googlesource.com/850896 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#542837}
-
https://webrtc.googlesource.com/src.git/+log/4160441178a0..313385726692 $ git log 416044117..313385726 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8b248617e9a6df50f524b12caf5deedc1173fa0 Reviewed-on: https://chromium-review.googlesource.com/960579Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542836}
-
Charles Harrison authored
This partially fixes breakage to gmail, which wants to redirect mail.google.com -> accounts.google.com for auto-logout. See the design doc for relaxing tab-under protection: https://docs.google.com/document/d/1N-0etmATN6PhQt-m9S8sCgfz88zv8lZ2dBFdqKlzsPg/edit?ts=5aa2f94e# It feels like this change is the least controversial and it won't reduce the efficacy of the intervention. Bug: 661629 Change-Id: I01c7435a12515aacf011a722ee155d60cb1d6bae Reviewed-on: https://chromium-review.googlesource.com/959689 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542835}
-
bsheedy authored
Adds VrShellControllerInputTest#testControllerScrollingNative, which ensures that scrolling via the Daydream controller works on the chrome://history NativePage. Bug: 737168 Change-Id: Idfa83286ee56a4c245634e64dc3d80a3ef0a8d43 Reviewed-on: https://chromium-review.googlesource.com/959609 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542834}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70196515..5018e7b8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id0cf0686f7d71ba052c65417ce3ace164abe6ea8 Reviewed-on: https://chromium-review.googlesource.com/960588Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542833}
-
David Jacobo authored
The bookmark star was for many years the rightmost icon and still is on !CrOS. We mistakenly added the intent picker icon on its right, besides fixing that, reevaluating the order of the first 4 icons. More precisely, this CL rearranges the first 4 rightmost icons in this order (rightmost first): - bookmarks icon - zoom icon - find icon - intent picker icon Bug: None. Test: Build, manual test. Change-Id: I5676a9550dbf383a446a19854a3b810bf961fc2b Reviewed-on: https://chromium-review.googlesource.com/958085Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542832}
-
Sammie Quon authored
Bug: none Test: ash_unittest WindowSelectorTest.* Change-Id: I81ecfd00386944e3cf285909cca847581643c377 Reviewed-on: https://chromium-review.googlesource.com/949610 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542831}
-
Mike Reed authored
Strict refactoring change: just renaming existing calls. TBR= Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I725ab3b4e83a2eb218cd90217a19d68947cc05d6 Reviewed-on: https://chromium-review.googlesource.com/960569 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#542830}
-
Sorin Jianu authored
The header names have been changed, we need to make a string substitution t o update them: X-GoogleUpdate-Interactivity -> X-Goog-Update-Interactivity X-GoogleUpdate-AppId -> X-Goog-Update-AppId X-GoogleUpdate-Updater -> X-Goog-Update-Updater Bug: 647516 Change-Id: I147ca276837ece5e9e8c28aa3a871b5ac5cae3b5 Reviewed-on: https://chromium-review.googlesource.com/959555Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542829}
-
Antonio Gomes authored
Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite convoluted today. This a 2/n of a seriee of patches that clean it up. CL adds a SetImplementation templatized function to be used instead of using wl_resource_set_implementation directly. BUG=None R=rjkroege@chromium.org Change-Id: I802c0b1ddbe68dd98da225eb5d4e04da2ab6b2e0 Reviewed-on: https://chromium-review.googlesource.com/960521 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#542828}
-
https://pdfium.googlesource.com/pdfium.git/+log/0c6b98182403..7a1aa5f65911 $ git log 0c6b98182..7a1aa5f65 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 rharrison Remove usage of FXSYS_*ASCIIlower/upper methods Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I56e6faeee8bcd020a1a94a6d592305d59ba268e8 Reviewed-on: https://chromium-review.googlesource.com/960589Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542827}
-
edchin authored
These tests have been failing on these device bots: (iPad Air iOS 10.3.3) on iOS-10.3.3 (iPhone 6s iOS 10.3.3) on iOS-10.3.3 Since March 7, revision: 1cbfed836fceb54df561b43e7cd8e5d65ea41137 TBR=huangml Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69616206990b473a3ea828136e87166a11308950 Reviewed-on: https://chromium-review.googlesource.com/960842 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542826}
-
Ted Choc authored
BUG= Change-Id: I85bc675f3b14b27ecbf6b63a46f2876b72a7fbe1 Reviewed-on: https://chromium-review.googlesource.com/953371 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542825}
-
https://skia.googlesource.com/skia.git/+log/4ce53a6ffd3c..fd6ed022db18 $ git log 4ce53a6ff..fd6ed022d --date=short --no-merges --format='%ad %ae %s' 2018-03-13 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 64e5ed2ab..f0b30dd8b (2 commits) 2018-03-13 caryclark protect SkPathMeasure against NaN 2018-03-13 brianosman Revert "Reland "Add SkColorSpaceXform_skcms"" 2018-03-13 brianosman Reland "Add SkColorSpaceXform_skcms" 2018-03-13 bsalomon Remove yoda rule from style guide 2018-03-12 caryclark fix a couple pathops fuzzers Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I6d6d5b9d346d52cc71ed32ec3c90928243b54f62 Reviewed-on: https://chromium-review.googlesource.com/960563Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542824}
-
Eric Karl authored
Currently, Android supports --enable-low-end-device-mode, but requires that the flag be set/visible to Java. This limits the usefulness, as we can't apply this flag via C++ in test scenarios. This change modifies SysInfo::IsLowEndDevice to behave like SysInfo::AmountOfAvailablePhysicalMemory in its handling of flags: flags are checked / applied in platform-independent C++ before forwarding to a platform-specific impl function in the case that the default behavior was not overridden. Change-Id: Ic2952ed5d2eb199f4daaa60aa2f1eb6dad87d205 Reviewed-on: https://chromium-review.googlesource.com/959301Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#542823}
-
Fredrik Söderquist authored
This CL transitions the ReferenceFilterOperation (used for 'filter') from SVGElementProxy to SVGResource. It introduces ExternalSVGResource as a new subclass of SVGResource. ExternalSVGResource handles loading of an external document, and notifies clients as needed when said document finishes loading. Since this leaves SVGElementProxy unused, it is removed together with some related structures. This also allows some code to be simplified because we no longer need a TreeScope (or Node) in some places. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If6cbbf32e0269878bdea897fcf0b8e41c062b0f6 Reviewed-on: https://chromium-review.googlesource.com/955684Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542822}
-
Nektarios Paisios authored
Will be used by AXSelectionBehavior in an upcoming patch which will determine if setting the selection on an AXRange that corresponds to an invalid DOM range should extend or shrink the range. R=dmazzoni@chromium.org Change-Id: I04d2e5aeb747aafb6e6f88e7fc5bd9304ba50d63 Reviewed-on: https://chromium-review.googlesource.com/952484 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542821}
-
edchin authored
This CL configures the tab grid toolbars for the current size class. For example, a portrait phone will have a bottom toolbar whereas an iPad will have a FAB. This CL configures based on size classes, not device idioms. Bug: 804499 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I56cb26e43f92ee6152bd5b1e1d747bafbc052880 Reviewed-on: https://chromium-review.googlesource.com/959921 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542820}
-
Albert Chaulk authored
This will be required for some extensions to run Bug: b/74441258, b/73383411 Test: load local content script, verify it prints to console Change-Id: Ia2499c789a263c7a589c6a9dcc519495879d48e7 Reviewed-on: https://chromium-review.googlesource.com/957647Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#542819}
-
rodmartin authored
Bugs: 820546, 820554, 821063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0022b28d5b3289e9b87f2f06498cbd03212d19c4 Reviewed-on: https://chromium-review.googlesource.com/929754Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#542818}
-
stkhapugin@chromium.org authored
CL 905511 introduced a bug where previously BVC was defocusing the omnibox by sending selectedTabChanged to the toolbar, but this was broken. Since the location bar now directly observes the webstate with its mediator, use this to defocus omnibox when the webstate changes. Bug: 813944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc67faaae115032e0a3c6e6b5e3879d7e52f8f0f Reviewed-on: https://chromium-review.googlesource.com/960663Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542817}
-
Ian Clelland authored
The renderer feature was removed in https://crrev.com/86dad9f3, except for the linkage between browser and renderer in c/c/runtime_features.cc. This CL removes that link, as well as the base::Feature for the removed feature, and the entry in chrome://flags. Bug: 704650 Change-Id: Iddf4038c7c2f4c8d7a45770262b977d78996b696 Reviewed-on: https://chromium-review.googlesource.com/957478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#542816}
-
https://webrtc.googlesource.com/src.git/+log/e61bf67b99a9..4160441178a0 $ git log e61bf67b9..416044117 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If63b7a76fff3b1bf83ba302a1191e20005fdafb9 Reviewed-on: https://chromium-review.googlesource.com/960622Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542815}
-
jonross authored
There are a series of tests currently flaking on Windows with timeouts, and no errors. This change disables them via the Viz filter. TBR=kylechar@chromium.org TEST=viz_browser_tests Bug: 794961 Change-Id: I4f2bfabc461f78cd9d187b610472c396d3c91a0b Reviewed-on: https://chromium-review.googlesource.com/960576Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542814}
-
Peter Kotwicz authored
According to the docs (https://developer.android.com/reference/android/content/pm/ShortcutManager.html) ShortcutManager#requestPinShortcut() throws an IllegalStateException if "The caller doesn't have a foreground activity or a foreground service, or the device is locked." We create a home screen shortcut if WebAPK install fails. WebAPK installs time out and fail out after 3 minutes. A user may be using a different app by the time that the time out occurs. This CL catches and ignores IllegalStateExceptions thrown by ShortcutHelper#requestPinShortcut() Bug=819725 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iceab1a25a0d80b9869cfc523f091c3af8e590a76 Reviewed-on: https://chromium-review.googlesource.com/959751 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#542813}
-
Taylor Brandstetter authored
Bug: chromium:820806 Change-Id: I36340c31ee6c5c88a4049d346ed9af9dbff43392 Reviewed-on: https://chromium-review.googlesource.com/959525Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542812}
-
Eugene But authored
This adds Drive icon below "Download state" icon. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2f6fee2339_3_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id0405502a338aacfe4c2de331adbca89f1fe747e Reviewed-on: https://chromium-review.googlesource.com/956700 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542811}
-
Luna Lu authored
Bug: 821455 Change-Id: I49c24c67d5eec2672829ceb9eeaa5f63019d20a3 Reviewed-on: https://chromium-review.googlesource.com/960572 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542810}
-
Scott Violet authored
EventRewriters don't honor the target, and so generally expect the root_location and location to be the same. This patch changes EventSource::SendEventToSink() to create a new Event if the existing has differing locations (and a target). BUG=817112 TEST=covered by tests Change-Id: I29f9cafe962194938c8e457aabc3a5ce6b379649 Reviewed-on: https://chromium-review.googlesource.com/959803Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542809}
-