- 28 Sep, 2017 40 commits
-
-
Chris Watkins authored
Previously MojoAndroidOverlays could only be created on the GPU main thread. Now we can create them on any thread, and specifically the media service thread, so that MediaCodecVideoDecoder can use them. Also, they now embed an optional ServiceContextRef so that if they're used from the media service, they can extend the lifetime of the thread their mojo interface is bound to. This is necessary because they will be jointly owned by both MCVD and CodecImages. Bug: 660942 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6497b81eeb7205a4893ef6c4de4ee5af571ac90a Reviewed-on: https://chromium-review.googlesource.com/684005Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#504854}
-
Emil A Eklund authored
Add support for text decoration (underline, overline, and strikethrough) painting for LayoutNG. Shares most of the line position resolution logic and paint implementation with legacy layout. Correctly supports roman underlines while the under (element edge) style isn't fully supported due to missing baseline and decorating box data. Edit Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie493469d7846605626c395645017e7214ae5224e Reviewed-on: https://chromium-review.googlesource.com/686091Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#504853}
-
Xida Chen authored
This reverts commit b123ea27. Reason for revert: <INSERT REASONING HERE> Causing build failure here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/92442 Original change's description: > applist-focus: Handle arrow key focus traversal > > Changes: > 1. Enable arrow key focus handling in FocusManager. > 2. Handle arrow up/down in SearchBoxView to move focus to the first/last > focusable element in ContentsView. > 3. Handle arrow up/down in AppsGridView. AppsGridView has three states: > Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps > (inside folder). Do separate handling for them, since they have > different layout. > > Design Doc: go/applist-focus > > BUG=766810 > TEST=AppListViewFocusTest.* > > Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0 > Reviewed-on: https://chromium-review.googlesource.com/687818 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504818} TBR=xiyuan@chromium.org,weidongg@chromium.org Change-Id: I571e6f941401c34cc996395d933b1d4478307e27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766810 Reviewed-on: https://chromium-review.googlesource.com/688838Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#504852}
-
Taiju Tsuiki authored
This reverts commit b123ea27. Reason for revert: This CL causes a compile error. The error log was: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/92442 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Builder__dbg_%2F92442%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout LINK ./app_list_unittests (snip) ../../ui/app_list/views/app_list_view_unittest.cc:609: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const' ../../ui/app_list/views/app_list_view_unittest.cc:718: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const' ../../ui/app_list/views/app_list_view_unittest.cc:777: error: undefined reference to 'app_list::AppsContainerView::IsInFolderView() const' clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > applist-focus: Handle arrow key focus traversal > > Changes: > 1. Enable arrow key focus handling in FocusManager. > 2. Handle arrow up/down in SearchBoxView to move focus to the first/last > focusable element in ContentsView. > 3. Handle arrow up/down in AppsGridView. AppsGridView has three states: > Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps > (inside folder). Do separate handling for them, since they have > different layout. > > Design Doc: go/applist-focus > > BUG=766810 > TEST=AppListViewFocusTest.* > > Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0 > Reviewed-on: https://chromium-review.googlesource.com/687818 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504818} TBR=xiyuan@chromium.org,weidongg@chromium.org Change-Id: Ic30e4ea6aea5c5c57c145be2aad0dc1d83edc777 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766810 Reviewed-on: https://chromium-review.googlesource.com/688874Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#504851}
-
Paul Meyer authored
This patch connects intervention reports to the ReporingServiceProxy mojo interface. Notes on testing: 1) The test for this patch's new functionality is added to reporting-api.html, where the mock reporting class there can be reused. 2) This patch also factors out the intervention-generating code to a function in intervention.js, so it can be used in both reporting-api.html and intervention.html tests. Bug: 731810, 564071 Change-Id: I9ea961f6672ece81712c657ee7d9350b0520bb29 Reviewed-on: https://chromium-review.googlesource.com/685992Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#504850}
-
Matthew Jones authored
This change adds getters to several classes that make adding animations easier. BUG=750381 Change-Id: Id82b8337ef66a614aebe0aaeb7e08eca59bc7beb Reviewed-on: https://chromium-review.googlesource.com/676263 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#504849}
-
Kent Tamura authored
Bug: 767849 Change-Id: Iaa02ed396dd0fde720bebcc276029326b20445a5 Reviewed-on: https://chromium-review.googlesource.com/684098Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#504848}
-
Tommy Steimel authored
This CL adds metrics to track exceptions and default setting for the sound content setting. Bug: 769376 Change-Id: Ic13dbcba4f3d958dadc61ecb64db102c15b845f2 Reviewed-on: https://chromium-review.googlesource.com/688154Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#504847}
-
Dave Schuyler authored
This CL sets user-select: none; on icon buttons. There doesn't appear to be a need/reason to do selection of a icon button (when drag selecting for example). This change is primarily to make the context menu (right- click menu) show options for a button rather than selected text. Bug: 769209 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64013d3f087ff6cd3c33b513acc2c2d340406202 Reviewed-on: https://chromium-review.googlesource.com/688499Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504846}
-
Charles Reis authored
Temporary hack to avoid OOPIFs for the most visited tiles on the NTP, until the underlying bugs are fixed to make them work. BUG=566091 TEST=Most visited tiles work on the NTP in --site-per-process Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9559f6a98e5cbbbe9ca699fae7b96c71553022c1 Reviewed-on: https://chromium-review.googlesource.com/686067 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504845}
-
Shimi Zhang authored
Current Smart Selection workflow: 1) When receiving showSelectionMenu() call in SelectionPopupController, it asks SmartSelectionClient to do classification and suggestion. 2) A callback onClassified() in SelectionPopupController is called when received classification/suggestion result. 3) onClassified() will call adjustSelectionByCharacterOffset() if necessary. 4) When selection range expands, SelectionPopupController will receive a onSelectionEvent() call, then it triggers selection menu if SELECTION_HANDLES_MOVED event comes. This workflow has one flaw since SELECTION_HANDLES_* events are not very reliable for this use case. Because under certain condition the original long press caused selection and the later selection expansion event can be draw at once. In this case, there is only one SELECTION_HANDLES_SHOWN event without a following SELECTION_HANDLES_MOVED event will happen. This CL changed 4), let adjustSelectionByCharacterOffset() triggers another showSelectionMenu() call and handle the last selection menu event from that point. It removes the dependency on SELECTION_HANDLES_* events, therefore resolved the bug. Bug: 763201 Change-Id: I3688fbb0a31e3794486cc9eab162f4392ab6ff80 Reviewed-on: https://chromium-review.googlesource.com/669881 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504844}
-
Vladislav Kaznacheev authored
This should minimize disruption when a user is writing/sketching while accidentally holding down the stylus button. Bug: 767441 Test: ash_unittests --gtest_filter=PaletteTrayTest* Change-Id: I155d6c7b0997dd56680aaae8a005fba074a15865 Reviewed-on: https://chromium-review.googlesource.com/688486 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#504843}
-
Jialiu Lin authored
Bug: 761114 Change-Id: I8904520f027a6dba423da4002df5191683e95ae0 Reviewed-on: https://chromium-review.googlesource.com/683245Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#504842}
-
Mark Pearson authored
Bug: 766438 Change-Id: Ib0627398de070fb53a3239b7c8bf665071c9d8b0 Reviewed-on: https://chromium-review.googlesource.com/675678 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#504841}
-
Morten Stenshorne authored
public/platform/web_feature.mojom-blink.h is heavy. Avoid it when possible. Break the WebFeature defintion out of UseCounter.h and also make that enum forward-declarable. There are quite a few translation units that don't need to deal with UseCounter, just because they need to name a web feature. And then there are also some places where we just need to have the type forward-declared, such as in CSSParserContext.h This reduces the number translation units that depend on UseCounter.h by about 1601 compilation units, which is ~56%. It seems that most translation units that include UseCounter.h really need the WebFeature definition as well, so at least for now, it will be included there. Bug: 766315 Change-Id: I1cc0ee843373eb407c424ecd3c03c0f9080770bd Reviewed-on: https://chromium-review.googlesource.com/669020 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Rune Lillesveen <rune@opera.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504840}
-
Bettina Dea authored
Previously, the new tab promo bubble would pop up and take off the focus off of the omnibox and place it on the promo bubble. This interrupts users as the user has to click back on the omnibox (making it two clicks). Thus by making it inactive, it prevents interruptions to users. However, there were some additional bugs due to the bubble now being inactive. Because it was inactive, it didn't register clicks anymore. When a user clicks on the new tab button or opens a new tab the promo didn't disappear and instead would block on the new tab. Thus, now every time a new tab is open, we have to call manually call CloseBubble to close the bubble. Another bug was that due to the new tab promo bubble using anchor_rect for the BubbleDialogDelegateView, whenever the window was resized when the bubble was still showing, the bubble would not move with the resizing window so it would just float on air in the screen. I changed this to using anchor_view instead and tested it on Linux. Another change is that now that the new tab promo is inactive, the promo will not auto-dismiss. The only time the promo will be dismissed is when a user opens a new tab or clicks on it. The promo will also dismiss after mouse hover in 2.5 seconds. Bug: 734132 Change-Id: I60d1f0a0ed8bb4c192aa2856f01a4baa7b495039 Reviewed-on: https://chromium-review.googlesource.com/665982 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#504839}
-
Simon Que authored
This factors out the rate limiting of access to log sources into a separate module. In the future, we can update the rate limiting policy by updating only the rate limiter. BUG=768967 Change-Id: Ic897112ad2adc58adac9e57ed95b424c532ae42e Reviewed-on: https://chromium-review.googlesource.com/685916Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#504838}
-
Geoff Lang authored
As ANGLE makes more extensions enableable (and disabled by default for WebGL contexts), they need to be requested by the passthrough command decoder in order to maintain the same functionality. Eventually these extensions can be requested from WebGL once the command buffer client is aware of the functionality. BUG=angleproject:1523 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I91194b32efc7df0fe340dcd5f52e4fc1dcd59e62 Reviewed-on: https://chromium-review.googlesource.com/687534 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504837}
-
Nathanael Alcock authored
Due to a Windows bug (https://crbug.com/177163), password import and export tests were failing as extension subtests were not being executed. This ensures the tests are safe even when the subtests are disabled. Change-Id: I46093e83a539be6c49a606300fe2e3b18a8dfbb0 Reviewed-on: https://chromium-review.googlesource.com/687515Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nathanael Alcock <varkor@google.com> Cr-Commit-Position: refs/heads/master@{#504836}
-
Zhongyi Shi authored
by QUIC users. Those notifications are: - NetworkConnected - NetworkMadeDefault - NetworkDisconnected - NetworkSoonToDisconnect - IpAddressChanged Bug: 765436 Change-Id: I6205540d9dbbff63010a40ef06febfede2257bef Reviewed-on: https://chromium-review.googlesource.com/687878Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Refresh Kerberos ticket-granting-ticket for Active Directory enrolled devices on the new views-based lock screen Bug: 676337 Change-Id: I2a211c5b1e9b03f3bd7e27ac018133e2edde1391 Reviewed-on: https://chromium-review.googlesource.com/685830Reviewed-by:
-
Hiroki Nakagawa authored
This CL upstreams http/tests/worklet to external/wpt/worklets on the WPT repository. Bug: 724907 Change-Id: I0928ea9bd7f615b84cf138a8682816c68a779ed5 Reviewed-on: https://chromium-review.googlesource.com/683714Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#504833}
-
Walter Korman authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I369c6e70116992f61ebc168b5cfad98a8a74168f Reviewed-on: https://chromium-review.googlesource.com/687820Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#504832}
-
Xianzhu Wang authored
This ensures repaint of the column rules which will be painted differently for different actual column count. Bug: 764213 Change-Id: Ia4c2d2ec847ba851f05e02cf2f9ac7a44d397dea Reviewed-on: https://chromium-review.googlesource.com/688480Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504831}
-
Tom Anderson authored
This CL: * Fixes the broken symlink. * Adds a check to ensure symlinks are valid. R=thestig@chromium.org BUG=768020 Change-Id: I98060b989b7723179128ccd9ee3b971638be83a7 Reviewed-on: https://chromium-review.googlesource.com/688489Reviewed-by:
-
danakj authored
Since all resources created with ResourceProvider are now immutable, we have no need for the texture hint to request immutability. So remove the hint, and make the DEFAULT behaviour create immutable resources whenever the context supports it for the format. All clients of ResourceProvider will need to assume resources are always immutable. Add some class-level documentation on ResourceProvider to mention this. R=piman@chromium.org Bug: 768976 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I75f98f8225cbde1a38910e3319c641a3a4fb2db6 Reviewed-on: https://chromium-review.googlesource.com/688098Reviewed-by:
-
Karan Thakkar authored
This change fixes a typo in the DOM Domain devtools protocol doc for `getSearchResults` method: sarch -> search Change-Id: I2b98550a1f955064c56afa80f4356f1d79b8597f Reviewed-on: https://chromium-review.googlesource.com/646806Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
-
Yue Li authored
Check whether the user is supervised when choosing the search page title in CrOS settings. Do not use the version contains voice interaction if the user is supervised. BUG=b/66913130 Change-Id: Ie631f7e476959f7ce315a627d13c13dca1ffbfd7 Reviewed-on: https://chromium-review.googlesource.com/686040Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#504827}
-
dpapad authored
- Restore 16px left/right padding. - Make progress bar visible again. Bug: 766046 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c9f3a6ca5117b0c7ed12ccd0cb9b2c7eae10c58 Reviewed-on: https://chromium-review.googlesource.com/685363Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#504826}
-
David Grogan authored
Most layout objects that have a writing mode orthogonal to their parents are laid out early so that the parents can know the children's widths before computing their own preferred widths. (https://crbug.com/550963) But table parts can't be laid out on their own, only in the context of their table ancestor. Bug: 719211 Change-Id: Ia2a56127c6d4e6c0239324a478cb664ceeed0e30 Reviewed-on: https://chromium-review.googlesource.com/685900Reviewed-by:
-
Nick Carter authored
some of the tricky cases for ReplaceSubstringsAfterOffsets. These tests uncovered a correctness bug involving a sorted vector, which is also fixed. Bug: None Change-Id: Ic96d709e70732705e7bf3be9655e5427bdfe396f Reviewed-on: https://chromium-review.googlesource.com/648215Reviewed-by:
-
Yuwei Huang authored
Currently MaterialComponents hasn't implemented the pull-to-refresh functionality, but internally we do have a component to provide Googlewide conforming pull-to-refresh UX. This CL: * Creates a RefreshControlProvider framework for providing pull-to- refresh UI depending on the app variant. * Provides the Chromium implementation, i.e. using the standard UIRefreshControl, the flower-like spinning wheel. * Modifies other code to use RefreshControlProviderand cleans up the old refresh button. Once MaterialComponents implements the pull-to-refresh component, we could start using it and get rid of the RefreshControlProvider. Bug: 768480 Change-Id: Ibfc519a5df620f0ecf7dd6250f726c9a0efa096a Reviewed-on: https://chromium-review.googlesource.com/680115Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#504823}
-
spqchan authored
Currently, when the Extension Installed bubble is closed, the BubbleManager is not informed about its closed status and would still hold on to it. This causes a crash in Mac when a relayout causes the BubbleManager to update all of its bubbles. This CL acts as a stopgap to this problem by having Extension Installed bubble to call back to BubbleController, which will then update the BubbleManager with the bubble's close status. Note: The ideal solution is to get rid of BubbleManager since it's an aborted project that needs to be deleted. Bug: 763064 Change-Id: I53bd2691e1e62a6df8b53876a6a4d228fe071064 Reviewed-on: https://chromium-review.googlesource.com/671638 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#504822}
-
Jay Civelli authored
Removing net/proxy/proxy_service_v8 which is unused. Bug: None Change-Id: I540e79f91ad8ba3315b2fee483ec57042a39a08e Reviewed-on: https://chromium-review.googlesource.com/687987Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#504821}
-
MinChen authored
Changes, 1. Show the wallpaper setting row only for login, whitelist types and active users (should satisfy the whole conditions at the same time). 2. Only can open the wallpaper manager if the wallpaper is not policy controlled. 3. Added wallpaper policy indicator. Show it if the wallpaper is policy controlled. Bug: 749755,768319 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I07ffb372bf511411188b847c969cdc2341658bfa Reviewed-on: https://chromium-review.googlesource.com/683221Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#504820}
-
Luis Hector Chavez authored
This change migrates all the ARC Mojo interfaces to use OnceCallback. Bug: 714018 Test: git cl try Change-Id: I44cd6ef8d6f708231bdd92694fce408674672000 Reviewed-on: https://chromium-review.googlesource.com/683225 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Owen Lin <owenlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#504819}
-
Weidong Guo authored
Changes: 1. Enable arrow key focus handling in FocusManager. 2. Handle arrow up/down in SearchBoxView to move focus to the first/last focusable element in ContentsView. 3. Handle arrow up/down in AppsGridView. AppsGridView has three states: Peeking, Fullscreen all apps (outside folder) and Fullscreen all apps (inside folder). Do separate handling for them, since they have different layout. Design Doc: go/applist-focus BUG=766810 TEST=AppListViewFocusTest.* Change-Id: I2ace4b3b21a69f10011eba2ed0079e1f7aee48d0 Reviewed-on: https://chromium-review.googlesource.com/687818 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
Previously, all card save dialogs under the new UI would have the logo. The logo should only apply to server card uploads, not local saves. Bug: 736944, 768951 Change-Id: I7b5a8845f66e808cba13e2822c6dd8ed50995056 Reviewed-on: https://chromium-review.googlesource.com/685503Reviewed-by:
-
Yuwei Huang authored
This CL finishes up the fullscreen control UI. It is a transparent-black circular button with a close (X) icon on the middle. It is used both as an indicator for exiting fullscreen when the keyboard lock reserves the ESC key and an actual button to exit fullscreen for touch devices. This CL also implements a FullscreenControlPopup class to show the indicator with a dropdown animation in replacement of the DropdownBarHost implementation. This is the UX spec (Google internal): https://docs.google.com/presentation/d/11D86S87NZK5sAMLhc8WSV9pk_VWkjMAjvnN08uUD5po/edit#slide=id.g23756e43b7_3_0 Bug: 758456 Change-Id: I44dc2d0944386f5f6f5e607831c5ea4e38364357 Reviewed-on: https://chromium-review.googlesource.com/647950 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/408b8e44..7c5095aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I3d37fe7c10f4ff01faf9ebda7a3e8f8eebc0fd80 Reviewed-on: https://chromium-review.googlesource.com/688415Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#504815}
-
